From: Kyösti Mälkki <kyosti.malkki@gmail.com>
Date: Wed, 19 Oct 2011 04:23:51 +0000 (+0300)
Subject: IOAPIC: fix bitmask
X-Git-Url: http://wien.tomnetworks.com/gitweb/?a=commitdiff_plain;h=939103c622ea9f9be32675643373a0d99aaba2b2;p=coreboot.git

IOAPIC: fix bitmask

APIC ID is bits 27..24, not 19..16.

Change-Id: Ib53a480bf4328901094ca2c4713e8317321962a1
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/299
Tested-by: build bot (Jenkins)
Reviewed-by: Peter Stuge <peter@stuge.se>
---

diff --git a/src/arch/x86/lib/ioapic.c b/src/arch/x86/lib/ioapic.c
index 3f6420974..81d964cf9 100644
--- a/src/arch/x86/lib/ioapic.c
+++ b/src/arch/x86/lib/ioapic.c
@@ -79,7 +79,7 @@ void setup_ioapic(u32 ioapic_base, u8 ioapic_id)
 		printk(BIOS_DEBUG, "IOAPIC: ID = 0x%02x\n", ioapic_id);
 		/* Set IOAPIC ID if it has been specified. */
 		io_apic_write(ioapic_base, 0x00,
-			(io_apic_read(ioapic_base, 0x00) & 0xfff0ffff) |
+			(io_apic_read(ioapic_base, 0x00) & 0xf0ffffff) |
 			(ioapic_id << 24));
 	}