From: Sebastien Pouliot <sebastien@ximian.com>
Date: Fri, 11 Mar 2005 20:25:21 +0000 (-0000)
Subject: 2005-03-11  Sebastien Pouliot  <sebastien@ximian.com>
X-Git-Url: http://wien.tomnetworks.com/gitweb/?a=commitdiff_plain;h=7455ec0d12d09719c3e3bf4cd5cbadaff300865f;p=mono.git

2005-03-11  Sebastien Pouliot  <sebastien@ximian.com>

	* mono-api-info.exe: Don't process attributes inheriting from
	SecurityAttribute as we won't ever match them 100% (at least from a
	syntaxic point of view). The tool permview.exe can be used to extract
	and compare them if/when required.


svn path=/trunk/mcs/; revision=41716
---

diff --git a/mcs/tools/corcompare/ChangeLog b/mcs/tools/corcompare/ChangeLog
index 699c73f28b2..d4fe58ab5b7 100644
--- a/mcs/tools/corcompare/ChangeLog
+++ b/mcs/tools/corcompare/ChangeLog
@@ -1,3 +1,10 @@
+2005-03-11  Sebastien Pouliot  <sebastien@ximian.com>
+
+	* mono-api-info.exe: Don't process attributes inheriting from 
+	SecurityAttribute as we won't ever match them 100% (at least from a 
+	syntaxic point of view). The tool permview.exe can be used to extract
+	and compare them if/when required.
+
 2005-02-21  Michal Moskal  <malekith@pld-linux.org>
 
 	* Makefile (PROGRAM_INSTALL_DIR): Define in terms of $(libdir).
diff --git a/mcs/tools/corcompare/mono-api-info.cs b/mcs/tools/corcompare/mono-api-info.cs
index 808f54ae2aa..9d30c3f2d63 100644
--- a/mcs/tools/corcompare/mono-api-info.cs
+++ b/mcs/tools/corcompare/mono-api-info.cs
@@ -4,7 +4,7 @@
 // Authors:
 //	Gonzalo Paniagua Javier (gonzalo@ximian.com)
 //
-// (C) 2003 Novell, Inc (http://www.novell.com)
+// Copyright (C) 2003-2005 Novell, Inc (http://www.novell.com)
 //
 
 using System;
@@ -12,6 +12,7 @@ using System.Collections;
 using System.Globalization;
 using System.Reflection;
 using System.Runtime.InteropServices;
+using System.Security.Permissions;
 using System.Text;
 using System.Xml;
 
@@ -813,6 +814,13 @@ namespace Mono.AssemblyInfo
 				if (!t.IsPublic && !t.Name.EndsWith ("TODOAttribute"))
 					continue;
 
+				// we ignore attributes that inherit from SecurityAttribute on purpose as they:
+				// * aren't part of GetCustomAttributes in Fx 1.0/1.1;
+				// * are encoded differently and in a different metadata table; and
+				// * won't ever exactly match MS implementation (from a syntax pov)
+				if (t.IsSubclassOf (typeof (SecurityAttribute)))
+					continue;
+
 				XmlNode node = document.CreateElement ("attribute");
 				AddAttribute (node, "name", t.FullName);