Add BuildEventContextTest and slightly made Equals() clear on how it works.

diff --git a/mcs/class/Microsoft.Build.Framework/Microsoft.Build.Framework/BuildEventContext.cs b/mcs/class/Microsoft.Build.Framework/Microsoft.Build.Framework/BuildEventContext.cs
index 00e4d8fae3406248dd87fe6600fc0f740560b9ea..2a550f46dc3812666e57072c69ddf9bbe2e37459 100644 (file)
--- a/mcs/class/Microsoft.Build.Framework/Microsoft.Build.Framework/BuildEventContext.cs
+++ b/mcs/class/Microsoft.Build.Framework/Microsoft.Build.Framework/BuildEventContext.cs
@@ -59,7 +59,7 @@ namespace Microsoft.Build.Framework
                public override bool Equals (object other)
                {
                        var o = other as BuildEventContext;
-                       return o != null &&
+                       return (object) o != null &&
                                o.NodeId == NodeId &&
                                o.ProjectContextId == ProjectContextId &&
                                o.ProjectInstanceId == ProjectInstanceId &&

diff --git a/mcs/class/Microsoft.Build.Framework/Microsoft.Build.Framework_test.dll.sources b/mcs/class/Microsoft.Build.Framework/Microsoft.Build.Framework_test.dll.sources
index 45374e536e127af7e6121b93e9449a5f749fd62c..b7c639277aec24f48c0e936b29afb771bd2e4af6 100644 (file)
--- a/mcs/class/Microsoft.Build.Framework/Microsoft.Build.Framework_test.dll.sources
+++ b/mcs/class/Microsoft.Build.Framework/Microsoft.Build.Framework_test.dll.sources
@@ -1,5 +1,6 @@
 Microsoft.Build.Framework/BuildErrorEventArgsTest.cs
 Microsoft.Build.Framework/BuildEventArgsTest.cs
+Microsoft.Build.Framework/BuildEventContextTest.cs
 Microsoft.Build.Framework/BuildFinishedEventArgsTest.cs
 Microsoft.Build.Framework/BuildMessageEventArgsTest.cs
 Microsoft.Build.Framework/BuildStartedEventArgsTest.cs

diff --git a/mcs/class/Microsoft.Build.Framework/Test/Microsoft.Build.Framework/BuildEventContextTest.cs b/mcs/class/Microsoft.Build.Framework/Test/Microsoft.Build.Framework/BuildEventContextTest.cs
new file mode 100644 (file)
index 0000000..ea8ff11
--- /dev/null
+++ b/mcs/class/Microsoft.Build.Framework/Test/Microsoft.Build.Framework/BuildEventContextTest.cs
@@ -0,0 +1,29 @@
+using System;
+using Microsoft.Build.Framework;
+using NUnit.Framework;
+
+namespace MonoTests.Microsoft.Build.Framework
+{
+       [TestFixture]
+       public class BuildEventContextTest
+       {
+               [Test]
+               public void Compare ()
+               {
+                       Assert.IsTrue (BuildEventContext.Invalid == BuildEventContext.Invalid, "#1");
+                       Assert.IsFalse (BuildEventContext.Invalid != BuildEventContext.Invalid, "#2");
+                       var inst = new BuildEventContext (0, 0, 0, 0);
+                       Assert.IsFalse (BuildEventContext.Invalid == inst, "#3");
+                       Assert.IsTrue (BuildEventContext.Invalid != inst, "#4");
+                       Assert.IsFalse (BuildEventContext.Invalid == null, "#5");
+                       Assert.IsTrue (BuildEventContext.Invalid != null, "#6");
+                       Assert.IsFalse (BuildEventContext.Invalid.Equals (null), "#7");
+                       Assert.IsFalse (BuildEventContext.Invalid.Equals (inst), "#8");
+                       Assert.IsTrue (BuildEventContext.Invalid.Equals (BuildEventContext.Invalid), "#9");
+                       Assert.IsFalse (inst.Equals (null), "#10");
+                       Assert.IsTrue (inst.Equals (inst), "#11");
+                       Assert.IsFalse (inst.Equals (BuildEventContext.Invalid), "#12");
+               }
+       }
+}
+