2006-11-22 Sebastien Pouliot <sebastien@ximian.com>

	* ImageAttributes.cs: Better MonoTODO description.
	* ImageCodecInfo.cs: Add MonoTODO description.
	* Metafile.cs: Use a single MonoTODO on the class itself. MoMA will
	detect and report that every ctors/methods/properties are throwing
	NotImplementedException.
	* MetafileHeader.cs: Use a single MonoTODO on the class itself. MoMA
	will detect and report that every ctors/methods/properties are
	throwing NotImplementedException.

svn path=/trunk/mcs/; revision=68365

diff --git a/mcs/class/System.Drawing/System.Drawing.Imaging/ChangeLog b/mcs/class/System.Drawing/System.Drawing.Imaging/ChangeLog
index 4e8ea37e4753583d890ad55573dcb96a9ab35dc0..e71f9e0d6035e29c4968f8130973766a7654d71f 100644 (file)
--- a/mcs/class/System.Drawing/System.Drawing.Imaging/ChangeLog
+++ b/mcs/class/System.Drawing/System.Drawing.Imaging/ChangeLog
@@ -1,3 +1,14 @@
+2006-11-22  Sebastien Pouliot  <sebastien@ximian.com>
+
+       * ImageAttributes.cs: Better MonoTODO description.
+       * ImageCodecInfo.cs: Add MonoTODO description.
+       * Metafile.cs: Use a single MonoTODO on the class itself. MoMA will 
+       detect and report that every ctors/methods/properties are throwing  
+       NotImplementedException.
+       * MetafileHeader.cs: Use a single MonoTODO on the class itself. MoMA 
+       will detect and report that every ctors/methods/properties are 
+       throwing NotImplementedException.
+
 2006-10-31  Sebastien Pouliot  <sebastien@ximian.com>
 
        * MetaHeader.cs: Fix layout (order is important in sequential structs)

diff --git a/mcs/class/System.Drawing/System.Drawing.Imaging/ImageAttributes.cs b/mcs/class/System.Drawing/System.Drawing.Imaging/ImageAttributes.cs
index e003745dfbb79106d1d64622a9df43abcc574299..7af13924408e8bde4f6d61b3e09761c6aa0b1705 100644 (file)
--- a/mcs/class/System.Drawing/System.Drawing.Imaging/ImageAttributes.cs
+++ b/mcs/class/System.Drawing/System.Drawing.Imaging/ImageAttributes.cs
@@ -186,7 +186,7 @@ namespace System.Drawing.Imaging {
                        }
                }
 
-               [MonoTODO ("colorMatrixFlag is ignored in libgdiplus")]
+               [MonoTODO ("colorMatrixFlag parameter is ignored in libgdiplus")]
                public void SetColorMatrix (ColorMatrix colorMatrix, ColorMatrixFlag colorMatrixFlag) 
                {
                        IntPtr cm = ColorMatrix.Alloc (colorMatrix);
@@ -200,7 +200,7 @@ namespace System.Drawing.Imaging {
                        }
                }
 
-               [MonoTODO ("colorMatrixFlag is ignored in libgdiplus")]
+               [MonoTODO ("colorMatrixFlag parameter is ignored in libgdiplus")]
                public void SetColorMatrix (ColorMatrix colorMatrix, ColorMatrixFlag colorMatrixFlag, ColorAdjustType colorAdjustType)
                {
                        IntPtr cm = ColorMatrix.Alloc (colorMatrix);
@@ -287,7 +287,7 @@ namespace System.Drawing.Imaging {
                }
                
                
-               [MonoTODO ("grayMatrix is ignored in libgdiplus")]
+               [MonoTODO ("grayMatrix parameter is ignored in libgdiplus")]
                public void SetColorMatrices (ColorMatrix newColorMatrix, ColorMatrix grayMatrix)
                {
                        IntPtr cm = ColorMatrix.Alloc (newColorMatrix);
@@ -307,7 +307,7 @@ namespace System.Drawing.Imaging {
                        }
                }               
                
-               [MonoTODO ("grayMatrix and colorMatrixFlag are ignored in libgdiplus")]
+               [MonoTODO ("grayMatrix and colorMatrixFlag parameters are ignored in libgdiplus")]
                public void SetColorMatrices (ColorMatrix newColorMatrix, ColorMatrix grayMatrix, ColorMatrixFlag flags)
                {
                        IntPtr cm = ColorMatrix.Alloc (newColorMatrix);
@@ -327,8 +327,8 @@ namespace System.Drawing.Imaging {
                        }
                }
                
-               [MonoTODO ("grayMatrix and colorMatrixFlag are ignored in libgdiplus")]
-               public void SetColorMatrices(ColorMatrix newColorMatrix, ColorMatrix grayMatrix, ColorMatrixFlag mode, ColorAdjustType type)
+               [MonoTODO ("grayMatrix and colorMatrixFlag parameters are ignored in libgdiplus")]
+               public void SetColorMatrices (ColorMatrix newColorMatrix, ColorMatrix grayMatrix, ColorMatrixFlag mode, ColorAdjustType type)
                {
                        IntPtr cm = ColorMatrix.Alloc (newColorMatrix);
                        try {

diff --git a/mcs/class/System.Drawing/System.Drawing.Imaging/ImageCodecInfo.cs b/mcs/class/System.Drawing/System.Drawing.Imaging/ImageCodecInfo.cs
index ecdc66b5760952cc609ec7bdb9e940695ed00e77..123afeaa016be35aee3a0c3821c46565fac49241 100644 (file)
--- a/mcs/class/System.Drawing/System.Drawing.Imaging/ImageCodecInfo.cs
+++ b/mcs/class/System.Drawing/System.Drawing.Imaging/ImageCodecInfo.cs
@@ -198,7 +198,7 @@ namespace System.Drawing.Imaging {
                        set { signatureMasks = value; }
                }
 
-               [MonoTODO]
+               [MonoTODO ("Property value is ignored.")]
                [CLSCompliant(false)]
                public byte[][] SignaturePatterns 
                {

diff --git a/mcs/class/System.Drawing/System.Drawing.Imaging/Metafile.cs b/mcs/class/System.Drawing/System.Drawing.Imaging/Metafile.cs
index 9367b7887674675c03576c5d8f37b88c5eb2792d..fd5df8ccf1c46b2add063216536c88e2a6fc45f9 100644 (file)
--- a/mcs/class/System.Drawing/System.Drawing.Imaging/Metafile.cs
+++ b/mcs/class/System.Drawing/System.Drawing.Imaging/Metafile.cs
@@ -35,6 +35,7 @@ using System.Runtime.InteropServices;
 
 namespace System.Drawing.Imaging {
 
+       [MonoTODO ("Metafiles, both WMF and EMF formats, aren't supported.")]
        [Serializable]
 #if ONLY_1_1
        [ComVisible (false)]
@@ -43,238 +44,200 @@ namespace System.Drawing.Imaging {
        public sealed class Metafile : Image {
 
                // constructors
-               [MonoTODO]
+
                public Metafile (Stream stream) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (string filename) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (IntPtr henhmetafile, bool deleteEmf) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (IntPtr referenceHtc, EmfType emfType) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (IntPtr referenceHtc, Rectangle frameRect) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (IntPtr referenceHtc, RectangleF frameRect) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (IntPtr hmetafile, WmfPlaceableFileHeader wmfHeader) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (Stream stream, IntPtr referenceHtc) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (String fileName, IntPtr referenceHtc) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (IntPtr referenceHdc, EmfType emfType, string description) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (IntPtr referenceHdc, Rectangle frameRect, MetafileFrameUnit frameUnit) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (IntPtr referenceHdc, RectangleF frameRect, MetafileFrameUnit frameUnit) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (IntPtr hmetafile, WmfPlaceableFileHeader wmfHeader, bool deleteWmf) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (Stream stream, IntPtr referenceHdc, EmfType type) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (Stream stream, IntPtr referenceHdc, Rectangle frameRect) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (Stream stream, IntPtr referenceHdc, RectangleF frameRect) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (string fileName, IntPtr referenceHdc, EmfType type) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (string fileName, IntPtr referenceHdc, Rectangle frameRect) 
                {
                        throw new NotImplementedException ();
                }
                
-               [MonoTODO]
                public Metafile (string fileName, IntPtr referenceHdc, RectangleF frameRect) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (IntPtr referenceHdc, Rectangle frameRect, MetafileFrameUnit frameUnit, EmfType type) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (IntPtr referenceHdc, RectangleF frameRect, MetafileFrameUnit frameUnit, EmfType type) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (Stream stream, IntPtr referenceHtc, EmfType type, string description) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (Stream stream, IntPtr referenceHdc, Rectangle frameRect, MetafileFrameUnit frameUnit) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (Stream stream, IntPtr referenceHdc, RectangleF frameRect, MetafileFrameUnit frameUnit) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (string fileName, IntPtr referenceHdc, EmfType type, string description)
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (string fileName, IntPtr referenceHdc, Rectangle frameRect, MetafileFrameUnit frameUnit) 
                {
                        throw new NotImplementedException ();
                }
                
-               [MonoTODO]
                public Metafile (string fileName, IntPtr referenceHdc, RectangleF frameRect, MetafileFrameUnit frameUnit)
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (IntPtr referenceHdc, Rectangle frameRect, MetafileFrameUnit frameUnit, EmfType type, string description) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (IntPtr referenceHdc, RectangleF frameRect, MetafileFrameUnit frameUnit, EmfType type, string description) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (Stream stream, IntPtr referenceHdc, Rectangle frameRect, MetafileFrameUnit frameUnit, EmfType type) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (Stream stream, IntPtr referenceHdc, RectangleF frameRect, MetafileFrameUnit frameUnit, EmfType type) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (string fileName, IntPtr referenceHdc, Rectangle frameRect, MetafileFrameUnit frameUnit, EmfType type) 
                {
                        throw new NotImplementedException ();
                }
                
-               [MonoTODO]
                public Metafile (string fileName, IntPtr referenceHdc, Rectangle frameRect, MetafileFrameUnit frameUnit, string description) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (string fileName, IntPtr referenceHdc, RectangleF frameRect, MetafileFrameUnit frameUnit, EmfType type) 
                {
                        throw new NotImplementedException ();
                }
                
-               [MonoTODO]
                public Metafile (string fileName, IntPtr referenceHdc, RectangleF frameRect, MetafileFrameUnit frameUnit, string description) 
                {
                        throw new NotImplementedException ();
                }
                
-               [MonoTODO]
                public Metafile (Stream stream, IntPtr referenceHdc, Rectangle frameRect, MetafileFrameUnit frameUnit, EmfType type,
                                                                                                                        string description) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (Stream stream, IntPtr referenceHdc, RectangleF frameRect, MetafileFrameUnit frameUnit, EmfType type,
                                                                                                                        string description) 
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public Metafile (string fileName, IntPtr referenceHdc, Rectangle frameRect, MetafileFrameUnit frameUnit, EmfType type,
                                                                                                                        string description) 
                {
                        throw new NotImplementedException ();
                }
                
-               [MonoTODO]
                public Metafile (string fileName, IntPtr referenceHdc, RectangleF frameRect, MetafileFrameUnit frameUnit, EmfType type,
                                                                                                                        string description) 
                {
@@ -282,47 +245,40 @@ namespace System.Drawing.Imaging {
                }
 
                // methods
-               [MonoTODO]
-               public IntPtr GetHenhmetafile()
+
+               public IntPtr GetHenhmetafile ()
                {
                        throw new NotImplementedException ();
                }
 
-               public MetafileHeader GetMetafileHeader()
+               public MetafileHeader GetMetafileHeader ()
                {
                        return GetMetafileHeader (GetHenhmetafile () );
                }
 
-               [MonoTODO]
-               public static MetafileHeader GetMetafileHeader(IntPtr henhmetafile)
+               public static MetafileHeader GetMetafileHeader (IntPtr henhmetafile)
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
-               public static MetafileHeader GetMetafileHeader(Stream stream)
+               public static MetafileHeader GetMetafileHeader (Stream stream)
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
-               public static MetafileHeader GetMetafileHeader(string fileName)
+               public static MetafileHeader GetMetafileHeader (string fileName)
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
-               public static MetafileHeader GetMetafileHeader(IntPtr henhmetafile, WmfPlaceableFileHeader wmfHeader)
+               public static MetafileHeader GetMetafileHeader (IntPtr henhmetafile, WmfPlaceableFileHeader wmfHeader)
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
-               public void PlayRecord(EmfPlusRecordType recordType, int flags, int dataSize, byte[] datawmfHeader)
+               public void PlayRecord (EmfPlusRecordType recordType, int flags, int dataSize, byte[] datawmfHeader)
                {
                        throw new NotImplementedException ();
                }
-               // properties
        }
-
 }

diff --git a/mcs/class/System.Drawing/System.Drawing.Imaging/MetafileHeader.cs b/mcs/class/System.Drawing/System.Drawing.Imaging/MetafileHeader.cs
index a248d74cc3997594c4f90d5a0f5ee35cf3cb72a9..0361eb3989e25717c678165bf3f72d84889df0f7 100644 (file)
--- a/mcs/class/System.Drawing/System.Drawing.Imaging/MetafileHeader.cs
+++ b/mcs/class/System.Drawing/System.Drawing.Imaging/MetafileHeader.cs
@@ -1,14 +1,12 @@
 //
 // System.Drawing.Imaging.MetafileHeader.cs
 //
-// (C) 2002 Ximian, Inc.  http://www.ximian.com
 // Author: Everaldo Canuto
 // eMail: everaldo.canuto@bol.com.br
 // Dennis Hayes (dennish@raytek.com)
 //
-
-//
-// Copyright (C) 2004 Novell, Inc (http://www.novell.com)
+// (C) 2002 Ximian, Inc.  http://www.ximian.com
+// Copyright (C) 2004, 2006 Novell, Inc (http://www.novell.com)
 //
 // Permission is hereby granted, free of charge, to any person obtaining
 // a copy of this software and associated documentation files (the
@@ -29,17 +27,16 @@
 // OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
 // WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 //
-using System;
+
 using System.Runtime.InteropServices;
 
 namespace System.Drawing.Imaging {
 
-       [MonoTODO]
+       [MonoTODO ("Metafiles, both WMF and EMF formats, aren't supported.")]
 #if !TARGET_JVM
        [StructLayout(LayoutKind.Sequential)]
 #endif
-       public sealed class MetafileHeader 
-       {
+       public sealed class MetafileHeader {
                
                //constructor
                internal MetafileHeader()
@@ -48,97 +45,87 @@ namespace System.Drawing.Imaging {
                }
 
                // methods
-               [MonoTODO]
-               public bool IsDisplay() {
+
+               public bool IsDisplay ()
+               {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
-               public bool IsEmf() {
+               public bool IsEmf ()
+               {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
-               public bool IsEmfOrEmfPlus() {
+               public bool IsEmfOrEmfPlus ()
+               {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
-               public bool IsEmfPlus() {
+               public bool IsEmfPlus ()
+               {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
-               public bool IsEmfPlusDual() {
+               public bool IsEmfPlusDual ()
+               {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
-               public bool IsEmfPlusOnly() {
+               public bool IsEmfPlusOnly ()
+               {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
-               public bool IsWmf() {
+               public bool IsWmf ()
+               {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
-               public bool IsWmfPlaceable() {
+               public bool IsWmfPlaceable ()
+               {
                        throw new NotImplementedException ();
                }
 
                // properties
-               [MonoTODO]
+
                public Rectangle Bounds {
                        get { throw new NotImplementedException (); }
                }
 
-               [MonoTODO]
                public float DpiX {
                        get { throw new NotImplementedException (); }
                }
                
-               [MonoTODO]
                public float DpiY {
                        get { throw new NotImplementedException (); }
                }
                
-               [MonoTODO]
                public int EmfPlusHeaderSize {
                        get { throw new NotImplementedException (); }
                }
 
-               [MonoTODO]
                public int LogicalDpiX {
                        get { throw new NotImplementedException (); }
                }
                
-               [MonoTODO]
                public int LogicalDpiY {
                        get { throw new NotImplementedException (); }
                }
                
-               [MonoTODO]
                public int MetafileSize {
                        get { throw new NotImplementedException (); }
                }
 
-               [MonoTODO]
                public MetafileType Type {
                        get { throw new NotImplementedException (); }
                }
 
-               [MonoTODO]
                public int Version {
                        get { throw new NotImplementedException (); }
                }
                
-               [MonoTODO]
                public MetaHeader WmfHeader {
                        get { throw new NotImplementedException (); }
                }
-
        }
-
 }