svn path=/trunk/mcs/; revision=107345

diff --git a/mcs/class/System.Data.OracleClient/System.Data.OracleClient.Oci/Changelog b/mcs/class/System.Data.OracleClient/System.Data.OracleClient.Oci/Changelog
index e8b4497724bf964a96733e26b6141078efde9ab5..e85a9c2d71c44b34bc481f2886a2dfea4befb222 100644 (file)
--- a/mcs/class/System.Data.OracleClient/System.Data.OracleClient.Oci/Changelog
+++ b/mcs/class/System.Data.OracleClient/System.Data.OracleClient.Oci/Changelog
@@ -1,3 +1,10 @@
+2008-07-06  Sebastien Pouliot  <sebastien@ximian.com> 
+
+       * OciDefineHandle.cs,
+       * OciParameterDescriptor.cs: Replace a few Type.GetType("System.Byte[])
+       by typeof(byte[])
+       [Found using Gendarme AvoidTypeGetTypeForConstantStringsRule]
+
 2007-01-19 Leszek Ciesielski <skolima@gmail.com>
        * OciCalls.cs: Speed up of the memory allocation
 

diff --git a/mcs/class/System.Data.OracleClient/System.Data.OracleClient.Oci/OciDefineHandle.cs b/mcs/class/System.Data.OracleClient/System.Data.OracleClient.Oci/OciDefineHandle.cs
index a9d01896454f25b25b1fbade1403004945c1dbbe..23a44f007c5e1216f9507c1cdc208965beac119a 100644 (file)
--- a/mcs/class/System.Data.OracleClient/System.Data.OracleClient.Oci/OciDefineHandle.cs
+++ b/mcs/class/System.Data.OracleClient/System.Data.OracleClient.Oci/OciDefineHandle.cs
@@ -322,7 +322,7 @@ namespace System.Data.OracleClient.Oci
                        if (ociType == OciDataType.Clob)
                                fieldType = typeof(System.String);
                        else if (ociType == OciDataType.Blob)
-                               fieldType = Type.GetType("System.Byte[]");
+                               fieldType = typeof(byte[]);
 
                        int status = 0;
 
@@ -362,7 +362,7 @@ namespace System.Data.OracleClient.Oci
                void DefineRaw (int position)
                {
                        ociType = OciDataType.Raw;
-                       fieldType = Type.GetType("System.Byte[]");
+                       fieldType = typeof (byte[]);
 
                        value = OciCalls.AllocateClear (definedSize);
 

diff --git a/mcs/class/System.Data.OracleClient/System.Data.OracleClient.Oci/OciParameterDescriptor.cs b/mcs/class/System.Data.OracleClient/System.Data.OracleClient.Oci/OciParameterDescriptor.cs
index 52e4b6c0cfb2beeb2d23a462847e8d4f7b7050a8..6c419e1c6cc23f8da6af6d80e1461d571c880dfc 100644 (file)
--- a/mcs/class/System.Data.OracleClient/System.Data.OracleClient.Oci/OciParameterDescriptor.cs
+++ b/mcs/class/System.Data.OracleClient/System.Data.OracleClient.Oci/OciParameterDescriptor.cs
@@ -153,17 +153,17 @@ namespace System.Data.OracleClient.Oci {
                        case "Date":
                                return typeof (System.DateTime);
                        case "VarRaw":
-                               return Type.GetType ("System.Byte[]");
+                               return typeof (byte[]);
                        case "Raw":
-                               return Type.GetType ("System.Byte[]");
+                               return typeof (byte[]);
                        case "LongRaw":
-                               return Type.GetType ("System.Byte[]");
+                               return typeof (byte[]);
                        case "UnsignedInt":
                                return typeof (System.UInt32);
                        case "LongVarChar":
                                return typeof (System.String);
                        case "LongVarRaw":
-                               return Type.GetType ("System.Byte[]");
+                               return typeof (byte[]);
                        case "Char":
                                return typeof (System.String);
                        case "CharZ":
@@ -177,9 +177,9 @@ namespace System.Data.OracleClient.Oci {
                        case "Clob":
                                return typeof (System.String);
                        case "Blob":
-                               return Type.GetType ("System.Byte[]");
+                               return typeof (byte[]);
                        case "BFile":
-                               return Type.GetType ("System.Byte[]");
+                               return typeof (byte[]);
                        case "OciString":
                                return typeof (System.String);
                        case "OciDate":