* src/vm/class.c (class_resolveclassmethod): Removed obsolete XXX comments.
authoredwin <none@none>
Fri, 26 May 2006 11:48:10 +0000 (11:48 +0000)
committeredwin <none@none>
Fri, 26 May 2006 11:48:10 +0000 (11:48 +0000)
(class_resolveinterfacemethod): Likewise.
(class_resolvefield): Likewise.

* src/vm/classcache.h: Removed obsolete XXX comment.

* src/vm/jit/allocator/lsra.h: Changed TYPE_XXX to TYPE_* in comments.
* src/vm/jit/jit.c: Likewise.

* src/native/vm/VMObject.c (Java_java_lang_VMObject_clone):
Removed obsolete XXX comment.

* src/mm/memory.c (dump_release): Removed obsolete debugging code.

src/mm/memory.c
src/native/vm/VMObject.c
src/vm/class.c
src/vm/classcache.h
src/vm/jit/allocator/lsra.h
src/vm/jit/jit.c

index e166443055fd4d7f57c76ab1dbba499bf45d81c4..db8bf3e6cff6e1ab8b1c09ef82ca4d600f93e511 100644 (file)
@@ -29,7 +29,7 @@
    Changes: Christian Thalinger
                        Edwin Steiner
 
-   $Id: memory.c 4921 2006-05-15 14:24:36Z twisti $
+   $Id: memory.c 4957 2006-05-26 11:48:10Z edwin $
 
 */
 
@@ -463,17 +463,6 @@ void dump_release(s4 size)
        while (di->currentdumpblock && di->allocateddumpsize - di->currentdumpblock->size >= di->useddumpsize) {
                dumpblock *tmp = di->currentdumpblock;
 
-#if 0
-               /* XXX TWISTI: can someone explain this to me? */
-#ifdef TRACECALLARGS
-               /* Keep the first dumpblock if we don't free memory. Otherwise
-                * a new dumpblock is allocated each time and we run out of
-                * memory.
-                */
-               if (!oldtop->prev) break;
-#endif
-#endif
-
                di->allocateddumpsize -= tmp->size;
                di->currentdumpblock = tmp->prev;
 
index 9bc68a404e6bffb3ebd38f0920d145d0ca4c1fe5..06d76a420f89ea5567d6d183aff05298d28c5767 100644 (file)
@@ -29,7 +29,7 @@
    Changes: Joseph Wenninger
             Christian Thalinger
 
-   $Id: VMObject.c 4921 2006-05-15 14:24:36Z twisti $
+   $Id: VMObject.c 4957 2006-05-26 11:48:10Z edwin $
 
 */
 
@@ -119,7 +119,6 @@ JNIEXPORT java_lang_Object* JNICALL Java_java_lang_VMObject_clone(JNIEnv *env, j
         return NULL;
     }
 
-    /* XXX should use vftbl */
     c = this->header.vftbl->class;
     new = (java_lang_Object *) builtin_new(c);
 
index cb296a06bceae1940ee44a83f111798eeb762e97..93be8377ffc395bb3a28dfc16a8778d8c2c018fa 100644 (file)
@@ -31,7 +31,7 @@
             Christian Thalinger
                        Edwin Steiner
 
-   $Id: class.c 4921 2006-05-15 14:24:36Z twisti $
+   $Id: class.c 4957 2006-05-26 11:48:10Z edwin $
 
 */
 
@@ -850,9 +850,6 @@ methodinfo *class_resolveclassmethod(classinfo *c, utf *name, utf *desc,
        methodinfo *m;
        s4          i;
 
-       /* XXX resolve class c */
-       /* XXX check access from REFERER to C */
-       
 /*     if (c->flags & ACC_INTERFACE) { */
 /*             if (throwexception) */
 /*                     *exceptionptr = */
@@ -913,9 +910,6 @@ methodinfo *class_resolveinterfacemethod(classinfo *c, utf *name, utf *desc,
 {
        methodinfo *mi;
 
-       /* XXX resolve class c */
-       /* XXX check access from REFERER to C */
-       
        if (!(c->flags & ACC_INTERFACE)) {
                if (throwexception)
                        *exceptionptr =
@@ -1066,9 +1060,6 @@ fieldinfo *class_resolvefield(classinfo *c, utf *name, utf *desc,
 {
        fieldinfo *fi;
 
-       /* XXX resolve class c */
-       /* XXX check access from REFERER to C */
-       
        fi = class_resolvefield_int(c, name, desc);
 
        if (!fi) {
index 4be010936938636aaf469df3117627c3e7475dcf..ec0dcc3f5da0298c17a5a1566bbd435dcb4ed480 100644 (file)
@@ -28,7 +28,7 @@
 
    Changes:
 
-   $Id: classcache.h 4945 2006-05-23 19:52:47Z motse $
+   $Id: classcache.h 4957 2006-05-26 11:48:10Z edwin $
 
 */
 
@@ -93,7 +93,7 @@ extern java_objectheader *lock_hashtable_classcache;
 /*   class name to this class object in the future                            */
 /*                                                                            */
 /* The classcache_class_entry:s approximate the equivalence classes created   */
-/* by the loading constraints and (XXX?) the equivalence of loaded classes.   */
+/* by the loading constraints and the equivalence of loaded classes.          */
 /*                                                                            */
 /* When a loading constraint (loaderA,loaderB,NAME) is added, then the        */
 /* classcache_class_entry:s for NAME containing loaderA and loaderB resp.     */
index 609e619bd6e43b14f9fb68be3c2ddaafee553de1..67665f85db6a31b32899465bd0bcb8abda9f4ceb 100644 (file)
@@ -28,7 +28,7 @@
 
    Changes: Edwin Steiner
 
-   $Id: lsra.h 4699 2006-03-28 14:52:32Z twisti $
+   $Id: lsra.h 4957 2006-05-26 11:48:10Z edwin $
 
 */
 
@@ -106,7 +106,7 @@ struct lifetime {
        int i_start;                /* instruction number of first use */
        int i_end;                  /* instruction number of last use */
        int v_index;           /* local variable index or negative for stackslots */
-       int type;                   /* TYPE_XXX or -1 for unused lifetime */
+       int type;                   /* TYPE_* or -1 for unused lifetime */
        long usagecount;            /* number of references*/
        int reg;                    /* regoffset allocated by lsra*/
        int savedvar;
index 4fbfca20a1142a0fc9a4295352320a7c724a77e1..eb4a19fdbb94fe22c37ad6a4f1ef833ff518122b 100644 (file)
@@ -31,7 +31,7 @@
             Christian Thalinger
             Christian Ullrich
 
-   $Id: jit.c 4921 2006-05-15 14:24:36Z twisti $
+   $Id: jit.c 4957 2006-05-26 11:48:10Z edwin $
 
 */
 
@@ -164,7 +164,7 @@ int jcommandsize[256] = {
 #define ICMD_IFLE_ICONST      20
        3,
                                            /* order of LOAD instructions must be */
-                                           /* equal to order of TYPE_XXX defines */
+                                           /* equal to order of TYPE_*   defines */
 #define JAVA_ILOAD            21
 #define ICMD_ILOAD            21        /* op1 = local variable               */
        2,                      
@@ -265,7 +265,7 @@ int jcommandsize[256] = {
 #define ICMD_SALOAD           53
        1,
                                            /* order of STORE instructions must be*/
-                                           /* equal to order of TYPE_XXX defines */
+                                           /* equal to order of TYPE_* defines   */
 #define JAVA_ISTORE           54
 #define ICMD_ISTORE           54        /* op1 = local variable               */
        2,