* HttpSoapWebServiceHandler.cs, SoapHttpClientProtocol.cs: Do not use

	  indented format for requests and responses. SOAPAction header value
	  must be quoted (fix by Yaacov Akiba Slama).

svn path=/trunk/mcs/; revision=22345

diff --git a/mcs/class/System.Web.Services/System.Web.Services.Protocols/ChangeLog b/mcs/class/System.Web.Services/System.Web.Services.Protocols/ChangeLog
index 933c63f1228842bdcef2f55590f5ffb52dc76712..854b46109d3f8e05d22d4922939bcc89805c75d3 100644 (file)
--- a/mcs/class/System.Web.Services/System.Web.Services.Protocols/ChangeLog
+++ b/mcs/class/System.Web.Services/System.Web.Services.Protocols/ChangeLog
@@ -1,3 +1,9 @@
+2004-01-21  Lluis Sanchez Gual <lluis@ximian.com>
+
+       * HttpSoapWebServiceHandler.cs, SoapHttpClientProtocol.cs: Do not use 
+         indented format for requests and responses. SOAPAction header value
+         must be quoted (fix by Yaacov Akiba Slama).
+       
 2004-01-21  Lluis Sanchez Gual <lluis@ximian.com>
 
        * Methods.cs: Set the correct namespaces for Fault. This fixes bug #53117.

diff --git a/mcs/class/System.Web.Services/System.Web.Services.Protocols/HttpSoapWebServiceHandler.cs b/mcs/class/System.Web.Services/System.Web.Services.Protocols/HttpSoapWebServiceHandler.cs
index cf51dfa5729febfc85ffbbe47aaf359bfcc39379..dc1ba17fa5df1e1a7dfadfc22ca75aa27040ec81 100755 (executable)
--- a/mcs/class/System.Web.Services/System.Web.Services.Protocols/HttpSoapWebServiceHandler.cs
+++ b/mcs/class/System.Web.Services/System.Web.Services.Protocols/HttpSoapWebServiceHandler.cs
@@ -239,7 +239,6 @@ namespace System.Web.Services.Protocols
                                
                                // What a waste of UTF8encoders, but it has to be thread safe.
                                XmlTextWriter xtw = new XmlTextWriter (outStream, new UTF8Encoding (false));
-                               xtw.Formatting = Formatting.Indented;   // TODO: remove formatting when code is stable
                                
                                if (message.Exception == null)
                                        WebServiceHelper.WriteSoapMessage (xtw, _typeStubInfo, methodInfo.Use, methodInfo.ResponseSerializer, message.OutParameters, message.Headers);

diff --git a/mcs/class/System.Web.Services/System.Web.Services.Protocols/SoapHttpClientProtocol.cs b/mcs/class/System.Web.Services/System.Web.Services.Protocols/SoapHttpClientProtocol.cs
index f0b21fb16b7930318c98e04e13bc1ba5bfff4e58..41611fb95de22b046593686297b1d9f27c606c7a 100644 (file)
--- a/mcs/class/System.Web.Services/System.Web.Services.Protocols/SoapHttpClientProtocol.cs
+++ b/mcs/class/System.Web.Services/System.Web.Services.Protocols/SoapHttpClientProtocol.cs
@@ -167,7 +167,7 @@ namespace System.Web.Services.Protocols {
                        WebRequest request = GetWebRequest (uri);\r
                        request.Method = "POST";\r
                        WebHeaderCollection headers = request.Headers;\r
-                       headers.Add ("SOAPAction", message.Action);\r
+                       headers.Add ("SOAPAction", "\"" + message.Action + "\"");\r
                        request.ContentType = message.ContentType + "; charset=utf-8";\r
                        return request;\r
                }\r
@@ -184,7 +184,6 @@ namespace System.Web.Services.Protocols {
 \r
                                // What a waste of UTF8encoders, but it has to be thread safe.\r
                                XmlTextWriter xtw = new XmlTextWriter (s, new UTF8Encoding (false));\r
-                               xtw.Formatting = Formatting.Indented;\r
 \r
                                WebServiceHelper.WriteSoapMessage (xtw, type_info, message.MethodStubInfo.Use, message.MethodStubInfo.RequestSerializer, message.Parameters, message.Headers);\r
 \r