[mono-api-html] Fix bogus IgnoreParameterNameChanges behavior.

It never ignored parameter name changes. Make the entire code just simple.

diff --git a/mcs/tools/mono-api-html/MemberComparer.cs b/mcs/tools/mono-api-html/MemberComparer.cs
index 2acb5ca3f5ac98c5c743ea4235ce938a46b4ecb9..72eed73390fec879e2d77b51835d648ec50c38d3 100644 (file)
--- a/mcs/tools/mono-api-html/MemberComparer.cs
+++ b/mcs/tools/mono-api-html/MemberComparer.cs
@@ -374,7 +374,7 @@ namespace Xamarin.ApiDiff {
                                                change.Append (paramSourceType);
                                        }
                                        change.Append (" ");
-                                       if (paramSourceName != paramTargetName) {
+                                       if (!State.IgnoreParameterNameChanges && paramSourceName != paramTargetName) {
                                                change.AppendModified (paramSourceName, paramTargetName, true);
                                        } else {
                                                change.Append (paramSourceName);
@@ -404,12 +404,6 @@ namespace Xamarin.ApiDiff {
                        }
 
                        change.Append (")");
-
-                       // Ignore any parameter name changes if requested.
-                       if (State.IgnoreParameterNameChanges && !change.Breaking) {
-                               change.AnyChange = false;
-                               change.HasIgnoredChanges = true;
-                       }
                }
 
                void RenderVTable (MethodAttributes source, MethodAttributes target, ApiChange change)