The flashrom makefile wants to redirect both stdout and stderr to

/dev/null for one compile test.
The old variant of using &>/dev/null works on bash and zsh, but not on
dash and tcsh. dash and tcsh interpret it as "background command and
truncate /dev/null" which is not what we want. >& works on tcsh and
bash, but it is not POSIX compliant.
Since make uses /bin/sh and /bin/sh has to be POSIX compliant, we can
use the POSIX variant of stderr and stdout redirection.

>/dev/null 2>&1
is POSIX compliant. This is specified in SuSv3, Shell Command Language,
sections 2.7.2 and 2.7.6.

Signed-off-by: Stephan Guilloux <stephan.guilloux@free.fr>
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Ward Vandewege <ward@gnu.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4211 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

diff --git a/util/flashrom/Makefile b/util/flashrom/Makefile
index cf9570a6bc851a0549d5de7fb59f665ecff15a36..4699784c07342dfd1d83013528eef593d425decb 100644 (file)
--- a/util/flashrom/Makefile
+++ b/util/flashrom/Makefile
@@ -65,7 +65,7 @@ pciutils:
                   echo "struct pci_access *pacc;";        \
                   echo "int main(int argc, char **argv)"; \
                   echo "{ pacc = pci_alloc(); return 0; }"; ) > .test.c )
-       @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) &>/dev/null &&     \
+       @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >/dev/null 2>&1 && \
                echo "found." || ( echo "not found."; echo;             \
                echo "Please install pciutils-devel and zlib-devel.";   \
                echo "See README for more information."; echo;          \