Fix USB Debug Device for Intel ICH chipsets
authorStefan Reinauer <stepan@coresystems.de>
Sat, 24 Oct 2009 13:02:14 +0000 (13:02 +0000)
committerStefan Reinauer <stepan@openbios.org>
Sat, 24 Oct 2009 13:02:14 +0000 (13:02 +0000)
The USB EHCI controller reset is not really needed on ICH, and in fact
the code bailed out there which is the most stupid thing to do. So just
keep trying.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4836 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

src/lib/usbdebug_direct.c

index 3125dc084dbfb220a990108ab279258b6280db57..48875dc610cf84d4bc90f78d685a410980f2cda2 100644 (file)
@@ -407,11 +407,10 @@ try_next_port:
                cmd = readl(&ehci_regs->command);
        } while ((cmd & CMD_RESET) && (--loop > 0));
 
-       if(!loop) {
+       if(!loop)
                dbgp_printk("Could not reset EHCI controller.\n");
-               return;
-       }
-       dbgp_printk("EHCI controller reset successfully.\n");
+       else
+               dbgp_printk("EHCI controller reset successfully.\n");
 
        /* Claim ownership, but do not enable yet */
        ctrl = readl(&ehci_debug->control);