* Mono.Mozilla/AsciiString.cs, Mono.Mozilla/UniString.cs: Fix for string

getter cache, always mark the string as dirty when fetching the handle.

2008-04-04  Andreia Gaita <avidigal@novell.com>

svn path=/trunk/mcs/; revision=99869

diff --git a/mcs/class/Mono.Mozilla/ChangeLog b/mcs/class/Mono.Mozilla/ChangeLog
index f525e6ee56f600ee8ff370d950b8120ba2340616..0ef6b858836e51b655888caca2e5e856fc41b2c0 100644 (file)
--- a/mcs/class/Mono.Mozilla/ChangeLog
+++ b/mcs/class/Mono.Mozilla/ChangeLog
@@ -1,3 +1,8 @@
+2008-04-04  Andreia Gaita <avidigal@novell.com> 
+
+       * Mono.Mozilla/AsciiString.cs, Mono.Mozilla/UniString.cs: Fix for string
+       getter cache, always mark the string as dirty when fetching the handle.
+
 2008-03-27  Andreia Gaita <avidigal@novell.com> 
 
        * Mono.WebBrowser/IWebBrowser.cs, Mono.Mozilla/WebBrowser.cs: Add

diff --git a/mcs/class/Mono.Mozilla/Mono.Mozilla/AsciiString.cs b/mcs/class/Mono.Mozilla/Mono.Mozilla/AsciiString.cs
index 0fea97f1049e3ec08f3066dc623bd01a2df380cb..b75caf6b89b60162b3cec78ca762f0cabb8e1df7 100644 (file)
--- a/mcs/class/Mono.Mozilla/Mono.Mozilla/AsciiString.cs
+++ b/mcs/class/Mono.Mozilla/Mono.Mozilla/AsciiString.cs
@@ -43,7 +43,7 @@ namespace Mono.Mozilla
                private nsStringContainer unmanagedContainer;
                private HandleRef handle;
                private string str = String.Empty;
-               private bool dirty = false;
+               private bool dirty;
                
 
                public AsciiString(string value)
@@ -85,9 +85,7 @@ namespace Mono.Mozilla
                
                public HandleRef Handle {
                        get {
-                               if (!str.Equals (String.Empty)) {
-                                       dirty = true;
-                               }
+                               dirty = true;
                                return handle; 
                        }
                }
@@ -112,12 +110,12 @@ namespace Mono.Mozilla
                }
                
                public int Length {
-                       get { return str.Length; }
+                       get { return String.Length; }
                }
                
                public override string ToString ()
                {
-                       return str;
+                       return String;
                }
                
        }

diff --git a/mcs/class/Mono.Mozilla/Mono.Mozilla/UniString.cs b/mcs/class/Mono.Mozilla/Mono.Mozilla/UniString.cs
index ec73260a7be01736ed8ac45c3d18fce5e74a9a0c..a6eccf26d3f1fafd7418c94cfe493923f1503712 100644 (file)
--- a/mcs/class/Mono.Mozilla/Mono.Mozilla/UniString.cs
+++ b/mcs/class/Mono.Mozilla/Mono.Mozilla/UniString.cs
@@ -41,7 +41,7 @@ namespace Mono.Mozilla
                private nsStringContainer unmanagedContainer;
                private HandleRef handle;
                private string str = String.Empty;
-               private bool dirty = false;
+               private bool dirty;
                
                public UniString(string value)
                {
@@ -82,8 +82,7 @@ namespace Mono.Mozilla
                
                public HandleRef Handle {
                        get {
-                               if (!str.Equals (String.Empty))
-                                       dirty = true;
+                               dirty = true;
                                return handle; 
                        }
                }
@@ -107,13 +106,13 @@ namespace Mono.Mozilla
                        }
                }
                
-               public int Length {
-                       get { return str.Length; }
+               public int Length {\r
+                       get { return String.Length; }
                }
                
                public override string ToString ()
-               {
-                       return str;
+               {\r
+                       return String;
                }
                
        }