* DataGridView.cs: fix compiler warnings.
authorChris Toshok <toshok@novell.com>
Tue, 5 Dec 2006 18:35:11 +0000 (18:35 -0000)
committerChris Toshok <toshok@novell.com>
Tue, 5 Dec 2006 18:35:11 +0000 (18:35 -0000)
* PrintControllerWithStatusDialog.cs: same.

* ToolBar.cs: same.

* FolderBrowserDialog.cs: same.

* Splitter.cs: same.

* DataGridViewComboBoxCell.cs: same.

* XplatUIWin32.cs: same.

* PictureBox.cs: same.

* Win32DnD.cs: same.

* PageSetupDialog.cs: same.

* FileDialog.cs: same.

* PrintDialog.cs: same.

* DataGridTextBoxColumn.cs: same.

* DrawTreeNodeEventArgs.cs: same (and fix corcompare)

2006-12-05  Chris Toshok  <toshok@ximian.com>

svn path=/trunk/mcs/; revision=69060

17 files changed:
mcs/class/Managed.Windows.Forms/System.Windows.Forms/ChangeLog
mcs/class/Managed.Windows.Forms/System.Windows.Forms/DataGrid.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/DataGridTextBoxColumn.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/DataGridView.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/DataGridViewComboBoxCell.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/DrawTreeNodeEventArgs.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/FileDialog.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/FolderBrowserDialog.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/PageSetupDialog.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/PictureBox.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/PrintControllerWithStatusDialog.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/PrintDialog.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/Splitter.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/TabPage.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/ToolBar.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/Win32DnD.cs
mcs/class/Managed.Windows.Forms/System.Windows.Forms/XplatUIWin32.cs

index 34abb6ea1cb45e3c5e36c7f31aa5f5dac865d653..a8af3ff64bcb3c556e6b836adacbc4687b33626c 100644 (file)
@@ -1,3 +1,33 @@
+2006-12-05  Chris Toshok  <toshok@ximian.com>
+
+       * DataGridView.cs: fix compiler warnings.
+
+       * PrintControllerWithStatusDialog.cs: same.
+
+       * ToolBar.cs: same.
+
+       * FolderBrowserDialog.cs: same.
+
+       * Splitter.cs: same.
+
+       * DataGridViewComboBoxCell.cs: same.
+
+       * XplatUIWin32.cs: same.
+
+       * PictureBox.cs: same.
+
+       * Win32DnD.cs: same.
+
+       * PageSetupDialog.cs: same.
+
+       * FileDialog.cs: same.
+
+       * PrintDialog.cs: same.
+
+       * DataGridTextBoxColumn.cs: same.
+
+       * DrawTreeNodeEventArgs.cs: same (and fix corcompare)
+
 2006-12-05  Chris Toshok  <toshok@ximian.com>
 
        * TextBox.cs, CheckedListBox.cs, MonthCalendar.cs, Menu.cs,
index 9ca75f29072f96ebd46ae7081db3938795f3c732..ff1bc02c90b8d77fedbcfaa809b19631500702b6 100644 (file)
@@ -195,7 +195,8 @@ namespace System.Windows.Forms
                static readonly Color   def_parentrowsfore_color = ThemeEngine.Current.DataGridParentRowsForeColor;
 
                /* colors */
-               Color background_color;
+               // XXX this needs addressing. Control.background_color should not be internal.
+               new Color background_color;
                Color caption_backcolor;
                Color caption_forecolor;
                Color parentrowsback_color;
index 3beb114343ab00d6da622f95acb33912eccd447a..a5abc3e2a638ce5d18c8e5f97248c02ff578b68b 100644 (file)
@@ -138,7 +138,7 @@ namespace System.Windows.Forms
                                                SetColumnValueAtRow (dataSource, rowNum, textbox.Text);
                                }
                        }
-                       catch (Exception e) {
+                       catch {
                                return false;
                        }
                        
index 4429879a6946862312e7e95117d6d4a96778816a..d09df900ebc5d1cad3ff436e2f7f374a738f9f07 100644 (file)
@@ -78,7 +78,7 @@ namespace System.Windows.Forms {
                private string dataMember;
                private object dataSource;
                private DataGridViewCellStyle defaultCellStyle;
-               private Control editingControl;
+               //private Control editingControl;
                private DataGridViewEditMode editMode;
                private bool enableHeadersVisualStyles;
                private DataGridViewCell firstDisplayedCell;
@@ -88,7 +88,7 @@ namespace System.Windows.Forms {
                private Color gridColor = Color.FromKnownColor(KnownColor.ControlDarkDark);
                private int horizontalScrollingOffset;
                private bool isCurrentCellDirty;
-               private bool isCurrentRowDirty;
+               //private bool isCurrentRowDirty;
                private bool multiSelect;
                private bool readOnly;
                private DataGridViewHeaderBorderStyle rowHeadersBorderStyle;
index a68a21dbdcd150140c8e03625837eb15bb5e1268..4101011c54c468c4812375051c58dbe50bb07457 100644 (file)
@@ -238,10 +238,10 @@ namespace System.Windows.Forms {
 
                        private ArrayList list;
 
-                       private DataGridViewComboBoxCell owner;
+                       //private DataGridViewComboBoxCell owner;
 
                        public ObjectCollection (DataGridViewComboBoxCell owner) {
-                               this.owner = owner;
+                               //this.owner = owner;
                                list = new ArrayList();
                        }
 
index 48a48a5747024aefa62224a65af6444bd8ffc487..2de8733e9088253cd4f3432d757d248564212a85 100644 (file)
@@ -61,21 +61,21 @@ namespace System.Windows.Forms
                        set { draw_default = value; }
                }
 
-               Graphics Graphics
+               public Graphics Graphics
                {
                        get { return graphics; }
                }
 
-               TreeNode Node
+               public TreeNode Node
                {
                        get { return node; }
                }
 
-               TreeNodeStates State
+               public TreeNodeStates State
                {
                        get { return state; }
                }
                #endregion // Public Instance Properties
        }
 }
-#endif
\ No newline at end of file
+#endif
index b5078c50c0398f28815fb28a59a43550254b12ac..3f100c60620ffe1215813b835d7d4f2d72b338d8 100644 (file)
@@ -1562,6 +1562,8 @@ namespace System.Windows.Forms {
                
                public DirComboBox (MWFVFS vfs)
                {
+                       this.vfs = vfs;
+
                        SuspendLayout ();
                        
                        DrawMode = DrawMode.OwnerDrawFixed;
@@ -1582,7 +1584,7 @@ namespace System.Windows.Forms {
                        myComputerDirComboboxItem = new DirComboBoxItem (imageList, 3, "My Computer", MWFVFS.MyComputerPrefix, indent);
                        networkDirComboboxItem = new DirComboBoxItem (imageList, 4, "My Network", MWFVFS.MyNetworkPrefix, indent);
                        
-                       ArrayList al = vfs.GetMyComputerContent ();
+                       ArrayList al = this.vfs.GetMyComputerContent ();
                        
                        foreach (FSEntry fsEntry in al) {
                                myComputerItems.Add (new DirComboBoxItem (MimeIconEngine.LargeIcons, fsEntry.IconIndex, fsEntry.Name, fsEntry.FullName, indent * 2));
@@ -1953,7 +1955,7 @@ namespace System.Windows.Forms {
                public MWFFileView (MWFVFS vfs)
                {
                        this.vfs = vfs;
-                       vfs.RegisterUpdateDelegate (new MWFVFS.UpdateDelegate (RealFileViewUpdate), this);
+                       this.vfs.RegisterUpdateDelegate (new MWFVFS.UpdateDelegate (RealFileViewUpdate), this);
                        
                        SuspendLayout ();
                        
index b3426f4571374a87d4bf97647241f0508a747a3f..49957008f8480c0adefbe2a1c67cd36d7f0dfa78 100644 (file)
@@ -307,7 +307,7 @@ namespace System.Windows.Forms {
                internal class FolderBrowserTreeView : TreeView
                {
                        private MWFVFS vfs = new MWFVFS ();
-                       private FBTreeNode root_node;
+                       new private FBTreeNode root_node;
                        private FolderBrowserDialog parentDialog;
                        private ImageList imageList = new ImageList ();
                        private Environment.SpecialFolder rootFolder;
index 4d41f5266a760fa651a8b3d163933a528031a527..dc99878a40f9c132114485fc6bd1bca6ea540cf9 100644 (file)
@@ -38,8 +38,8 @@ namespace System.Windows.Forms {
 
        [DefaultProperty("Document")]
        public sealed class PageSetupDialog : CommonDialog {
-               const int yard_pound_default = 100;
-               static readonly int meter_default = (int) Math.Round (10 * 3.937 * 100);
+               //const int yard_pound_default = 100;
+               //static readonly int meter_default = (int) Math.Round (10 * 3.937 * 100);
 
                #region Local variables
                private PrintDocument document;
index 4abfa218d9ee3eeca6a59cee1567f6d2286d89b2..029644b072d85fed07f3f0a36a9395a0d4a4dee0 100644 (file)
@@ -44,7 +44,9 @@ namespace System.Windows.Forms {
                private Image   image;
                private PictureBoxSizeMode size_mode;
                //private bool  recalc;
+#if NET_2_0
                private Image   initial_image;
+#endif
                private int     no_update;
                #endregion      // Fields
 
@@ -211,7 +213,9 @@ namespace System.Windows.Forms {
                                StopAnimation ();
                                image = null;
                        }
+#if NET_2_0
                        initial_image = null;
+#endif
 
                        base.Dispose (disposing);
                }
index 2759d95442489e52599414f79fb2cca464ec97fd..65de6297d01c25df3198a5874f85a5ba05ddc652 100644 (file)
@@ -34,7 +34,6 @@ namespace System.Windows.Forms
        public class PrintControllerWithStatusDialog : PrintController {
                #region Local variables
                PrintController underlyingController;
-               string dialogTitle;
                PrintingDialog dialog;
                int currentPage;
                #endregion // Local variables
index f08fff1346a11c97e3912ea5985fd4e9b1c7a015..64ae3fcfdfd11c9961decac7201dc988b1d1b7ce 100644 (file)
@@ -40,7 +40,9 @@ namespace System.Windows.Forms
        [DefaultProperty("Document")]
        public sealed class PrintDialog : CommonDialog {
                PrintDocument document;
+#if NET_2_0
                bool allow_current_page;
+#endif
                bool allow_print_to_file;
                bool allow_selection;
                bool allow_some_pages;
index 0af8dadc7fd92d42e1a83cf39ae8319dea59401b..56eed4c14689588bf22afc1a2714979ee1b91a1e 100644 (file)
@@ -50,7 +50,8 @@ namespace System.Windows.Forms {
                #region Local Variables
                static private Cursor           splitter_ns;
                static private Cursor           splitter_we;
-               private BorderStyle             border_style;
+               // XXX this "new" shouldn't be here.  Control shouldn't define border_style as internal.
+               new private BorderStyle         border_style;
                private int                     min_extra;
                private int                     min_size;
                private int                     split_position;         // Current splitter position
index 182c7e32f1cd502dea8ffc906799fae8729f7bab..48a7170c99e90f0d891fdba05580146b6a30caab 100644 (file)
@@ -40,7 +40,9 @@ namespace System.Windows.Forms {
                private string tooltip_text = String.Empty;
                private Rectangle tab_bounds;
                private int row;
+#if NET_2_0
                private bool use_visual_style_back_color;
+#endif
                #endregion      // Fields
                
                #region Public Constructors
index cb7f09cc527fce3d61fffe2d544ac99f2efdac84..e3386353b6146f29a1d8fa7525e36fa8d8fdb322 100644 (file)
@@ -332,7 +332,7 @@ namespace System.Windows.Forms
 
                // XXX this should probably go away and it should call
                // into Control.ImeMode instead.
-               ImeMode ime_mode = ImeMode.Disable;
+               new ImeMode ime_mode = ImeMode.Disable;
 
                [Browsable (false)]
                [EditorBrowsable (EditorBrowsableState.Never)]
index e5112e27f2224dfb6edf943f7fc47d0a2f1b0f87..61ec117c766cebb47f35d2f599ae21cde800ec32 100644 (file)
@@ -169,7 +169,8 @@ namespace System.Windows.Forms {
                private static readonly Guid IID_IDropSource = new Guid("00000121-0000-0000-C000-000000000046");
                private static readonly Guid IID_IDropTarget = new Guid("00000122-0000-0000-C000-000000000046");
 
-               internal Win32DnD() {
+               static Win32DnD()
+               {
                        // Required for all other OLE functions to work
                        Win32OleInitialize(IntPtr.Zero);
 
index cead7b67afc267a3ef745498ccb6b6f962c12cdd..67e0e7f12647aee115b3168ff54c0bfcc45148f8 100644 (file)
@@ -63,7 +63,6 @@ namespace System.Windows.Forms {
                private static int              scroll_height;
                private static Hashtable        wm_nc_registered;
 
-               private static Win32DnD         DnD;
                #endregion      // Local Variables
 
                #region Private Structs
@@ -636,8 +635,6 @@ namespace System.Windows.Forms {
                        // Handle singleton stuff first
                        ref_count=0;
 
-                       DnD = new Win32DnD();
-
                        mouse_state = MouseButtons.None;
                        mouse_position = Point.Empty;