2010-03-15 Atsushi Enomoto <atsushi@ximian.com>

	* ServiceEndpointCollection.cs : those overrides are rather to check
	  null arguments, not to skip contract duplicates.

svn path=/trunk/mcs/; revision=153589

diff --git a/mcs/class/System.ServiceModel/System.ServiceModel.Description/ChangeLog b/mcs/class/System.ServiceModel/System.ServiceModel.Description/ChangeLog
index 13309137d54ddf0fdcbd33952e4b1bbc18272a8a..26fc249386885115773e4da9b2d69a930963391d 100644 (file)
--- a/mcs/class/System.ServiceModel/System.ServiceModel.Description/ChangeLog
+++ b/mcs/class/System.ServiceModel/System.ServiceModel.Description/ChangeLog
@@ -1,3 +1,8 @@
+2010-03-15  Atsushi Enomoto  <atsushi@ximian.com>
+
+       * ServiceEndpointCollection.cs : those overrides are rather to check
+         null arguments, not to skip contract duplicates.
+
 2010-03-12  Atsushi Enomoto  <atsushi@ximian.com>
 
        * MessageDescription.cs : implement MessageName.

diff --git a/mcs/class/System.ServiceModel/System.ServiceModel.Description/ServiceEndpointCollection.cs b/mcs/class/System.ServiceModel/System.ServiceModel.Description/ServiceEndpointCollection.cs
index 58d0024e3de8b588bd15331cbae98872dd6af249..191d411ed41c86e21abe97d4709a70aeb911dc9d 100644 (file)
--- a/mcs/class/System.ServiceModel/System.ServiceModel.Description/ServiceEndpointCollection.cs
+++ b/mcs/class/System.ServiceModel/System.ServiceModel.Description/ServiceEndpointCollection.cs
@@ -107,20 +107,18 @@ namespace System.ServiceModel.Description
                        return list;
                }
 
-               [MonoTODO]
                protected override void InsertItem (int index, ServiceEndpoint item)
                {
-                       if (Find (new XmlQualifiedName (item.Contract.Name, item.Contract.Namespace)) == null)
-                               base.InsertItem (index, item);
+                       if (item == null)
+                               throw new ArgumentNullException ("item");
+                       base.InsertItem (index, item);
                }
 
-               [MonoTODO]
                protected override void SetItem (int index, ServiceEndpoint item)
                {
-                       if (Find (new XmlQualifiedName (item.Contract.Name, item.Contract.Namespace)) == null)
-                               base.SetItem (index, item);
-                       else
-                               base.RemoveItem (index);
+                       if (item == null)
+                               throw new ArgumentNullException ("item");
+                       base.SetItem (index, item);
                }
        }
 }