refactoring

svn path=/trunk/mcs/; revision=63257

diff --git a/mcs/class/System.Data.OracleClient/System.Data.OracleClient.jvm/OracleParameter.cs b/mcs/class/System.Data.OracleClient/System.Data.OracleClient.jvm/OracleParameter.cs
index 983b24d87b3198221f76c1aa73028c61cd44cd47..368a68ba7f893d35aba1914849afe7e13b971e99 100644 (file)
--- a/mcs/class/System.Data.OracleClient/System.Data.OracleClient.jvm/OracleParameter.cs
+++ b/mcs/class/System.Data.OracleClient/System.Data.OracleClient.jvm/OracleParameter.cs
@@ -57,7 +57,7 @@ namespace System.Data.OracleClient {
                public OracleParameter(String parameterName, Object value)\r
                        : this (parameterName, OracleType.VarChar, 0, ParameterDirection.Input,\r
                        false, 0, 0, String.Empty, DataRowVersion.Current, value) {\r
-                       _isDbTypeSet = false;\r
+                       IsDbTypeSet = false;\r
                }\r
     \r
                public OracleParameter(String parameterName, OracleType dbType)\r
@@ -112,14 +112,14 @@ namespace System.Data.OracleClient {
                        get { return _oleDbType; }            \r
                        set {\r
                                _oleDbType = value;\r
-                               _isDbTypeSet = true;\r
+                               IsDbTypeSet = true;\r
                        }\r
                }    \r
     \r
                public new Object Value {\r
                        get { return base.Value; }\r
                        set {\r
-                               if (!_isDbTypeSet && (value != null) && (value != DBNull.Value)) {\r
+                               if (!IsDbTypeSet && (value != null) && (value != DBNull.Value)) {\r
                                        _oleDbType = OracleConvert.ValueTypeToOracleType(value.GetType());\r
                                }\r
                                base.Value = value;\r
@@ -148,15 +148,6 @@ namespace System.Data.OracleClient {
                                return Placeholder;\r
                        }\r
                }\r
-    \r
-               public override object Clone() {\r
-                       OracleParameter clone = new OracleParameter();\r
-                       CopyTo(clone);\r
-\r
-                       clone._oleDbType = _oleDbType;\r
-                       clone._isDbTypeSet = _isDbTypeSet;\r
-                       return clone;\r
-               }\r
 \r
                protected sealed override object ConvertValue(object value) {\r
                        // can not convert null or DbNull to other types\r
@@ -172,8 +163,8 @@ namespace System.Data.OracleClient {
                        object convertedValue  = value;\r
 \r
                        // note : if we set user parameter jdbc type inside prepare interbal, the db type is not set\r
-                       if (value is IConvertible && (_isDbTypeSet || IsJdbcTypeSet)) {\r
-                               OracleType oleDbType = (_isDbTypeSet) ? OracleType : OracleConvert.JdbcTypeToOracleType((int)JdbcType);\r
+                       if (value is IConvertible && (IsDbTypeSet || IsJdbcTypeSet)) {\r
+                               OracleType oleDbType = (IsDbTypeSet) ? OracleType : OracleConvert.JdbcTypeToOracleType((int)JdbcType);\r
                                Type to = OracleConvert.OracleTypeToValueType(oleDbType);\r
                                if (!(value is DateTime && to == OracleConvert.TypeOfTimespan)) //anyway will go by jdbc type\r
                                        convertedValue = Convert.ChangeType(value,to);\r