* ActivatedClientTypeEntry.cs, ActivatedServiceTypeEntry.cs,

	  IRemotingTypeInfo.cs, RemotingServices.cs, WellKnownServiceTypeEntry.cs:
	  Removed some TODOs.

svn path=/trunk/mcs/; revision=19802

diff --git a/mcs/class/corlib/System.Runtime.Remoting/ActivatedClientTypeEntry.cs b/mcs/class/corlib/System.Runtime.Remoting/ActivatedClientTypeEntry.cs
index 404f2f9e86c1841f1c781217bc9c4b85caca8261..11f5f27e29cc02f26ce49190a18ed5f05e1f0d7f 100644 (file)
--- a/mcs/class/corlib/System.Runtime.Remoting/ActivatedClientTypeEntry.cs
+++ b/mcs/class/corlib/System.Runtime.Remoting/ActivatedClientTypeEntry.cs
@@ -45,7 +45,6 @@ namespace System.Runtime.Remoting {
                        get { return obj_type; }
                }
 
-               [MonoTODO]
                public override string ToString ()
                {
                        return TypeName + AssemblyName + ApplicationUrl;

diff --git a/mcs/class/corlib/System.Runtime.Remoting/ActivatedServiceTypeEntry.cs b/mcs/class/corlib/System.Runtime.Remoting/ActivatedServiceTypeEntry.cs
index bf0365cbfb621ba7f7d1e78e8fe59b89663a0a4f..36753d6617b870b3e7c55083d89b79db029d4493 100644 (file)
--- a/mcs/class/corlib/System.Runtime.Remoting/ActivatedServiceTypeEntry.cs
+++ b/mcs/class/corlib/System.Runtime.Remoting/ActivatedServiceTypeEntry.cs
@@ -41,7 +41,6 @@ namespace System.Runtime.Remoting {
                        get { return obj_type; }
                }
 
-               [MonoTODO]
                public override string ToString ()
                {
                        return AssemblyName + TypeName;

diff --git a/mcs/class/corlib/System.Runtime.Remoting/ChangeLog b/mcs/class/corlib/System.Runtime.Remoting/ChangeLog
index 78e3aae672c52b89af423d4e38ccc6e656ae52f0..12a22d0877e8b04967e92853115f9c24ac8193a7 100755 (executable)
--- a/mcs/class/corlib/System.Runtime.Remoting/ChangeLog
+++ b/mcs/class/corlib/System.Runtime.Remoting/ChangeLog
@@ -1,3 +1,9 @@
+2003-11-11  Lluis Sanchez Gual <lluis@ximian.com>
+
+       * ActivatedClientTypeEntry.cs, ActivatedServiceTypeEntry.cs, 
+         IRemotingTypeInfo.cs, RemotingServices.cs, WellKnownServiceTypeEntry.cs:
+         Removed some TODOs.
+
 2003-11-01  Zoltan Varga  <vargaz@freemail.hu>
 
        * RemotingServices.cs (GetDomainProxy): Use the new InvokeInDomain 

diff --git a/mcs/class/corlib/System.Runtime.Remoting/IRemotingTypeInfo.cs b/mcs/class/corlib/System.Runtime.Remoting/IRemotingTypeInfo.cs
index 238b55c827af14a19fa507d3c255a813692ed4db..78f9890973c033263dc55db90c12b5b45269e79c 100644 (file)
--- a/mcs/class/corlib/System.Runtime.Remoting/IRemotingTypeInfo.cs
+++ b/mcs/class/corlib/System.Runtime.Remoting/IRemotingTypeInfo.cs
@@ -16,49 +16,4 @@ namespace System.Runtime.Remoting {
                string TypeName { get; set; }
                bool CanCastTo (Type fromType, object o);
        }
-
-       // fixme: dont know if we really need this
-       internal class RemotingTypeInfo : IRemotingTypeInfo
-       {
-
-               string type_name;
-
-               public RemotingTypeInfo (Type type)
-               {
-                       type_name = type.AssemblyQualifiedName;
-               }
-               
-               public string TypeName {
-
-                       get {
-                               return type_name;
-                       }
-
-                       set {
-                               type_name = value;
-                       }
-               }
-
-               public Type GetRealType ()
-               {
-                       string type_name = null;
-                       Assembly assembly = null;
-                       
-                       int pos = type_name.IndexOf (",");
-                       if (pos >= 0) {
-                               if (pos != 0) {
-                                       string ass_name = type_name.Substring (0, pos - 1);
-                                       assembly = Assembly.Load (ass_name);
-                               } 
-                               type_name = type_name.Substring (pos + 1);
-                       }
-                       return assembly.GetType (type_name);
-               }
-               
-               public bool CanCastTo (Type fromType, object o)
-               {
-                       return false;
-               }
-       }
 }
-

diff --git a/mcs/class/corlib/System.Runtime.Remoting/RemotingServices.cs b/mcs/class/corlib/System.Runtime.Remoting/RemotingServices.cs
index db59cc84130006b86909863e3cbc177bf00a8ba3..38811ec9e5b0cfd714c21a2004147df88f0c63ca 100644 (file)
--- a/mcs/class/corlib/System.Runtime.Remoting/RemotingServices.cs
+++ b/mcs/class/corlib/System.Runtime.Remoting/RemotingServices.cs
@@ -166,8 +166,6 @@ namespace System.Runtime.Remoting
 
                public static object Unmarshal (ObjRef objref, bool fRefine)
                {
-                       // FIXME: use type name when fRefine==true
-
                        Type classToProxy = fRefine ? objref.ServerType : typeof (MarshalByRefObject);
                        if (classToProxy == null) classToProxy = typeof (MarshalByRefObject);
 
@@ -311,6 +309,7 @@ namespace System.Runtime.Remoting
 
                public static bool IsMethodOverloaded(IMethodMessage msg)
                {
+                       // TODO: use internal call for better performance
                        Type type = msg.MethodBase.DeclaringType;
                        MemberInfo[] members = type.GetMember (msg.MethodName, MemberTypes.Method, BindingFlags.NonPublic | BindingFlags.Public | BindingFlags.Instance);
                        return members.Length > 1;
@@ -318,6 +317,7 @@ namespace System.Runtime.Remoting
 
                public static bool IsObjectOutOfAppDomain(object tp)
                {
+                       // TODO: use internal call for better performance
                        Identity ident = GetObjectIdentity((MarshalByRefObject)tp);
                        if (ident != null) return !ident.IsFromThisAppDomain;
                        else return false;
@@ -325,6 +325,7 @@ namespace System.Runtime.Remoting
 
                public static bool IsObjectOutOfContext(object tp)
                {
+                       // TODO: use internal call for better performance
                        ServerIdentity ident = GetObjectIdentity((MarshalByRefObject)tp) as ServerIdentity;
                        if (ident != null) return ident.Context != System.Threading.Thread.CurrentContext;
                        else return false;

diff --git a/mcs/class/corlib/System.Runtime.Remoting/WellKnownServiceTypeEntry.cs b/mcs/class/corlib/System.Runtime.Remoting/WellKnownServiceTypeEntry.cs
index e97b5038ba5c5e591b2e77cfcc04c30f4c092ed4..4efdc1ebb9f2feeb091446d80069f9ed10d875af 100644 (file)
--- a/mcs/class/corlib/System.Runtime.Remoting/WellKnownServiceTypeEntry.cs
+++ b/mcs/class/corlib/System.Runtime.Remoting/WellKnownServiceTypeEntry.cs
@@ -55,7 +55,6 @@ namespace System.Runtime.Remoting {
                        get { return obj_uri; }
                }
 
-               [MonoTODO]
                public override string ToString ()
                {
                        return TypeName + AssemblyName + ObjectUri;