[Mono.Security]: Fix TLS Alert level." This breaks the System test suite.

Prevent further abuse (calling it before the fields have been assigned to)
by making the helper function static.

diff --git a/mcs/class/Mono.Security/Mono.Security.Protocol.Tls/Alert.cs b/mcs/class/Mono.Security/Mono.Security.Protocol.Tls/Alert.cs
index b40292c2b94e0c078b0f47d926cb3048d3455ae9..62ac7b9f2931bbab64f5967f9878b54ab01f7d2b 100644 (file)
--- a/mcs/class/Mono.Security/Mono.Security.Protocol.Tls/Alert.cs
+++ b/mcs/class/Mono.Security/Mono.Security.Protocol.Tls/Alert.cs
@@ -124,8 +124,8 @@ namespace Mono.Security.Protocol.Tls
 
                public Alert(AlertDescription description)
                {
-                       this.inferAlertLevel();
                        this.description = description;
+                       this.level = inferAlertLevel(description);
                }
 
                public Alert(
@@ -140,15 +140,14 @@ namespace Mono.Security.Protocol.Tls
 
                #region Private Methods
 
-               private void inferAlertLevel()
+               private static AlertLevel inferAlertLevel(AlertDescription description)
                {
                        switch (description)
                        {
                                case AlertDescription.CloseNotify:
                                case AlertDescription.NoRenegotiation:
                                case AlertDescription.UserCancelled:
-                                       this.level = AlertLevel.Warning;
-                                       break;
+                                       return AlertLevel.Warning;
 
                                case AlertDescription.AccessDenied:
                                case AlertDescription.BadCertificate:
@@ -171,8 +170,7 @@ namespace Mono.Security.Protocol.Tls
                                case AlertDescription.UnknownCA:
                                case AlertDescription.UnsupportedCertificate:
                                default:
-                                       this.level = AlertLevel.Fatal;
-                                       break;
+                                       return AlertLevel.Fatal;
                        }
                }