2008-05-30 Sebastien Pouliot <sebastien@ximian.com>

	* CodeAccessPermission.cs,
	* PermissionSet.cs,
	* SecurityManager.cs: Provide better MonoTODO messages for the
	next version of MoMA.

svn path=/trunk/mcs/; revision=104578

diff --git a/mcs/class/corlib/System.Security/ChangeLog b/mcs/class/corlib/System.Security/ChangeLog
index 1fccf2d38467597a8a1aad58a92c864d3fddceeb..e73d18d774b664f85149a8b2193ae68d8f948471 100644 (file)
--- a/mcs/class/corlib/System.Security/ChangeLog
+++ b/mcs/class/corlib/System.Security/ChangeLog
@@ -1,3 +1,10 @@
+2008-05-30  Sebastien Pouliot  <sebastien@ximian.com> 
+
+       * CodeAccessPermission.cs,
+       * PermissionSet.cs,
+       * SecurityManager.cs: Provide better MonoTODO messages for the 
+       next version of MoMA.
+
 2008-04-02  Andreas Nahr  <ClassDevelopment@A-SoftTech.com>
 
        * VerificationException.cs

diff --git a/mcs/class/corlib/System.Security/CodeAccessPermission.cs b/mcs/class/corlib/System.Security/CodeAccessPermission.cs
index 152db9cf8b0a780ba422ef064d23a0d1f80f1bab..47d9ed0a65762c5ab0ebd62b36de7abacc511d41 100644 (file)
--- a/mcs/class/corlib/System.Security/CodeAccessPermission.cs
+++ b/mcs/class/corlib/System.Security/CodeAccessPermission.cs
@@ -46,6 +46,7 @@ namespace System.Security {
 #if NET_2_0
        [ComVisible (true)]
 #endif
+       [MonoTODO ("CAS support is experimental (and unsupported).")]
        public abstract class CodeAccessPermission : IPermission, ISecurityEncodable, IStackWalk {
 
 
@@ -53,7 +54,7 @@ namespace System.Security {
                {
                }
 
-               [MonoTODO ("Imperative mode isn't supported")]
+               [MonoTODO ("CAS support is experimental (and unsupported). Imperative mode is not implemented.")]
                public void Assert ()
                {
                        new PermissionSet (this).Assert ();
@@ -115,7 +116,7 @@ namespace System.Security {
                        new PermissionSet (this).CasOnlyDemand (3);
                }
 
-               [MonoTODO ("Imperative mode isn't supported")]
+               [MonoTODO ("CAS support is experimental (and unsupported). Imperative mode is not implemented.")]
                public void Deny ()
                {
                        new PermissionSet (this).Deny ();
@@ -163,13 +164,13 @@ namespace System.Security {
                        return null;
                }
 
-               [MonoTODO ("Imperative mode isn't supported")]
+               [MonoTODO ("CAS support is experimental (and unsupported). Imperative mode is not implemented.")]
                public void PermitOnly ()
                {
                        new PermissionSet (this).PermitOnly ();
                }
 
-               [MonoTODO ("Imperative mode isn't supported")]
+               [MonoTODO ("CAS support is experimental (and unsupported). Imperative mode is not implemented.")]
                public static void RevertAll ()
                {
                        if (!SecurityManager.SecurityEnabled)
@@ -198,7 +199,7 @@ namespace System.Security {
                        }
                }
 
-               [MonoTODO ("Imperative mode isn't supported")]
+               [MonoTODO ("CAS support is experimental (and unsupported). Imperative mode is not implemented.")]
                public static void RevertAssert ()
                {
                        if (!SecurityManager.SecurityEnabled)
@@ -213,7 +214,7 @@ namespace System.Security {
                        }
                }
 
-               [MonoTODO ("Imperative mode isn't supported")]
+               [MonoTODO ("CAS support is experimental (and unsupported). Imperative mode is not implemented.")]
                public static void RevertDeny ()
                {
                        if (!SecurityManager.SecurityEnabled)
@@ -228,7 +229,7 @@ namespace System.Security {
                        }
                }
 
-               [MonoTODO ("Imperative mode isn't supported")]
+               [MonoTODO ("CAS support is experimental (and unsupported). Imperative mode is not implemented.")]
                public static void RevertPermitOnly ()
                {
                        if (!SecurityManager.SecurityEnabled)

diff --git a/mcs/class/corlib/System.Security/PermissionSet.cs b/mcs/class/corlib/System.Security/PermissionSet.cs
index a0a914108322e670c0c166ea4d32eb0a7af5ff06..33806f746a2681793fe1ba52bee7ec0d8c837adb 100644 (file)
--- a/mcs/class/corlib/System.Security/PermissionSet.cs
+++ b/mcs/class/corlib/System.Security/PermissionSet.cs
@@ -49,6 +49,7 @@ namespace System.Security {
 #if NET_2_0
        [ComVisible (true)]
 #endif
+       [MonoTODO ("CAS support is experimental (and unsupported).")]
        public class PermissionSet: ISecurityEncodable, ICollection, IEnumerable, IStackWalk, IDeserializationCallback {
 
                private const string tagName = "PermissionSet";
@@ -153,7 +154,7 @@ namespace System.Security {
                        return perm;
                }
 
-               [MonoTODO ("Imperative mode isn't supported")]
+               [MonoTODO ("CAS support is experimental (and unsupported). Imperative mode is not implemented.")]
                [SecurityPermission (SecurityAction.Demand, Assertion = true)]
 #if NET_2_0
                public void Assert ()
@@ -288,7 +289,7 @@ namespace System.Security {
                        }
                }
 
-               [MonoTODO ("Imperative mode isn't supported")]
+               [MonoTODO ("CAS support is experimental (and unsupported). Imperative mode is not implemented.")]
 #if NET_2_0
                public void Deny ()
 #else
@@ -398,7 +399,7 @@ namespace System.Security {
                        return true;
                }
 
-               [MonoTODO ("Imperative mode isn't supported")]
+               [MonoTODO ("CAS support is experimental (and unsupported). Imperative mode is not implemented.")]
 #if NET_2_0
                public void PermitOnly ()
 #else
@@ -427,7 +428,7 @@ namespace System.Security {
                        return false;
                }
 
-               [MonoTODO ("little documentation in Fx 2.0 beta 1")]
+               // FIXME little documentation in Fx 2.0 beta 1
                public static byte[] ConvertPermissionSet (string inFormat, byte[] inData, string outFormat) 
                {
                        if (inFormat == null)
@@ -772,7 +773,7 @@ namespace System.Security {
                        return (list.Count == 0) ? (int) state : base.GetHashCode ();
                }
 
-               [MonoTODO ("(2.0) what's it doing here? There's probably a reason this was added here.")]
+               // FIXME what's it doing here? There's probably a reason this was added here.
                static public void RevertAssert ()
                {
                        CodeAccessPermission.RevertAssert ();

diff --git a/mcs/class/corlib/System.Security/SecurityManager.cs b/mcs/class/corlib/System.Security/SecurityManager.cs
index aa2f66430797ebce0ad83e5bb52d4660d685f368..100fe29efff746ee1fcbf715cc02cd706d14d88e 100644 (file)
--- a/mcs/class/corlib/System.Security/SecurityManager.cs
+++ b/mcs/class/corlib/System.Security/SecurityManager.cs
@@ -102,7 +102,8 @@ namespace System.Security {
                // NOTE: This method doesn't show in the class library status page because
                // it cannot be "found" with the StrongNameIdentityPermission for ECMA key.
                // But it's there!
-               [MonoTODO ("works for fulltrust (empty), documentation doesn't really make sense, type wise")]
+               // FIXME works for fulltrust (empty), documentation doesn't really make sense, type wise
+               [MonoTODO ("CAS support is experimental (and unsupported). This method only works in FullTrust.")]
                [StrongNameIdentityPermission (SecurityAction.LinkDemand, PublicKey = "0x00000000000000000400000000000000")]
                public static void GetZoneAndOrigin (out ArrayList zone, out ArrayList origin) 
                {