Fix for bingind procedure parameters by name rather than position contributed by...

svn path=/trunk/mcs/; revision=89427

diff --git a/mcs/class/System.Data.OracleClient/System.Data.OracleClient/ChangeLog b/mcs/class/System.Data.OracleClient/System.Data.OracleClient/ChangeLog
index 7135ec00e9d04e784b37690f0cd065b5c84fa518..7dfaf533131e8996dc4dfb9ccd5f2632e4dca656 100644 (file)
--- a/mcs/class/System.Data.OracleClient/System.Data.OracleClient/ChangeLog
+++ b/mcs/class/System.Data.OracleClient/System.Data.OracleClient/ChangeLog
@@ -1,3 +1,6 @@
+2007-11-11 Leszek Ciesielski <skolima@gmail.com>
+       * OracleCommands.cs: fix for binging procedure parameters by name
+       rather than position (by Gary Thomas)
 2007-11-01  Marek Safar  <marek.safar@gmail.com>
 
        * OracleCommand.cs,

diff --git a/mcs/class/System.Data.OracleClient/System.Data.OracleClient/OracleCommand.cs b/mcs/class/System.Data.OracleClient/System.Data.OracleClient/OracleCommand.cs
index e4ad560bc77e79ceb7b4436b8dd048a614cca6fa..9d6e441772e6eb0be7ffa3fb9061734efcf60d2e 100644 (file)
--- a/mcs/class/System.Data.OracleClient/System.Data.OracleClient/OracleCommand.cs
+++ b/mcs/class/System.Data.OracleClient/System.Data.OracleClient/OracleCommand.cs
@@ -643,10 +643,10 @@ namespace System.Data.OracleClient
                                        foreach (OracleParameter parm in Parameters) {
                                                if (sb.Length > 0)
                                                        sb.Append (",");
-                                               sb.Append (":" + parm.ParameterName);
+                                               sb.Append (parm.ParameterName + "=>:" + parm.ParameterName);
                                        }
 
-                               string sql = "call " + commandText + "(" + sb.ToString() + ")";
+                               string sql = "begin " + commandText + "(" + sb.ToString() + "); end;";
                                statement.Prepare (sql);
                        }
                        else    // Text