Fix Microsoft.Build.Tasks make check on OS X
authorAndi McClure <andi.mcclure@xamarin.com>
Tue, 15 Dec 2015 22:23:31 +0000 (17:23 -0500)
committerAndi McClure <andi.mcclure@xamarin.com>
Tue, 15 Dec 2015 22:23:31 +0000 (17:23 -0500)
The mcs/class/Microsoft.Build.Tasks make check contains a test whose
goal is to verify that Microsoft.Build.Evaluation.Project can run a
MSBuild code fragment which has an assembly reference. The assembly
referenced in the test is System.Drawing. However on many systems
System.Drawing does not work without special setup. The test should
reference a different assembly (I picked System.Runtime.Serialization)
because ensuring System.Drawing is working isn't relevant to the test.

mcs/class/Microsoft.Build.Tasks/Test/Microsoft.Build.Tasks/CodeTaskFactoryTest.cs

index e665a41cebfd6fa4869e4fbba2cdc3927fed736d..2b83e4dc5559141b393d4cba4aa4caac5d86fd79 100644 (file)
@@ -115,10 +115,10 @@ Log.LogWarning(""Message: "" + Message);
     AssemblyFile='$(MSBuildToolsPath)\Microsoft.Build.Tasks.v4.0.dll' >
     <ParameterGroup />
     <Task>
-      <Reference Include='System.Drawing' />
+      <Reference Include='System.Runtime.Serialization' />
       <Code Type='Fragment' Language='cs'>
 <![CDATA[
-Log.LogWarning(""Color: "" + System.Drawing.Color.CornflowerBlue);
+Log.LogWarning(""A GUID generated by System.Xml: "" + new System.Xml.UniqueId());
 ]]>      </Code>
     </Task>
   </UsingTask>