Fixed a typo and a whitespacing mistake.
authorJamesB7 <jfb@zer7.com>
Sun, 29 Apr 2012 22:40:38 +0000 (19:40 -0300)
committerJamesB7 <jfb@zer7.com>
Sun, 29 Apr 2012 22:40:38 +0000 (19:40 -0300)
Also made CheckRange more descriptive - no performance loss since the conditions were ORed before and so both got checked anyway.

mcs/class/System/System.Net.Sockets/Socket.cs

index 78aae7ddeaf83a3ab62e040a2645788c783bed5d..52b9a5013f2700deef747ba731ca614392771a3d 100644 (file)
@@ -748,13 +748,19 @@ namespace System.Net.Sockets
                        return(req);
                }
 
-               void CheckRange(byte[] buffer, int offset, int size)
+               void CheckRange (byte[] buffer, int offset, int size)
                {
-                       if (offset < 0 || offset > buffer.Length)
-                               throw new ArgumentOutOfRangeException ("offset");
+                       if (offset < 0)
+                               throw new ArgumentOutOfRangeException ("offset", "offset must be >= 0");
+                               
+                       if (offset > buffer.Length)
+                               throw new ArgumentOutOfRangeException ("offset", "offset must be <= buffer.Length");
 
-                       if (size < 0 || size > buffer.Length - offset)
-                               throw new ArgumentOutOfRangeException ("size");
+                       if (size < 0)
+                               throw new ArgumentOutOfRangeException ("size", "size must be >= 0")
+                               
+                       if (size > buffer.Length - offset)
+                               throw new ArgumentOutOfRangeException ("size", "size must be <= buffer.Length - offset");
                }
                
                public IAsyncResult BeginReceive(byte[] buffer, int offset,
@@ -769,7 +775,7 @@ namespace System.Net.Sockets
                        if (buffer == null)
                                throw new ArgumentNullException ("buffer");
 
-                       CheckRange(buffer, offset, size);
+                       CheckRange (buffer, offset, size);
 
                        SocketAsyncResult req = new SocketAsyncResult (this, state, callback, SocketOperation.Receive);
                        req.Buffer = buffer;
@@ -890,7 +896,7 @@ namespace System.Net.Sockets
                        if (remoteEP == null)
                                throw new ArgumentNullException ("remoteEP");
 
-                       CheckRange (bufer, offset, size);
+                       CheckRange (buffer, offset, size);
 
                        throw new NotImplementedException ();
                }