Improved the MonoTODO messages, as these will be developer visible
authorMiguel de Icaza <miguel@gnome.org>
Thu, 16 Nov 2006 13:33:32 +0000 (13:33 -0000)
committerMiguel de Icaza <miguel@gnome.org>
Thu, 16 Nov 2006 13:33:32 +0000 (13:33 -0000)
2006-11-16  Miguel de Icaza  <miguel@novell.com>

* Hashtable.cs: Serialize EqualityComparer.

svn path=/trunk/mcs/; revision=67996

28 files changed:
mcs/class/corlib/Microsoft.Win32.SafeHandles/SafeFileHandle.cs
mcs/class/corlib/Microsoft.Win32.SafeHandles/SafeHandleZeroOrMinusOneIsInvalid.cs
mcs/class/corlib/Mono.Security.Cryptography/DSAManaged.cs
mcs/class/corlib/Mono.Security/Uri.cs
mcs/class/corlib/System.Collections.Generic/List.cs
mcs/class/corlib/System.Collections/ChangeLog
mcs/class/corlib/System.Collections/Hashtable.cs
mcs/class/corlib/System.Collections/SortedList.cs
mcs/class/corlib/System.Diagnostics/Debugger.cs
mcs/class/corlib/System.Diagnostics/StackFrame.cs
mcs/class/corlib/System.Diagnostics/StackTrace.cs
mcs/class/corlib/System.Globalization/CompareInfo.cs
mcs/class/corlib/System.Globalization/CultureInfo.cs
mcs/class/corlib/System.Security.Principal/WindowsIdentity.cs
mcs/class/corlib/System/ActivationContext.cs
mcs/class/corlib/System/Activator.cs
mcs/class/corlib/System/AppDomain.cs
mcs/class/corlib/System/AppDomainManager.cs
mcs/class/corlib/System/AppDomainSetup.cs
mcs/class/corlib/System/ApplicationIdentity.cs
mcs/class/corlib/System/Array.cs
mcs/class/corlib/System/Attribute.cs
mcs/class/corlib/System/Console.cs
mcs/class/corlib/System/DateTime.cs
mcs/class/corlib/System/Double.cs
mcs/class/corlib/System/Environment.cs
mcs/class/corlib/System/GC.cs
mcs/class/corlib/Test/System.Security.Policy/ZoneTest.cs

index 5457ba1ca34b1ce10feceeef42339a786d2e2511..bf473579355a13961260dcfc99fb8f810d365002 100644 (file)
@@ -32,7 +32,7 @@ using System;
 
 namespace Microsoft.Win32.SafeHandles {
 
-       [MonoTODO]
+       [MonoTODO("Not implemented on Mono")]
        public sealed class SafeFileHandle : SafeHandleZeroOrMinusOneIsInvalid {
 
                public SafeFileHandle (IntPtr preexistingHandle, bool ownsHandle) : base (ownsHandle)
index 4f6dc86c0b0c67cc782157609b9e1154c1260e60..d2da68db46a19a0879f178c7ec915b2ba1e84d25 100644 (file)
@@ -33,7 +33,7 @@ using System.Runtime.InteropServices;
 
 namespace Microsoft.Win32.SafeHandles {
 
-       [MonoTODO]
+       [MonoTODO ("Not implemented on Mono")]
        public abstract class SafeHandleZeroOrMinusOneIsInvalid : SafeHandle, IDisposable {
                protected SafeHandleZeroOrMinusOneIsInvalid (bool ownsHandle) : base ((IntPtr) 0, ownsHandle) {
                }
index 456d3be995fb74ce1fe349de4a8105a6f11b7835..ca29b42fc7845f3415fb4c6a99f4c09aff63be45 100644 (file)
@@ -205,7 +205,6 @@ namespace Mono.Security.Cryptography {
                        j = (p - 1) / q;
                }
 
-               [MonoTODO()]
                private bool Validate () 
                {
                        // J is optional
index 5d7b3e8f736b97213367c0ba8ff7e480b6348292..5ed7d085fab273c7ce26411b69333e71ca7564ae 100644 (file)
@@ -525,11 +525,6 @@ namespace Mono.Security {
                        return true;
                }
 
-/*             [MonoTODO ("Find out what this should do")]
-               protected virtual void Canonicalize ()
-               {
-               }*/
-
                public static bool CheckSchemeName (string schemeName) 
                {
                        if (schemeName == null || schemeName.Length == 0)
@@ -548,11 +543,6 @@ namespace Mono.Security {
                        return true;
                }
 
-/*             [MonoTODO ("Find out what this should do")]
-               protected virtual void CheckSecurity ()
-               {
-               }*/
-
                public override bool Equals (object comparant) 
                {
                        if (comparant == null) 
index 0e5adfdf0e4ce6c3aabf67774d545941b828bc84..eaed69560646b07ec22d8de260422e6313d3ed39 100644 (file)
@@ -428,7 +428,7 @@ namespace System.Collections.Generic {
                        return loc != -1;
                }
                
-               [MonoTODO ("I can make it faster than this...")]
+               // FIXME: this could probably be made faster.
                public int RemoveAll (Predicate <T> match)
                {
                        CheckMatch (match);
index 97be1672bfc459413247db4a2fc0efd42a8a2079..37d4b2b3bdd9e92c40e5ceaa149aa74f06c08698 100644 (file)
@@ -1,3 +1,7 @@
+2006-11-16  Miguel de Icaza  <miguel@novell.com>
+
+       * Hashtable.cs: Serialize EqualityComparer.
+
 2006-08-16  Miguel de Icaza  <miguel@novell.com>
 
        * Hashtable.cs (PutImpl): Do not access the table twice, only
index c73fa875a781ccfe8a62a257e2e518084db37a8b..1d021568bf7e038bb7b3386d043a138c12589105 100644 (file)
@@ -532,9 +532,6 @@ namespace System.Collections {
                        return ht;
                }
 
-#if NET_2_0
-               [MonoTODO ("Serialize equalityComparer")]
-#endif
                public virtual void GetObjectData (SerializationInfo info, StreamingContext context)
                {
                        if (info == null)
@@ -542,7 +539,14 @@ namespace System.Collections {
 
                        info.AddValue ("LoadFactor", loadFactor);
                        info.AddValue ("Version", modificationCount);
-                       info.AddValue ("Comparer", comparerRef);
+#if NET_2_0
+                       if (equalityComparer != null)
+                               info.AddValue ("KeyComparer", equalityComparer);
+                       else
+                               info.AddValue ("Comparer", comparerRef);
+#else
+                               info.AddValue ("Comparer", comparerRef);
+#endif
                        info.AddValue ("HashCodeProvider", hcpRef);
                        info.AddValue ("HashSize", this.table.Length);
 // Create Keys
@@ -556,6 +560,9 @@ namespace System.Collections {
                        info.AddValue ("Keys", keys);
                        info.AddValue ("Values", values);
 
+#if NET_2_0
+                       info.AddValue ("equalityComparer", equalityComparer);
+#endif
                }
 
 #if NET_2_0
@@ -567,7 +574,14 @@ namespace System.Collections {
 
                        loadFactor = (float) serializationInfo.GetValue ("LoadFactor", typeof(float));
                        modificationCount = (int) serializationInfo.GetValue ("Version", typeof(int));
+#if NET_2_0
+                       equalityComparer = (IEqualityComparer) serializationInfo.GetValue ("KeyComparer", typeof (object));
+                       if (equalityComparer == null)
+                               comparerRef = (IComparer) serializationInfo.GetValue ("Comparer", typeof (object));
+#else
                        comparerRef = (IComparer) serializationInfo.GetValue ("Comparer", typeof (object));
+#endif
+                       
                        hcpRef = (IHashCodeProvider) serializationInfo.GetValue ("HashCodeProvider", typeof (object));
                        int size = (int) serializationInfo.GetValue ("HashSize", typeof(int));
                        
index 3fc8fe47b684ce83fab7dac9c55c78d3a8291fe9..8c435239b496c998b65c5b5f3e3314363c34ad27 100644 (file)
@@ -913,17 +913,12 @@ namespace System.Collections {
                        }
 
 
-                       [MonoTODO]
                        public virtual object this [int index] {
                                get {
                                        return host.GetByIndex (index);
                                }
                                set {
-                                       // FIXME: It seems (according to tests)
-                                       // that modifications are allowed
-                                       // in Beta2.
-                                       // ? host.SetByIndex (index, value);
-                                       throw new NotSupportedException("attempt to modify a value");
+                                       throw new NotSupportedException("This operation is not supported on GetValueList return");
                                }
                        }
 
index 76f2a205bdb24eadbfdec9823ba1a7e0171c8324..39482c1523cd8220051b91ab324a9a8516ada292 100644 (file)
@@ -36,7 +36,7 @@ namespace System.Diagnostics
        /// <summary>
        /// Enables communication with a debugger.
        /// </summary>
-       [MonoTODO]
+       [MonoTODO ("The Debugger class is not functional")]
        public sealed class Debugger
        {
                private static bool isAttached;
@@ -72,19 +72,18 @@ namespace System.Diagnostics
                /// <summary>
                /// Checks to see if logging is enabled by an attached debugger.
                /// </summary>
-               [MonoTODO]
                public static bool IsLogging()
                {
                        // Return false. DefaultTraceListener invokes this method, so throwing
                        // a NotImplementedException wouldn't be appropriate.
-      return false;
+                       return false;
 
                }
                
                /// <summary>
                /// Launches and attaches a debugger to the process.
                /// </summary>
-               [MonoTODO]
+               [MonoTODO ("Not implemented")]
                public static bool Launch()
                {
                        throw new NotImplementedException();
@@ -102,7 +101,6 @@ namespace System.Diagnostics
                /// <param name="message">
                /// A string representing the message to show.
                /// </param>
-               [MonoTODO]
                public static void Log(int level, string category, string message)
                {
                        // Do nothing. DefaultTraceListener invokes this method, so throwing
index fd1c8bc4a89af8fbaa1c1c89f9450c52cbb9f89b..69568b7f5622c5fa70d82e4ea0db8b1b91ef5aeb 100644 (file)
@@ -38,7 +38,7 @@ using System.Text;
 namespace System.Diagnostics {
 
        [Serializable]
-       [MonoTODO ("Fix serialization compatibility with MS.NET")]
+       [MonoTODO ("Serialized objects are not compatible with MS.NET")]
         public class StackFrame {
 
                 public const int OFFSET_UNKNOWN = -1;
index bebf216d981dec2b3415fd8fb35f0d6ad4f2cc01..f3d77466dd80ec257b9138fb62252db658a59cf1 100644 (file)
@@ -41,7 +41,7 @@ using System.Threading;
 namespace System.Diagnostics {
 
        [Serializable]
-       [MonoTODO ("Fix serialization compatibility with MS.NET")]
+       [MonoTODO ("Serialized objects are not compatible with .NET")]
        public class StackTrace {
 
                public const int METHODS_TO_SKIP = 0;
@@ -152,7 +152,7 @@ namespace System.Diagnostics {
 #if ONLY_1_1
                [ReflectionPermission (SecurityAction.Demand, TypeInformation = true)]
 #endif
-               [MonoTODO]
+               [MonoTODO ("Not possible to create StackTraces from other threads")]
                public StackTrace (Thread targetThread, bool needFileInfo)
                {
                        throw new NotImplementedException ();
index afeba9dfc5a3b3cb3a977ef9914bafb057311a0f..80cc3fe38cba9508daa434eaefb6f702f406b6b2 100644 (file)
@@ -241,7 +241,7 @@ namespace System.Globalization
                                                 CompareOptions.None));
                }
 
-               [MonoTODO("Add support for CompareOptions.OrdinalIgnoreCase")]
+               [MonoTODO("Does not support CompareOptions.OrdinalIgnoreCase")]
                public virtual int Compare (string string1, int offset1,
                                            int length1, string string2,
                                            int offset2, int length2,
@@ -476,7 +476,7 @@ namespace System.Globalization
                                internal_index (s, sindex, count, c, opt, first);
                }
 
-               [MonoTODO("Add support for CompareOptions.OrdinalIgnoreCase")]
+               [MonoTODO("Does not support CompareOptions.OrdinalIgnoreCase")]
                public virtual int IndexOf (string source, char value,
                                            int startIndex, int count,
                                            CompareOptions options)
@@ -544,7 +544,7 @@ namespace System.Globalization
                                internal_index (s1, sindex, count, s2, opt, first);
                }
 
-               [MonoTODO("Add support for CompareOptions.OrdinalIgnoreCase")]
+               [MonoTODO("Does not support CompareOptions.OrdinalIgnoreCase")]
                public virtual int IndexOf (string source, string value,
                                            int startIndex, int count,
                                            CompareOptions options)
@@ -698,7 +698,7 @@ namespace System.Globalization
                                            CompareOptions.None));
                }
 
-               [MonoTODO("Add support for CompareOptions.OrdinalIgnoreCase")]
+               [MonoTODO("Does not support CompareOptions.OrdinalIgnoreCase")]
                public virtual int LastIndexOf(string source, char value,
                                               int startIndex, int count,
                                               CompareOptions options)
index 7e4b8511b6634574d02ff823188d4f2437879b7d..f2803370cdb1da8e5f49855cfacb12f826eb5e5a 100644 (file)
@@ -457,7 +457,7 @@ namespace System.Globalization
                        }
                }
 
-               [MonoTODO]
+               [MonoTODO ("Always returns null")]
                public static CultureInfo InstalledUICulture
                {
                        get {
@@ -682,9 +682,14 @@ namespace System.Globalization
                        }
                }
 
-               [MonoTODO]
+               [MonoTODO ("Currently it ignores the altName parameter")]
                public static CultureInfo GetCultureInfo (string name, string altName) {
-                       throw new NotImplementedException ();
+                       if (name == null)
+                               throw new ArgumentNullException ("null");
+                       if (altName == null)
+                               throw new ArgumentNullException ("null");
+
+                       return GetCultureInfo (name);
                }
 #endif
 
index 535efdc986bc3ffbb5553d93446586e2d7464d19..73869f07d344be556a88eaccf226aa5bb0a3b13c 100644 (file)
@@ -278,7 +278,7 @@ namespace System.Security.Principal {
 #if !NET_1_0
                void ISerializable.GetObjectData (SerializationInfo info, StreamingContext context) 
                {
-                       info.AddValue ("m_userToken", _token);
+                       info.AddValue ("m_userToken", (long) _token);
                        // can be null when not resolved
                        info.AddValue ("m_name", _name);
                        info.AddValue ("m_type", _type);
index 8f69640a21ed020158698b991373ef276204f676..d71bee0f759a0924e02a7d7882ec7d3ee85ff5bf 100644 (file)
@@ -56,7 +56,6 @@ namespace System {
                        Dispose (false);
                }
 
-               [MonoTODO ("default ?")]
                public ContextForm Form {
                        get { return _form; }
                }
@@ -65,7 +64,7 @@ namespace System {
                        get { return _appid; }
                }
 
-               [MonoTODO]
+               [MonoTODO ("Missing validation")]
                static public ActivationContext CreatePartialActivationContext (ApplicationIdentity identity)
                {
                        if (identity == null)
@@ -77,7 +76,7 @@ namespace System {
                        return new ActivationContext (identity);
                }
 
-               [MonoTODO]
+               [MonoTODO("Missing validation")]
                static public ActivationContext CreatePartialActivationContext (ApplicationIdentity identity, string[] manifestPaths)
                {
                        if (identity == null)
@@ -108,7 +107,7 @@ namespace System {
                        }
                }
 
-               [MonoTODO]
+               [MonoTODO("Missing serialization support")]
                void ISerializable.GetObjectData (SerializationInfo info, StreamingContext context)
                {
                        if (info == null)
index 36e1bece98dca8826cbb6e7cb30e6f0a449c4531..5eddaa34a6c5874ae2a97f68e134f0da507f5504 100644 (file)
@@ -57,7 +57,7 @@ namespace System
                {
                }
 
-               [MonoTODO]
+               [MonoTODO ("No COM support")]
                public static ObjectHandle CreateComInstanceFrom (string assemblyName, string typeName)
                {
                        if (assemblyName == null)
index 7961c11c8008e16078279c158bd51a75d2183bc3..9d7cccb35fe7d0c97171d38511da6aa8aa0a77ec 100644 (file)
@@ -419,7 +419,6 @@ namespace System {
                                refusedPermissions, false);
                }
 
-               [MonoTODO ("FIXME: examine all other parameters")]
                public AssemblyBuilder DefineDynamicAssembly (AssemblyName name, AssemblyBuilderAccess access, string dir,
                                                              Evidence evidence,
                                                              PermissionSet requiredPermissions,
@@ -457,7 +456,7 @@ namespace System {
                [MethodImplAttribute (MethodImplOptions.InternalCall)]
                public extern int ExecuteAssembly (string assemblyFile, Evidence assemblySecurity, string[] args);
 
-               [MonoTODO]
+               [MonoTODO ("No support for ExecuteAssembly")]
                public int ExecuteAssembly (string assemblyFile, Evidence assemblySecurity, string[] args, byte[] hashValue, AssemblyHashAlgorithm hashAlgorithm)
                {
                        throw new NotImplementedException ();
@@ -1071,7 +1070,6 @@ namespace System {
                        return Object.ReferenceEquals (this, DefaultDomain);
                }
 
-               [MonoTODO ("see Assembly.ReflectionOnlyLoad")]
                public Assembly[] ReflectionOnlyGetAssemblies ()
                {
                        return GetAssemblies (true);
index f09ea94d0b1f26404900bc5bc3f466059d07b929..bb6921b81f080dfd9281fc34fa89c6214f467346 100644 (file)
@@ -100,7 +100,7 @@ namespace System {
 
                // static
 
-               [MonoTODO ("maybe AppDomain.CreateDomain should be calling this ?")]
+               // FIXME: maybe AppDomain.CreateDomain should be calling this?
                protected static AppDomain CreateDomainHelper (string friendlyName, Evidence securityInfo, AppDomainSetup appDomainInfo)
                {
                        return AppDomain.CreateDomain (friendlyName, securityInfo, appDomainInfo);
index 379c641ab114f424a3610a7a51a4ad02b5b95f3d..f6d97f9e66d2aca05609d05e1d7a9d54e4a53bb9 100644 (file)
@@ -8,6 +8,9 @@
 // (C) 2001 Ximian, Inc.  http://www.ximian.com
 // Copyright (C) 2004-2005 Novell, Inc (http://www.novell.com)
 //
+// Known Problems:
+//     Fix serialization compatibility with MS.NET.
+//
 // Permission is hereby granted, free of charge, to any person obtaining
 // a copy of this software and associated documentation files (the
 // "Software"), to deal in the Software without restriction, including
@@ -40,7 +43,6 @@ namespace System
 {
        [Serializable]
        [ClassInterface (ClassInterfaceType.None)]
-       [MonoTODO ("Fix serialization compatibility with MS.NET")]
 #if NET_2_0
        [ComVisible (true)]
 #endif
@@ -197,7 +199,7 @@ namespace System
                        }
                }
 
-               [MonoTODO ("--share-code")]
+               [MonoTODO ("In Mono this is controlled by the --share-code flag")]
                public LoaderOptimization LoaderOptimization {
                        get {
                                return loader_optimization;
index bd00f7fdb34aa53d19b193a45e86ab7e241c176b..b0fda9a20db292b0aa95742db35180105d7e187c 100644 (file)
@@ -51,7 +51,9 @@ namespace System {
                                _fullName = applicationIdentityFullName;
                }
 
-               [MonoTODO ("URL for deployment manifest")]
+               //
+               // FIXME: "URL for deployment manifest", this message should be clearer!
+               // 
                public string CodeBase {
                        get { return _codeBase; }
                }
@@ -65,7 +67,7 @@ namespace System {
                        return _fullName;
                }
 
-               [MonoTODO]
+               [MonoTODO ("Missing serialization")]
                void ISerializable.GetObjectData (SerializationInfo info, StreamingContext context)
                {
                        if (info == null)
index 2c69e40eb303c43e13cfdd157b6ba909a4f20392..45dc558b2543f9ab968145020f23ca5110146112 100644 (file)
@@ -1039,7 +1039,6 @@ namespace System
                        return array.GetLowerBound (0) - 1;
                }
 
-               [MonoTODO]
                public void Initialize()
                {
                        //FIXME: We would like to find a compiler that uses
index 72ca335bf272f1967a33d55f6751bdcdf4cea343..1e92fa4b31cffe482725ffe1c6dce21bc0fff43a 100644 (file)
@@ -318,7 +318,7 @@ namespace System
                        return element.IsDefined (attributeType, inherit);
                }
 
-               [MonoTODO]
+               // FIXME: MS apparently walks the inheritance way in some form.
                public static bool IsDefined (ParameterInfo element, Type attributeType, bool inherit)
                {
                        CheckParameters (element, attributeType);
index d94d8134c3e2218605c09e733d4aa78575bbbc68..49849da3383e13e07e53fa1592fca7549186b47e 100644 (file)
@@ -596,14 +596,14 @@ namespace System
                        ConsoleDriver.Clear ();
                }
 
-               [MonoTODO]
+               [MonoTODO ("Not implemented")]
                public static void MoveBufferArea (int sourceLeft, int sourceTop, int sourceWidth, int sourceHeight,
                                                int targetLeft, int targetTop)
                {
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
+               [MonoTODO("Not implemented")]
                public static void MoveBufferArea (int sourceLeft, int sourceTop, int sourceWidth, int sourceHeight,
                                                int targetLeft, int targetTop, Char sourceChar,
                                                ConsoleColor sourceForeColor, ConsoleColor sourceBackColor)
index 7c4f5963eface7ed458760ab7d83c31ac79f0641..2df073a000f85ce600a2d04e45b955a35fc66d8b 100644 (file)
@@ -269,25 +269,24 @@ namespace System
 #endif
                }
 
-               [MonoTODO ("Calendar is unused")]
+               [MonoTODO ("The Calendar is not taken into consideration")]
                public DateTime (int year, int month, int day, Calendar calendar)
                        : this (year, month, day, 0, 0, 0, 0, calendar)
                {
                }
                
-               [MonoTODO ("Calendar is unused")]
+               [MonoTODO ("The Calendar is not taken into consideration")]
                public DateTime (int year, int month, int day, int hour, int minute, int second, Calendar calendar)
                        : this (year, month, day, hour, minute, second, 0, calendar)
                {
                }
 
-               [MonoTODO ("Calendar is unused")]
+               [MonoTODO ("The Calendar is not taken into consideration")]
                public DateTime (int year, int month, int day, int hour, int minute, int second, int millisecond, Calendar calendar)
                        : this (year, month, day, hour, minute, second, millisecond) 
                {
                        if (calendar == null)
                                throw new ArgumentNullException ("calendar");
-                       // FIXME: we're not using the calendar anywhere???
                }
 
                internal DateTime (bool check, TimeSpan value)
@@ -764,7 +763,6 @@ namespace System
                        return Parse (s, fp, DateTimeStyles.AllowWhiteSpaces);
                }
 
-               [MonoTODO ("see the comments inline")]
                public static DateTime Parse (string s, IFormatProvider fp, DateTimeStyles styles)
                {
                        // This method should try only expected patterns. 
index f1acedc9b9f62e2f353a05f2df4845424fa4f28c..356794c8f9b8a0063516a9242f492a8fb3e6f4a0 100644 (file)
@@ -210,7 +210,7 @@ namespace System {
                        return result;
                }
                
-               [MonoTODO("check if digits are group in correct numbers between the group separators")]
+               // FIXME: check if digits are group in correct numbers between the group separators
                internal static bool Parse (string s, NumberStyles style, IFormatProvider provider, bool tryParse, out double result, out Exception exc)
                {
                        result = 0;
index 21c8f809374aceecaf10191ee940032ecd9459c0..363c80cc2a4fefcc1c55342bce6fe92ef06568e5 100644 (file)
@@ -61,7 +61,6 @@ namespace System {
                 */
                private const int mono_corlib_version = 54;
                
-               [MonoTODO]
                public enum SpecialFolder
                {       // TODO: Determine if these windoze style folder identifiers 
                        //       have unix/linux counterparts
@@ -233,7 +232,7 @@ namespace System {
                /// <summary>
                /// Gets a flag indicating whether the process is in interactive mode
                /// </summary>
-               [MonoTODO]
+               [MonoTODO ("Currently always returns false, regardless of interactive state")]
                public static bool UserInteractive {
                        get {
                                return false;
@@ -261,7 +260,7 @@ namespace System {
                /// <summary>
                /// Get the amount of physical memory mapped to process
                /// </summary>
-               [MonoTODO]
+               [MonoTODO ("Currently always returns zero")]
                public static long WorkingSet {
                        [EnvironmentPermission (SecurityAction.Demand, Unrestricted=true)]
                        get { return 0; }
@@ -629,7 +628,7 @@ namespace System {
                        get;                    
                }
 
-               [MonoTODO ("not much documented")]
+               [MonoTODO ("Not implemented")]
                [SecurityPermission (SecurityAction.LinkDemand, UnmanagedCode=true)]
                public static void FailFast (string message)
                {
index 069fe8ea23734db646365e26a9eeee9e0c927e37..2b9ce65d6a29af6ba50db92c8c3241c19cd8db1d 100644 (file)
@@ -105,19 +105,18 @@ namespace System
 
 #if NET_2_0
                [ReliabilityContractAttribute (Consistency.WillNotCorruptState, Cer.Success)]
-               [MonoTODO]
+               [MonoTODO ("Not implemented, always returns 0")]
                public static int CollectionCount (int generation) {
-                       throw new NotImplementedException ();
+                       return 1;
                }
 
-               [MonoTODO]
+               [MonoTODO ("Not implemented")]
                public static void AddMemoryPressure (long bytesAllocated) {
-                       throw new NotImplementedException ();
+                       
                }
 
-               [MonoTODO]
+               [MonoTODO ("Not implemented")]
                public static void RemoveMemoryPressure (long bytesAllocated) {
-                       throw new NotImplementedException ();
                }
 #endif
        }
index ccab0f753e2a6ce44e11aa38605a79806ba24718..c3eadb2f96225d220daaf17c45349034f0054b42 100644 (file)
@@ -214,6 +214,7 @@ namespace MonoTests.System.Security.Policy {
                public void CreateFromUrl_Intranet ()
                {
                        foreach (string url in intranetUrls) {
+                               Console.WriteLine ("url: " + url) ;
                                Zone z = Zone.CreateFromUrl (url);
                                AssertEquals (url, SecurityZone.Intranet, z.SecurityZone);
                        }