2006-02-01 Atsushi Enomoto <atsushi@ximian.com>

	* ConfigurationElement.cs : ListErrors() and SetPropertyValue()
	  are protected.
	* ConfigurationSection.cs : the .ctor() is protected.
	* ConfigurationElementCollection.cs : CollectionType is public.
	  Count and BaseAdd() are not virtual.
	* ConfigurationPropertyCollection.cs : Count is not virtual.

	* SettingElementCollection.cs : CollectionType is protected.

	* TrustLevelCollection.cs, CodeSubDirectoriesCollection.cs,
	  CustomErrorCollection.cs, CompilerCollection.cs,
	  HttpHandlerActionCollection.cs,
	  FormsAuthenticationUserCollection.cs,
	  AuthorizationRuleCollection.cs, TagPrefixCollection.cs :
	  CollectionType is public.

svn path=/trunk/mcs/; revision=56425

diff --git a/mcs/class/System.Configuration/System.Configuration/ChangeLog b/mcs/class/System.Configuration/System.Configuration/ChangeLog
index 83bd15d1434368204505af581fd625df163d3351..02d0aae13bbc0a5660979f6df9e206b743ba0c4a 100644 (file)
--- a/mcs/class/System.Configuration/System.Configuration/ChangeLog
+++ b/mcs/class/System.Configuration/System.Configuration/ChangeLog
@@ -1,3 +1,12 @@
+2006-02-01  Atsushi Enomoto  <atsushi@ximian.com>
+
+       * ConfigurationElement.cs : ListErrors() and SetPropertyValue()
+         are protected.
+       * ConfigurationSection.cs : the .ctor() is protected.
+       * ConfigurationElementCollection.cs : CollectionType is public.
+         Count and BaseAdd() are not virtual.
+       * ConfigurationPropertyCollection.cs : Count is not virtual.
+
 2006-02-01  Chris Toshok  <toshok@ximian.com>
 
        * ConfigurationElement.cs: revert the patch that stores and writes

diff --git a/mcs/class/System.Configuration/System.Configuration/ConfigurationElement.cs b/mcs/class/System.Configuration/System.Configuration/ConfigurationElement.cs
index b5984ba7090fc1a71c94cb0fe3d20cdfcc6c4808..bfefca0fdaf6e50a509136bf338ec8545b33678d 100644 (file)
--- a/mcs/class/System.Configuration/System.Configuration/ConfigurationElement.cs
+++ b/mcs/class/System.Configuration/System.Configuration/ConfigurationElement.cs
@@ -140,13 +140,13 @@ namespace System.Configuration
                }
 
                [MonoTODO]
-               public void ListErrors (IList list)
+               protected void ListErrors (IList list)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO]
-               public void SetPropertyValue (ConfigurationProperty prop, object value, bool ignoreLocks)
+               protected void SetPropertyValue (ConfigurationProperty prop, object value, bool ignoreLocks)
                {
                        try {
                                /* XXX all i know for certain is that Validation happens here */

diff --git a/mcs/class/System.Configuration/System.Configuration/ConfigurationElementCollection.cs b/mcs/class/System.Configuration/System.Configuration/ConfigurationElementCollection.cs
index 45df76232db5a2503487d12f750b3d62a7810de2..7d9832b3d58d32e219740ee805aeced18b3cf16a 100644 (file)
--- a/mcs/class/System.Configuration/System.Configuration/ConfigurationElementCollection.cs
+++ b/mcs/class/System.Configuration/System.Configuration/ConfigurationElementCollection.cs
@@ -80,7 +80,7 @@ namespace System.Configuration
 
                #region Properties
                
-               protected virtual ConfigurationElementCollectionType CollectionType {
+               public virtual ConfigurationElementCollectionType CollectionType {
                        get { return ConfigurationElementCollectionType.AddRemoveClearMap; }
                }
                
@@ -98,7 +98,7 @@ namespace System.Configuration
                        }
                }
 
-               public virtual int Count {
+               public int Count {
                        get { return list.Count; }
                }
 
@@ -147,7 +147,7 @@ namespace System.Configuration
                        BaseAdd (element, ThrowOnDuplicate);
                }
 
-               protected virtual void BaseAdd (ConfigurationElement element, bool throwIfExists)
+               protected void BaseAdd (ConfigurationElement element, bool throwIfExists)
                {
                        if (throwIfExists && BaseIndexOf (element) != -1)
                                throw new ConfigurationException ("Duplicate element in collection");

diff --git a/mcs/class/System.Configuration/System.Configuration/ConfigurationPropertyCollection.cs b/mcs/class/System.Configuration/System.Configuration/ConfigurationPropertyCollection.cs
index dfca501b34987d2da64198abf9cbd9a24f1efa90..bbe44f45133bb4941f85dab8eb9c28fd3283c946 100644 (file)
--- a/mcs/class/System.Configuration/System.Configuration/ConfigurationPropertyCollection.cs
+++ b/mcs/class/System.Configuration/System.Configuration/ConfigurationPropertyCollection.cs
@@ -42,7 +42,7 @@ namespace System.Configuration
                        collection = new List <ConfigurationProperty> ();
                }
 
-               public virtual int Count {
+               public int Count {
                        get { return collection.Count; }
                }
 

diff --git a/mcs/class/System.Configuration/System.Configuration/ConfigurationSection.cs b/mcs/class/System.Configuration/System.Configuration/ConfigurationSection.cs
index 5d0dce37fa4ea5a806411257855dc71ad92b3ac8..2b42088ed87f60a2250d7f67097794d7f628f807 100644 (file)
--- a/mcs/class/System.Configuration/System.Configuration/ConfigurationSection.cs
+++ b/mcs/class/System.Configuration/System.Configuration/ConfigurationSection.cs
@@ -39,7 +39,7 @@ namespace System.Configuration
        {
                SectionInformation sectionInformation;
                
-               public ConfigurationSection ()
+               protected ConfigurationSection ()
                {
                }
                

diff --git a/mcs/class/System.Web/System.Web.Configuration_2.0/AuthorizationRuleCollection.cs b/mcs/class/System.Web/System.Web.Configuration_2.0/AuthorizationRuleCollection.cs
index 702125ed2d5d3b0562eba9e1427619353aaca865..cf9c59f83b0462db076bfa87ebe7ecfac7e49d5d 100644 (file)
--- a/mcs/class/System.Web/System.Web.Configuration_2.0/AuthorizationRuleCollection.cs
+++ b/mcs/class/System.Web/System.Web.Configuration_2.0/AuthorizationRuleCollection.cs
@@ -104,7 +104,7 @@ namespace System.Web.Configuration {
                        BaseAdd(index, rule);
                }
 
-               protected override ConfigurationElementCollectionType CollectionType {
+               public override ConfigurationElementCollectionType CollectionType {
                        get { return ConfigurationElementCollectionType.BasicMapAlternate; }
                }
 

diff --git a/mcs/class/System.Web/System.Web.Configuration_2.0/ChangeLog b/mcs/class/System.Web/System.Web.Configuration_2.0/ChangeLog
index 37b8dbe2103451dad49808352a59d0ce5c202e62..24d2d208ada7ded52abd0431dfe8b8d74de144c7 100644 (file)
--- a/mcs/class/System.Web/System.Web.Configuration_2.0/ChangeLog
+++ b/mcs/class/System.Web/System.Web.Configuration_2.0/ChangeLog
@@ -1,3 +1,12 @@
+2006-02-01  Atsushi Enomoto  <atsushi@ximian.com>
+
+       * TrustLevelCollection.cs, CodeSubDirectoriesCollection.cs,
+         CustomErrorCollection.cs, CompilerCollection.cs,
+         HttpHandlerActionCollection.cs,
+         FormsAuthenticationUserCollection.cs,
+         AuthorizationRuleCollection.cs, TagPrefixCollection.cs :
+         CollectionType is public.
+
 2006-02-01  Chris Toshok  <toshok@ximian.com>
 
        * WebConfigurationManager.cs: In the normal case, get the current

diff --git a/mcs/class/System.Web/System.Web.Configuration_2.0/CodeSubDirectoriesCollection.cs b/mcs/class/System.Web/System.Web.Configuration_2.0/CodeSubDirectoriesCollection.cs
index 3354d9c0d881c3b0c7d755fb98f3db272218c45e..ae84c3af6073a65b15e1808f4b134b6fd30e5a0f 100644 (file)
--- a/mcs/class/System.Web/System.Web.Configuration_2.0/CodeSubDirectoriesCollection.cs
+++ b/mcs/class/System.Web/System.Web.Configuration_2.0/CodeSubDirectoriesCollection.cs
@@ -54,7 +54,7 @@ namespace System.Web.Configuration
                        set { if (BaseGet (index) != null) BaseRemoveAt (index); BaseAdd (index, value); }
                }
 
-               protected override ConfigurationElementCollectionType CollectionType {
+               public override ConfigurationElementCollectionType CollectionType {
                        get { return ConfigurationElementCollectionType.BasicMap; }
                }
 

diff --git a/mcs/class/System.Web/System.Web.Configuration_2.0/CompilerCollection.cs b/mcs/class/System.Web/System.Web.Configuration_2.0/CompilerCollection.cs
index 29258ba58197974196997d3349205ee11db2fb48..f089d7ad93ae09e7941a764d402f0a2c4baa6513 100644 (file)
--- a/mcs/class/System.Web/System.Web.Configuration_2.0/CompilerCollection.cs
+++ b/mcs/class/System.Web/System.Web.Configuration_2.0/CompilerCollection.cs
@@ -83,7 +83,7 @@ namespace System.Web.Configuration
                        }
                }
 
-               protected override ConfigurationElementCollectionType CollectionType {
+               public override ConfigurationElementCollectionType CollectionType {
                        get { return ConfigurationElementCollectionType.BasicMap; }
                }
 

diff --git a/mcs/class/System.Web/System.Web.Configuration_2.0/CustomErrorCollection.cs b/mcs/class/System.Web/System.Web.Configuration_2.0/CustomErrorCollection.cs
index b9e1932ca25a8abdc31f3ebbcaf22e229a6e2e7c..3aff1cf05918c9698ad9347134ef3a6b1246f898 100644 (file)
--- a/mcs/class/System.Web/System.Web.Configuration_2.0/CustomErrorCollection.cs
+++ b/mcs/class/System.Web/System.Web.Configuration_2.0/CustomErrorCollection.cs
@@ -114,7 +114,7 @@ namespace System.Web.Configuration {
                        }
                }
 
-               protected override ConfigurationElementCollectionType CollectionType {
+               public override ConfigurationElementCollectionType CollectionType {
                        get { return ConfigurationElementCollectionType.BasicMap; }
                }
 

diff --git a/mcs/class/System.Web/System.Web.Configuration_2.0/FormsAuthenticationUserCollection.cs b/mcs/class/System.Web/System.Web.Configuration_2.0/FormsAuthenticationUserCollection.cs
index 52669e31184bdf504cb12cc13949e3a8a59c8463..8eb653de0d5a726e6fab2e5caa880b384c4e4fc5 100644 (file)
--- a/mcs/class/System.Web/System.Web.Configuration_2.0/FormsAuthenticationUserCollection.cs
+++ b/mcs/class/System.Web/System.Web.Configuration_2.0/FormsAuthenticationUserCollection.cs
@@ -118,7 +118,7 @@ namespace System.Web.Configuration
                        }
                }
 
-               protected override ConfigurationElementCollectionType CollectionType {
+               public override ConfigurationElementCollectionType CollectionType {
                        get { return ConfigurationElementCollectionType.BasicMap; }
                }
 

diff --git a/mcs/class/System.Web/System.Web.Configuration_2.0/HttpHandlerActionCollection.cs b/mcs/class/System.Web/System.Web.Configuration_2.0/HttpHandlerActionCollection.cs
index b0b83d77b5578f78f17ba0366b8fe2cc1f29d152..56821fd81c994e70baeeed69baa1821a15762d9a 100644 (file)
--- a/mcs/class/System.Web/System.Web.Configuration_2.0/HttpHandlerActionCollection.cs
+++ b/mcs/class/System.Web/System.Web.Configuration_2.0/HttpHandlerActionCollection.cs
@@ -89,7 +89,7 @@ namespace System.Web.Configuration
                        BaseRemoveAt (index);
                }
 
-               protected override ConfigurationElementCollectionType CollectionType {
+               public override ConfigurationElementCollectionType CollectionType {
                        get { return ConfigurationElementCollectionType.AddRemoveClearMapAlternate; }
                }
 

diff --git a/mcs/class/System.Web/System.Web.Configuration_2.0/TagPrefixCollection.cs b/mcs/class/System.Web/System.Web.Configuration_2.0/TagPrefixCollection.cs
index f82a65e76230a6088d5d46895762217001391b5c..032963c93e0dc84121d4dbebcb3b2f60cf2110fd 100644 (file)
--- a/mcs/class/System.Web/System.Web.Configuration_2.0/TagPrefixCollection.cs
+++ b/mcs/class/System.Web/System.Web.Configuration_2.0/TagPrefixCollection.cs
@@ -77,7 +77,7 @@ namespace System.Web.Configuration
                }
 
                [MonoTODO ("why override this?")]
-               protected override ConfigurationElementCollectionType CollectionType {
+               public override ConfigurationElementCollectionType CollectionType {
                        get { return ConfigurationElementCollectionType.BasicMap; }
                }
 

diff --git a/mcs/class/System.Web/System.Web.Configuration_2.0/TrustLevelCollection.cs b/mcs/class/System.Web/System.Web.Configuration_2.0/TrustLevelCollection.cs
index 56316ab5c1b85a75dd09edbe9e8a7acfa8f2bbad..4d6cd7efaea2995126c588e8bbadeed3522b55bb 100644 (file)
--- a/mcs/class/System.Web/System.Web.Configuration_2.0/TrustLevelCollection.cs
+++ b/mcs/class/System.Web/System.Web.Configuration_2.0/TrustLevelCollection.cs
@@ -92,7 +92,7 @@ namespace System.Web.Configuration {
                        return elementname == "trustlevel";
                }
 
-               protected override ConfigurationElementCollectionType CollectionType {
+               public override ConfigurationElementCollectionType CollectionType {
                        get { return ConfigurationElementCollectionType.BasicMap; }
                }
 

diff --git a/mcs/class/System/System.Configuration/ChangeLog b/mcs/class/System/System.Configuration/ChangeLog
index 3863e43f9059a8ef811782359e8d555faf7acbb9..89e945964608f15bb237b16aa4107ed7bfe3d093 100644 (file)
--- a/mcs/class/System/System.Configuration/ChangeLog
+++ b/mcs/class/System/System.Configuration/ChangeLog
@@ -1,3 +1,7 @@
+2006-02-01  Atsushi Enomoto  <atsushi@ximian.com>
+
+       * SettingElementCollection.cs : CollectionType is protected.
+
 2006-01-16  Chris Toshok  <toshok@ximian.com>
 
        * ConfigurationSettings.cs (AppSettings): move back to a 1.x

diff --git a/mcs/class/System/System.Configuration/SettingElementCollection.cs b/mcs/class/System/System.Configuration/SettingElementCollection.cs
index 91f91e45ef67d1d328d34a007ae757d43407e823..617c1a0e8e11a3b37b2208f9f6221039ae3f21d6 100644 (file)
--- a/mcs/class/System/System.Configuration/SettingElementCollection.cs
+++ b/mcs/class/System/System.Configuration/SettingElementCollection.cs
@@ -78,7 +78,7 @@ namespace System.Configuration
                }
 
                [MonoTODO]
-               protected override ConfigurationElementCollectionType CollectionType {
+               public override ConfigurationElementCollectionType CollectionType {
                        get {
                                throw new NotImplementedException ();
                        }