Revert "[HttpWebRequest] Avoid using the threadpool for synchronous requests"
authorMiguel de Icaza <miguel@gnome.org>
Fri, 15 Feb 2013 16:08:47 +0000 (11:08 -0500)
committerMiguel de Icaza <miguel@gnome.org>
Fri, 15 Feb 2013 16:11:58 +0000 (11:11 -0500)
commit14f0405443693ec2586e73e4b3746134046210d5
tree6e11e93975bb92ce71add86596f20c2505110585
parent6e54963a8e205dc0e0f9ed10cd5ab3d8583963a1
Revert "[HttpWebRequest] Avoid using the threadpool for synchronous requests"

This reverts commit b190db44cbf321391ab0cf946f4501eae76f2eb3.

The reason is:

"The HttpWebRequests tests are not enough"

"A quick review of the code shows that the code is taking a lock, while
calling a function that retries connections (which in turn takes another
important lock --for the socket--) which might casue a stack overflow
if someone calls SetWriteStream"

"This also will make the opereation sync when calling Begin/End"

"Finally, this is a patch that improves the use of the threadpool, but
the threadpool still will end up exhausted"

Probably best to just increase the number of threads?
mcs/class/System/System.Net/HttpWebRequest.cs
mcs/class/System/System.Net/WebConnection.cs