X-Git-Url: http://wien.tomnetworks.com/gitweb/?a=blobdiff_plain;f=mono%2Fmini%2Ftramp-mips.c;h=aac6eb016e92593c01e5e1583f9c08434ae6a375;hb=1a608685342027c7802a6124924949232a424760;hp=d054c1fab336594723154e6c97139045e800d73c;hpb=4323fbeaebf249f016dfdd6dc9b3b52a515f87c4;p=mono.git diff --git a/mono/mini/tramp-mips.c b/mono/mini/tramp-mips.c index d054c1fab33..aac6eb016e9 100644 --- a/mono/mini/tramp-mips.c +++ b/mono/mini/tramp-mips.c @@ -24,9 +24,10 @@ #include "mini.h" #include "mini-mips.h" +static guint8* nullified_class_init_trampoline; + /* * get_unbox_trampoline: - * @gsctx: the generic sharing context * @m: method pointer * @addr: pointer to native code for @m * @@ -35,21 +36,16 @@ * unboxing before calling the method */ gpointer -mono_arch_get_unbox_trampoline (MonoGenericSharingContext *gsctx, MonoMethod *m, gpointer addr) +mono_arch_get_unbox_trampoline (MonoMethod *m, gpointer addr) { guint8 *code, *start; - int this_pos = mips_a0; MonoDomain *domain = mono_domain_get (); - - if (MONO_TYPE_ISSTRUCT (mono_method_signature (m)->ret)) - this_pos = mips_a1; - mono_domain_lock (domain); - start = code = mono_code_manager_reserve (domain->code_mp, 20); - mono_domain_unlock (domain); + start = code = mono_domain_code_reserve (domain, 20); mips_load (code, mips_t9, addr); - mips_addiu (code, this_pos, this_pos, sizeof (MonoObject)); + /* The this pointer is kept in a0 */ + mips_addiu (code, mips_a0, mips_a0, sizeof (MonoObject)); mips_jr (code, mips_t9); mips_nop (code); @@ -66,11 +62,12 @@ mono_arch_patch_callsite (guint8 *method_start, guint8 *orig_code, guint8 *addr) { guint32 *code = (guint32*)orig_code; - /* Locate the address of the method-specific trampoline. The call using - the vtable slot that took the processing flow to 'arch_create_jit_trampoline' - looks something like this: + /* Locate the address of the method-specific trampoline. + The call using the vtable slot that took the processing flow to + 'arch_create_jit_trampoline' looks something like one of these: jal XXXXYYYY + nop lui t9, XXXX addiu t9, YYYY @@ -84,23 +81,23 @@ mono_arch_patch_callsite (guint8 *method_start, guint8 *orig_code, guint8 *addr) if ((code[-2] >> 26) == 0x03) { //g_print ("direct patching\n"); mips_patch ((code-2), (gsize)addr); - } else { - /* Sanity check: look for the jalr */ - g_assert((code[-2] & 0xfc1f003f) == 0x00000009); - - //printf ("mips_magic_trampoline: jalr @ 0x%0x, w/ reg %d\n", code-2, reg); - + return; + } + /* Look for the jalr */ + if ((code[-2] & 0xfc1f003f) == 0x00000009) { /* The lui / addiu / jalr case */ - if ((code [-4] >> 26) == 0x0f && (code [-3] >> 26) == 0x09 && (code [-2] >> 26) == 0) { + if ((code [-4] >> 26) == 0x0f && (code [-3] >> 26) == 0x09 + && (code [-2] >> 26) == 0) { mips_patch ((code-4), (gsize)addr); - } else { - g_assert_not_reached (); + return; } } + g_print("error: bad patch at 0x%08x\n", code); + g_assert_not_reached (); } void -mono_arch_patch_plt_entry (guint8 *code, guint8 *addr) +mono_arch_patch_plt_entry (guint8 *code, gpointer *got, mgreg_t *regs, guint8 *addr) { g_assert_not_reached (); } @@ -112,192 +109,19 @@ mono_arch_patch_plt_entry (guint8 *code, guint8 *addr) * STACK would be 444 for 32 bit darwin */ -#define STACK (4*4 + 8 + sizeof(MonoLMF) + 32) - -gpointer* -mono_arch_get_vcall_slot_addr (guint8* code8, gpointer *regs) -{ - char *vtable = NULL; - int reg, offset = 0; - guint32 base = 0; - guint32 *code = (guint32*)code8; - char *sp; - - /* On MIPS, we are passed sp instead of the register array */ - sp = (char*)regs; - - //printf ("mips_magic_trampoline: 0x%08x @ 0x%0x\n", *(code-2), code-2); - - /* The jal case */ - if ((code[-2] >> 26) == 0x03) - return NULL; - - /* Sanity check: look for the jalr */ - g_assert((code[-2] & 0xfc1f003f) == 0x00000009); - - reg = (code[-2] >> 21) & 0x1f; - - //printf ("mips_magic_trampoline: jalr @ 0x%0x, w/ reg %d\n", code-2, reg); - - /* The lui / addiu / jalr case */ - if ((code [-4] >> 26) == 0x0f && (code [-3] >> 26) == 0x09 && (code [-2] >> 26) == 0) { - return NULL; - } - - /* Probably a vtable lookup */ - - /* Walk backwards to find 'lw reg,XX(base)' */ - for(; --code;) { - guint32 mask = (0x3f << 26) | (0x1f << 16); - guint32 match = (0x23 << 26) | (reg << 16); - if((*code & mask) == match) { - gint16 soff; - gint reg_offset; - - /* lw reg,XX(base) */ - base = (*code >> 21) & 0x1f; - soff = (*code & 0xffff); - if (soff & 0x8000) - soff |= 0xffff0000; - offset = soff; - reg_offset = STACK - sizeof (MonoLMF) - + G_STRUCT_OFFSET (MonoLMF, iregs[base]); - /* o contains now the value of register reg */ - vtable = *((char**) (sp + reg_offset)); - return (gpointer*)vtable; - } - } - - g_assert_not_reached (); - return NULL; -} +#define STACK (4*IREG_SIZE + 8 + sizeof(MonoLMF) + 32) void -mono_arch_nullify_plt_entry (guint8 *code) +mono_arch_nullify_plt_entry (guint8 *code, mgreg_t *regs) { - g_assert_not_reached (); -} - -/** - * mips_magic_trampoline: - * @code: pointer into caller code - * @method: the method to translate - * @sp: stack pointer - * - * This method is called by the function 'arch_create_jit_trampoline', which in - * turn is called by the trampoline functions for virtual methods. - * After having called the JIT compiler to compile the method, it inspects the - * caller code to find the address of the method-specific part of the - * trampoline vtable slot for this method, updates it with a fragment that calls - * the newly compiled code and returns this address of the compiled code to - * 'arch_create_jit_trampoline' - */ -#if 0 -static gpointer -mips_magic_trampoline (MonoMethod *method, guint32 *code, char *sp) -{ - char *vtable = NULL; - gpointer addr; - MonoJitInfo *ji, *target_ji; - int reg, offset = 0; - guint32 base = 0; - - addr = mono_compile_method (method); - g_assert (addr); - - if (!code) - return addr; - - /* We can't trampoline across domains */ - ji = mono_jit_info_table_find (mono_domain_get (), code); - target_ji = mono_jit_info_table_find (mono_domain_get (), addr); - if (!mono_method_same_domain (ji, target_ji)) - return addr; - -#if 0 - g_print ("mips_magic: method code at %p from %p for %s:%s\n", - addr, code, method->klass->name, method->name); -#endif - /* Locate the address of the method-specific trampoline. The call using - the vtable slot that took the processing flow to 'arch_create_jit_trampoline' - looks something like this: - - jal XXXXYYYY - - lui t9, XXXX - addiu t9, YYYY - jalr t9 - nop - - On entry, 'code' points just after one of the above sequences. - */ - - /* The jal case */ - if ((code[-2] >> 26) == 0x03) { - g_print ("direct patching\n"); - mips_patch ((char*)(code-2), addr); - return addr; - } - - /* Sanity check: look for the jalr */ - g_assert((code[-2] & 0xfc1f003f) == 0x00000009); - - reg = (code[-2] >> 21) & 0x1f; - - //printf ("mips_magic_trampoline: jalr @ 0x%0x, w/ reg %d\n", code-2, reg); - - /* The lui / addiu / jalr case */ - if ((code [-4] >> 26) == 0x0f && (code [-3] >> 26) == 0x09 && (code [-2] >> 26) == 0) { - mips_patch ((char*)(code-4), addr); - return addr; - } - - //printf ("mips_magic_trampoline: 0x%08x @ 0x%0x\n", *(code-2), code-2); - - /* Probably a vtable lookup */ - - /* Walk backwards to find 'lw reg,XX(base)' */ - for(; --code;) { - guint32 mask = (0x3f << 26) | (0x1f << 16); - guint32 match = (0x23 << 26) | (reg << 16); - if((*code & mask) == match) { - gint16 soff; - gint reg_offset; - - /* lw reg,XX(base) */ - base = (*code >> 21) & 0x1f; - soff = (*code & 0xffff); - if (soff & 0x8000) - soff |= 0xffff0000; - offset = soff; - reg_offset = STACK - sizeof (MonoLMF) - + G_STRUCT_OFFSET (MonoLMF, iregs[base]); - /* o contains now the value of register reg */ - vtable = *((char**) (sp + reg_offset)); -#if 0 - g_print ("patching reg is %d, offset %d (vtable %p) @ %p\n", - base, offset, vtable, code); -#endif - break; - } - } + if (mono_aot_only && !nullified_class_init_trampoline) + nullified_class_init_trampoline = mono_aot_get_trampoline ("nullified_class_init_trampoline"); - /* this is not done for non-virtual calls, because in that case - we won't have an object, but the actual pointer to the - valuetype as the this argument - */ - if (method->klass->valuetype && !mono_aot_is_got_entry (code, vtable)) - addr = get_unbox_trampoline (method, addr); - - vtable += offset; - if (mono_aot_is_got_entry (code, vtable) || mono_domain_owns_vtable_slot (mono_domain_get (), vtable)) - *((gpointer *)vtable) = addr; - return addr; + mono_arch_patch_plt_entry (code, NULL, regs, nullified_class_init_trampoline); } -#endif void -mono_arch_nullify_class_init_trampoline (guint8 *code, gssize *regs) +mono_arch_nullify_class_init_trampoline (guint8 *code, mgreg_t *regs) { guint32 *code32 = (guint32*)code; @@ -310,9 +134,26 @@ mono_arch_nullify_class_init_trampoline (guint8 *code, gssize *regs) mips_nop (code32); mono_arch_flush_icache ((gpointer)(code32 - 1), 4); return; - } else { - g_assert_not_reached (); } + g_assert_not_reached (); +} + +gpointer +mono_arch_get_nullified_class_init_trampoline (MonoTrampInfo **info) +{ + guint8 *buf, *code; + + code = buf = mono_global_codeman_reserve (16); + + mips_jr (code, mips_ra); + mips_nop (code); + + mono_arch_flush_icache (buf, code - buf); + + if (info) + *info = mono_tramp_info_create (g_strdup_printf ("nullified_class_init_trampoline"), buf, code - buf, NULL, NULL); + + return buf; } /* @@ -331,12 +172,17 @@ mono_arch_nullify_class_init_trampoline (guint8 *code, gssize *regs) * ------------------- */ guchar* -mono_arch_create_trampoline_code (MonoTrampolineType tramp_type) +mono_arch_create_generic_trampoline (MonoTrampolineType tramp_type, MonoTrampInfo **info, gboolean aot) { guint8 *buf, *tramp, *code = NULL; int i, lmf; + GSList *unwind_ops = NULL; + MonoJumpInfo *ji = NULL; int max_code_len = 768; + /* AOT not supported on MIPS yet */ + g_assert (!aot); + /* Now we'll create in 'buf' the MIPS trampoline code. This is the trampoline code common to all methods */ @@ -351,20 +197,21 @@ mono_arch_create_trampoline_code (MonoTrampolineType tramp_type) lmf = STACK - sizeof (MonoLMF) - 8; for (i = 0; i < MONO_MAX_IREGS; i++) - mips_sw (code, i, mips_sp, lmf + G_STRUCT_OFFSET (MonoLMF, iregs[i])); + MIPS_SW (code, i, mips_sp, lmf + G_STRUCT_OFFSET (MonoLMF, iregs[i])); for (i = 0; i < MONO_MAX_FREGS; i++) - mips_swc1 (code, i, mips_sp, lmf + G_STRUCT_OFFSET (MonoLMF, fregs[i])); + MIPS_SWC1 (code, i, mips_sp, lmf + G_STRUCT_OFFSET (MonoLMF, fregs[i])); /* Set the magic number */ mips_load_const (code, mips_at, MIPS_LMF_MAGIC2); mips_sw (code, mips_at, mips_sp, lmf + G_STRUCT_OFFSET(MonoLMF, magic)); + /* Save caller sp */ + mips_addiu (code, mips_at, mips_sp, STACK); + MIPS_SW (code, mips_at, mips_sp, lmf + G_STRUCT_OFFSET (MonoLMF, iregs[mips_sp])); + /* save method info (it was in t8) */ mips_sw (code, mips_t8, mips_sp, lmf + G_STRUCT_OFFSET(MonoLMF, method)); - /* save frame pointer (caller fp) */ - mips_sw (code, mips_fp, mips_sp, lmf + G_STRUCT_OFFSET(MonoLMF, ebp)); - /* save the IP (caller ip) */ if (tramp_type == MONO_TRAMPOLINE_JUMP) { mips_sw (code, mips_zero, mips_sp, lmf + G_STRUCT_OFFSET(MonoLMF, eip)); @@ -394,11 +241,11 @@ mono_arch_create_trampoline_code (MonoTrampolineType tramp_type) * Now we're ready to call mips_magic_trampoline (). */ - /* Arg 1: stack pointer so that the magic trampoline can access the - * registers we saved above + /* Arg 1: pointer to registers so that the magic trampoline can + * access what we saved above */ - mips_move (code, mips_a0, mips_sp); - + mips_addiu (code, mips_a0, mips_sp, lmf + G_STRUCT_OFFSET (MonoLMF, iregs[0])); + /* Arg 2: code (next address to the instruction that called us) */ if (tramp_type == MONO_TRAMPOLINE_JUMP) { mips_move (code, mips_a1, mips_zero); @@ -407,7 +254,10 @@ mono_arch_create_trampoline_code (MonoTrampolineType tramp_type) } /* Arg 3: MonoMethod *method. */ - mips_lw (code, mips_a2, mips_sp, lmf + G_STRUCT_OFFSET (MonoLMF, method)); + if (tramp_type == MONO_TRAMPOLINE_GENERIC_CLASS_INIT) + mips_lw (code, mips_a2, mips_sp, lmf + G_STRUCT_OFFSET (MonoLMF, iregs [mips_a0])); + else + mips_lw (code, mips_a2, mips_sp, lmf + G_STRUCT_OFFSET (MonoLMF, method)); /* Arg 4: Trampoline */ mips_move (code, mips_a3, mips_zero); @@ -435,19 +285,21 @@ mono_arch_create_trampoline_code (MonoTrampolineType tramp_type) /* Restore the callee-saved & argument registers */ for (i = 0; i < MONO_MAX_IREGS; i++) { if ((MONO_ARCH_CALLEE_SAVED_REGS | MONO_ARCH_CALLEE_REGS | MIPS_ARG_REGS) & (1 << i)) - mips_lw (code, i, mips_sp, lmf + G_STRUCT_OFFSET (MonoLMF, iregs[i])); + MIPS_LW (code, i, mips_sp, lmf + G_STRUCT_OFFSET (MonoLMF, iregs[i])); } for (i = 0; i < MONO_MAX_FREGS; i++) - mips_lwc1 (code, i, mips_sp, lmf + G_STRUCT_OFFSET (MonoLMF, fregs[i])); + MIPS_LWC1 (code, i, mips_sp, lmf + G_STRUCT_OFFSET (MonoLMF, fregs[i])); /* Non-standard function epilogue. Instead of doing a proper * return, we just jump to the compiled code. */ /* Restore ra & stack pointer, and jump to the code */ + if (tramp_type == MONO_TRAMPOLINE_RGCTX_LAZY_FETCH) + mips_move (code, mips_v0, mips_at); mips_lw (code, mips_ra, mips_sp, STACK + MIPS_RET_ADDR_OFFSET); mips_addiu (code, mips_sp, mips_sp, STACK); - if (tramp_type == MONO_TRAMPOLINE_CLASS_INIT) + if (MONO_TRAMPOLINE_TYPE_MUST_RETURN (tramp_type)) mips_jr (code, mips_ra); else mips_jr (code, mips_at); @@ -459,6 +311,13 @@ mono_arch_create_trampoline_code (MonoTrampolineType tramp_type) /* Sanity check */ g_assert ((code - buf) <= max_code_len); + if (tramp_type == MONO_TRAMPOLINE_CLASS_INIT) + /* Initialize the nullified class init trampoline used in the AOT case */ + nullified_class_init_trampoline = mono_arch_get_nullified_class_init_trampoline (NULL); + + if (info) + *info = mono_tramp_info_create (mono_get_generic_trampoline_name (tramp_type), buf, code - buf, ji, unwind_ops); + return buf; } @@ -469,9 +328,7 @@ mono_arch_create_specific_trampoline (gpointer arg1, MonoTrampolineType tramp_ty tramp = mono_get_trampoline_code (tramp_type); - mono_domain_lock (domain); - code = buf = mono_code_manager_reserve (domain->code_mp, 32); - mono_domain_unlock (domain); + code = buf = mono_domain_code_reserve (domain, 32); /* Prepare the jump to the generic trampoline code * mono_arch_create_trampoline_code() knows we're putting this in t8 @@ -495,9 +352,192 @@ mono_arch_create_specific_trampoline (gpointer arg1, MonoTrampolineType tramp_ty } gpointer -mono_arch_create_rgctx_lazy_fetch_trampoline (guint32 encoded_offset) +mono_arch_get_static_rgctx_trampoline (MonoMethod *m, MonoMethodRuntimeGenericContext *mrgctx, gpointer addr) { - /* FIXME: implement! */ - g_assert_not_reached (); - return NULL; + guint8 *code, *start; + int buf_len; + + MonoDomain *domain = mono_domain_get (); + + buf_len = 24; + + start = code = mono_domain_code_reserve (domain, buf_len); + + mips_load (code, MONO_ARCH_RGCTX_REG, mrgctx); + mips_load (code, mips_at, addr); + mips_jr (code, mips_at); + mips_nop (code); + + g_assert ((code - start) <= buf_len); + + mono_arch_flush_icache (start, code - start); + + return start; +} + +gpointer +mono_arch_create_rgctx_lazy_fetch_trampoline (guint32 slot, MonoTrampInfo **info, gboolean aot) +{ + guint8 *tramp; + guint8 *code, *buf; + int tramp_size; + guint32 code_len; + guint8 **rgctx_null_jumps; + int depth, index; + int i, njumps; + gboolean mrgctx; + MonoJumpInfo *ji = NULL; + GSList *unwind_ops = NULL; + + mrgctx = MONO_RGCTX_SLOT_IS_MRGCTX (slot); + index = MONO_RGCTX_SLOT_INDEX (slot); + if (mrgctx) + index += MONO_SIZEOF_METHOD_RUNTIME_GENERIC_CONTEXT / sizeof (gpointer); + for (depth = 0; ; ++depth) { + int size = mono_class_rgctx_get_array_size (depth, mrgctx); + + if (index < size - 1) + break; + index -= size - 1; + } + + tramp_size = 64 + 16 * depth; + + code = buf = mono_global_codeman_reserve (tramp_size); + + mono_add_unwind_op_def_cfa (unwind_ops, code, buf, mips_sp, 0); + + rgctx_null_jumps = g_malloc (sizeof (guint8*) * (depth + 2)); + njumps = 0; + + /* The vtable/mrgctx is in a0 */ + g_assert (MONO_ARCH_VTABLE_REG == mips_a0); + if (mrgctx) { + /* get mrgctx ptr */ + mips_move (code, mips_a1, mips_a0); + } else { + /* load rgctx ptr from vtable */ + g_assert (mips_is_imm16 (G_STRUCT_OFFSET (MonoVTable, runtime_generic_context))); + mips_lw (code, mips_a1, mips_a0, G_STRUCT_OFFSET (MonoVTable, runtime_generic_context)); + /* is the rgctx ptr null? */ + /* if yes, jump to actual trampoline */ + rgctx_null_jumps [njumps ++] = code; + mips_beq (code, mips_a1, mips_zero, 0); + mips_nop (code); + } + + for (i = 0; i < depth; ++i) { + /* load ptr to next array */ + if (mrgctx && i == 0) { + g_assert (mips_is_imm16 (MONO_SIZEOF_METHOD_RUNTIME_GENERIC_CONTEXT)); + mips_lw (code, mips_a1, mips_a1, MONO_SIZEOF_METHOD_RUNTIME_GENERIC_CONTEXT); + } else { + mips_lw (code, mips_a1, mips_a1, 0); + } + /* is the ptr null? */ + /* if yes, jump to actual trampoline */ + rgctx_null_jumps [njumps ++] = code; + mips_beq (code, mips_a1, mips_zero, 0); + mips_nop (code); + } + + /* fetch slot */ + g_assert (mips_is_imm16 (sizeof (gpointer) * (index + 1))); + mips_lw (code, mips_a1, mips_a1, sizeof (gpointer) * (index + 1)); + /* is the slot null? */ + /* if yes, jump to actual trampoline */ + rgctx_null_jumps [njumps ++] = code; + mips_beq (code, mips_a1, mips_zero, 0); + mips_nop (code); + /* otherwise return, result is in R1 */ + mips_move (code, mips_v0, mips_a1); + mips_jr (code, mips_ra); + mips_nop (code); + + g_assert (njumps <= depth + 2); + for (i = 0; i < njumps; ++i) + mips_patch ((guint32*)rgctx_null_jumps [i], (guint32)code); + + g_free (rgctx_null_jumps); + + /* Slowpath */ + + /* The vtable/mrgctx is still in a0 */ + + if (aot) { + ji = mono_patch_info_list_prepend (ji, code - buf, MONO_PATCH_INFO_JIT_ICALL_ADDR, g_strdup_printf ("specific_trampoline_lazy_fetch_%u", slot)); + mips_load (code, mips_at, 0); + mips_jr (code, mips_at); + mips_nop (code); + } else { + tramp = mono_arch_create_specific_trampoline (GUINT_TO_POINTER (slot), MONO_TRAMPOLINE_RGCTX_LAZY_FETCH, mono_get_root_domain (), &code_len); + mips_load (code, mips_at, tramp); + mips_jr (code, mips_at); + mips_nop (code); + } + + mono_arch_flush_icache (buf, code - buf); + + g_assert (code - buf <= tramp_size); + + if (info) + *info = mono_tramp_info_create (mono_get_rgctx_fetch_trampoline_name (slot), buf, code - buf, ji, unwind_ops); + + return buf; +} + +gpointer +mono_arch_create_generic_class_init_trampoline (MonoTrampInfo **info, gboolean aot) +{ + guint8 *tramp; + guint8 *code, *buf; + static int byte_offset = -1; + static guint8 bitmask; + guint8 *jump; + int tramp_size; + guint32 code_len; + GSList *unwind_ops = NULL; + MonoJumpInfo *ji = NULL; + + tramp_size = 64; + + code = buf = mono_global_codeman_reserve (tramp_size); + + if (byte_offset < 0) + mono_marshal_find_bitfield_offset (MonoVTable, initialized, &byte_offset, &bitmask); + + /* if (!(vtable->initialized)) */ + mips_lbu (code, mips_at, MONO_ARCH_VTABLE_REG, byte_offset); + g_assert (!(bitmask & 0xffff0000)); + mips_andi (code, mips_at, mips_at, bitmask); + jump = code; + mips_beq (code, mips_at, mips_zero, 0); + mips_nop (code); + /* Initialized case */ + mips_jr (code, mips_ra); + mips_nop (code); + + /* Uninitialized case */ + mips_patch ((guint32*)jump, (guint32)code); + + if (aot) { + ji = mono_patch_info_list_prepend (ji, code - buf, MONO_PATCH_INFO_JIT_ICALL_ADDR, "specific_trampoline_generic_class_init"); + mips_load (code, mips_at, 0); + mips_jr (code, mips_at); + mips_nop (code); + } else { + tramp = mono_arch_create_specific_trampoline (NULL, MONO_TRAMPOLINE_GENERIC_CLASS_INIT, mono_get_root_domain (), &code_len); + mips_load (code, mips_at, tramp); + mips_jr (code, mips_at); + mips_nop (code); + } + + mono_arch_flush_icache (buf, code - buf); + + g_assert (code - buf <= tramp_size); + + if (info) + *info = mono_tramp_info_create (g_strdup_printf ("generic_class_init_trampoline"), buf, code - buf, ji, unwind_ops); + + return buf; }