X-Git-Url: http://wien.tomnetworks.com/gitweb/?a=blobdiff_plain;f=mono%2Fmetadata%2Fmarshal.c;h=792a1dcf37eae662456b75b0dfa42202ec2db2b0;hb=30305335b8295bfb9426e95443ad2e32784c154f;hp=dddd049d4b0d5f0261c16640ec778843635aa3e9;hpb=f274be9b817942f40ed187b355d62389e4407580;p=mono.git diff --git a/mono/metadata/marshal.c b/mono/metadata/marshal.c index dddd049d4b0..792a1dcf37e 100644 --- a/mono/metadata/marshal.c +++ b/mono/metadata/marshal.c @@ -72,11 +72,12 @@ typedef struct _MonoRemotingMethods MonoRemotingMethods; /* * This mutex protects the various marshalling related caches in MonoImage * and a few other data structures static to this file. - * Note that when this lock is held it is not possible to take other runtime - * locks like the loader lock. + * + * The marshal lock is a non-recursive complex lock that sits below the domain lock in the + * runtime locking latice. Which means it can take simple locks suck as the image lock. */ -#define mono_marshal_lock() EnterCriticalSection (&marshal_mutex) -#define mono_marshal_unlock() LeaveCriticalSection (&marshal_mutex) +#define mono_marshal_lock() mono_locks_acquire (&marshal_mutex, MarshalLock) +#define mono_marshal_unlock() mono_locks_release (&marshal_mutex, MarshalLock) static CRITICAL_SECTION marshal_mutex; static gboolean marshal_mutex_initialized; @@ -4296,7 +4297,11 @@ mono_marshal_get_delegate_invoke (MonoMethod *method, MonoDelegate *del) invoke_sig = static_sig; if (static_method_with_first_arg_bound) - name = mono_signature_to_name (invoke_sig, "invoke_bound_"); + name = mono_signature_to_name (invoke_sig, "invoke_bound"); + else if (closed_over_null) + name = mono_signature_to_name (invoke_sig, "invoke_closed_over_null"); + else if (callvirt) + name = mono_signature_to_name (invoke_sig, "invoke_callvirt"); else name = mono_signature_to_name (sig, "invoke"); if (ctx) @@ -9655,8 +9660,8 @@ mono_marshal_get_vtfixup_ftnptr (MonoImage *image, guint32 token, guint16 type) sig = mono_method_signature (method); mb = mono_mb_new (method->klass, method->name, MONO_WRAPPER_MANAGED_TO_MANAGED); -#ifndef DISABLE_JIT param_count = sig->param_count + sig->hasthis; +#ifndef DISABLE_JIT for (i = 0; i < param_count; i++) mono_mb_emit_ldarg (mb, i); @@ -11799,7 +11804,9 @@ ves_icall_System_Runtime_InteropServices_Marshal_SizeOf (MonoReflectionType *rty layout = (klass->flags & TYPE_ATTRIBUTE_LAYOUT_MASK); - if (layout == TYPE_ATTRIBUTE_AUTO_LAYOUT) { + if (type->type == MONO_TYPE_PTR || type->type == MONO_TYPE_FNPTR) { + return sizeof (gpointer); + } else if (layout == TYPE_ATTRIBUTE_AUTO_LAYOUT) { gchar *msg; MonoException *exc; @@ -12289,7 +12296,7 @@ mono_marshal_load_type_info (MonoClass* klass) case TYPE_ATTRIBUTE_EXPLICIT_LAYOUT: size = mono_marshal_type_size (field->type, info->fields [j].mspec, &align, TRUE, klass->unicode); - min_align = packing; + min_align = MAX (align, min_align); info->fields [j].offset = field->offset - sizeof (MonoObject); info->native_size = MAX (info->native_size, info->fields [j].offset + size); break; @@ -12303,9 +12310,12 @@ mono_marshal_load_type_info (MonoClass* klass) * If the provided Size is equal or larger than the calculated size, and there * was no Pack attribute, we set min_align to 1 to avoid native_size being increased */ - if (layout == TYPE_ATTRIBUTE_EXPLICIT_LAYOUT) + if (layout == TYPE_ATTRIBUTE_EXPLICIT_LAYOUT) { if (native_size && native_size == info->native_size && klass->packing_size == 0) min_align = 1; + else + min_align = MIN (min_align, packing); + } } if (info->native_size & (min_align - 1)) {