* dirent.c: Fix `struct dirent' overflow on Solaris. See #82678.

[mono.git] / support / dirent.c

diff --git a/support/dirent.c b/support/dirent.c
index 6fb49902d0beef6f1284d781c9e68523fd3cbd33..50d2f64a8443bd31700edf70fa912262969549ef 100644 (file)
--- a/support/dirent.c
+++ b/support/dirent.c
@@ -11,30 +11,22 @@
 #include <errno.h>
 #include <string.h>
 #include <stdlib.h>
+#include <limits.h>
 #include <unistd.h>
 
+#include "map.h"
 #include "mph.h"
 
 G_BEGIN_DECLS
 
-struct Mono_Posix_Syscall__Dirent {
-       /* ino_t  */ mph_ino_t      d_ino;
-       /* off_t  */ mph_off_t      d_off;
-       /* ushort */ unsigned short d_reclen;
-       /* byte   */ unsigned char  d_type;
-       /* string */ char          *d_name;
-};
-
 gint32
 Mono_Posix_Syscall_seekdir (void *dir, mph_off_t offset)
 {
        mph_return_if_off_t_overflow (offset);
 
-       errno = 0;
-
        seekdir ((DIR*) dir, (off_t) offset);
 
-       return errno != 0;
+       return 0;
 }
 
 mph_off_t
@@ -86,24 +78,26 @@ Mono_Posix_Syscall_readdir (void *dirp, struct Mono_Posix_Syscall__Dirent *entry
 gint32
 Mono_Posix_Syscall_readdir_r (void *dirp, struct Mono_Posix_Syscall__Dirent *entry, void **result)
 {
-       struct dirent _entry;
+       struct dirent *_entry = malloc(sizeof(struct dirent) + 
+                       MAX(PATH_MAX, NAME_MAX) + 1);
        int r;
 
-       r = readdir_r (dirp, &_entry, (struct dirent**) result);
+       r = readdir_r (dirp, _entry, (struct dirent**) result);
 
-       if (r == 0 && result != NULL) {
-               copy_dirent (entry, &_entry);
+       if (r == 0 && *result != NULL) {
+               copy_dirent (entry, _entry);
        }
 
+       free (_entry);
+
        return r;
 }
 
 int
 Mono_Posix_Syscall_rewinddir (void* dir)
 {
-       errno = 0;
        rewinddir (dir);
-       return errno == 0 ? 0 : -1;
+       return 0;
 }
 
 G_END_DECLS