* src/vm/jit/stack.h (COPY): Prevent setting varkind to STACKVAR for stackslots copie...
[cacao.git] / src / vm / jit / stack.c
index 7d93c2f43c1244da93fef294796fed0535e24778..2b22f3be2dbc86a9f2b2ddc6e2af7ac08ba46ae8 100644 (file)
@@ -1,9 +1,9 @@
 /* src/vm/jit/stack.c - stack analysis
 
-   Copyright (C) 1996-2005 R. Grafl, A. Krall, C. Kruegel, C. Oates,
-   R. Obermaisser, M. Platter, M. Probst, S. Ring, E. Steiner,
-   C. Thalinger, D. Thuernbeck, P. Tomsich, C. Ullrich, J. Wenninger,
-   Institut f. Computersprachen - TU Wien
+   Copyright (C) 1996-2005, 2006 R. Grafl, A. Krall, C. Kruegel,
+   C. Oates, R. Obermaisser, M. Platter, M. Probst, S. Ring,
+   E. Steiner, C. Thalinger, D. Thuernbeck, P. Tomsich, C. Ullrich,
+   J. Wenninger, Institut f. Computersprachen - TU Wien
 
    This file is part of CACAO.
 
 
    You should have received a copy of the GNU General Public License
    along with this program; if not, write to the Free Software
-   Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
-   02111-1307, USA.
+   Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+   02110-1301, USA.
 
-   Contact: cacao@complang.tuwien.ac.at
+   Contact: cacao@cacaojvm.org
 
    Authors: Andreas Krall
 
    Changes: Edwin Steiner
             Christian Thalinger
-           Christian Ullrich
+            Christian Ullrich
 
-   $Id: stack.c 3995 2005-12-22 14:00:44Z twisti $
+   $Id: stack.c 4524 2006-02-16 19:39:36Z christian $
 
 */
 
 #include "vm/resolve.h"
 #include "vm/statistics.h"
 #include "vm/stringlocal.h"
-#include "vm/jit/codegen.inc.h"
+#include "vm/jit/codegen-common.h"
 #include "vm/jit/disass.h"
 #include "vm/jit/jit.h"
 #include "vm/jit/reg.h"
 #include "vm/jit/stack.h"
-#include "vm/jit/lsra.h"
+#include "vm/jit/allocator/lsra.h"
 
 
 /* global variables ***********************************************************/
@@ -127,7 +127,7 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
        stackptr      curstack;
        stackptr      new;
        stackptr      copy;
-       int           opcode, i, len, loops;
+       int           opcode, i, j, len, loops;
        int           superblockend, repeat, deadcode;
        instruction  *iptr;
        basicblock   *bptr;
@@ -135,6 +135,12 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
        s4           *s4ptr;
        void        **tptr;
        s4           *argren;
+       s4           *last_store;/* instruction index of last XSTORE */
+                                /* [ local_index * 5 + type ] */
+       s4            last_pei;  /* instruction index of last possible exception */
+                                /* used for conflict resolution for copy        */
+                             /* elimination (XLOAD, IINC, XSTORE) */
+       s4            last_dupx;
 
        builtintable_entry *bte;
        unresolved_method  *um;
@@ -147,6 +153,8 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
        argren = DMNEW(s4, cd->maxlocals);   /* table for argument renaming       */
        for (i = 0; i < cd->maxlocals; i++)
                argren[i] = i;
+
+       last_store = DMNEW(s4 , cd->maxlocals * 5);
        
        new = m->stack;
        loops = 0;
@@ -276,6 +284,14 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
                                iptr = bptr->iinstr;
                                b_index = bptr - m->basicblocks;
 
+                               last_pei = -1;
+                               last_dupx = -1;
+                               for( i = 0; i < cd->maxlocals; i++)
+                                       for( j = 0; j < 5; j++)
+                                               last_store[5 * i + j] = -1;
+
+                               bptr->stack = new;
+
                                while (--len >= 0)  {
                                        opcode = iptr->opc;
 
@@ -1099,6 +1115,8 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
                                                                count_store_depth[i]++;
                                                }
 #endif
+                                               last_store[5 * iptr->op1 + TYPE_INT] = bptr->icount - len - 1;
+
                                                copy = curstack;
                                                i = stackdepth - 1;
                                                while (copy) {
@@ -1110,12 +1128,6 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
                                                        i--;
                                                        copy = copy->prev;
                                                }
-
-                                               /* allocate a dummy stack slot to keep ISTORE from */
-                                               /* marking its input stack as a LOCALVAR, since we */
-                                               /* change the value of the local variable here.    */
-                                               NEWSTACK0(TYPE_INT);
-                                               POP(TYPE_INT);
                                                
                                                SETDST;
                                                break;
@@ -1150,6 +1162,7 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
                                                        count_store_depth[i]++;
                                        }
 #endif
+                                       /* check for conflicts as described in Figure 5.2 */
                                        copy = curstack->prev;
                                        i = stackdepth - 2;
                                        while (copy) {
@@ -1161,10 +1174,107 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
                                                i--;
                                                copy = copy->prev;
                                        }
-                                       if ((new - curstack) == 1) {
-                                               curstack->varkind = LOCALVAR;
-                                               curstack->varnum = iptr->op1;
-                                       };
+
+                                       /* do not change instack Stackslots */
+                                       /* it won't improve performance if we copy the interface */
+                                       /* at the BB begin or here, and lsra relies that no      */
+                                       /* instack stackslot is marked LOCALVAR */
+                                       if (curstack->varkind == STACKVAR)
+                                               goto _possible_conflict;
+
+                                       /* check for a DUPX,SWAP while the lifetime of curstack */
+                                       /* and as creator curstack */
+                                       if (last_dupx != -1) { 
+                                               /* we have to look at the dst stack of DUPX */
+                                               /* == src Stack of PEI */
+                                               copy = bptr->iinstr[last_dupx].dst;
+                                               /*
+                                               if (last_pei == 0)
+                                                       copy = bptr->instack;
+                                               else
+                                                       copy = bptr->iinstr[last_pei-1].dst;
+                                               */
+                                               if ((copy != NULL) && (curstack <= copy)) {
+                                                       /* curstack alive at or created by DUPX */
+
+                                                       /* TODO:.... */
+                                                       /* now look, if there is a LOCALVAR at anyone of */
+                                                       /* the src stacklots used by DUPX */
+
+                                                       goto _possible_conflict;
+                                               }
+                                       }
+
+                                       /* check for a PEI while the lifetime of curstack */
+                                       if (last_pei != -1) { 
+                                               /* && there are exception handler in this method */
+                                               /* when this is checked prevent ARGVAR from      */
+                                               /* overwriting LOCALVAR!!! */
+
+                                               /* we have to look at the stack _before_ the PEI! */
+                                               /* == src Stack of PEI */
+                                               if (last_pei == 0)
+                                                       copy = bptr->instack;
+                                               else
+                                                       copy = bptr->iinstr[last_pei-1].dst;
+                                               if ((copy != NULL) && (curstack <= copy)) {
+                                                       /* curstack alive at PEI */
+                                                       goto _possible_conflict;
+                                               }
+                                       }
+                                       
+                                       /* check if there is a possible conflicting XSTORE */
+                                       if (last_store[5 * iptr->op1 + opcode - ICMD_ISTORE] != -1) {
+                                               /* we have to look at the stack _before_ the XSTORE! */
+                                               /* == src Stack of XSTORE */
+                                               if (last_store[5 * iptr->op1 + opcode - ICMD_ISTORE] == 0)
+                                                       copy = bptr->instack;
+                                               else
+                                                       copy = bptr->iinstr[last_store[5 * iptr->op1 + opcode - ICMD_ISTORE] - 1].dst;
+                                               if ((copy != NULL) && (curstack <= copy)) {
+                                                       /* curstack alive at Last Store */
+                                                       goto _possible_conflict;
+                                               }
+                                       }
+
+                                       /* check if there is a conflict with a XLOAD */
+                                       /* this is done indirectly by looking if a Stackslot is */
+                                       /* marked LOCALVAR and is live while curstack is live   */
+                                       /* see figure 5.3 */
+
+                                       /* First check "above" stackslots of the instack */
+                                       copy = curstack + 1;
+                                       for(;(copy <= bptr->instack); copy++)
+                                               if ((copy->varkind == LOCALVAR) && (copy->varnum == iptr->op1)) {
+                                                       goto _possible_conflict;
+                                               }
+                                       
+                                       /* "intra" Basic Block Stackslots are allocated above    */
+                                       /* bptr->stack (see doc/stack.txt), so if curstack + 1   */
+                                       /* is an instack, copy could point now to the stackslots */
+                                       /* of an inbetween analysed Basic Block */
+                                       if (copy < bptr->stack)
+                                               copy = bptr->stack;
+                                       while (copy < new) {
+                                               if ((copy->varkind == LOCALVAR) && (copy->varnum == iptr->op1)) {
+                                                       goto _possible_conflict;
+                                               }
+                                               copy++;
+                                       }
+                                       /* no conflict - mark the Stackslot as LOCALVAR */
+                                       curstack->varkind = LOCALVAR;
+                                       curstack->varnum = iptr->op1;
+                                       
+                                       goto _local_join;
+                               _possible_conflict:
+                                       if ((curstack->varkind == LOCALVAR) 
+                                               && (curstack->varnum == iptr->op1)) {
+                                               curstack->varkind = TEMPVAR;
+                                               curstack->varnum = stackdepth-1;
+                                       }
+                               _local_join:
+                                       last_store[5 * iptr->op1 + opcode - ICMD_ISTORE] = bptr->icount - len - 1;
+
                                        STORE(opcode - ICMD_ISTORE);
                                        break;
 
@@ -1233,7 +1343,13 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
                                        case ICMD_FRETURN:
                                        case ICMD_DRETURN:
                                        case ICMD_ARETURN:
-                                               md_return_alloc(m, rd, opcode - ICMD_IRETURN, curstack);
+#if defined(ENABLE_JIT)
+# if defined(ENABLE_INTRP)
+                                               if (!opt_intrp)
+# endif
+                                                       md_return_alloc(m, rd, opcode - ICMD_IRETURN,
+                                                                                       curstack);
+#endif
                                                COUNT(count_pcmd_return);
                                                OP1_0(opcode - ICMD_IRETURN);
                                                superblockend = true;
@@ -1502,11 +1618,13 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
                                                        }
                                                }
 #endif
+                                               last_dupx = bptr->icount - len - 1;
                                                COUNT(count_dup_instruction);
                                                DUP;
                                                break;
 
                                        case ICMD_DUP2:
+                                               last_dupx = bptr->icount - len - 1;
                                                REQUIRE_1;
                                                if (IS_2_WORD_TYPE(curstack->type)) {
                                                        /* ..., cat2 */
@@ -1547,10 +1665,12 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
                                                        }
                                                }
 #endif
+                                               last_dupx = bptr->icount - len - 1;
                                                DUP_X1;
                                                break;
 
                                        case ICMD_DUP2_X1:
+                                               last_dupx = bptr->icount - len - 1;
                                                REQUIRE_2;
                                                if (IS_2_WORD_TYPE(curstack->type)) {
                                                        /* ..., ????, cat2 */
@@ -1584,6 +1704,7 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
                                                /* pop 3 push 4 dup */
                                                
                                        case ICMD_DUP_X2:
+                                               last_dupx = bptr->icount - len - 1;
                                                REQUIRE_2;
                                                if (IS_2_WORD_TYPE(curstack->prev->type)) {
                                                        /* ..., cat2, ???? */
@@ -1615,6 +1736,7 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
                                                break;
 
                                        case ICMD_DUP2_X2:
+                                               last_dupx = bptr->icount - len - 1;
                                                REQUIRE_2;
                                                if (IS_2_WORD_TYPE(curstack->type)) {
                                                        /* ..., ????, cat2 */
@@ -1674,6 +1796,7 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
                                                /* pop 2 push 2 swap */
                                                
                                        case ICMD_SWAP:
+                                               last_dupx = bptr->icount - len - 1;
 #ifdef TYPECHECK_STACK_COMPCAT
                                                if (opt_verify) {
                                                        REQUIRE_2;
@@ -2002,6 +2125,9 @@ methodinfo *analyse_stack(methodinfo *m, codegendata *cd, registerdata *rd)
 /*                              {COUNT(count_check_null);} */   
 
                                        _callhandling:
+
+                                               last_pei = bptr->icount - len - 1;
+
                                                i = md->paramcount;
 
                                                if (md->memuse > rd->memuse)
@@ -2298,16 +2424,34 @@ void icmd_print_stack(codegendata *cd, stackptr s)
                                        printf(" F%02d", s->regoff);
                                else {
 #if defined(SUPPORT_COMBINE_INTEGER_REGISTERS)
-                                       if (IS_2_WORD_TYPE(s->type))
-                                               printf(" %3s/%3s", regs[GET_LOW_REG(s->regoff)],
-                            regs[GET_HIGH_REG(s->regoff)]);
-                                       else
-#endif
-#if defined(ENABLE_INTRP)
-                                               printf(" %3d", s->regoff);
+                                       if (IS_2_WORD_TYPE(s->type)) {
+# if defined(ENABLE_JIT)
+#  if defined(ENABLE_INTRP)
+                                               if (opt_intrp)
+                                                       printf(" %3d/%3d", GET_LOW_REG(s->regoff),
+                                                                  GET_HIGH_REG(s->regoff));
+                                               else
+#  endif
+                                                       printf(" %3s/%3s", regs[GET_LOW_REG(s->regoff)],
+                                                                  regs[GET_HIGH_REG(s->regoff)]);
+# else
+                                               printf(" %3d/%3d", GET_LOW_REG(s->regoff),
+                                                          GET_HIGH_REG(s->regoff));
+# endif
+                                       } else 
+#endif /* defined(SUPPORT_COMBINE_INTEGER_REGISTERS) */
+                                               {
+#if defined(ENABLE_JIT)
+# if defined(ENABLE_INTRP)
+                                                       if (opt_intrp)
+                                                               printf(" %3d", s->regoff);
+                                                       else
+# endif
+                                                               printf(" %3s", regs[s->regoff]);
 #else
-                                               printf(" %3s", regs[s->regoff]);
+                                                       printf(" %3d", s->regoff);
 #endif
+                                               }
                                }
                                break;
                        case STACKVAR:
@@ -2323,12 +2467,6 @@ void icmd_print_stack(codegendata *cd, stackptr s)
                                        printf("  V0");
                                } else /* "normal" Argvar */
                                        printf(" A%02d", s->varnum);
-#ifdef INVOKE_NEW_DEBUG
-                               if (s->flags & INMEMORY)
-                                       printf("(M%i)", s->regoff);
-                               else
-                                       printf("(R%i)", s->regoff);
-#endif
                                break;
                        default:
                                printf(" !%02d", j);
@@ -2346,16 +2484,34 @@ void icmd_print_stack(codegendata *cd, stackptr s)
                                        printf(" f%02d", s->regoff);
                                else {
 #if defined(SUPPORT_COMBINE_INTEGER_REGISTERS)
-                                       if (IS_2_WORD_TYPE(s->type))
-                                               printf(" %3s/%3s", regs[GET_LOW_REG(s->regoff)],
-                            regs[GET_HIGH_REG(s->regoff)]);
-                                       else
-#endif
-#if defined(ENABLE_INTRP)
-                                               printf(" %3d", s->regoff);
+                                       if (IS_2_WORD_TYPE(s->type)) {
+# if defined(ENABLE_JIT)
+#  if defined(ENABLE_INTRP)
+                                               if (opt_intrp)
+                                                       printf(" %3d/%3d", GET_LOW_REG(s->regoff),
+                                                                  GET_HIGH_REG(s->regoff));
+                                               else
+#  endif
+                                                       printf(" %3s/%3s", regs[GET_LOW_REG(s->regoff)],
+                                                                  regs[GET_HIGH_REG(s->regoff)]);
+# else
+                                               printf(" %3d/%3d", GET_LOW_REG(s->regoff),
+                                                          GET_HIGH_REG(s->regoff));
+# endif
+                                       } else
+#endif /* defined(SUPPORT_COMBINE_INTEGER_REGISTERS) */
+                                               {
+#if defined(ENABLE_JIT)
+# if defined(ENABLE_INTRP)
+                                                       if (opt_intrp)
+                                                               printf(" %3d", s->regoff);
+                                                       else
+# endif
+                                                               printf(" %3s", regs[s->regoff]);
 #else
-                                               printf(" %3s", regs[s->regoff]);
+                                                       printf(" %3d", s->regoff);
 #endif
+                                               }
                                }
                                break;
                        case STACKVAR:
@@ -2371,12 +2527,6 @@ void icmd_print_stack(codegendata *cd, stackptr s)
                                        printf("  v0");
                                } else /* "normal" Argvar */
                                printf(" a%02d", s->varnum);
-#ifdef INVOKE_NEW_DEBUG
-                               if (s->flags & INMEMORY)
-                                       printf("(M%i)", s->regoff);
-                               else
-                                       printf("(R%i)", s->regoff);
-#endif
                                break;
                        default:
                                printf(" ?%02d", j);
@@ -2469,12 +2619,12 @@ void show_icmd_method(methodinfo *m, codegendata *cd, registerdata *rd)
 #endif
 
        printf("\n");
-       utf_fprint_classname(stdout, m->class->name);
-       printf(".");
-       utf_fprint(stdout, m->name);
-       utf_fprint(stdout, m->descriptor);
-       printf("\n\nMax locals: %d\n", (int) cd->maxlocals);
-       printf("Max stack:  %d\n", (int) cd->maxstack);
+
+       method_println(m);
+
+       printf("\nBasic blocks: %d\n", m->basicblockcount);
+       printf("Max locals:   %d\n", cd->maxlocals);
+       printf("Max stack:    %d\n", cd->maxstack);
        printf("Line number table length: %d\n", m->linenumbercount);
 
        printf("Exceptions (Number: %d):\n", cd->exceptiontablelength);
@@ -2496,35 +2646,39 @@ void show_icmd_method(methodinfo *m, codegendata *cd, registerdata *rd)
        printf("Local Table:\n");
        for (i = 0; i < cd->maxlocals; i++) {
                printf("   %3d: ", i);
+
+#if defined(ENABLE_JIT)
                for (j = TYPE_INT; j <= TYPE_ADR; j++) {
-#if defined(ENABLE_INTRP)
+# if defined(ENABLE_INTRP)
                        if (!opt_intrp) {
-#endif
+# endif
                                if (rd->locals[i][j].type >= 0) {
                                        printf("   (%s) ", jit_type[j]);
                                        if (rd->locals[i][j].flags & INMEMORY)
                                                printf("m%2d", rd->locals[i][j].regoff);
-#ifdef HAS_ADDRESS_REGISTER_FILE
+# ifdef HAS_ADDRESS_REGISTER_FILE
                                        else if (j == TYPE_ADR)
                                                printf("r%02d", rd->locals[i][j].regoff);
-#endif
+# endif
                                        else if ((j == TYPE_FLT) || (j == TYPE_DBL))
                                                printf("f%02d", rd->locals[i][j].regoff);
                                        else {
-#if defined(SUPPORT_COMBINE_INTEGER_REGISTERS)
+# if defined(SUPPORT_COMBINE_INTEGER_REGISTERS)
                                                if (IS_2_WORD_TYPE(j))
                                                        printf(" %3s/%3s",
                                                                   regs[GET_LOW_REG(rd->locals[i][j].regoff)],
                                                                   regs[GET_HIGH_REG(rd->locals[i][j].regoff)]);
                                                else
-#endif
+# endif
                                                        printf("%3s", regs[rd->locals[i][j].regoff]);
                                        }
                                }
-#if defined(ENABLE_INTRP)
+# if defined(ENABLE_INTRP)
                        }
-#endif
+# endif
                }
+#endif /* defined(ENABLE_JIT) */
+
                printf("\n");
        }
        printf("\n");
@@ -2543,51 +2697,62 @@ void show_icmd_method(methodinfo *m, codegendata *cd, registerdata *rd)
                        (rd->interfaces[i][3].type >= 0) ||
                    (rd->interfaces[i][4].type >= 0)) {
                        printf("   %3d: ", i);
-                       for (j = TYPE_INT; j <= TYPE_ADR; j++)
-                               if (rd->interfaces[i][j].type >= 0) {
-                                       printf("   (%s) ", jit_type[j]);
-                                       if (rd->interfaces[i][j].flags & SAVEDVAR) {
-                                               if (rd->interfaces[i][j].flags & INMEMORY)
-                                                       printf("M%2d", rd->interfaces[i][j].regoff);
+
+#if defined(ENABLE_JIT)
+# if defined(ENABLE_INTRP)
+                       if (!opt_intrp) {
+# endif
+                               for (j = TYPE_INT; j <= TYPE_ADR; j++) {
+                                       if (rd->interfaces[i][j].type >= 0) {
+                                               printf("   (%s) ", jit_type[j]);
+                                               if (rd->interfaces[i][j].flags & SAVEDVAR) {
+                                                       if (rd->interfaces[i][j].flags & INMEMORY)
+                                                               printf("M%2d", rd->interfaces[i][j].regoff);
 #ifdef HAS_ADDRESS_REGISTER_FILE
-                                               else if (j == TYPE_ADR)
-                                                       printf("R%02d", rd->interfaces[i][j].regoff);
+                                                       else if (j == TYPE_ADR)
+                                                               printf("R%02d", rd->interfaces[i][j].regoff);
 #endif
-                                               else if ((j == TYPE_FLT) || (j == TYPE_DBL))
-                                                       printf("F%02d", rd->interfaces[i][j].regoff);
-                                               else {
+                                                       else if ((j == TYPE_FLT) || (j == TYPE_DBL))
+                                                               printf("F%02d", rd->interfaces[i][j].regoff);
+                                                       else {
 #if defined(SUPPORT_COMBINE_INTEGER_REGISTERS)
-                                                       if (IS_2_WORD_TYPE(j))
-                                                               printf(" %3s/%3s",
-                             regs[GET_LOW_REG(rd->interfaces[i][j].regoff)],
-                             regs[GET_HIGH_REG(rd->interfaces[i][j].regoff)]);
-                                                       else
+                                                               if (IS_2_WORD_TYPE(j))
+                                                                       printf(" %3s/%3s",
+                                                                                  regs[GET_LOW_REG(rd->interfaces[i][j].regoff)],
+                                                                                  regs[GET_HIGH_REG(rd->interfaces[i][j].regoff)]);
+                                                               else
 #endif
-                                                               printf("%3s",regs[rd->interfaces[i][j].regoff]);
+                                                                       printf("%3s",regs[rd->interfaces[i][j].regoff]);
+                                                       }
                                                }
-                                       }
-                                       else {
-                                               if (rd->interfaces[i][j].flags & INMEMORY)
-                                                       printf("m%2d", rd->interfaces[i][j].regoff);
+                                               else {
+                                                       if (rd->interfaces[i][j].flags & INMEMORY)
+                                                               printf("m%2d", rd->interfaces[i][j].regoff);
 #ifdef HAS_ADDRESS_REGISTER_FILE
-                                               else if (j == TYPE_ADR)
-                                                       printf("r%02d", rd->interfaces[i][j].regoff);
+                                                       else if (j == TYPE_ADR)
+                                                               printf("r%02d", rd->interfaces[i][j].regoff);
 #endif
-                                               else if ((j == TYPE_FLT) || (j == TYPE_DBL))
-                                                       printf("f%02d", rd->interfaces[i][j].regoff);
-                                               else {
+                                                       else if ((j == TYPE_FLT) || (j == TYPE_DBL))
+                                                               printf("f%02d", rd->interfaces[i][j].regoff);
+                                                       else {
 #if defined(SUPPORT_COMBINE_INTEGER_REGISTERS)
-                                                       if (IS_2_WORD_TYPE(j))
-                                                               printf(" %3s/%3s",
-                             regs[GET_LOW_REG(rd->interfaces[i][j].regoff)],
-                                                        regs[GET_HIGH_REG(rd->interfaces[i][j].regoff)]);
-                                                       else
+                                                               if (IS_2_WORD_TYPE(j))
+                                                                       printf(" %3s/%3s",
+                                                                                  regs[GET_LOW_REG(rd->interfaces[i][j].regoff)],
+                                                                                  regs[GET_HIGH_REG(rd->interfaces[i][j].regoff)]);
+                                                               else
 #endif
-                                                               printf("%3s",regs[rd->interfaces[i][j].regoff]);
+                                                                       printf("%3s",regs[rd->interfaces[i][j].regoff]);
+                                                       }
                                                }
                                        }
                                }
-                       printf("\n");
+                               printf("\n");
+# if defined(ENABLE_INTRP)
+                       }
+# endif
+#endif /* defined(ENABLE_JIT) */
+
                }
        }
        printf("\n");
@@ -2605,7 +2770,7 @@ void show_icmd_method(methodinfo *m, codegendata *cd, registerdata *rd)
                u1ptr = (u1 *) ((ptrint) m->mcode + cd->dseglen);
 
                for (; u1ptr < (u1 *) ((ptrint) m->mcode + cd->dseglen + m->basicblocks[0].mpc);)
-                       u1ptr = disassinstr(u1ptr);
+                       DISASSINSTR(u1ptr);
 
                printf("\n");
        }
@@ -2628,7 +2793,7 @@ void show_icmd_method(methodinfo *m, codegendata *cd, registerdata *rd)
                                                m->basicblocks[m->basicblockcount].mpc);
 
                for (; (ptrint) u1ptr < ((ptrint) m->mcode + m->mcodelength);)
-                       u1ptr = disassinstr(u1ptr);
+                       DISASSINSTR(u1ptr);
 
                printf("\n");
        }
@@ -2656,23 +2821,44 @@ void show_icmd_block(methodinfo *m, codegendata *cd, basicblock *bptr)
 
        if (bptr->flags != BBDELETED) {
                deadcode = bptr->flags <= BBREACHED;
+
                printf("[");
+
                if (deadcode)
                        for (j = cd->maxstack; j > 0; j--)
                                printf(" ?  ");
                else
                        icmd_print_stack(cd, bptr->instack);
-               printf("] L%03d(%d - %d) flags=%d:\n", bptr->debug_nr, bptr->icount, bptr->pre_count,bptr->flags);
+
+               printf("] L%03d(flags: %d, next: %d, type: ",
+                          bptr->debug_nr, bptr->flags, (bptr->next) ? (bptr->next->debug_nr) : -1);
+
+               switch (bptr->type) {
+               case BBTYPE_STD:
+                       printf("STD");
+                       break;
+               case BBTYPE_EXH:
+                       printf("EXH");
+                       break;
+               case BBTYPE_SBR:
+                       printf("SBR");
+                       break;
+               }
+
+               printf(", instruction count: %d, predecessors: %d):\n",
+                          bptr->icount, bptr->pre_count);
+
                iptr = bptr->iinstr;
 
                for (i = 0; i < bptr->icount; i++, iptr++) {
                        printf("[");
-                       if (deadcode) {
+
+                       if (deadcode)
                                for (j = cd->maxstack; j > 0; j--)
                                        printf(" ?  ");
-                       }
                        else
                                icmd_print_stack(cd, iptr->dst);
+
                        printf("] %5d (line: %5d)  ", i, iptr->line);
 
                        show_icmd(iptr, deadcode);
@@ -2685,11 +2871,11 @@ void show_icmd_block(methodinfo *m, codegendata *cd, basicblock *bptr)
 
                        if (bptr->next != NULL) {
                                for (; u1ptr < (u1 *) ((ptrint) m->mcode + cd->dseglen + bptr->next->mpc);)
-                                       u1ptr = disassinstr(u1ptr);
+                                       DISASSINSTR(u1ptr);
 
                        } else {
                                for (; u1ptr < (u1 *) ((ptrint) m->mcode + m->mcodelength);)
-                                       u1ptr = disassinstr(u1ptr); 
+                                       DISASSINSTR(u1ptr); 
                        }
                        printf("\n");
                }
@@ -2730,7 +2916,6 @@ void show_icmd(instruction *iptr, bool deadcode)
        case ICMD_LSHRCONST:
        case ICMD_LUSHRCONST:
        case ICMD_ICONST:
-       case ICMD_ELSE_ICONST:
        case ICMD_IASTORECONST:
        case ICMD_BASTORECONST:
        case ICMD_CASTORECONST:
@@ -2744,7 +2929,11 @@ void show_icmd(instruction *iptr, bool deadcode)
        case ICMD_IFGE_ICONST:
        case ICMD_IFGT_ICONST:
        case ICMD_IFLE_ICONST:
-               printf("(%d) %d", iptr[1].op1, iptr->val.i);
+               printf(" %d, %d (0x%08x)", iptr[1].op1, iptr->val.i, iptr->val.i);
+               break;
+
+       case ICMD_ELSE_ICONST:
+               printf("    %d (0x%08x)", iptr->val.i, iptr->val.i);
                break;
 
        case ICMD_LADDCONST:
@@ -2818,7 +3007,7 @@ void show_icmd(instruction *iptr, bool deadcode)
        case ICMD_PUTSTATIC:
        case ICMD_GETSTATIC:
                if (iptr->val.a) {
-                       if (!(((fieldinfo *) iptr->val.a)->class->state & CLASS_INITIALIZED))
+                       if (!CLASS_IS_OR_ALMOST_INITIALIZED(((fieldinfo *) iptr->val.a)->class))
                                printf(" (NOT INITIALIZED) ");
                        else
                                printf(" ");
@@ -2955,12 +3144,12 @@ void show_icmd(instruction *iptr, bool deadcode)
                break;
 
        case ICMD_MULTIANEWARRAY:
-               if (iptr->target) {
-                       printf(" (NOT RESOLVED) %d ",iptr->op1);
-                       utf_display(((constant_classref *) iptr->val.a)->name);
+               if (iptr->val.a == NULL) {
+                       printf(" (NOT RESOLVED) %d ", iptr->op1);
+                       utf_display(((constant_classref *) iptr->target)->name);
                } else {
                        printf(" %d ",iptr->op1);
-                       utf_display_classname(((vftbl_t *) iptr->val.a)->class->name);
+                       utf_display_classname(((classinfo *) iptr->val.a)->name);
                }
                break;
 
@@ -2981,15 +3170,12 @@ void show_icmd(instruction *iptr, bool deadcode)
                break;
 
        case ICMD_INLINE_START:
+       case ICMD_INLINE_END:
                printf(" ");
                utf_display_classname(iptr->method->class->name);
                printf(".");
                utf_display_classname(iptr->method->name);
                utf_display_classname(iptr->method->descriptor);
-               printf(", depth=%i", iptr->op1);
-               break;
-
-       case ICMD_INLINE_END:
                break;
 
        case ICMD_BUILTIN:
@@ -3019,7 +3205,7 @@ void show_icmd(instruction *iptr, bool deadcode)
                if (deadcode || !iptr->target)
                        printf(" %d (0x%08x) op1=%d", iptr->val.i, iptr->val.i, iptr->op1);
                else
-                       printf(" %d (0x%08x) L%03d", iptr->val.i, iptr->val.i, ((basicblock *) iptr->target)->debug_nr);
+                       printf(" %d (0x%08x) L%03d (%p)", iptr->val.i, iptr->val.i, ((basicblock *) iptr->target)->debug_nr,iptr->target);
                break;
 
        case ICMD_IF_LEQ:
@@ -3060,10 +3246,11 @@ void show_icmd(instruction *iptr, bool deadcode)
        case ICMD_IF_LCMPLE:
        case ICMD_IF_ACMPEQ:
        case ICMD_IF_ACMPNE:
+       case ICMD_INLINE_GOTO:
                if (deadcode || !iptr->target)
                        printf(" op1=%d", iptr->op1);
                else
-                       printf(" L%03d", ((basicblock *) iptr->target)->debug_nr);
+                       printf(" L%03d (%p)", ((basicblock *) iptr->target)->debug_nr,iptr->target);
                break;
 
        case ICMD_TABLESWITCH:
@@ -3140,4 +3327,5 @@ void show_icmd(instruction *iptr, bool deadcode)
  * c-basic-offset: 4
  * tab-width: 4
  * End:
+ * vim:noexpandtab:sw=4:ts=4:
  */