* renamed CACAO_TYPECHECK to ENABLE_VERIFIER
[cacao.git] / src / vm / builtin.c
index 7741f2371391ec7121d32d7cda286020a28473c2..7788d2056164c1796853e17df68260d1003337b1 100644 (file)
    calls instead of machine instructions, using the C calling
    convention.
 
-   $Id: builtin.c 2888 2005-07-03 16:38:33Z christian $
+   $Id: builtin.c 3801 2005-11-26 19:15:45Z twisti $
 
 */
 
 
 #include <assert.h>
-#include <math.h>
 #include <stdlib.h>
 #include <string.h>
 
 #include "config.h"
+#include "vm/types.h"
+
 #include "arch.h"
 #include "md-abi.h"
-#include "types.h"
+
+#include "fdlibm/fdlibm.h"
 
 #include "mm/boehm.h"
 #include "mm/memory.h"
 #include "vm/jit/patcher.h"
 
 
-#undef DEBUG /*define DEBUG 1*/
-
-THREADSPECIFIC methodinfo* _threadrootmethod = NULL;
-THREADSPECIFIC void *_thread_nativestackframeinfo = NULL;
-
-
 /* include builtin tables *****************************************************/
 
 #include "vm/builtintable.inc"
@@ -263,35 +259,6 @@ bool builtin_init(void)
 }
 
 
-/* builtintable_entry_debug_dump ***********************************************
-
-   Prints a builtintable_entry in human-readable form.
-
-*******************************************************************************/
-
-void builtintable_entry_debug_dump(FILE *file, builtintable_entry *bte)
-{
-       char *name;
-       char *desc;
-       
-       if (!bte) {
-               fprintf(file,"(builtintable_entry *)NULL");
-               return;
-       }
-
-       name = bte->name;
-       if (!name)
-               name = "<name=NULL>";
-       desc = (bte->md) ? "parsed " : bte->descriptor;
-       if (!desc)
-               desc = "<desc=NULL>";
-       fprintf(file,"BUILTIN(%d,%p,%s %s",
-                       bte->opcode,(void*)bte->fp,name,desc);
-       descriptor_debug_print_methoddesc(file,bte->md);
-       fputc(')',file);
-}
-
-
 /* builtintable_get_internal ***************************************************
 
    Finds an entry in the builtintable for internal functions and
@@ -371,14 +338,16 @@ s4 builtin_isanysubclass(classinfo *sub, classinfo *super)
        if (sub == super)
                return 1;
 
-       if (super->flags & ACC_INTERFACE)
-               return (sub->vftbl->interfacetablelength > super->index) &&
+       if (super->flags & ACC_INTERFACE) {
+               res = (sub->vftbl->interfacetablelength > super->index) &&
                        (sub->vftbl->interfacetable[-super->index] != NULL);
 
-       asm_getclassvalues_atomic(super->vftbl, sub->vftbl, &classvalues);
+       } else {
+               asm_getclassvalues_atomic(super->vftbl, sub->vftbl, &classvalues);
 
-       res = (u4) (classvalues.sub_baseval - classvalues.super_baseval) <=
-               (u4) classvalues.super_diffval;
+               res = (u4) (classvalues.sub_baseval - classvalues.super_baseval) <=
+                       (u4) classvalues.super_diffval;
+       }
 
        return res;
 }
@@ -395,13 +364,14 @@ s4 builtin_isanysubclass_vftbl(vftbl_t *sub, vftbl_t *super)
 
        asm_getclassvalues_atomic(super, sub, &classvalues);
 
-       if ((base = classvalues.super_baseval) <= 0)
+       if ((base = classvalues.super_baseval) <= 0) {
                /* super is an interface */
                res = (sub->interfacetablelength > -base) &&
                        (sub->interfacetable[base] != NULL);
-       else
+       } else {
            res = (u4) (classvalues.sub_baseval - classvalues.super_baseval)
                        <= (u4) classvalues.super_diffval;
+       }
 
        return res;
 }
@@ -417,12 +387,8 @@ s4 builtin_isanysubclass_vftbl(vftbl_t *sub, vftbl_t *super)
                         
 *****************************************************************************/
 
-/* XXX should use vftbl */
 s4 builtin_instanceof(java_objectheader *obj, classinfo *class)
 {
-#ifdef DEBUG
-       log_text ("builtin_instanceof called");
-#endif 
        if (!obj)
                return 0;
 
@@ -438,26 +404,14 @@ s4 builtin_instanceof(java_objectheader *obj, classinfo *class)
                          
 ****************************************************************************/
 
-/* XXX should use vftbl */
 s4 builtin_checkcast(java_objectheader *obj, classinfo *class)
 {
-#ifdef DEBUG
-       log_text("builtin_checkcast called");
-#endif
-
        if (obj == NULL)
                return 1;
+
        if (builtin_isanysubclass(obj->vftbl->class, class))
                return 1;
 
-#if DEBUG
-       printf("#### checkcast failed ");
-       utf_display(obj->vftbl->class->name);
-       printf(" -> ");
-       utf_display(class->name);
-       printf("\n");
-#endif
-
        return 0;
 }
 
@@ -471,7 +425,8 @@ s4 builtin_checkcast(java_objectheader *obj, classinfo *class)
                        
 *******************************************************************************/
 
-static s4 builtin_descriptorscompatible(arraydescriptor *desc, arraydescriptor *target)
+static s4 builtin_descriptorscompatible(arraydescriptor *desc,
+                                                                               arraydescriptor *target)
 {
        if (desc == target)
                return 1;
@@ -485,14 +440,24 @@ static s4 builtin_descriptorscompatible(arraydescriptor *desc, arraydescriptor *
        /* {both arrays are arrays of references} */
 
        if (desc->dimension == target->dimension) {
-               /* an array which contains elements of interface types is allowed to be casted to Object (JOWENN)*/
-               if ( (desc->elementvftbl->baseval<0) && (target->elementvftbl->baseval==1) ) return 1;
-               return builtin_isanysubclass_vftbl(desc->elementvftbl,target->elementvftbl);
+               /* an array which contains elements of interface types is
+           allowed to be casted to Object (JOWENN)*/
+
+               if ((desc->elementvftbl->baseval < 0) &&
+                       (target->elementvftbl->baseval == 1))
+                       return 1;
+
+               return builtin_isanysubclass_vftbl(desc->elementvftbl,
+                                                                                  target->elementvftbl);
        }
-       if (desc->dimension < target->dimension) return 0;
+
+       if (desc->dimension < target->dimension)
+               return 0;
 
        /* {desc has higher dimension than target} */
-       return builtin_isanysubclass_vftbl(pseudo_class_Arraystub->vftbl, target->elementvftbl);
+
+       return builtin_isanysubclass_vftbl(pseudo_class_Arraystub->vftbl,
+                                                                          target->elementvftbl);
 }
 
 
@@ -509,7 +474,7 @@ static s4 builtin_descriptorscompatible(arraydescriptor *desc, arraydescriptor *
        
 *******************************************************************************/
 
-s4 builtin_arraycheckcast(java_objectheader *o, vftbl_t *target)
+s4 builtin_arraycheckcast(java_objectheader *o, classinfo *targetclass)
 {
        arraydescriptor *desc;
 
@@ -519,16 +484,16 @@ s4 builtin_arraycheckcast(java_objectheader *o, vftbl_t *target)
        if ((desc = o->vftbl->arraydesc) == NULL)
                return 0;
  
-       return builtin_descriptorscompatible(desc, target->arraydesc);
+       return builtin_descriptorscompatible(desc, targetclass->vftbl->arraydesc);
 }
 
 
-s4 builtin_arrayinstanceof(java_objectheader *obj, vftbl_t *target)
+s4 builtin_arrayinstanceof(java_objectheader *o, classinfo *targetclass)
 {
-       if (!obj)
-               return 1;
+       if (!o)
+               return 0;
 
-       return builtin_arraycheckcast(obj, target);
+       return builtin_arraycheckcast(o, targetclass);
 }
 
 
@@ -607,14 +572,14 @@ java_objectheader *builtin_throw_exception(java_objectheader *xptr)
 
 *******************************************************************************/
 
-s4 builtin_canstore(java_objectarray *a, java_objectheader *o)
+s4 builtin_canstore(java_objectarray *oa, java_objectheader *o)
 {
        arraydescriptor *desc;
        arraydescriptor *valuedesc;
-       vftbl_t *componentvftbl;
-       vftbl_t *valuevftbl;
-       int base;
-       castinfo classvalues;
+       vftbl_t         *componentvftbl;
+       vftbl_t         *valuevftbl;
+       s4               base;
+       castinfo         classvalues;
        
        if (!o)
                return 1;
@@ -626,9 +591,9 @@ s4 builtin_canstore(java_objectarray *a, java_objectheader *o)
         *     *) o->vftbl is not an interface vftbl
         */
        
-       desc a->header.objheader.vftbl->arraydesc;
+       desc           = oa->header.objheader.vftbl->arraydesc;
        componentvftbl = desc->componentvftbl;
-       valuevftbl = o->vftbl;
+       valuevftbl     = o->vftbl;
 
        if ((desc->dimension - 1) == 0) {
                s4 res;
@@ -646,8 +611,8 @@ s4 builtin_canstore(java_objectarray *a, java_objectheader *o)
                        return (valuevftbl->interfacetablelength > -base &&
                                        valuevftbl->interfacetable[base] != NULL);
                
-               res = (unsigned) (classvalues.sub_baseval - classvalues.super_baseval)
-                       <= (unsigned) classvalues.super_diffval;
+               res = ((unsigned) (classvalues.sub_baseval - classvalues.super_baseval)
+                          <= (unsigned) classvalues.super_diffval);
 
                return res;
        }
@@ -656,11 +621,13 @@ s4 builtin_canstore(java_objectarray *a, java_objectheader *o)
        /* {componentvftbl->arraydesc != NULL} */
 
        /* check if o is an array */
+
        if ((valuedesc = valuevftbl->arraydesc) == NULL)
                return 0;
+
        /* {o is an array} */
 
-       return builtin_descriptorscompatible(valuedesc,componentvftbl->arraydesc);
+       return builtin_descriptorscompatible(valuedesc, componentvftbl->arraydesc);
 }
 
 
@@ -758,9 +725,18 @@ java_objectheader *builtin_new(classinfo *c)
        java_objectheader *o;
 
        /* is the class loaded */
-       /*utf_fprint(stderr,c->name);fprintf(stderr,"\n");*/
+
        assert(c->loaded);
 
+       /* check if we can instantiate this class */
+
+       if (c->flags & ACC_ABSTRACT) {
+               *exceptionptr =
+                       new_exception_utfmessage(string_java_lang_InstantiationError,
+                                                                        c->name);
+               return NULL;
+       }
+
        /* is the class linked */
        if (!c->linked)
                if (!link_class(c))
@@ -779,8 +755,6 @@ java_objectheader *builtin_new(classinfo *c)
        if (!o)
                return NULL;
 
-       MSET(o, 0, u1, c->instancesize);
-
        o->vftbl = c->vftbl;
 
 #if defined(USE_THREADS) && defined(NATIVE_THREADS)
@@ -793,25 +767,23 @@ java_objectheader *builtin_new(classinfo *c)
 
 /* builtin_newarray ************************************************************
 
-   Creates an array with the given vftbl on the heap.
+   Creates an array with the given vftbl on the heap. This function
+   takes as class argument an array class.
 
    Return value: pointer to the array or NULL if no memory is available
 
-   CAUTION: The given vftbl must be the vftbl of the *array* class,
-   not of the element class.
-
 *******************************************************************************/
 
-java_arrayheader *builtin_newarray(s4 size, vftbl_t *arrayvftbl)
+java_arrayheader *builtin_newarray(s4 size, classinfo *arrayclass)
 {
+       arraydescriptor  *desc;
+       s4                dataoffset;
+       s4                componentsize;
+       s4                actualsize;
        java_arrayheader *a;
-       arraydescriptor *desc;
-       s4 dataoffset;
-       s4 componentsize;
-       s4 actualsize;
 
-       desc = arrayvftbl->arraydesc;
-       dataoffset = desc->dataoffset;
+       desc          = arrayclass->vftbl->arraydesc;
+       dataoffset    = desc->dataoffset;
        componentsize = desc->componentsize;
 
        if (size < 0) {
@@ -831,9 +803,7 @@ java_arrayheader *builtin_newarray(s4 size, vftbl_t *arrayvftbl)
        if (!a)
                return NULL;
 
-       MSET(a, 0, u1, actualsize);
-
-       a->objheader.vftbl = arrayvftbl;
+       a->objheader.vftbl = arrayclass->vftbl;
 
 #if defined(USE_THREADS) && defined(NATIVE_THREADS)
        initObjectLock(&a->objheader);
@@ -854,159 +824,161 @@ java_arrayheader *builtin_newarray(s4 size, vftbl_t *arrayvftbl)
 
 *******************************************************************************/
 
-java_objectarray *builtin_anewarray(s4 size, classinfo *component)
+java_objectarray *builtin_anewarray(s4 size, classinfo *componentclass)
 {
-       classinfo *c;
+       classinfo *arrayclass;
        
        /* is class loaded */
-       assert(component->loaded);
+
+       assert(componentclass->loaded);
 
        /* is class linked */
-       if (!component->linked)
-               if (!link_class(component))
+
+       if (!componentclass->linked)
+               if (!link_class(componentclass))
                        return NULL;
 
-       c = class_array_of(component, true);
+       arrayclass = class_array_of(componentclass, true);
 
-       if (!c)
+       if (!arrayclass)
                return NULL;
 
-       return (java_objectarray *) builtin_newarray(size, c->vftbl);
+       return (java_objectarray *) builtin_newarray(size, arrayclass);
 }
 
 
-/* builtin_newarray_int ********************************************************
-
-   Creates an array of 32 bit Integers on the heap.
+/* builtin_newarray_boolean ****************************************************
 
+   Creates an array of bytes on the heap. The array is designated as
+   an array of booleans (important for casts)
+       
    Return value: pointer to the array or NULL if no memory is
    available
 
 *******************************************************************************/
 
-java_intarray *builtin_newarray_int(s4 size)
+java_booleanarray *builtin_newarray_boolean(s4 size)
 {
-       return (java_intarray *)
-               builtin_newarray(size, primitivetype_table[ARRAYTYPE_INT].arrayvftbl);
+       return (java_booleanarray *)
+               builtin_newarray(size,
+                                                primitivetype_table[ARRAYTYPE_BOOLEAN].arrayclass);
 }
 
 
-/* builtin_newarray_long *******************************************************
+/* builtin_newarray_byte *******************************************************
 
-   Creates an array of 64 bit Integers on the heap.
+   Creates an array of 8 bit Integers on the heap.
 
    Return value: pointer to the array or NULL if no memory is
    available
 
 *******************************************************************************/
 
-java_longarray *builtin_newarray_long(s4 size)
+java_bytearray *builtin_newarray_byte(s4 size)
 {
-       return (java_longarray *)
-               builtin_newarray(size, primitivetype_table[ARRAYTYPE_LONG].arrayvftbl);
+       return (java_bytearray *)
+               builtin_newarray(size, primitivetype_table[ARRAYTYPE_BYTE].arrayclass);
 }
 
 
-/* builtin_newarray_float ******************************************************
+/* builtin_newarray_char *******************************************************
 
-   Creates an array of 32 bit IEEE floats on the heap.
+   Creates an array of characters on the heap.
 
    Return value: pointer to the array or NULL if no memory is
    available
 
 *******************************************************************************/
 
-java_floatarray *builtin_newarray_float(s4 size)
+java_chararray *builtin_newarray_char(s4 size)
 {
-       return (java_floatarray *)
-               builtin_newarray(size, primitivetype_table[ARRAYTYPE_FLOAT].arrayvftbl);
+       return (java_chararray *)
+               builtin_newarray(size, primitivetype_table[ARRAYTYPE_CHAR].arrayclass);
 }
 
 
-/* builtin_newarray_double *****************************************************
+/* builtin_newarray_short ******************************************************
 
-   Creates an array of 64 bit IEEE floats on the heap.
+   Creates an array of 16 bit Integers on the heap.
 
    Return value: pointer to the array or NULL if no memory is
    available
 
 *******************************************************************************/
 
-java_doublearray *builtin_newarray_double(s4 size)
+java_shortarray *builtin_newarray_short(s4 size)
 {
-       return (java_doublearray *)
-               builtin_newarray(size,
-                                                primitivetype_table[ARRAYTYPE_DOUBLE].arrayvftbl);
+       return (java_shortarray *)
+               builtin_newarray(size, primitivetype_table[ARRAYTYPE_SHORT].arrayclass);
 }
 
 
-/* builtin_newarray_byte *******************************************************
+/* builtin_newarray_int ********************************************************
 
-   Creates an array of 8 bit Integers on the heap.
+   Creates an array of 32 bit Integers on the heap.
 
    Return value: pointer to the array or NULL if no memory is
    available
 
 *******************************************************************************/
 
-java_bytearray *builtin_newarray_byte(s4 size)
+java_intarray *builtin_newarray_int(s4 size)
 {
-       return (java_bytearray *)
-               builtin_newarray(size, primitivetype_table[ARRAYTYPE_BYTE].arrayvftbl);
+       return (java_intarray *)
+               builtin_newarray(size, primitivetype_table[ARRAYTYPE_INT].arrayclass);
 }
 
 
-/* builtin_newarray_char *******************************************************
+/* builtin_newarray_long *******************************************************
 
-   Creates an array of characters on the heap.
+   Creates an array of 64 bit Integers on the heap.
 
    Return value: pointer to the array or NULL if no memory is
    available
 
 *******************************************************************************/
 
-java_chararray *builtin_newarray_char(s4 size)
+java_longarray *builtin_newarray_long(s4 size)
 {
-       return (java_chararray *)
-               builtin_newarray(size, primitivetype_table[ARRAYTYPE_CHAR].arrayvftbl);
+       return (java_longarray *)
+               builtin_newarray(size, primitivetype_table[ARRAYTYPE_LONG].arrayclass);
 }
 
 
-/* builtin_newarray_short ******************************************************
+/* builtin_newarray_float ******************************************************
 
-   Creates an array of 16 bit Integers on the heap.
+   Creates an array of 32 bit IEEE floats on the heap.
 
    Return value: pointer to the array or NULL if no memory is
    available
 
 *******************************************************************************/
 
-java_shortarray *builtin_newarray_short(s4 size)
+java_floatarray *builtin_newarray_float(s4 size)
 {
-       return (java_shortarray *)
-               builtin_newarray(size, primitivetype_table[ARRAYTYPE_SHORT].arrayvftbl);
+       return (java_floatarray *)
+               builtin_newarray(size, primitivetype_table[ARRAYTYPE_FLOAT].arrayclass);
 }
 
 
-/* builtin_newarray_boolean ****************************************************
+/* builtin_newarray_double *****************************************************
+
+   Creates an array of 64 bit IEEE floats on the heap.
 
-   Creates an array of bytes on the heap. The array is designated as
-   an array of booleans (important for casts)
-       
    Return value: pointer to the array or NULL if no memory is
    available
 
 *******************************************************************************/
 
-java_booleanarray *builtin_newarray_boolean(s4 size)
+java_doublearray *builtin_newarray_double(s4 size)
 {
-       return (java_booleanarray *)
+       return (java_doublearray *)
                builtin_newarray(size,
-                                                primitivetype_table[ARRAYTYPE_BOOLEAN].arrayvftbl);
+                                                primitivetype_table[ARRAYTYPE_DOUBLE].arrayclass);
 }
 
 
-/* builtin_multianewarray ******************************************************
+/* builtin_multianewarray_intern ***********************************************
 
    Creates a multi-dimensional array on the heap. The dimensions are
    passed in an array of longs.
@@ -1021,16 +993,19 @@ java_booleanarray *builtin_newarray_boolean(s4 size)
 
 ******************************************************************************/
 
-java_arrayheader *builtin_multianewarray(int n, vftbl_t *arrayvftbl, long *dims)
+static java_arrayheader *builtin_multianewarray_intern(int n,
+                                                                                                          classinfo *arrayclass,
+                                                                                                          long *dims)
 {
-       s4 size, i;
+       s4                size;
        java_arrayheader *a;
-       vftbl_t *componentvftbl;
+       classinfo        *componentclass;
+       s4                i;
 
        /* create this dimension */
 
        size = (s4) dims[0];
-       a = builtin_newarray(size, arrayvftbl);
+       a = builtin_newarray(size, arrayclass);
 
        if (!a)
                return NULL;
@@ -1040,17 +1015,23 @@ java_arrayheader *builtin_multianewarray(int n, vftbl_t *arrayvftbl, long *dims)
        if (!--n)
                return a;
 
-       /* get the vftbl of the components to create */
+       /* get the class of the components to create */
 
-       componentvftbl = arrayvftbl->arraydesc->componentvftbl;
+       componentclass = arrayclass->vftbl->arraydesc->componentvftbl->class;
 
        /* The verifier guarantees that the dimension count is in the range. */
 
        /* create the component arrays */
 
        for (i = 0; i < size; i++) {
-               java_arrayheader *ea = 
-                       builtin_multianewarray(n, componentvftbl, dims + 1);
+               java_arrayheader *ea =
+#if defined(__MIPS__) && (SIZEOF_VOID_P == 4)
+                       /* we save an s4 to a s8 slot, 8-byte aligned */
+
+                       builtin_multianewarray_intern(n, componentclass, dims + 2);
+#else
+                       builtin_multianewarray_intern(n, componentclass, dims + 1);
+#endif
 
                if (!ea)
                        return NULL;
@@ -1062,6 +1043,41 @@ java_arrayheader *builtin_multianewarray(int n, vftbl_t *arrayvftbl, long *dims)
 }
 
 
+/* builtin_multianewarray ******************************************************
+
+   Wrapper for builtin_multianewarray_intern which checks all
+   dimensions before we start allocating.
+
+******************************************************************************/
+
+java_arrayheader *builtin_multianewarray(int n, classinfo *arrayclass,
+                                                                                long *dims)
+{
+       s4 i;
+       s4 size;
+
+       /* check all dimensions before doing anything */
+
+       for (i = 0; i < n; i++) {
+#if defined(__MIPS__) && (SIZEOF_VOID_P == 4)
+               /* we save an s4 to a s8 slot, 8-byte aligned */
+               size = (s4) dims[i * 2];
+#else
+               size = (s4) dims[i];
+#endif
+
+               if (size < 0) {
+                       *exceptionptr = new_negativearraysizeexception();
+                       return NULL;
+               }
+       }
+
+       /* now call the real function */
+
+       return builtin_multianewarray_intern(n, arrayclass, dims);
+}
+
+
 /*****************************************************************************
                                          METHOD LOGGING
 
@@ -1070,26 +1086,23 @@ java_arrayheader *builtin_multianewarray(int n, vftbl_t *arrayvftbl, long *dims)
        
 *****************************************************************************/
 
-u4 methodindent = 0;
+s4 methodindent = 0;
 
 java_objectheader *builtin_trace_exception(java_objectheader *xptr,
                                                                                   methodinfo *m,
                                                                                   void *pos,
-                                                                                  s4 line,
-                                                                                  s4 noindent)
+                                                                                  s4 indent)
 {
        char *logtext;
        s4    logtextlen;
        s4    dumpsize;
 
-       if (!noindent) {
-               if (methodindent)
+       if (opt_verbose || runverbose || opt_verboseexception) {
+               /* when running with verbosecall we remove one indent level */
+
+               if (runverbose && indent)
                        methodindent--;
-               else
-                       log_text("WARNING: unmatched methodindent--");
-       }
 
-       if (opt_verbose || runverbose || verboseexception) {
                /* calculate message length */
 
                if (xptr) {
@@ -1097,8 +1110,9 @@ java_objectheader *builtin_trace_exception(java_objectheader *xptr,
                                strlen("Exception ") +
                                utf_strlen(xptr->vftbl->class->name);
 
-               } else
+               } else {
                        logtextlen = strlen("Some Throwable");
+               }
 
                logtextlen += strlen(" thrown in ");
 
@@ -1107,6 +1121,7 @@ java_objectheader *builtin_trace_exception(java_objectheader *xptr,
                                utf_strlen(m->class->name) +
                                strlen(".") +
                                utf_strlen(m->name) +
+                               utf_strlen(m->descriptor) +
                                strlen("(NOSYNC,NATIVE");
 
 #if SIZEOF_VOID_P == 8
@@ -1148,6 +1163,7 @@ java_objectheader *builtin_trace_exception(java_objectheader *xptr,
                        utf_strcat_classname(logtext, m->class->name);
                        strcat(logtext, ".");
                        utf_strcat(logtext, m->name);
+                       utf_strcat(logtext, m->descriptor);
 
                        if (m->flags & ACC_SYNCHRONIZED)
                                strcat(logtext, "(SYNC");
@@ -1183,7 +1199,7 @@ java_objectheader *builtin_trace_exception(java_objectheader *xptr,
                                else
                                        utf_strcat(logtext, m->class->sourcefile);
 
-                               sprintf(logtext + strlen(logtext), ":%d)", line);
+                               sprintf(logtext + strlen(logtext), ":%d)", 0);
                        }
 
                } else
@@ -1194,6 +1210,13 @@ java_objectheader *builtin_trace_exception(java_objectheader *xptr,
                /* release memory */
 
                dump_release(dumpsize);
+
+               /* print stacktrace for exception */
+
+               if (opt_verboseexception) {
+                       exceptions_print_exception(xptr);
+                       stacktrace_print_trace(xptr);
+               }
        }
 
        return xptr;
@@ -1207,13 +1230,16 @@ java_objectheader *builtin_trace_exception(java_objectheader *xptr,
 *******************************************************************************/
 
 #ifdef TRACE_ARGS_NUM
-void builtin_trace_args(s8 a0, s8 a1, s8 a2, s8 a3,
+void builtin_trace_args(s8 a0, s8 a1,
+#if TRACE_ARGS_NUM >= 4
+                                               s8 a2, s8 a3,
+#endif /* TRACE_ARGS_NUM >= 4 */
 #if TRACE_ARGS_NUM >= 6
                                                s8 a4, s8 a5,
-#endif
+#endif /* TRACE_ARGS_NUM >= 6 */
 #if TRACE_ARGS_NUM == 8
                                                s8 a6, s8 a7,
-#endif
+#endif /* TRACE_ARGS_NUM == 8 */
                                                methodinfo *m)
 {
        methoddesc *md;
@@ -1221,15 +1247,14 @@ void builtin_trace_args(s8 a0, s8 a1, s8 a2, s8 a3,
        s4          logtextlen;
        s4          dumpsize;
        s4          i;
+       s4          pos;
 
        md = m->parseddesc;
 
-       if ( strcmp(m->name->text, "arraycopy")==0 )
-               printf("-----------\n");
        /* calculate message length */
 
        logtextlen =
-               methodindent + strlen("called: ") +
+               6 + methodindent + strlen("called: ") +
                utf_strlen(m->class->name) +
                strlen(".") +
                utf_strlen(m->name) +
@@ -1246,10 +1271,13 @@ void builtin_trace_args(s8 a0, s8 a1, s8 a2, s8 a3,
 
        logtext = DMNEW(char, logtextlen);
 
+       sprintf(logtext,"-%d-",methodindent);
+       pos = strlen(logtext);
+
        for (i = 0; i < methodindent; i++)
-               logtext[i] = '\t';
+               logtext[pos++] = '\t';
 
-       strcpy(logtext + methodindent, "called: ");
+       strcpy(logtext + pos, "called: ");
 
        utf_strcat_classname(logtext, m->class->name);
        strcat(logtext, ".");
@@ -1292,6 +1320,7 @@ void builtin_trace_args(s8 a0, s8 a1, s8 a2, s8 a3,
                                a0, a1);
                break;
 
+#if TRACE_ARGS_NUM >= 4
        case 3:
                sprintf(logtext + strlen(logtext),
                                "0x%llx, 0x%llx, 0x%llx",
@@ -1304,6 +1333,7 @@ void builtin_trace_args(s8 a0, s8 a1, s8 a2, s8 a3,
                sprintf(logtext + strlen(logtext), ", 0x%llx", a3);
 
                break;
+#endif /* TRACE_ARGS_NUM >= 4 */
 
 #if TRACE_ARGS_NUM >= 6
        case 5:
@@ -1340,15 +1370,18 @@ void builtin_trace_args(s8 a0, s8 a1, s8 a2, s8 a3,
 #endif /* TRACE_ARGS_NUM == 8 */
 
        default:
-#if TRACE_ARGS_NUM == 4
+#if TRACE_ARGS_NUM == 2
+               sprintf(logtext + strlen(logtext), "0x%llx, 0x%llx, ...(%d)", a0, a1, md->paramcount - 2);
+
+#elif TRACE_ARGS_NUM == 4
                sprintf(logtext + strlen(logtext),
                                "0x%llx, 0x%llx, 0x%llx, 0x%llx, ...(%d)",
-                               a0, a1, a2, a3, m->paramcount - 4);
+                               a0, a1, a2, a3, md->paramcount - 4);
 
 #elif TRACE_ARGS_NUM == 6
                sprintf(logtext + strlen(logtext),
                                "0x%llx, 0x%llx, 0x%llx, 0x%llx, 0x%llx, 0x%llx, ...(%d)",
-                               a0, a1, a2, a3, a4, a5, m->paramcount - 6);
+                               a0, a1, a2, a3, a4, a5, md->paramcount - 6);
 
 #elif TRACE_ARGS_NUM == 8
                sprintf(logtext + strlen(logtext),"0x%llx, 0x%llx, 0x%llx,"
@@ -1356,7 +1389,7 @@ void builtin_trace_args(s8 a0, s8 a1, s8 a2, s8 a3,
                sprintf(logtext + strlen(logtext)," 0x%llx, 0x%llx, 0x%llx,"
                                , a3, a4, a5);
                sprintf(logtext + strlen(logtext)," 0x%llx, 0x%llx, ...(%d)"
-                               , a6, a7, m->paramcount - 8);
+                               , a6, a7, md->paramcount - 8);
 #endif
                break;
 
@@ -1417,17 +1450,17 @@ void builtin_trace_args(s8 a0, s8 a1, s8 a2, s8 a3,
 #if TRACE_ARGS_NUM == 4
                sprintf(logtext + strlen(logtext),
                                "0x%lx, 0x%lx, 0x%lx, 0x%lx, ...(%d)",
-                               a0, a1, a2, a3, m->paramcount - 4);
+                               a0, a1, a2, a3, md->paramcount - 4);
 
 #elif TRACE_ARGS_NUM == 6
                sprintf(logtext + strlen(logtext),
                                "0x%lx, 0x%lx, 0x%lx, 0x%lx, 0x%lx, 0x%lx, ...(%d)",
-                               a0, a1, a2, a3, a4, a5, m->paramcount - 6);
+                               a0, a1, a2, a3, a4, a5, md->paramcount - 6);
 
 #elif TRACE_ARGS_NUM == 8
                sprintf(logtext + strlen(logtext),
                                "0x%lx, 0x%lx, 0x%lx, 0x%lx, 0x%lx, 0x%lx, 0x%lx, 0x%lx, ...(%d)",
-                               a0, a1, a2, a3, a4, a5, a6, a7, m->paramcount - 8);
+                               a0, a1, a2, a3, a4, a5, a6, a7, md->paramcount - 8);
 #endif
                break;
 #endif /* SIZEOF_VOID_P == 4 */
@@ -1459,6 +1492,7 @@ void builtin_displaymethodstop(methodinfo *m, s8 l, double d, float f)
        s4          logtextlen;
        s4          dumpsize;
        s4          i;
+       s4          pos;
        imm_union   imu;
 
        md = m->parseddesc;
@@ -1466,7 +1500,7 @@ void builtin_displaymethodstop(methodinfo *m, s8 l, double d, float f)
        /* calculate message length */
 
        logtextlen =
-               methodindent + strlen("finished: ") +
+               6 + methodindent + strlen("finished: ") +
                utf_strlen(m->class->name) +
                strlen(".") +
                utf_strlen(m->name) +
@@ -1483,17 +1517,22 @@ void builtin_displaymethodstop(methodinfo *m, s8 l, double d, float f)
 
        logtext = DMNEW(char, logtextlen);
 
-       /* generate the message */
-
-       for (i = 0; i < methodindent; i++)
-               logtext[i] = '\t';
+       /* outdent the log message */
 
        if (methodindent)
                methodindent--;
        else
                log_text("WARNING: unmatched methodindent--");
 
-       strcpy(logtext + methodindent, "finished: ");
+       /* generate the message */
+
+       sprintf(logtext,"-%d-",methodindent);
+       pos = strlen(logtext);
+
+       for (i = 0; i < methodindent; i++)
+               logtext[pos++] = '\t';
+
+       strcpy(logtext + pos, "finished: ");
        utf_strcat_classname(logtext, m->class->name);
        strcat(logtext, ".");
        utf_strcat(logtext, m->name);
@@ -1654,13 +1693,9 @@ void builtin_monitorenter(java_objectheader *o)
 #if defined(USE_THREADS)
 /*
  * Locks the class object - needed for static synchronized methods.
- * The use_class_as_object call is needed in order to circumvent a
- * possible deadlock with builtin_monitorenter called by another
- * thread calling use_class_as_object.
  */
 void builtin_staticmonitorenter(classinfo *c)
 {
-       use_class_as_object(c);
        builtin_monitorenter(&c->header);
 }
 #endif
@@ -1717,113 +1752,160 @@ s4 builtin_irem(s4 a, s4 b) { return a % b; }
 
 ******************************************************************************/
 
-
 s8 builtin_ladd(s8 a, s8 b)
-{ 
+{
+       s8 c;
+
 #if U8_AVAILABLE
-       return a + b; 
+       c = a + b; 
 #else
-       return builtin_i2l(0);
+       c = builtin_i2l(0);
 #endif
+
+       return c;
 }
 
 s8 builtin_lsub(s8 a, s8 b) 
-{ 
+{
+       s8 c;
+
 #if U8_AVAILABLE
-       return a - b; 
+       c = a - b; 
 #else
-       return builtin_i2l(0);
+       c = builtin_i2l(0);
 #endif
+
+       return c;
 }
 
 s8 builtin_lmul(s8 a, s8 b) 
-{ 
+{
+       s8 c;
+
 #if U8_AVAILABLE
-       return a * b; 
+       c = a * b; 
 #else
-       return builtin_i2l(0);
+       c = builtin_i2l(0);
 #endif
+
+       return c;
 }
 
 s8 builtin_ldiv(s8 a, s8 b) 
-{ 
+{
+       s8 c;
+
 #if U8_AVAILABLE
-       return a / b; 
+       c = a / b; 
 #else
-       return builtin_i2l(0);
+       c = builtin_i2l(0);
 #endif
+
+       return c;
 }
 
 s8 builtin_lrem(s8 a, s8 b) 
-{ 
+{
+       s8 c;
+
 #if U8_AVAILABLE
-       return a % b; 
+       c = a % b; 
 #else
-       return builtin_i2l(0);
+       c = builtin_i2l(0);
 #endif
+
+       return c;
 }
 
 s8 builtin_lshl(s8 a, s4 b) 
-{ 
+{
+       s8 c;
+
 #if U8_AVAILABLE
-       return a << (b & 63);
+       c = a << (b & 63);
 #else
-       return builtin_i2l(0);
+       c = builtin_i2l(0);
 #endif
+
+       return c;
 }
 
 s8 builtin_lshr(s8 a, s4 b) 
-{ 
+{
+       s8 c;
+
 #if U8_AVAILABLE
-       return a >> (b & 63);
+       c = a >> (b & 63);
 #else
-       return builtin_i2l(0);
+       c = builtin_i2l(0);
 #endif
+
+       return c;
 }
 
 s8 builtin_lushr(s8 a, s4 b) 
-{ 
+{
+       s8 c;
+
 #if U8_AVAILABLE
-       return ((u8) a) >> (b & 63);
+       c = ((u8) a) >> (b & 63);
 #else
-       return builtin_i2l(0);
+       c = builtin_i2l(0);
 #endif
+
+       return c;
 }
 
 s8 builtin_land(s8 a, s8 b) 
-{ 
+{
+       s8 c;
+
 #if U8_AVAILABLE
-       return a & b; 
+       c = a & b; 
 #else
-       return builtin_i2l(0);
+       c = builtin_i2l(0);
 #endif
+
+       return c;
 }
 
 s8 builtin_lor(s8 a, s8 b) 
-{ 
+{
+       s8 c;
+
 #if U8_AVAILABLE
-       return a | b; 
+       c = a | b; 
 #else
-       return builtin_i2l(0);
+       c = builtin_i2l(0);
 #endif
+
+       return c;
 }
 
 s8 builtin_lxor(s8 a, s8 b) 
-{ 
+{
+       s8 c;
+
 #if U8_AVAILABLE
-       return a ^ b; 
+       c = a ^ b; 
 #else
-       return builtin_i2l(0);
+       c = builtin_i2l(0);
 #endif
+
+       return c;
 }
 
 s8 builtin_lneg(s8 a) 
-{ 
+{
+       s8 c;
+
 #if U8_AVAILABLE
-       return -a;
+       c = -a;
 #else
-       return builtin_i2l(0);
+       c = builtin_i2l(0);
 #endif
+
+       return c;
 }
 
 s4 builtin_lcmp(s8 a, s8 b) 
@@ -1843,6 +1925,28 @@ s4 builtin_lcmp(s8 a, s8 b)
 
 /*********** Functions for floating point operations *************************/
 
+/* used to convert FLT_xxx defines into float values */
+
+static inline float intBitsToFloat(s4 i)
+{
+       imm_union imb;
+
+       imb.i = i;
+       return imb.f;
+}
+
+
+/* used to convert DBL_xxx defines into double values */
+
+static inline float longBitsToDouble(s8 l)
+{
+       imm_union imb;
+
+       imb.l = l;
+       return imb.d;
+}
+
+
 float builtin_fadd(float a, float b)
 {
        if (isnanf(a)) return intBitsToFloat(FLT_NAN);
@@ -2238,8 +2342,11 @@ double builtin_l2d(s8 a)
 
 s4 builtin_f2i(float a) 
 {
+       s4 i;
+
+       i = builtin_d2i((double) a);
 
-       return builtin_d2i((double) a);
+       return i;
 
        /*      float f;
        
@@ -2261,8 +2368,11 @@ s4 builtin_f2i(float a)
 
 s8 builtin_f2l(float a)
 {
+       s8 l;
 
-       return builtin_d2l((double) a);
+       l = builtin_d2l((double) a);
+
+       return l;
 
        /*      float f;
        
@@ -2347,43 +2457,22 @@ float builtin_d2f(double a)
 }
 
 
-/* used to convert FLT_xxx defines into float values */
-
-inline float intBitsToFloat(s4 i)
-{
-       imm_union imb;
-
-       imb.i = i;
-       return imb.f;
-}
-
-
-/* used to convert DBL_xxx defines into double values */
-
-inline float longBitsToDouble(s8 l)
-{
-       imm_union imb;
+/* builtin_clone_array *********************************************************
 
-       imb.l = l;
-       return imb.d;
-}
+   Wrapper function for cloning arrays.
 
+*******************************************************************************/
 
 java_arrayheader *builtin_clone_array(void *env, java_arrayheader *o)
 {
-       return (java_arrayheader *)
-               Java_java_lang_VMObject_clone(0, 0, (java_lang_Cloneable *) o);
-}
+       java_arrayheader    *ah;
+       java_lang_Cloneable *c;
 
+       c = (java_lang_Cloneable *) o;
 
-s4 builtin_dummy(void)
-{
-       log_text("Internal error: builtin_dummy called (native function is missing)");
-       assert(0);
-
-       /* keep the compiler happy */
+       ah = (java_arrayheader *) Java_java_lang_VMObject_clone(0, 0, c);
 
-       return 0;
+       return ah;
 }
 
 
@@ -2401,47 +2490,6 @@ java_objectheader **builtin_asm_get_exceptionptrptr(void)
 #endif
 
 
-methodinfo *builtin_asm_get_threadrootmethod(void)
-{
-       return *threadrootmethod;
-}
-
-
-void *builtin_asm_get_stackframeinfo(void)
-{
-#if defined(USE_THREADS) && defined(NATIVE_THREADS)
-       return &THREADINFO->_stackframeinfo;
-#else
-       /* XXX FIXME FOR OLD THREAD IMPL (jowenn) */
-
-       return &_thread_nativestackframeinfo; /* no threading, at least no native*/
-#endif
-}
-
-
-stacktraceelement *builtin_stacktrace_copy(stacktraceelement **el,
-                                                                                  stacktraceelement *begin,
-                                                                                  stacktraceelement *end)
-{
-/*     stacktraceelement *el;*/
-       size_t s;
-       s=(end-begin);
-       /*printf ("begin: %p, end: %p, diff: %ld, size :%ld\n",begin,end,s,s*sizeof(stacktraceelement));*/
-       *el=heap_allocate(sizeof(stacktraceelement)*(s+1), true, 0);
-#if 0
-       *el=MNEW(stacktraceelement,s+1); /*GC*/
-#endif
-       memcpy(*el,begin,(end-begin)*sizeof(stacktraceelement));
-       (*el)[s].method=0;
-
-       /* XXX change this if line numbers bigger than u2 are allowed, the */
-       /* currently supported class file format does no allow that */
-
-       (*el)[s].linenumber=-1; /* -1 can never be reched otherwise, since line numbers are only u2, so it is save to use that as flag */
-       return *el;
-}
-
-
 /*
  * These are local overrides for various environment variables in Emacs.
  * Please do not remove this and leave it at the end of the file, where