C and other Super I/O cosmetic fixes.

[coreboot.git] / src / superio / smsc / lpc47b272 / lpc47b272_early_serial.c

diff --git a/src/superio/smsc/lpc47b272/lpc47b272_early_serial.c b/src/superio/smsc/lpc47b272/lpc47b272_early_serial.c
index 71641e9ff8396adeed196f80bbcb3118953668ff..75093ea0a9bfd0fc59180b3af8722739e93ac7cc 100644 (file)
--- a/src/superio/smsc/lpc47b272/lpc47b272_early_serial.c
+++ b/src/superio/smsc/lpc47b272/lpc47b272_early_serial.c
@@ -23,38 +23,26 @@
 #include <arch/romcc_io.h>
 #include "lpc47b272.h"
 
-//----------------------------------------------------------------------------------
-// Function:           pnp_enter_conf_state
-// Parameters:         dev - high 8 bits = Super I/O port
-// Return Value:       None
-// Description:        Enable access to the LPC47B272's configuration registers.
-//
-static inline void pnp_enter_conf_state(device_t dev) {
-       unsigned port = dev>>8;
-    outb(0x55, port);
+static void pnp_enter_conf_state(device_t dev)
+{
+       u16 port = dev >> 8;
+       outb(0x55, port);
 }
 
-//----------------------------------------------------------------------------------
-// Function:           pnp_exit_conf_state
-// Parameters:         dev - high 8 bits = Super I/O port
-// Return Value:       None
-// Description:        Disable access to the LPC47B272's configuration registers.
-//
-static void pnp_exit_conf_state(device_t dev) {
-       unsigned port = dev>>8;
-    outb(0xaa, port);
+static void pnp_exit_conf_state(device_t dev)
+{
+       u16 port = dev >> 8;
+       outb(0xaa, port);
 }
 
-//----------------------------------------------------------------------------------
-// Function:           lpc47b272_enable_serial
-// Parameters:         dev - high 8 bits = Super I/O port, 
-//                                               low 8 bits = logical device number (per lpc47b272.h)
-//                                     iobase - processor I/O port address to assign to this serial device
-// Return Value:       bool
-// Description:        Configure the base I/O port of the specified serial device
-//                                     and enable the serial device.
-//
-static void lpc47b272_enable_serial(device_t dev, unsigned iobase)
+/**
+ * Configure the base I/O port of the specified serial device and enable the
+ * serial device.
+ *
+ * @param dev High 8 bits = Super I/O port, low 8 bits = logical device number.
+ * @param iobase Processor I/O port address to assign to this serial device.
+ */
+static void lpc47b272_enable_serial(device_t dev, u16 iobase)
 {
        pnp_enter_conf_state(dev);
        pnp_set_logical_device(dev);