- Fix race condition in option_table.h generation by moving the include

[coreboot.git] / src / pc80 / mc146818rtc_early.c

diff --git a/src/pc80/mc146818rtc_early.c b/src/pc80/mc146818rtc_early.c
index 83e340c70bc40919cdcf8ddf2d9e025733546bcb..d09d6b9df0cae7d5824b7c26a0eee3d4c23302a3 100644 (file)
--- a/src/pc80/mc146818rtc_early.c
+++ b/src/pc80/mc146818rtc_early.c
@@ -1,35 +1,16 @@
 #include <pc80/mc146818rtc.h>
-#include <part/fallback_boot.h>
+#include <fallback.h>
+#if CONFIG_USE_OPTION_TABLE
+#include "option_table.h"
+#endif
 
-#ifndef MAX_REBOOT_CNT
-#error "MAX_REBOOT_CNT not defined"
+#ifndef CONFIG_MAX_REBOOT_CNT
+#error "CONFIG_MAX_REBOOT_CNT not defined"
 #endif
-#if  MAX_REBOOT_CNT > 15
-#error "MAX_REBOOT_CNT too high"
+#if  CONFIG_MAX_REBOOT_CNT > 15
+#error "CONFIG_MAX_REBOOT_CNT too high"
 #endif
 
-static unsigned char cmos_read(unsigned char addr)
-{
-       int offs = 0;
-       if (addr >= 128) {
-               offs = 2;
-               addr -= 128;
-       }
-       outb(addr, RTC_BASE_PORT + offs + 0);
-       return inb(RTC_BASE_PORT + offs + 1);
-}
-
-static void cmos_write(unsigned char val, unsigned char addr)
-{
-       int offs = 0;
-       if (addr >= 128) {
-               offs = 2;
-               addr -= 128;
-       }
-       outb(addr, RTC_BASE_PORT + offs + 0);
-       outb(val, RTC_BASE_PORT + offs + 1);
-}
-
 static int cmos_error(void)
 {
        unsigned char reg_d;
@@ -40,6 +21,7 @@ static int cmos_error(void)
 
 static int cmos_chksum_valid(void)
 {
+#if CONFIG_USE_OPTION_TABLE
        unsigned char addr;
        unsigned long sum, old_sum;
        sum = 0;
@@ -54,35 +36,37 @@ static int cmos_chksum_valid(void)
        old_sum |=  cmos_read(LB_CKS_LOC+1);
 
        return sum == old_sum;
+#else
+       return 0;
+#endif
 }
 
 
-static int last_boot_normal(void)
+static inline int last_boot_normal(void)
 {
        unsigned char byte;
        byte = cmos_read(RTC_BOOT_BYTE);
        return (byte & (1 << 1));
 }
 
-static int do_normal_boot(void)
+static inline int do_normal_boot(void)
 {
        unsigned char byte;
 
        if (cmos_error() || !cmos_chksum_valid()) {
-               unsigned char byte;
-               /* There are no impossible values, no cheksums so just
+               /* There are no impossible values, no checksums so just
                 * trust whatever value we have in the the cmos,
                 * but clear the fallback bit.
                 */
                byte = cmos_read(RTC_BOOT_BYTE);
                byte &= 0x0c;
-               byte |= MAX_REBOOT_CNT << 4;
+               byte |= CONFIG_MAX_REBOOT_CNT << 4;
                cmos_write(byte, RTC_BOOT_BYTE);
        }
 
        /* The RTC_BOOT_BYTE is now o.k. see where to go. */
        byte = cmos_read(RTC_BOOT_BYTE);
-       
+
        /* Are we in normal mode? */
        if (byte & 1) {
                byte &= 0x0f; /* yes, clear the boot count */
@@ -90,12 +74,12 @@ static int do_normal_boot(void)
 
        /* Properly set the last boot flag */
        byte &= 0xfc;
-       if ((byte >> 4) < MAX_REBOOT_CNT) {
+       if ((byte >> 4) < CONFIG_MAX_REBOOT_CNT) {
                byte |= (1<<1);
        }
 
        /* Are we already at the max count? */
-       if ((byte >> 4) < MAX_REBOOT_CNT) {
+       if ((byte >> 4) < CONFIG_MAX_REBOOT_CNT) {
                byte += 1 << 4; /* No, add 1 to the count */
        }
        else {
@@ -108,9 +92,9 @@ static int do_normal_boot(void)
        return (byte & (1<<1));
 }
 
-static unsigned read_option(unsigned start, unsigned size, unsigned def)
+unsigned read_option(unsigned start, unsigned size, unsigned def)
 {
-#if USE_OPTION_TABLE == 1
+#if CONFIG_USE_OPTION_TABLE
        unsigned byte;
        byte = cmos_read(start/8);
        return (byte >> (start & 7U)) & ((1U << size) - 1U);