Factor out a few commonly duplicated functions from northbridge.c.
[coreboot.git] / src / northbridge / intel / i945 / northbridge.c
index 5f71e19a9096a986e97bc55a3ab83a698a929669..9963bed5ce3354880af78de22c09855f17e9d17d 100644 (file)
@@ -31,7 +31,6 @@
 #include <boot/tables.h>
 #include "chip.h"
 #include "i945.h"
-#include <arch/coreboot_tables.h>
 
 static int get_pcie_bar(u32 *base, u32 *len)
 {
@@ -71,57 +70,26 @@ static int get_pcie_bar(u32 *base, u32 *len)
 /* IDG memory */
 uint64_t uma_memory_base=0, uma_memory_size=0;
 
-int add_northbridge_resources(struct lb_memory *mem)
-{
-       u32 pcie_config_base, pcie_config_size;
-
-       printk_debug("Adding UMA memory area\n");
-       lb_add_memory_range(mem, LB_MEM_RESERVED,
-               uma_memory_base, uma_memory_size);
-
-       printk_debug("Adding PCIe config bar\n");
-       get_pcie_bar(&pcie_config_base, &pcie_config_size);
-       lb_add_memory_range(mem, LB_MEM_RESERVED,
-               pcie_config_base, pcie_config_size);
-
-       return 0;
-}
-
-static void ram_resource(device_t dev, unsigned long index, unsigned long basek,
-                        unsigned long sizek)
+static void add_fixed_resources(struct device *dev, int index)
 {
        struct resource *resource;
+       u32 pcie_config_base, pcie_config_size;
 
+       printk(BIOS_DEBUG, "Adding UMA memory area\n");
        resource = new_resource(dev, index);
-       resource->base = ((resource_t) basek) << 10;
-       resource->size = ((resource_t) sizek) << 10;
-       resource->flags = IORESOURCE_MEM | IORESOURCE_CACHEABLE |
+       resource->base = (resource_t) uma_memory_base;
+       resource->size = (resource_t) uma_memory_size;
+       resource->flags = IORESOURCE_MEM | IORESOURCE_RESERVE |
            IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED;
-}
-
-static void tolm_test(void *gp, struct device *dev, struct resource *new)
-{
-       struct resource **best_p = gp;
-       struct resource *best;
-       best = *best_p;
-       if (!best || (best->base > new->base)) {
-               best = new;
-       }
-       *best_p = best;
-}
 
-static uint32_t find_pci_tolm(struct bus *bus)
-{
-       struct resource *min;
-       uint32_t tolm;
-       min = 0;
-       search_bus_resources(bus, IORESOURCE_MEM, IORESOURCE_MEM, tolm_test,
-                            &min);
-       tolm = 0xffffffffUL;
-       if (min && tolm > min->base) {
-               tolm = min->base;
+       if (get_pcie_bar(&pcie_config_base, &pcie_config_size)) {
+               printk(BIOS_DEBUG, "Adding PCIe config bar\n");
+               resource = new_resource(dev, index+1);
+               resource->base = (resource_t) pcie_config_base;
+               resource->size = (resource_t) pcie_config_size;
+               resource->flags = IORESOURCE_MEM | IORESOURCE_RESERVE |
+                   IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED;
        }
-       return tolm;
 }
 
 #if CONFIG_WRITE_HIGH_TABLES==1
@@ -139,14 +107,14 @@ static void pci_domain_set_resources(device_t dev)
        /* Can we find out how much memory we can use at most
         * this way?
         */
-       pci_tolm = find_pci_tolm(&dev->link[0]);
-       printk_debug("pci_tolm: 0x%x\n", pci_tolm);
+       pci_tolm = find_pci_tolm(dev->link_list);
+       printk(BIOS_DEBUG, "pci_tolm: 0x%x\n", pci_tolm);
 
-       printk_spew("Base of stolen memory: 0x%08x\n",
+       printk(BIOS_SPEW, "Base of stolen memory: 0x%08x\n",
                    pci_read_config32(dev_find_slot(0, PCI_DEVFN(2, 0)), 0x5c));
 
        tolud = pci_read_config8(dev_find_slot(0, PCI_DEVFN(0, 0)), 0x9c);
-       printk_spew("Top of Low Used DRAM: 0x%08x\n", tolud << 24);
+       printk(BIOS_SPEW, "Top of Low Used DRAM: 0x%08x\n", tolud << 24);
 
        tomk = tolud << 14;
 
@@ -154,7 +122,7 @@ static void pci_domain_set_resources(device_t dev)
        reg8 = pci_read_config8(dev_find_slot(0, PCI_DEVFN(0, 0)), 0x9e);
        if (reg8 & 1) {
                int tseg_size = 0;
-               printk_debug("TSEG decoded, subtracting ");
+               printk(BIOS_DEBUG, "TSEG decoded, subtracting ");
                reg8 >>= 1;
                reg8 &= 3;
                switch (reg8) {
@@ -169,14 +137,14 @@ static void pci_domain_set_resources(device_t dev)
                        break;  /* TSEG = 8M */
                }
 
-               printk_debug("%dM\n", tseg_size >> 10);
+               printk(BIOS_DEBUG, "%dM\n", tseg_size >> 10);
                tomk -= tseg_size;
        }
 
        reg16 = pci_read_config16(dev_find_slot(0, PCI_DEVFN(0, 0)), GGC);
        if (!(reg16 & 2)) {
                int uma_size = 0;
-               printk_debug("IGD decoded, subtracting ");
+               printk(BIOS_DEBUG, "IGD decoded, subtracting ");
                reg16 >>= 4;
                reg16 &= 7;
                switch (reg16) {
@@ -188,7 +156,7 @@ static void pci_domain_set_resources(device_t dev)
                        break;
                }
 
-               printk_debug("%dM UMA\n", uma_size >> 10);
+               printk(BIOS_DEBUG, "%dM UMA\n", uma_size >> 10);
                tomk -= uma_size;
 
                /* For reserving UMA memory in the memory map */
@@ -199,8 +167,8 @@ static void pci_domain_set_resources(device_t dev)
        /* The following needs to be 2 lines, otherwise the second
         * number is always 0
         */
-       printk_info("Available memory: %dK", (uint32_t)tomk);
-       printk_info(" (%dM)\n", (uint32_t)(tomk >> 10));
+       printk(BIOS_INFO, "Available memory: %dK", (uint32_t)tomk);
+       printk(BIOS_INFO, " (%dM)\n", (uint32_t)(tomk >> 10));
 
        /* Report the memory regions */
        ram_resource(dev, 3, 0, 640);
@@ -209,7 +177,9 @@ static void pci_domain_set_resources(device_t dev)
                ram_resource(dev, 5, 4096 * 1024, tomk - 4 * 1024 * 1024);
        }
 
-       assign_resources(&dev->link[0]);
+       add_fixed_resources(dev, 6);
+
+       assign_resources(dev->link_list);
 
 #if CONFIG_WRITE_HIGH_TABLES==1
        /* Leave some space for ACPI, PIRQ and MP tables */
@@ -225,8 +195,8 @@ static void pci_domain_set_resources(device_t dev)
 static struct device_operations pci_domain_ops = {
        .read_resources   = pci_domain_read_resources,
        .set_resources    = pci_domain_set_resources,
-       .enable_resources = enable_childrens_resources,
-       .init             = 0,
+       .enable_resources = NULL,
+       .init             = NULL,
        .scan_bus         = pci_domain_scan_bus,
 #if CONFIG_MMCONF_SUPPORT_DEFAULT
        .ops_pci_bus      = &pci_ops_mmconf,
@@ -253,7 +223,7 @@ static void mc_read_resources(device_t dev)
        resource->flags =
            IORESOURCE_MEM | IORESOURCE_FIXED | IORESOURCE_STORED |
            IORESOURCE_ASSIGNED;
-       printk_debug("Adding PCIe enhanced config space BAR 0x%08lx-0x%08lx.\n",
+       printk(BIOS_DEBUG, "Adding PCIe enhanced config space BAR 0x%08lx-0x%08lx.\n",
                     (unsigned long)(resource->base), (unsigned long)(resource->base + resource->size));
 }
 
@@ -289,15 +259,15 @@ static void northbridge_init(struct device *dev)
 {
        switch (pci_read_config32(dev, SKPAD)) {
        case 0xcafebabe:
-               printk_debug("Normal boot.\n");
+               printk(BIOS_DEBUG, "Normal boot.\n");
                acpi_slp_type=0;
                break;
        case 0xcafed00d:
-               printk_debug("S3 Resume.\n");
+               printk(BIOS_DEBUG, "S3 Resume.\n");
                acpi_slp_type=3;
                break;
        default:
-               printk_debug("Unknown boot method, assuming normal.\n");
+               printk(BIOS_DEBUG, "Unknown boot method, assuming normal.\n");
                acpi_slp_type=0;
                break;
        }
@@ -327,7 +297,7 @@ static const struct pci_driver mc_driver __pci_driver = {
 
 static void cpu_bus_init(device_t dev)
 {
-       initialize_cpus(&dev->link[0]);
+       initialize_cpus(dev->link_list);
 }
 
 static void cpu_bus_noop(device_t dev)