printk_foo -> printk(BIOS_FOO, ...)
[coreboot.git] / src / northbridge / amd / amdk8 / northbridge.c
index 2c7c9813c2c2c60ac40eafba50b95284208c69ad..2ca14444cbdb82039ac439f9763c5b7062a2c5c3 100644 (file)
@@ -19,8 +19,8 @@
 
 #include <cpu/x86/lapic.h>
 
-#if CONFIG_LOGICAL_CPUS==1
 #include <cpu/amd/dualcore.h>
+#if CONFIG_LOGICAL_CPUS==1
 #include <pc80/mc146818rtc.h>
 #endif
 
 
 #include "amdk8.h"
 
-#if HW_MEM_HOLE_SIZEK != 0
 #include <cpu/amd/model_fxx_rev.h>
-#endif
 
 #include <cpu/amd/amdk8_sysconf.h>
 
 struct amdk8_sysconf_t sysconf;
 
-#define FX_DEVS 8
-static device_t __f0_dev[FX_DEVS];
-static device_t __f1_dev[FX_DEVS];
-
-#if 0
-static void debug_fx_devs(void)
-{
-       int i;
-       for(i = 0; i < FX_DEVS; i++) {
-               device_t dev;
-               dev = __f0_dev[i];
-               if (dev) {
-                       printk_debug("__f0_dev[%d]: %s bus: %p\n",
-                               i, dev_path(dev), dev->bus);
-               }
-               dev = __f1_dev[i];
-               if (dev) {
-                       printk_debug("__f1_dev[%d]: %s bus: %p\n",
-                               i, dev_path(dev), dev->bus);
-               }
-       }
-}
-#endif
+#define MAX_FX_DEVS 8
+static device_t __f0_dev[MAX_FX_DEVS];
+static device_t __f1_dev[MAX_FX_DEVS];
+static unsigned fx_devs=0;
 
 static void get_fx_devs(void)
 {
        int i;
-       if (__f1_dev[0]) {
-               return;
-       }
-       for(i = 0; i < FX_DEVS; i++) {
+       for(i = 0; i < MAX_FX_DEVS; i++) {
                __f0_dev[i] = dev_find_slot(0, PCI_DEVFN(0x18 + i, 0));
                __f1_dev[i] = dev_find_slot(0, PCI_DEVFN(0x18 + i, 1));
+               if (__f0_dev[i] != NULL && __f1_dev[i] != NULL)
+                       fx_devs = i+1;
        }
-       if (!__f1_dev[0]) {
-               die("Cannot find 0:0x18.1\n");
+       if (__f1_dev[0] == NULL || __f0_dev[0] == NULL || fx_devs == 0) {
+               die("Cannot find 0:0x18.[0|1]\n");
        }
 }
 
 static uint32_t f1_read_config32(unsigned reg)
 {
-       get_fx_devs();
+       if ( fx_devs == 0)
+               get_fx_devs();
        return pci_read_config32(__f1_dev[0], reg);
 }
 
 static void f1_write_config32(unsigned reg, uint32_t value)
 {
        int i;
-       get_fx_devs();
-       for(i = 0; i < FX_DEVS; i++) {
+       if ( fx_devs == 0)
+               get_fx_devs();
+       for(i = 0; i < fx_devs; i++) {
                device_t dev;
                dev = __f1_dev[i];
                if (dev && dev->enabled) {
@@ -98,7 +78,7 @@ static void f1_write_config32(unsigned reg, uint32_t value)
 
 static unsigned int amdk8_nodeid(device_t dev)
 {
-       return (dev->path.u.pci.devfn >> 3) - 0x18;
+       return (dev->path.pci.devfn >> 3) - 0x18;
 }
 
 static unsigned int amdk8_scan_chain(device_t dev, unsigned nodeid, unsigned link, unsigned sblink, unsigned int max, unsigned offset_unitid)
@@ -157,12 +137,12 @@ static unsigned int amdk8_scan_chain(device_t dev, unsigned nodeid, unsigned lin
                 * We have no idea how many busses are behind this bridge yet,
                 * so we set the subordinate bus number to 0xff for the moment.
                 */
-#if SB_HT_CHAIN_ON_BUS0 > 0
+#if CONFIG_SB_HT_CHAIN_ON_BUS0 > 0
                // first chain will on bus 0
                if((nodeid == 0) && (sblink==link)) { // actually max is 0 here
                        min_bus = max;
                }
-       #if SB_HT_CHAIN_ON_BUS0 > 1
+       #if CONFIG_SB_HT_CHAIN_ON_BUS0 > 1
                // second chain will be on 0x40, third 0x80, forth 0xc0
                else {
                        min_bus = ((max>>6) + 1) * 0x40;
@@ -259,8 +239,8 @@ static unsigned int amdk8_scan_chains(device_t dev, unsigned int max)
 
        if(nodeid==0) {
                sblink = (pci_read_config32(dev, 0x64)>>8) & 3;
-#if SB_HT_CHAIN_ON_BUS0 > 0
-       #if ((HT_CHAIN_UNITID_BASE != 1) || (HT_CHAIN_END_UNITID_BASE != 0x20))
+#if CONFIG_SB_HT_CHAIN_ON_BUS0 > 0
+       #if ((CONFIG_HT_CHAIN_UNITID_BASE != 1) || (CONFIG_HT_CHAIN_END_UNITID_BASE != 0x20))
                offset_unitid = 1;
        #endif
                max = amdk8_scan_chain(dev, nodeid, sblink, sblink, max, offset_unitid ); // do sb ht chain at first, in case s2885 put sb chain (8131/8111) on link2, but put 8151 on link0
@@ -268,12 +248,12 @@ static unsigned int amdk8_scan_chains(device_t dev, unsigned int max)
        }
 
        for(link = 0; link < dev->links; link++) {
-#if SB_HT_CHAIN_ON_BUS0 > 0
+#if CONFIG_SB_HT_CHAIN_ON_BUS0 > 0
                if( (nodeid == 0) && (sblink == link) ) continue; //already done
 #endif
                offset_unitid = 0;
-               #if ((HT_CHAIN_UNITID_BASE != 1) || (HT_CHAIN_END_UNITID_BASE != 0x20))
-                       #if SB_HT_CHAIN_UNITID_OFFSET_ONLY == 1
+               #if ((CONFIG_HT_CHAIN_UNITID_BASE != 1) || (CONFIG_HT_CHAIN_END_UNITID_BASE != 0x20))
+                       #if CONFIG_SB_HT_CHAIN_UNITID_OFFSET_ONLY == 1
                        if((nodeid == 0) && (sblink == link))
                        #endif
                                offset_unitid = 1;
@@ -290,14 +270,16 @@ static int reg_useable(unsigned reg,
        device_t goal_dev, unsigned goal_nodeid, unsigned goal_link)
 {
        struct resource *res;
-       unsigned nodeid, link;
+       unsigned nodeid, link=0;
        int result;
        res = 0;
-       for(nodeid = 0; !res && (nodeid < 8); nodeid++) {
+       for(nodeid = 0; !res && (nodeid < fx_devs); nodeid++) {
                device_t dev;
                dev = __f0_dev[nodeid];
+               if (!dev)
+                       continue;
                for(link = 0; !res && (link < 3); link++) {
-                       res = probe_resource(dev, 0x100 + (reg | link));
+                       res = probe_resource(dev, IOINDEX(0x100 + reg, link));
                }
        }
        result = 2;
@@ -313,13 +295,14 @@ static int reg_useable(unsigned reg,
        return result;
 }
 
-static struct resource *amdk8_find_iopair(device_t dev, unsigned nodeid, unsigned link)
+static unsigned amdk8_find_reg(device_t dev, unsigned nodeid, unsigned link,
+                              unsigned min, unsigned max)
 {
-       struct resource *resource;
+       unsigned resource;
        unsigned free_reg, reg;
        resource = 0;
        free_reg = 0;
-       for(reg = 0xc0; reg <= 0xd8; reg += 0x8) {
+       for(reg = min; reg <= max; reg += 0x8) {
                int result;
                result = reg_useable(reg, dev, nodeid, link);
                if (result == 1) {
@@ -331,40 +314,23 @@ static struct resource *amdk8_find_iopair(device_t dev, unsigned nodeid, unsigne
                        free_reg = reg;
                }
        }
-       if (reg > 0xd8) {
+       if (reg > max) {
                reg = free_reg;
        }
        if (reg > 0) {
-               resource = new_resource(dev, 0x100 + (reg | link));
+               resource = IOINDEX(0x100 + reg, link);
        }
        return resource;
 }
 
-static struct resource *amdk8_find_mempair(device_t dev, unsigned nodeid, unsigned link)
+static unsigned amdk8_find_iopair(device_t dev, unsigned nodeid, unsigned link)
 {
-       struct resource *resource;
-       unsigned free_reg, reg;
-       resource = 0;
-       free_reg = 0;
-       for(reg = 0x80; reg <= 0xb8; reg += 0x8) {
-               int result;
-               result = reg_useable(reg, dev, nodeid, link);
-               if (result == 1) {
-                       /* I have been allocated this one */
-                       break;
-               }
-               else if (result > 1) {
-                       /* I have a free register pair */
-                       free_reg = reg;
-               }
-       }
-       if (reg > 0xb8) {
-               reg = free_reg;
-       }
-       if (reg > 0) {
-               resource = new_resource(dev, 0x100 + (reg | link));
-       }
-       return resource;
+       return amdk8_find_reg(dev, nodeid, link, 0xc0, 0xd8);
+}
+
+static unsigned amdk8_find_mempair(device_t dev, unsigned nodeid, unsigned link)
+{
+       return amdk8_find_reg(dev, nodeid, link, 0x80, 0xb8);
 }
 
 static void amdk8_link_read_bases(device_t dev, unsigned nodeid, unsigned link)
@@ -372,20 +338,18 @@ static void amdk8_link_read_bases(device_t dev, unsigned nodeid, unsigned link)
        struct resource *resource;
 
        /* Initialize the io space constraints on the current bus */
-       resource =  amdk8_find_iopair(dev, nodeid, link);
+       resource = new_resource(dev, IOINDEX(0, link));
        if (resource) {
                resource->base  = 0;
                resource->size  = 0;
                resource->align = log2(HT_IO_HOST_ALIGN);
                resource->gran  = log2(HT_IO_HOST_ALIGN);
                resource->limit = 0xffffUL;
-               resource->flags = IORESOURCE_IO;
-               compute_allocate_resource(&dev->link[link], resource,
-                       IORESOURCE_IO, IORESOURCE_IO);
+               resource->flags = IORESOURCE_IO | IORESOURCE_BRIDGE;
        }
 
        /* Initialize the prefetchable memory constraints on the current bus */
-       resource = amdk8_find_mempair(dev, nodeid, link);
+       resource = new_resource(dev, IOINDEX(2, link));
        if (resource) {
                resource->base  = 0;
                resource->size  = 0;
@@ -393,26 +357,23 @@ static void amdk8_link_read_bases(device_t dev, unsigned nodeid, unsigned link)
                resource->gran  = log2(HT_MEM_HOST_ALIGN);
                resource->limit = 0xffffffffffULL;
                resource->flags = IORESOURCE_MEM | IORESOURCE_PREFETCH;
-               compute_allocate_resource(&dev->link[link], resource,
-                       IORESOURCE_MEM | IORESOURCE_PREFETCH,
-                       IORESOURCE_MEM | IORESOURCE_PREFETCH);
+               resource->flags |= IORESOURCE_BRIDGE;
        }
 
        /* Initialize the memory constraints on the current bus */
-       resource = amdk8_find_mempair(dev, nodeid, link);
+       resource = new_resource(dev, IOINDEX(1, link));
        if (resource) {
                resource->base  = 0;
                resource->size  = 0;
                resource->align = log2(HT_MEM_HOST_ALIGN);
                resource->gran  = log2(HT_MEM_HOST_ALIGN);
-               resource->limit = 0xffffffffffULL;
-               resource->flags = IORESOURCE_MEM;
-               compute_allocate_resource(&dev->link[link], resource,
-                       IORESOURCE_MEM | IORESOURCE_PREFETCH,
-                       IORESOURCE_MEM);
+               resource->limit = 0xffffffffULL;
+               resource->flags = IORESOURCE_MEM | IORESOURCE_BRIDGE;
        }
 }
 
+static void amdk8_create_vga_resource(device_t dev, unsigned nodeid);
+
 static void amdk8_read_resources(device_t dev)
 {
        unsigned nodeid, link;
@@ -422,6 +383,8 @@ static void amdk8_read_resources(device_t dev)
                        amdk8_link_read_bases(dev, nodeid, link);
                }
        }
+
+       amdk8_create_vga_resource(dev, nodeid);
 }
 
 static void amdk8_set_resource(device_t dev, struct resource *resource, unsigned nodeid)
@@ -432,11 +395,15 @@ static void amdk8_set_resource(device_t dev, struct resource *resource, unsigned
 
        /* Make certain the resource has actually been set */
        if (!(resource->flags & IORESOURCE_ASSIGNED)) {
+               printk(BIOS_ERR, "%s: can't set unassigned resource @%lx %lx\n",
+                          __func__, resource->index, resource->flags);
                return;
        }
 
        /* If I have already stored this resource don't worry about it */
        if (resource->flags & IORESOURCE_STORED) {
+               printk(BIOS_ERR, "%s: can't set stored resource @%lx %lx\n", __func__,
+                          resource->index, resource->flags);
                return;
        }
 
@@ -448,6 +415,10 @@ static void amdk8_set_resource(device_t dev, struct resource *resource, unsigned
        if (resource->index < 0x100) {
                return;
        }
+
+       if (resource->size == 0)
+               return;
+
        /* Get the base address */
        rbase = resource->base;
 
@@ -456,12 +427,10 @@ static void amdk8_set_resource(device_t dev, struct resource *resource, unsigned
 
        /* Get the register and link */
        reg  = resource->index & 0xfc;
-       link = resource->index & 3;
+       link = IOINDEX_LINK(resource->index);
 
        if (resource->flags & IORESOURCE_IO) {
                uint32_t base, limit;
-               compute_allocate_resource(&dev->link[link], resource,
-                       IORESOURCE_IO, IORESOURCE_IO);
                base  = f1_read_config32(reg);
                limit = f1_read_config32(reg + 0x4);
                base  &= 0xfe000fcc;
@@ -473,7 +442,7 @@ static void amdk8_set_resource(device_t dev, struct resource *resource, unsigned
                limit |= (nodeid & 7);
 
                if (dev->link[link].bridge_ctrl & PCI_BRIDGE_CTL_VGA) {
-                       printk_spew("%s, enabling legacy VGA IO forwarding for %s link %s\n",
+                       printk(BIOS_SPEW, "%s, enabling legacy VGA IO forwarding for %s link 0x%x\n",
                                    __func__, dev_path(dev), link);
                        base |= PCI_IO_BASE_VGA_EN;
                }
@@ -486,9 +455,6 @@ static void amdk8_set_resource(device_t dev, struct resource *resource, unsigned
        }
        else if (resource->flags & IORESOURCE_MEM) {
                uint32_t base, limit;
-               compute_allocate_resource(&dev->link[link], resource,
-                       IORESOURCE_MEM | IORESOURCE_PREFETCH,
-                       resource->flags & (IORESOURCE_MEM | IORESOURCE_PREFETCH));
                base  = f1_read_config32(reg);
                limit = f1_read_config32(reg + 0x4);
                base  &= 0x000000f0;
@@ -507,11 +473,6 @@ static void amdk8_set_resource(device_t dev, struct resource *resource, unsigned
        report_resource_stored(dev, resource, buf);
 }
 
-/**
- *
- * I tried to reuse the resource allocation code in amdk8_set_resource()
- * but it is too diffcult to deal with the resource allocation magic.
- */
 #if CONFIG_CONSOLE_VGA_MULTI == 1
 extern device_t vga_pri;       // the primary vga device, defined in device.c
 #endif
@@ -520,15 +481,13 @@ static void amdk8_create_vga_resource(device_t dev, unsigned nodeid)
 {
        struct resource *resource;
        unsigned link;
-       uint32_t base, limit;
-       unsigned reg;
 
        /* find out which link the VGA card is connected,
         * we only deal with the 'first' vga card */
        for (link = 0; link < dev->links; link++) {
                if (dev->link[link].bridge_ctrl & PCI_BRIDGE_CTL_VGA) {
 #if CONFIG_CONSOLE_VGA_MULTI == 1
-                       printk_debug("VGA: vga_pri bus num = %d dev->link[link] bus range [%d,%d]\n", vga_pri->bus->secondary,
+                       printk(BIOS_DEBUG, "VGA: vga_pri bus num = %d dev->link[link] bus range [%d,%d]\n", vga_pri->bus->secondary,
                                dev->link[link].secondary,dev->link[link].subordinate);
                        /* We need to make sure the vga_pri is under the link */
                        if((vga_pri->bus->secondary >= dev->link[link].secondary ) &&
@@ -543,33 +502,19 @@ static void amdk8_create_vga_resource(device_t dev, unsigned nodeid)
        if (link == dev->links)
                return;
 
-       printk_debug("VGA: %s (aka node %d) link %d has VGA device\n", dev_path(dev), nodeid, link);
+       printk(BIOS_DEBUG, "VGA: %s (aka node %d) link %d has VGA device\n", dev_path(dev), nodeid, link);
 
-       /* allocate a temp resrouce for legacy VGA buffer */
-       resource = amdk8_find_mempair(dev, nodeid, link);
+       /* allocate a temp resource for the legacy VGA buffer */
+       resource = new_resource(dev, IOINDEX(4, link));
        if(!resource){
-               printk_debug("VGA: Can not find free mmio reg for legacy VGA buffer\n");
+               printk(BIOS_DEBUG, "VGA: %s out of resources.\n", dev_path(dev));
                return;
        }
        resource->base = 0xa0000;
        resource->size = 0x20000;
-
-       /* write the resource to the hardware */
-       reg  = resource->index & 0xfc;
-       base  = f1_read_config32(reg);
-       limit = f1_read_config32(reg + 0x4);
-       base  &= 0x000000f0;
-       base  |= (resource->base >> 8) & 0xffffff00;
-       base  |= 3;
-       limit &= 0x00000048;
-       limit |= (resource_end(resource) >> 8) & 0xffffff00;
-       limit |= (resource->index & 3) << 4;
-       limit |= (nodeid & 7);
-       f1_write_config32(reg + 0x4, limit);
-       f1_write_config32(reg, base);
-
-       /* release the temp resource */
-       resource->flags = 0;
+       resource->limit = 0xffffffff;
+       resource->flags = IORESOURCE_FIXED | IORESOURCE_MEM |
+                         IORESOURCE_ASSIGNED;
 }
 
 static void amdk8_set_resources(device_t dev)
@@ -580,13 +525,36 @@ static void amdk8_set_resources(device_t dev)
        /* Find the nodeid */
        nodeid = amdk8_nodeid(dev);
 
-       amdk8_create_vga_resource(dev, nodeid);
-
        /* Set each resource we have found */
        for(i = 0; i < dev->resources; i++) {
-               amdk8_set_resource(dev, &dev->resource[i], nodeid);
+               struct resource *res = &dev->resource[i];
+               struct resource *old = NULL;
+               unsigned index;
+
+               if (res->size == 0) /* No need to allocate registers. */
+                       continue;
+
+               if (res->flags & IORESOURCE_IO)
+                       index = amdk8_find_iopair(dev, nodeid,
+                                                 IOINDEX_LINK(res->index));
+               else
+                       index = amdk8_find_mempair(dev, nodeid,
+                                                  IOINDEX_LINK(res->index));
+
+               old = probe_resource(dev, index);
+               if (old) {
+                       res->index = old->index;
+                       old->index = 0;
+                       old->flags = 0;
+               }
+               else
+                       res->index = index;
+
+               amdk8_set_resource(dev, res, nodeid);
        }
 
+       compact_resources(dev);
+
        for(link = 0; link < dev->links; link++) {
                struct bus *bus;
                bus = &dev->link[link];
@@ -605,10 +573,10 @@ static void amdk8_enable_resources(device_t dev)
 static void mcf0_control_init(struct device *dev)
 {
 #if 0
-       printk_debug("NB: Function 0 Misc Control.. ");
+       printk(BIOS_DEBUG, "NB: Function 0 Misc Control.. ");
 #endif
 #if 0
-       printk_debug("done.\n");
+       printk(BIOS_DEBUG, "done.\n");
 #endif
 }
 
@@ -629,18 +597,13 @@ static const struct pci_driver mcf0_driver __pci_driver = {
        .device = 0x1100,
 };
 
-#if CONFIG_CHIP_NAME == 1
-
 struct chip_operations northbridge_amd_amdk8_ops = {
        CHIP_NAME("AMD K8 Northbridge")
        .enable_dev = 0,
 };
 
-#endif
-
-static void pci_domain_read_resources(device_t dev)
+static void amdk8_domain_read_resources(device_t dev)
 {
-       struct resource *resource;
        unsigned reg;
 
        /* Find the already assigned resource pairs */
@@ -652,55 +615,30 @@ static void pci_domain_read_resources(device_t dev)
                /* Is this register allocated? */
                if ((base & 3) != 0) {
                        unsigned nodeid, link;
-                       device_t dev;
+                       device_t reg_dev;
                        nodeid = limit & 7;
                        link   = (limit >> 4) & 3;
-                       dev = __f0_dev[nodeid];
-                       if (dev) {
+                       reg_dev = __f0_dev[nodeid];
+                       if (reg_dev) {
                                /* Reserve the resource  */
-                               struct resource *resource;
-                               resource = new_resource(dev, 0x100 + (reg | link));
-                               if (resource) {
-                                       resource->flags = 1;
+                               struct resource *res;
+                               res = new_resource(reg_dev, IOINDEX(0x100 + reg, link));
+                               if (res) {
+                                       res->base = base;
+                                       res->limit = limit;
+                                       res->flags = 1;
                                }
                        }
                }
        }
-#if CONFIG_PCI_64BIT_PREF_MEM == 0
-       /* Initialize the system wide io space constraints */
-       resource = new_resource(dev, IOINDEX_SUBTRACTIVE(0, 0));
-       resource->base  = 0x400;
-       resource->limit = 0xffffUL;
-       resource->flags = IORESOURCE_IO | IORESOURCE_SUBTRACTIVE | IORESOURCE_ASSIGNED;
-
-       /* Initialize the system wide memory resources constraints */
-       resource = new_resource(dev, IOINDEX_SUBTRACTIVE(1, 0));
-       resource->limit = 0xfcffffffffULL;
-       resource->flags = IORESOURCE_MEM | IORESOURCE_SUBTRACTIVE | IORESOURCE_ASSIGNED;
-#else
-       /* Initialize the system wide io space constraints */
-       resource = new_resource(dev, 0);
-       resource->base  = 0x400;
-       resource->limit = 0xffffUL;
-       resource->flags = IORESOURCE_IO;
-       compute_allocate_resource(&dev->link[0], resource,
-               IORESOURCE_IO, IORESOURCE_IO);
 
-       /* Initialize the system wide prefetchable memory resources constraints */
-       resource = new_resource(dev, 1);
-       resource->limit = 0xfcffffffffULL;
-       resource->flags = IORESOURCE_MEM | IORESOURCE_PREFETCH;
-       compute_allocate_resource(&dev->link[0], resource,
-               IORESOURCE_MEM | IORESOURCE_PREFETCH,
-               IORESOURCE_MEM | IORESOURCE_PREFETCH);
+       pci_domain_read_resources(dev);
 
-       /* Initialize the system wide memory resources constraints */
+#if CONFIG_PCI_64BIT_PREF_MEM == 1
+       /* Initialize the system wide prefetchable memory resources constraints */
        resource = new_resource(dev, 2);
        resource->limit = 0xfcffffffffULL;
-       resource->flags = IORESOURCE_MEM;
-       compute_allocate_resource(&dev->link[0], resource,
-               IORESOURCE_MEM | IORESOURCE_PREFETCH,
-               IORESOURCE_MEM);
+       resource->flags = IORESOURCE_MEM | IORESOURCE_PREFETCH;
 #endif
 }
 
@@ -724,7 +662,8 @@ static void tolm_test(void *gp, struct device *dev, struct resource *new)
        struct resource **best_p = gp;
        struct resource *best;
        best = *best_p;
-       if (!best || (best->base > new->base)) {
+       /* Skip VGA. */
+       if (!best || (best->base > new->base && new->base > 0xa0000)) {
                best = new;
        }
        *best_p = best;
@@ -743,11 +682,7 @@ static uint32_t find_pci_tolm(struct bus *bus)
        return tolm;
 }
 
-#if CONFIG_PCI_64BIT_PREF_MEM == 1
-#define BRIDGE_IO_MASK (IORESOURCE_IO | IORESOURCE_MEM | IORESOURCE_PREFETCH)
-#endif
-
-#if HW_MEM_HOLE_SIZEK != 0
+#if CONFIG_HW_MEM_HOLE_SIZEK != 0
 
 struct hw_mem_hole_info {
        unsigned hole_startk;
@@ -759,10 +694,10 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void)
                struct hw_mem_hole_info mem_hole;
                int i;
 
-               mem_hole.hole_startk = HW_MEM_HOLE_SIZEK;
+               mem_hole.hole_startk = CONFIG_HW_MEM_HOLE_SIZEK;
                mem_hole.node_id = -1;
 
-               for (i = 0; i < 8; i++) {
+               for (i = 0; i < fx_devs; i++) {
                        uint32_t base;
                        uint32_t hole;
                        base  = f1_read_config32(0x40 + (i << 3));
@@ -805,9 +740,10 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void)
                return mem_hole;
 
 }
-static void disable_hoist_memory(unsigned long hole_startk, int i)
+
+static void disable_hoist_memory(unsigned long hole_startk, int node_id)
 {
-       int ii;
+       int i;
        device_t dev;
        uint32_t base, limit;
        uint32_t hoist;
@@ -823,33 +759,35 @@ static void disable_hoist_memory(unsigned long hole_startk, int i)
 
        hole_sizek = (4*1024*1024) - hole_startk;
 
-       for(ii=7;ii>i;ii--) {
+       for(i=7;i>node_id;i--) {
 
-               base  = f1_read_config32(0x40 + (ii << 3));
+               base  = f1_read_config32(0x40 + (i << 3));
                if ((base & ((1<<1)|(1<<0))) != ((1<<1)|(1<<0))) {
                        continue;
                }
-               limit = f1_read_config32(0x44 + (ii << 3));
-               f1_write_config32(0x44 + (ii << 3),limit - (hole_sizek << 2));
-               f1_write_config32(0x40 + (ii << 3),base - (hole_sizek << 2));
+               limit = f1_read_config32(0x44 + (i << 3));
+               f1_write_config32(0x44 + (i << 3),limit - (hole_sizek << 2));
+               f1_write_config32(0x40 + (i << 3),base - (hole_sizek << 2));
+       }
+       limit = f1_read_config32(0x44 + (node_id << 3));
+       f1_write_config32(0x44 + (node_id << 3),limit - (hole_sizek << 2));
+       dev = __f1_dev[node_id];
+       if (dev == NULL) {
+               printk(BIOS_ERR, "%s: node %x is NULL!\n", __func__, node_id);
+               return;
        }
-       limit = f1_read_config32(0x44 + (i << 3));
-       f1_write_config32(0x44 + (i << 3),limit - (hole_sizek << 2));
-       dev = __f1_dev[i];
        hoist = pci_read_config32(dev, 0xf0);
-       if(hoist & 1) {
+       if(hoist & 1)
                pci_write_config32(dev, 0xf0, 0);
-       }
        else {
-               base = pci_read_config32(dev, 0x40 + (i << 3));
-               f1_write_config32(0x40 + (i << 3),base - (hole_sizek << 2));
+               base = pci_read_config32(dev, 0x40 + (node_id << 3));
+               f1_write_config32(0x40 + (node_id << 3),base - (hole_sizek << 2));
        }
-
 }
 
-static uint32_t hoist_memory(unsigned long hole_startk, int i)
+static uint32_t hoist_memory(unsigned long hole_startk, int node_id)
 {
-       int ii;
+       int i;
        uint32_t carry_over;
        device_t dev;
        uint32_t base, limit;
@@ -858,29 +796,29 @@ static uint32_t hoist_memory(unsigned long hole_startk, int i)
 
        carry_over = (4*1024*1024) - hole_startk;
 
-       for(ii=7;ii>i;ii--) {
+       for(i=7;i>node_id;i--) {
 
-               base  = f1_read_config32(0x40 + (ii << 3));
+               base  = f1_read_config32(0x40 + (i << 3));
                if ((base & ((1<<1)|(1<<0))) != ((1<<1)|(1<<0))) {
                        continue;
                }
-               limit = f1_read_config32(0x44 + (ii << 3));
-               f1_write_config32(0x44 + (ii << 3),limit + (carry_over << 2));
-               f1_write_config32(0x40 + (ii << 3),base + (carry_over << 2));
+               limit = f1_read_config32(0x44 + (i << 3));
+               f1_write_config32(0x44 + (i << 3),limit + (carry_over << 2));
+               f1_write_config32(0x40 + (i << 3),base + (carry_over << 2));
        }
-       limit = f1_read_config32(0x44 + (i << 3));
-       f1_write_config32(0x44 + (i << 3),limit + (carry_over << 2));
-       dev = __f1_dev[i];
-       base  = pci_read_config32(dev, 0x40 + (i << 3));
+       limit = f1_read_config32(0x44 + (node_id << 3));
+       f1_write_config32(0x44 + (node_id << 3),limit + (carry_over << 2));
+       dev = __f1_dev[node_id];
+       base  = pci_read_config32(dev, 0x40 + (node_id << 3));
        basek  = (base & 0xffff0000) >> 2;
        if(basek == hole_startk) {
                //don't need set memhole here, because hole off set will be 0, overflow
                //so need to change base reg instead, new basek will be 4*1024*1024
                base &= 0x0000ffff;
                base |= (4*1024*1024)<<2;
-               f1_write_config32(0x40 + (i<<3), base);
+               f1_write_config32(0x40 + (node_id<<3), base);
        }
-       else
+       else if (dev)
        {
                hoist = /* hole start address */
                        ((hole_startk << 10) & 0xff000000) +
@@ -896,7 +834,15 @@ static uint32_t hoist_memory(unsigned long hole_startk, int i)
 }
 #endif
 
-static void pci_domain_set_resources(device_t dev)
+#if CONFIG_WRITE_HIGH_TABLES==1
+#define HIGH_TABLES_SIZE 64    // maximum size of high tables in KB
+extern uint64_t high_tables_base, high_tables_size;
+#if CONFIG_GFXUMA == 1
+extern uint64_t uma_memory_base, uma_memory_size;
+#endif
+#endif
+
+static void amdk8_domain_set_resources(device_t dev)
 {
 #if CONFIG_PCI_64BIT_PREF_MEM == 1
        struct resource *io, *mem1, *mem2;
@@ -905,7 +851,7 @@ static void pci_domain_set_resources(device_t dev)
        unsigned long mmio_basek;
        uint32_t pci_tolm;
        int i, idx;
-#if HW_MEM_HOLE_SIZEK != 0
+#if CONFIG_HW_MEM_HOLE_SIZEK != 0
        struct hw_mem_hole_info mem_hole;
        unsigned reset_memhole = 1;
 #endif
@@ -923,9 +869,9 @@ static void pci_domain_set_resources(device_t dev)
        mem2 = find_resource(dev, 2);
 
 #if 1
-       printk_debug("base1: 0x%08Lx limit1: 0x%08Lx size: 0x%08Lx align: %d\n",
+       printk(BIOS_DEBUG, "base1: 0x%08Lx limit1: 0x%08Lx size: 0x%08Lx align: %d\n",
                mem1->base, mem1->limit, mem1->size, mem1->align);
-       printk_debug("base2: 0x%08Lx limit2: 0x%08Lx size: 0x%08Lx align: %d\n",
+       printk(BIOS_DEBUG, "base2: 0x%08Lx limit2: 0x%08Lx size: 0x%08Lx align: %d\n",
                mem2->base, mem2->limit, mem2->size, mem2->align);
 #endif
 
@@ -953,22 +899,16 @@ static void pci_domain_set_resources(device_t dev)
        }
 
 #if 1
-       printk_debug("base1: 0x%08Lx limit1: 0x%08Lx size: 0x%08Lx align: %d\n",
+       printk(BIOS_DEBUG, "base1: 0x%08Lx limit1: 0x%08Lx size: 0x%08Lx align: %d\n",
                mem1->base, mem1->limit, mem1->size, mem1->align);
-       printk_debug("base2: 0x%08Lx limit2: 0x%08Lx size: 0x%08Lx align: %d\n",
+       printk(BIOS_DEBUG, "base2: 0x%08Lx limit2: 0x%08Lx size: 0x%08Lx align: %d\n",
                mem2->base, mem2->limit, mem2->size, mem2->align);
 #endif
 
        last = &dev->resource[dev->resources];
        for(resource = &dev->resource[0]; resource < last; resource++)
        {
-#if 1
                resource->flags |= IORESOURCE_ASSIGNED;
-               resource->flags &= ~IORESOURCE_STORED;
-#endif
-               compute_allocate_resource(&dev->link[0], resource,
-                       BRIDGE_IO_MASK, resource->flags & BRIDGE_IO_MASK);
-
                resource->flags |= IORESOURCE_STORED;
                report_resource_stored(dev, resource, "");
 
@@ -989,12 +929,12 @@ static void pci_domain_set_resources(device_t dev)
        mmio_basek &= ~((64*1024) - 1);
 #endif
 
-#if HW_MEM_HOLE_SIZEK != 0
+#if CONFIG_HW_MEM_HOLE_SIZEK != 0
        /* if the hw mem hole is already set in raminit stage, here we will compare mmio_basek and hole_basek
         * if mmio_basek is bigger that hole_basek and will use hole_basek as mmio_basek and we don't need to reset hole.
         * otherwise We reset the hole to the mmio_basek
         */
-       #if K8_REV_F_SUPPORT == 0
+       #if CONFIG_K8_REV_F_SUPPORT == 0
                if (!is_cpu_pre_e0()) {
        #endif
 
@@ -1008,16 +948,16 @@ static void pci_domain_set_resources(device_t dev)
                //mmio_basek = 3*1024*1024; // for debug to meet boundary
 
                if(reset_memhole) {
-                       if(mem_hole.node_id!=-1) { // We need to select HW_MEM_HOLE_SIZEK for raminit, it can not make hole_startk to some basek too....!
+                       if(mem_hole.node_id!=-1) { // We need to select CONFIG_HW_MEM_HOLE_SIZEK for raminit, it can not make hole_startk to some basek too....!
                               // We need to reset our Mem Hole, because We want more big HOLE than we already set
                               //Before that We need to disable mem hole at first, becase memhole could already be set on i+1 instead
                                disable_hoist_memory(mem_hole.hole_startk, mem_hole.node_id);
                        }
 
-               #if HW_MEM_HOLE_SIZE_AUTO_INC == 1
+               #if CONFIG_HW_MEM_HOLE_SIZE_AUTO_INC == 1
                        //We need to double check if the mmio_basek is valid for hole setting, if it is equal to basek, we need to decrease it some
                        uint32_t basek_pri;
-                       for (i = 0; i < 8; i++) {
+                       for (i = 0; i < fx_devs; i++) {
                                uint32_t base;
                                uint32_t basek;
                                base  = f1_read_config32(0x40 + (i << 3));
@@ -1035,14 +975,14 @@ static void pci_domain_set_resources(device_t dev)
                #endif
                }
 
-#if K8_REV_F_SUPPORT == 0
+#if CONFIG_K8_REV_F_SUPPORT == 0
        } // is_cpu_pre_e0
 #endif
 
 #endif
 
        idx = 0x10;
-       for(i = 0; i < 8; i++) {
+       for(i = 0; i < fx_devs; i++) {
                uint32_t base, limit;
                unsigned basek, limitk, sizek;
                base  = f1_read_config32(0x40 + (i << 3));
@@ -1064,7 +1004,13 @@ static void pci_domain_set_resources(device_t dev)
                }
 
 
-//             printk_debug("node %d : mmio_basek=%08x, basek=%08x, limitk=%08x\n", i, mmio_basek, basek, limitk); //yhlu
+#if CONFIG_GFXUMA == 1
+               printk(BIOS_DEBUG, "node %d : uma_memory_base/1024=0x%08x, mmio_basek=0x%08x, basek=0x%08x, limitk=0x%08x\n", i, uma_memory_base >> 10, mmio_basek, basek, limitk);
+               if ((uma_memory_base >> 10) < mmio_basek)
+                       printk(BIOS_ALERT, "node %d: UMA memory starts below mmio_basek\n", i);
+#else
+//             printk(BIOS_DEBUG, "node %d : mmio_basek=%08x, basek=%08x, limitk=%08x\n", i, mmio_basek, basek, limitk); //yhlu
+#endif
 
                /* See if I need to split the region to accomodate pci memory space */
                if ( (basek < 4*1024*1024 ) && (limitk > mmio_basek) ) {
@@ -1075,10 +1021,23 @@ static void pci_domain_set_resources(device_t dev)
                                        ram_resource(dev, (idx | i), basek, pre_sizek);
                                        idx += 0x10;
                                        sizek -= pre_sizek;
+#if CONFIG_WRITE_HIGH_TABLES==1
+                                       if (i==0 && high_tables_base==0) {
+                                       /* Leave some space for ACPI, PIRQ and MP tables */
+#if CONFIG_GFXUMA == 1
+                                               high_tables_base = uma_memory_base - (HIGH_TABLES_SIZE * 1024);
+#else
+                                               high_tables_base = (mmio_basek - HIGH_TABLES_SIZE) * 1024;
+#endif
+                                               high_tables_size = HIGH_TABLES_SIZE * 1024;
+                                               printk(BIOS_DEBUG, " split: %dK table at =%08llx\n", HIGH_TABLES_SIZE,
+                                                            high_tables_base);
+                                       }
+#endif
                                }
-                               #if HW_MEM_HOLE_SIZEK != 0
+                               #if CONFIG_HW_MEM_HOLE_SIZEK != 0
                                if(reset_memhole)
-                                       #if K8_REV_F_SUPPORT == 0
+                                       #if CONFIG_K8_REV_F_SUPPORT == 0
                                        if(!is_cpu_pre_e0() )
                                        #endif
                                                 sizek += hoist_memory(mmio_basek,i);
@@ -1094,13 +1053,31 @@ static void pci_domain_set_resources(device_t dev)
                                sizek -= (4*1024*1024 - mmio_basek);
                        }
                }
-               ram_resource(dev, (idx | i), basek, sizek);
+               /* If sizek == 0, it was split at mmio_basek without a hole.
+                * Don't create an empty ram_resource.
+                */
+               if (sizek)
+                       ram_resource(dev, (idx | i), basek, sizek);
                idx += 0x10;
+#if CONFIG_WRITE_HIGH_TABLES==1
+               printk(BIOS_DEBUG, "%d: mmio_basek=%08lx, basek=%08x, limitk=%08x\n",
+                            i, mmio_basek, basek, limitk);
+               if (i==0 && high_tables_base==0) {
+               /* Leave some space for ACPI, PIRQ and MP tables */
+#if CONFIG_GFXUMA == 1
+                       high_tables_base = uma_memory_base - (HIGH_TABLES_SIZE * 1024);
+#else
+                       high_tables_base = (limitk - HIGH_TABLES_SIZE) * 1024;
+#endif
+                       high_tables_size = HIGH_TABLES_SIZE * 1024;
+               }
+#endif
        }
        assign_resources(&dev->link[0]);
+
 }
 
-static unsigned int pci_domain_scan_bus(device_t dev, unsigned int max)
+static unsigned int amdk8_domain_scan_bus(device_t dev, unsigned int max)
 {
        unsigned reg;
        int i;
@@ -1114,7 +1091,7 @@ static unsigned int pci_domain_scan_bus(device_t dev, unsigned int max)
         * Including enabling relaxed ordering if it is safe.
         */
        get_fx_devs();
-       for(i = 0; i < FX_DEVS; i++) {
+       for(i = 0; i < fx_devs; i++) {
                device_t f0_dev;
                f0_dev = __f0_dev[i];
                if (f0_dev && f0_dev->enabled) {
@@ -1124,7 +1101,7 @@ static unsigned int pci_domain_scan_bus(device_t dev, unsigned int max)
                        if (!dev->link[0].disable_relaxed_ordering) {
                                httc |= HTTC_RSP_PASS_PW;
                        }
-                       printk_spew("%s passpw: %s\n",
+                       printk(BIOS_SPEW, "%s passpw: %s\n",
                                dev_path(dev),
                                (!dev->link[0].disable_relaxed_ordering)?
                                "enabled":"disabled");
@@ -1135,11 +1112,11 @@ static unsigned int pci_domain_scan_bus(device_t dev, unsigned int max)
 }
 
 static struct device_operations pci_domain_ops = {
-       .read_resources   = pci_domain_read_resources,
-       .set_resources    = pci_domain_set_resources,
+       .read_resources   = amdk8_domain_read_resources,
+       .set_resources    = amdk8_domain_set_resources,
        .enable_resources = enable_childrens_resources,
        .init             = 0,
-       .scan_bus         = pci_domain_scan_bus,
+       .scan_bus         = amdk8_domain_scan_bus,
        .ops_pci_bus      = &pci_cf8_conf1,
 };
 
@@ -1186,7 +1163,7 @@ static unsigned int cpu_bus_scan(device_t dev, unsigned int max)
                sysconf.enabled_apic_ext_id = 1;
                if(bsp_apicid == 0) {
                        /* bsp apic id is not changed */
-                       sysconf.apicid_offset = APIC_ID_OFFSET;
+                       sysconf.apicid_offset = CONFIG_APIC_ID_OFFSET;
                } else
                {
                        sysconf.lift_bsp_apicid = 1;
@@ -1197,20 +1174,20 @@ static unsigned int cpu_bus_scan(device_t dev, unsigned int max)
        /* Find which cpus are present */
        cpu_bus = &dev->link[0];
        for(i = 0; i < sysconf.nodes; i++) {
-               device_t dev, cpu;
+               device_t cpu_dev, cpu;
                struct device_path cpu_path;
 
                /* Find the cpu's pci device */
-               dev = dev_find_slot(0, PCI_DEVFN(0x18 + i, 3));
-               if (!dev) {
+               cpu_dev = dev_find_slot(0, PCI_DEVFN(0x18 + i, 3));
+               if (!cpu_dev) {
                        /* If I am probing things in a weird order
                         * ensure all of the cpu's pci devices are found.
                         */
-                       int j;
+                       int local_j;
                        device_t dev_f0;
-                       for(j = 0; j <= 3; j++) {
-                               dev = pci_probe_dev(NULL, dev_mc->bus,
-                                       PCI_DEVFN(0x18 + i, j));
+                       for(local_j = 0; local_j <= 3; local_j++) {
+                               cpu_dev = pci_probe_dev(NULL, dev_mc->bus,
+                                       PCI_DEVFN(0x18 + i, local_j));
                        }
                        /* Ok, We need to set the links for that device.
                         * otherwise the device under it will not be scanned
@@ -1218,19 +1195,19 @@ static unsigned int cpu_bus_scan(device_t dev, unsigned int max)
                        dev_f0 = dev_find_slot(0, PCI_DEVFN(0x18+i,0));
                        if(dev_f0) {
                                dev_f0->links = 3;
-                               for(j=0;j<3;j++) {
-                                       dev_f0->link[j].link = j;
-                                       dev_f0->link[j].dev = dev_f0;
+                               for(local_j=0;local_j<3;local_j++) {
+                                       dev_f0->link[local_j].link = local_j;
+                                       dev_f0->link[local_j].dev = dev_f0;
                                }
                        }
 
                }
 
                e0_later_single_core = 0;
-               if (dev && dev->enabled) {
-                       j = pci_read_config32(dev, 0xe8);
+               if (cpu_dev && cpu_dev->enabled) {
+                       j = pci_read_config32(cpu_dev, 0xe8);
                        j = (j >> 12) & 3; // dev is func 3
-                       printk_debug("  %s siblings=%d\n", dev_path(dev), j);
+                       printk(BIOS_DEBUG, "  %s siblings=%d\n", dev_path(cpu_dev), j);
 
                        if(nb_cfg_54) {
                                // For e0 single core if nb_cfg_54 is set, apicid will be 0, 2, 4....
@@ -1238,7 +1215,7 @@ static unsigned int cpu_bus_scan(device_t dev, unsigned int max)
                                // That is the typical case
 
                                if(j == 0 ){
-                                      #if K8_REV_F_SUPPORT == 0
+                                      #if CONFIG_K8_REV_F_SUPPORT == 0
                                        e0_later_single_core = is_e0_later_in_bsp(i);  // single core
                                       #else
                                        e0_later_single_core = is_cpu_f0_in_bsp(i);  // We can read cpuid(1) from Func3
@@ -1247,7 +1224,7 @@ static unsigned int cpu_bus_scan(device_t dev, unsigned int max)
                                       e0_later_single_core = 0;
                                }
                                if(e0_later_single_core) {
-                                       printk_debug("\tFound Rev E or Rev F later single core\r\n");
+                                       printk(BIOS_DEBUG, "\tFound Rev E or Rev F later single core\r\n");
 
                                        j=1;
                                }
@@ -1277,13 +1254,13 @@ static unsigned int cpu_bus_scan(device_t dev, unsigned int max)
 
                        /* Build the cpu device path */
                        cpu_path.type = DEVICE_PATH_APIC;
-                       cpu_path.u.apic.apic_id = i * (nb_cfg_54?(siblings+1):1) + j * (nb_cfg_54?1:8);
+                       cpu_path.apic.apic_id = i * (nb_cfg_54?(siblings+1):1) + j * (nb_cfg_54?1:8);
 
                        /* See if I can find the cpu */
                        cpu = find_dev_path(cpu_bus, &cpu_path);
 
                        /* Enable the cpu if I have the processor */
-                       if (dev && dev->enabled) {
+                       if (cpu_dev && cpu_dev->enabled) {
                                if (!cpu) {
                                        cpu = alloc_dev(cpu_bus, &cpu_path);
                                }
@@ -1293,24 +1270,24 @@ static unsigned int cpu_bus_scan(device_t dev, unsigned int max)
                        }
 
                        /* Disable the cpu if I don't have the processor */
-                       if (cpu && (!dev || !dev->enabled)) {
+                       if (cpu && (!cpu_dev || !cpu_dev->enabled)) {
                                cpu->enabled = 0;
                        }
 
                        /* Report what I have done */
                        if (cpu) {
-                               cpu->path.u.apic.node_id = i;
-                               cpu->path.u.apic.core_id = j;
+                               cpu->path.apic.node_id = i;
+                               cpu->path.apic.core_id = j;
                                if(sysconf.enabled_apic_ext_id) {
                                        if(sysconf.lift_bsp_apicid) {
-                                               cpu->path.u.apic.apic_id += sysconf.apicid_offset;
+                                               cpu->path.apic.apic_id += sysconf.apicid_offset;
                                        } else
                                        {
-                                              if (cpu->path.u.apic.apic_id != 0)
-                                                      cpu->path.u.apic.apic_id += sysconf.apicid_offset;
+                                              if (cpu->path.apic.apic_id != 0)
+                                                      cpu->path.apic.apic_id += sysconf.apicid_offset;
                                        }
                                }
-                               printk_debug("CPU: %s %s\n",
+                               printk(BIOS_DEBUG, "CPU: %s %s\n",
                                        dev_path(cpu), cpu->enabled?"enabled":"disabled");
                        }