remove astray char
[mono.git] / mono / mini / mini-x86.c
index 7c9c529f2fae4fe1040f8b92281e878e4518a8a1..d23083d2c9bad4eb71c453588ac26f80cb8886d5 100644 (file)
 #include <mono/metadata/profiler-private.h>
 #include <mono/utils/mono-math.h>
 
-#ifdef HAVE_VALGRIND_MEMCHECK_H
-#include <valgrind/memcheck.h>
-#endif
-
 #include "trace.h"
 #include "mini-x86.h"
 #include "inssel.h"
@@ -247,7 +243,7 @@ mono_arch_get_allocatable_int_vars (MonoCompile *cfg)
                MonoMethodVar *vmv = MONO_VARINFO (cfg, i);
 
                /* unused vars */
-               if (vmv->range.first_use.abs_pos > vmv->range.last_use.abs_pos)
+               if (vmv->range.first_use.abs_pos >= vmv->range.last_use.abs_pos)
                        continue;
 
                if ((ins->flags & (MONO_INST_IS_DEAD|MONO_INST_VOLATILE|MONO_INST_INDIRECT)) || 
@@ -282,6 +278,26 @@ mono_arch_get_global_int_regs (MonoCompile *cfg)
 
        return regs;
 }
+
+/*
+ * mono_arch_regalloc_cost:
+ *
+ *  Return the cost, in number of memory references, of the action of 
+ * allocating the variable VMV into a register during global register
+ * allocation.
+ */
+guint32
+mono_arch_regalloc_cost (MonoCompile *cfg, MonoMethodVar *vmv)
+{
+       MonoInst *ins = cfg->varinfo [vmv->idx];
+
+       if (cfg->method->save_lmf)
+               /* The register is already saved */
+               return (ins->opcode == OP_ARG) ? 1 : 0;
+       else
+               /* push+pop+possible load if it is an argument */
+               return (ins->opcode == OP_ARG) ? 3 : 2;
+}
  
 /*
  * Set var information according to the calling convention. X86 version.
@@ -1292,6 +1308,7 @@ mono_arch_local_regalloc (MonoCompile *cfg, MonoBasicBlock *bb)
        /* forward pass on the instructions to collect register liveness info */
        while (ins) {
                spec = ins_spec [ins->opcode];
+               
                DEBUG (print_ins (i, ins));
 
                if (spec [MONO_INST_SRC1]) {
@@ -2070,9 +2087,15 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                case OP_X86_ADD_MEMBASE_IMM:
                        x86_alu_membase_imm (code, X86_ADD, ins->inst_basereg, ins->inst_offset, ins->inst_imm);
                        break;
+               case OP_X86_ADD_MEMBASE:
+                       x86_alu_reg_membase (code, X86_ADD, ins->sreg1, ins->sreg2, ins->inst_offset);
+                       break;
                case OP_X86_SUB_MEMBASE_IMM:
                        x86_alu_membase_imm (code, X86_SUB, ins->inst_basereg, ins->inst_offset, ins->inst_imm);
                        break;
+               case OP_X86_SUB_MEMBASE:
+                       x86_alu_reg_membase (code, X86_SUB, ins->sreg1, ins->sreg2, ins->inst_offset);
+                       break;
                case OP_X86_INC_MEMBASE:
                        x86_inc_membase (code, ins->inst_basereg, ins->inst_offset);
                        break;
@@ -2085,6 +2108,9 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                case OP_X86_DEC_REG:
                        x86_dec_reg (code, ins->dreg);
                        break;
+               case OP_X86_MUL_MEMBASE:
+                       x86_imul_reg_membase (code, ins->sreg1, ins->sreg2, ins->inst_offset);
+                       break;
                case CEE_BREAK:
                        x86_breakpoint (code);
                        break;
@@ -2230,12 +2256,12 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                        }
                        x86_mul_reg (code, non_eax_reg, FALSE);
                        /* save before the check since pop and mov don't change the flags */
+                       if (ins->dreg != X86_EAX)
+                               x86_mov_reg_reg (code, ins->dreg, X86_EAX, 4);
                        if (saved_edx)
                                x86_pop_reg (code, X86_EDX);
                        if (saved_eax)
                                x86_pop_reg (code, X86_EAX);
-                       if (ins->dreg != X86_EAX)
-                               x86_mov_reg_reg (code, ins->dreg, X86_EAX, 4);
                        EMIT_COND_SYSTEM_EXCEPTION (X86_CC_O, FALSE, "OverflowException");
                        break;
                }
@@ -2247,10 +2273,11 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                        x86_mov_reg_imm (code, ins->dreg, 0);
                        break;
                case CEE_CONV_I4:
-               case CEE_CONV_U4:
                case OP_MOVE:
                        x86_mov_reg_reg (code, ins->dreg, ins->sreg1, 4);
                        break;
+               case CEE_CONV_U4:
+                       g_assert_not_reached ();
                case CEE_JMP: {
                        /*
                         * Note: this 'frame destruction' logic is useful for tail calls, too.
@@ -2655,7 +2682,7 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                        x86_push_reg (code, X86_EAX);
                        x86_fptan (code);
                        x86_fnstsw (code);
-                       x86_test_reg_imm (code, X86_EAX, 0x400);
+                       x86_test_reg_imm (code, X86_EAX, X86_FP_C2);
                        check_pos = code;
                        x86_branch8 (code, X86_CC_NE, 0, FALSE);
                        x86_fstp (code, 0); /* pop the 1.0 */
@@ -2666,7 +2693,7 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                        x86_fxch (code, 1);
                        x86_fprem1 (code);
                        x86_fstsw (code);
-                       x86_test_reg_imm (code, X86_EAX, 0x400);
+                       x86_test_reg_imm (code, X86_EAX, X86_FP_C2);
                        pop_jump = code;
                        x86_branch8 (code, X86_CC_NE, 0, FALSE);
                        x86_fstp (code, 1);
@@ -2702,7 +2729,7 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                        /* x86_fprem1 (code); */
                        x86_fprem (code);
                        x86_fnstsw (code);
-                       x86_alu_reg_imm (code, X86_AND, X86_EAX, 0x0400);
+                       x86_alu_reg_imm (code, X86_AND, X86_EAX, X86_FP_C2);
                        l2 = code + 2;
                        x86_branch8 (code, X86_CC_NE, l1 - l2, FALSE);
 
@@ -2720,7 +2747,7 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                        }
                        /* this overwrites EAX */
                        EMIT_FPCOMPARE(code);
-                       x86_alu_reg_imm (code, X86_AND, X86_EAX, 0x4500);
+                       x86_alu_reg_imm (code, X86_AND, X86_EAX, X86_FP_CC_MASK);
                        break;
                case OP_FCEQ:
                        if (cfg->opt & MONO_OPT_FCMOV) {
@@ -2741,7 +2768,7 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                                x86_push_reg (code, X86_EAX);
 
                        EMIT_FPCOMPARE(code);
-                       x86_alu_reg_imm (code, X86_AND, X86_EAX, 0x4500);
+                       x86_alu_reg_imm (code, X86_AND, X86_EAX, X86_FP_CC_MASK);
                        x86_alu_reg_imm (code, X86_CMP, X86_EAX, 0x4000);
                        x86_set_reg (code, X86_CC_EQ, ins->dreg, TRUE);
                        x86_widen_reg (code, ins->dreg, ins->dreg, FALSE, FALSE);
@@ -2777,7 +2804,7 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                                x86_push_reg (code, X86_EAX);
 
                        EMIT_FPCOMPARE(code);
-                       x86_alu_reg_imm (code, X86_AND, X86_EAX, 0x4500);
+                       x86_alu_reg_imm (code, X86_AND, X86_EAX, X86_FP_CC_MASK);
                        if (ins->opcode == OP_FCLT_UN) {
                                guchar *is_not_zero_check, *end_jump;
                                is_not_zero_check = code;
@@ -2785,7 +2812,7 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                                end_jump = code;
                                x86_jump8 (code, 0);
                                x86_patch (is_not_zero_check, code);
-                               x86_alu_reg_imm (code, X86_CMP, X86_EAX, 0x4500);
+                               x86_alu_reg_imm (code, X86_CMP, X86_EAX, X86_FP_CC_MASK);
 
                                x86_patch (end_jump, code);
                        }
@@ -2819,8 +2846,8 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                                x86_push_reg (code, X86_EAX);
 
                        EMIT_FPCOMPARE(code);
-                       x86_alu_reg_imm (code, X86_AND, X86_EAX, 0x4500);
-                       x86_alu_reg_imm (code, X86_CMP, X86_EAX, 0x0100);
+                       x86_alu_reg_imm (code, X86_AND, X86_EAX, X86_FP_CC_MASK);
+                       x86_alu_reg_imm (code, X86_CMP, X86_EAX, X86_FP_C0);
                        if (ins->opcode == OP_FCGT_UN) {
                                guchar *is_not_zero_check, *end_jump;
                                is_not_zero_check = code;
@@ -2828,7 +2855,7 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                                end_jump = code;
                                x86_jump8 (code, 0);
                                x86_patch (is_not_zero_check, code);
-                               x86_alu_reg_imm (code, X86_CMP, X86_EAX, 0x4500);
+                               x86_alu_reg_imm (code, X86_CMP, X86_EAX, X86_FP_CC_MASK);
 
                                x86_patch (end_jump, code);
                        }
@@ -2850,12 +2877,15 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                        EMIT_COND_BRANCH (ins, X86_CC_EQ, TRUE);
                        break;
                case OP_FBNE_UN:
+                       /* Branch if C013 != 100 */
                        if (cfg->opt & MONO_OPT_FCMOV) {
-                               EMIT_COND_BRANCH (ins, X86_CC_P, FALSE);
+                               /* branch if !ZF or (PF|CF) */
                                EMIT_COND_BRANCH (ins, X86_CC_NE, FALSE);
+                               EMIT_COND_BRANCH (ins, X86_CC_P, FALSE);
+                               EMIT_COND_BRANCH (ins, X86_CC_B, FALSE);
                                break;
                        }
-                       x86_alu_reg_imm (code, X86_CMP, X86_EAX, 0x4000);
+                       x86_alu_reg_imm (code, X86_CMP, X86_EAX, X86_FP_C3);
                        EMIT_COND_BRANCH (ins, X86_CC_NE, FALSE);
                        break;
                case OP_FBLT:
@@ -2878,7 +2908,7 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                                end_jump = code;
                                x86_jump8 (code, 0);
                                x86_patch (is_not_zero_check, code);
-                               x86_alu_reg_imm (code, X86_CMP, X86_EAX, 0x4500);
+                               x86_alu_reg_imm (code, X86_CMP, X86_EAX, X86_FP_CC_MASK);
 
                                x86_patch (end_jump, code);
                        }
@@ -2890,7 +2920,7 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                                EMIT_COND_BRANCH (ins, X86_CC_LT, FALSE);
                                break;
                        }
-                       x86_alu_reg_imm (code, X86_CMP, X86_EAX, 0x0100);
+                       x86_alu_reg_imm (code, X86_CMP, X86_EAX, X86_FP_C0);
                        if (ins->opcode == OP_FBGT_UN) {
                                guchar *is_not_zero_check, *end_jump;
                                is_not_zero_check = code;
@@ -2898,14 +2928,32 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                                end_jump = code;
                                x86_jump8 (code, 0);
                                x86_patch (is_not_zero_check, code);
-                               x86_alu_reg_imm (code, X86_CMP, X86_EAX, 0x4500);
+                               x86_alu_reg_imm (code, X86_CMP, X86_EAX, X86_FP_CC_MASK);
 
                                x86_patch (end_jump, code);
                        }
                        EMIT_COND_BRANCH (ins, X86_CC_EQ, FALSE);
                        break;
                case OP_FBGE:
+                       /* Branch if C013 == 100 or 001 */
+                       if (cfg->opt & MONO_OPT_FCMOV) {
+                               guchar *br1;
+
+                               /* skip branch if C1=1 */
+                               br1 = code;
+                               x86_branch8 (code, X86_CC_P, 0, FALSE);
+                               /* branch if (C0 | C3) = 1 */
+                               EMIT_COND_BRANCH (ins, X86_CC_BE, FALSE);
+                               x86_patch (br1, code);
+                               break;
+                       }
+                       x86_alu_reg_imm (code, X86_CMP, X86_EAX, X86_FP_C0);
+                       EMIT_COND_BRANCH (ins, X86_CC_EQ, FALSE);
+                       x86_alu_reg_imm (code, X86_CMP, X86_EAX, X86_FP_C3);
+                       EMIT_COND_BRANCH (ins, X86_CC_EQ, FALSE);
+                       break;
                case OP_FBGE_UN:
+                       /* Branch if C013 == 000 */
                        if (cfg->opt & MONO_OPT_FCMOV) {
                                EMIT_COND_BRANCH (ins, X86_CC_LE, FALSE);
                                break;
@@ -2913,13 +2961,30 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                        EMIT_COND_BRANCH (ins, X86_CC_NE, FALSE);
                        break;
                case OP_FBLE:
+                       /* Branch if C013=000 or 100 */
+                       if (cfg->opt & MONO_OPT_FCMOV) {
+                               guchar *br1;
+
+                               /* skip branch if C1=1 */
+                               br1 = code;
+                               x86_branch8 (code, X86_CC_P, 0, FALSE);
+                               /* branch if C0=0 */
+                               EMIT_COND_BRANCH (ins, X86_CC_NB, FALSE);
+                               x86_patch (br1, code);
+                               break;
+                       }
+                       x86_alu_reg_imm (code, X86_AND, X86_EAX, (X86_FP_C0|X86_FP_C1));
+                       x86_alu_reg_imm (code, X86_CMP, X86_EAX, 0);
+                       EMIT_COND_BRANCH (ins, X86_CC_EQ, FALSE);
+                       break;
                case OP_FBLE_UN:
+                       /* Branch if C013 != 001 */
                        if (cfg->opt & MONO_OPT_FCMOV) {
                                EMIT_COND_BRANCH (ins, X86_CC_P, FALSE);
                                EMIT_COND_BRANCH (ins, X86_CC_GE, FALSE);
                                break;
                        }
-                       x86_alu_reg_imm (code, X86_CMP, X86_EAX, 0x0100);
+                       x86_alu_reg_imm (code, X86_CMP, X86_EAX, X86_FP_C0);
                        EMIT_COND_BRANCH (ins, X86_CC_NE, FALSE);
                        break;
                case CEE_CKFINITE: {
@@ -2927,7 +2992,7 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
                        x86_fxam (code);
                        x86_fnstsw (code);
                        x86_alu_reg_imm (code, X86_AND, X86_EAX, 0x4100);
-                       x86_alu_reg_imm (code, X86_CMP, X86_EAX, 0x0100);
+                       x86_alu_reg_imm (code, X86_CMP, X86_EAX, X86_FP_C0);
                        x86_pop_reg (code, X86_EAX);
                        EMIT_COND_SYSTEM_EXCEPTION (X86_CC_EQ, FALSE, "ArithmeticException");
                        break;
@@ -2967,135 +3032,49 @@ mono_arch_patch_code (MonoMethod *method, MonoDomain *domain, guint8 *code, Mono
 
        for (patch_info = ji; patch_info; patch_info = patch_info->next) {
                unsigned char *ip = patch_info->ip.i + code;
-               const unsigned char *target = NULL;
+               const unsigned char *target;
+
+               target = mono_resolve_patch_target (method, domain, code, patch_info, run_cctors);
 
                switch (patch_info->type) {
-               case MONO_PATCH_INFO_BB:
-                       target = patch_info->data.bb->native_offset + code;
-                       break;
-               case MONO_PATCH_INFO_ABS:
-                       target = patch_info->data.target;
-                       break;
-               case MONO_PATCH_INFO_LABEL:
-                       target = patch_info->data.inst->inst_c0 + code;
-                       break;
                case MONO_PATCH_INFO_IP:
-                       *((gpointer *)(ip)) = ip;
+                       *((gconstpointer *)(ip)) = target;
                        continue;
                case MONO_PATCH_INFO_METHOD_REL:
-                       *((gpointer *)(ip)) = code + patch_info->data.offset;
+                       *((gconstpointer *)(ip)) = target;
                        continue;
-               case MONO_PATCH_INFO_INTERNAL_METHOD: {
-                       MonoJitICallInfo *mi = mono_find_jit_icall_by_name (patch_info->data.name);
-                       if (!mi) {
-                               g_warning ("unknown MONO_PATCH_INFO_INTERNAL_METHOD %s", patch_info->data.name);
-                               g_assert_not_reached ();
-                       }
-                       target = mono_icall_get_wrapper (mi);
-                       break;
-               }
-               case MONO_PATCH_INFO_METHOD_JUMP: {
-                       GSList *list;
-
-                       /* get the trampoline to the method from the domain */
-                       target = mono_create_jump_trampoline (domain, patch_info->data.method, TRUE);
-                       if (!domain->jump_target_hash)
-                               domain->jump_target_hash = g_hash_table_new (NULL, NULL);
-                       list = g_hash_table_lookup (domain->jump_target_hash, patch_info->data.method);
-                       list = g_slist_prepend (list, ip);
-                       g_hash_table_insert (domain->jump_target_hash, patch_info->data.method, list);
-                       break;
-               }
-               case MONO_PATCH_INFO_METHOD:
-                       if (patch_info->data.method == method) {
-                               target = code;
-                       } else
-                               /* get the trampoline to the method from the domain */
-                               target = mono_arch_create_jit_trampoline (patch_info->data.method);
-                       break;
                case MONO_PATCH_INFO_SWITCH: {
-                       gpointer *jump_table = mono_code_manager_reserve (domain->code_mp, sizeof (gpointer) * patch_info->table_size);
-                       int i;
-
-                       *((gconstpointer *)(ip + 2)) = jump_table;
-
-                       for (i = 0; i < patch_info->table_size; i++) {
-                               jump_table [i] = code + (int)patch_info->data.table [i];
-                       }
+                       *((gconstpointer *)(ip + 2)) = target;
                        /* we put into the table the absolute address, no need for x86_patch in this case */
                        continue;
                }
-               case MONO_PATCH_INFO_METHODCONST:
-               case MONO_PATCH_INFO_CLASS:
-               case MONO_PATCH_INFO_IMAGE:
-               case MONO_PATCH_INFO_FIELD:
-                       *((gconstpointer *)(ip + 1)) = patch_info->data.target;
-                       continue;
                case MONO_PATCH_INFO_IID:
-                       mono_class_init (patch_info->data.klass);
-                       *((guint32 *)(ip + 1)) = patch_info->data.klass->interface_id;
+                       *((guint32 *)(ip + 1)) = (guint32)target;
                        continue;                       
-               case MONO_PATCH_INFO_VTABLE:
-                       *((gconstpointer *)(ip + 1)) = mono_class_vtable (domain, patch_info->data.klass);
-                       continue;
                case MONO_PATCH_INFO_CLASS_INIT: {
                        guint8 *code = ip;
                        /* Might already been changed to a nop */
                        x86_call_imm (code, 0);
-                       target = mono_create_class_init_trampoline (mono_class_vtable (domain, patch_info->data.klass));
                        break;
                }
-               case MONO_PATCH_INFO_SFLDA: {
-                       MonoVTable *vtable = mono_class_vtable (domain, patch_info->data.field->parent);
-                       if (!vtable->initialized && !(vtable->klass->flags & TYPE_ATTRIBUTE_BEFORE_FIELD_INIT) && mono_class_needs_cctor_run (vtable->klass, method))
-                               /* Done by the generated code */
-                               ;
-                       else {
-                               if (run_cctors)
-                                       mono_runtime_class_init (vtable);
-                       }
-                       *((gconstpointer *)(ip + 1)) = 
-                               (char*)vtable->data + patch_info->data.field->offset;
-                       continue;
-               }
                case MONO_PATCH_INFO_R4:
                case MONO_PATCH_INFO_R8:
-                       *((gconstpointer *)(ip + 2)) = patch_info->data.target;
+                       *((gconstpointer *)(ip + 2)) = target;
                        continue;
+               case MONO_PATCH_INFO_METHODCONST:
+               case MONO_PATCH_INFO_CLASS:
+               case MONO_PATCH_INFO_IMAGE:
+               case MONO_PATCH_INFO_FIELD:
+               case MONO_PATCH_INFO_VTABLE:
+               case MONO_PATCH_INFO_SFLDA:
                case MONO_PATCH_INFO_EXC_NAME:
-                       *((gconstpointer *)(ip + 1)) = patch_info->data.name;
-                       continue;
                case MONO_PATCH_INFO_LDSTR:
-                       *((gconstpointer *)(ip + 1)) = 
-                               mono_ldstr (domain, patch_info->data.token->image, 
-                                                       mono_metadata_token_index (patch_info->data.token->token));
-                       continue;
-               case MONO_PATCH_INFO_TYPE_FROM_HANDLE: {
-                       gpointer handle;
-                       MonoClass *handle_class;
-
-                       handle = mono_ldtoken (patch_info->data.token->image, 
-                                                                  patch_info->data.token->token, &handle_class);
-                       mono_class_init (handle_class);
-                       mono_class_init (mono_class_from_mono_type (handle));
-
-                       *((gconstpointer *)(ip + 1)) = 
-                               mono_type_get_object (domain, handle);
-                       continue;
-               }
-               case MONO_PATCH_INFO_LDTOKEN: {
-                       gpointer handle;
-                       MonoClass *handle_class;
-
-                       handle = mono_ldtoken (patch_info->data.token->image,
-                                                                  patch_info->data.token->token, &handle_class);
-                       mono_class_init (handle_class);
-
-                       *((gconstpointer *)(ip + 1)) = handle;
+               case MONO_PATCH_INFO_TYPE_FROM_HANDLE:
+               case MONO_PATCH_INFO_LDTOKEN:
+                       *((gconstpointer *)(ip + 1)) = target;
                        continue;
-               }
                default:
-                       g_assert_not_reached ();
+                       break;
                }
                x86_patch (ip, target);
        }
@@ -3338,15 +3317,13 @@ mono_arch_emit_epilog (MonoCompile *cfg)
        x86_leave (code);
 
        if (CALLCONV_IS_STDCALL (sig->call_convention)) {
-         MonoJitArgumentInfo *arg_info = alloca (sizeof (MonoJitArgumentInfo) * (sig->param_count + 1));
+               MonoJitArgumentInfo *arg_info = alloca (sizeof (MonoJitArgumentInfo) * (sig->param_count + 1));
 
-         stack_to_pop = mono_arch_get_argument_info (sig, sig->param_count, arg_info);
-       }
-       else
-       if (MONO_TYPE_ISSTRUCT (cfg->method->signature->ret))
-         stack_to_pop = 4;
+               stack_to_pop = mono_arch_get_argument_info (sig, sig->param_count, arg_info);
+       } else if (MONO_TYPE_ISSTRUCT (cfg->method->signature->ret))
+               stack_to_pop = 4;
        else
-         stack_to_pop = 0;
+               stack_to_pop = 0;
 
        if (stack_to_pop)
                x86_ret_imm (code, stack_to_pop);
@@ -3410,7 +3387,7 @@ mono_arch_get_lmf_addr (void)
 void
 mono_arch_setup_jit_tls_data (MonoJitTlsData *tls)
 {
-#ifndef PLATFORM_WIN32
+#ifdef MONO_ARCH_SIGSEGV_ON_ALTSTACK
        pthread_t self = pthread_self();
        pthread_attr_t attr;
        void *staddr = NULL;
@@ -3440,17 +3417,21 @@ mono_arch_setup_jit_tls_data (MonoJitTlsData *tls)
                }
        }               
 
-#ifndef PLATFORM_WIN32
+#ifdef MONO_ARCH_SIGSEGV_ON_ALTSTACK
 
        /* Determine stack boundaries */
-#ifdef HAVE_VALGRIND_MEMCHECK_H
-       if (!RUNNING_ON_VALGRIND) {
+       if (!mono_running_on_valgrind ()) {
+#ifdef HAVE_PTHREAD_GETATTR_NP
+               pthread_getattr_np( self, &attr );
+#else
+#ifdef HAVE_PTHREAD_ATTR_GET_NP
+               pthread_attr_get_np( self, &attr );
+#else
+#error "Not implemented"
 #endif
-       pthread_getattr_np( self, &attr );
-       pthread_attr_getstack( &attr, &staddr, &stsize );
-#ifdef HAVE_VALGRIND_MEMCHECK_H
-       }
 #endif
+               pthread_attr_getstack( &attr, &staddr, &stsize );
+       }
 
        /* 
         * staddr seems to be wrong for the main thread, so we keep the value in
@@ -3465,7 +3446,7 @@ mono_arch_setup_jit_tls_data (MonoJitTlsData *tls)
        sa.ss_sp = tls->signal_stack;
        sa.ss_size = SIGNAL_STACK_SIZE;
        sa.ss_flags = SS_ONSTACK;
-       sigaltstack  (&sa, NULL);
+       sigaltstack (&sa, NULL);
 #endif
 
 #ifdef HAVE_KW_THREAD
@@ -3476,7 +3457,7 @@ mono_arch_setup_jit_tls_data (MonoJitTlsData *tls)
 void
 mono_arch_free_jit_tls_data (MonoJitTlsData *tls)
 {
-#ifndef PLATFORM_WIN32
+#ifdef MONO_ARCH_SIGSEGV_ON_ALTSTACK
        struct sigaltstack sa;
 
        sa.ss_sp = tls->signal_stack;