Merge pull request #1419 from directhex/bump_msvc_VERSION
[mono.git] / mono / mini / aot-compiler.c
index 70e11b7730f483f97e20093d88d33800cdbca90e..44812084153173ded322f433b649682b9cae6fe0 100644 (file)
  * Copyright 2011 Xamarin Inc (http://www.xamarin.com)
  */
 
-/* Remaining AOT-only work:
- * - optimize the trampolines, generate more code in the arch files.
- * - make things more consistent with how elf works, for example, use ELF 
- *   relocations.
- * Remaining generics sharing work:
- * - optimize the size of the data which is encoded.
- * - optimize the runtime loading of data:
- *   - the trampoline code calls mono_jit_info_table_find () to find the rgctx, 
- *     which loads the debugging+exception handling info for the method. This is a 
- *     huge waste of time and code, since the rgctx structure is currently empty.
- */
 #include "config.h"
 #include <sys/types.h>
 #ifdef HAVE_UNISTD_H
@@ -42,7 +31,6 @@
 #include <errno.h>
 #include <sys/stat.h>
 
-
 #include <mono/metadata/abi-details.h>
 #include <mono/metadata/tabledefs.h>
 #include <mono/metadata/class.h>
@@ -1274,6 +1262,11 @@ arch_emit_specific_trampoline_pages (MonoAotCompile *acfg)
                g_assert (code - buf == 8);
                emit_bytes (acfg, buf, code - buf);
        }
+
+       acfg->tramp_page_code_offsets [MONO_AOT_TRAMP_SPECIFIC] = 16;
+       acfg->tramp_page_code_offsets [MONO_AOT_TRAMP_STATIC_RGCTX] = 16;
+       acfg->tramp_page_code_offsets [MONO_AOT_TRAMP_IMT_THUNK] = 72;
+       acfg->tramp_page_code_offsets [MONO_AOT_TRAMP_GSHAREDVT_ARG] = 16;
 #elif defined(TARGET_ARM64)
        arm64_emit_specific_trampoline_pages (acfg);
 #endif
@@ -3371,8 +3364,9 @@ add_wrappers (MonoAotCompile *acfg)
                        if (info && !has_nullable) {
                                /* Supported by the dynamic runtime-invoke wrapper */
                                skip = TRUE;
-                               g_free (info);
                        }
+                       if (info)
+                               mono_arch_dyn_call_free (info);
                }
 #endif
 
@@ -4878,13 +4872,14 @@ get_debug_sym (MonoMethod *method, const char *prefix, GHashTable *cache)
        char *name1, *name2, *cached;
        int i, j, len, count;
 
+       name1 = mono_method_full_name (method, TRUE);
+
 #ifdef TARGET_MACH
        // This is so that we don't accidentally create a local symbol (which starts with 'L')
-       if (!prefix || !*prefix)
+       if ((!prefix || !*prefix) && name1 [0] == 'L')
                prefix = "_";
 #endif
 
-       name1 = mono_method_full_name (method, TRUE);
        len = strlen (name1);
        name2 = malloc (strlen (prefix) + len + 16);
        memcpy (name2, prefix, strlen (prefix));
@@ -5775,41 +5770,16 @@ emit_plt (MonoAotCompile *acfg)
                plt_entry = g_hash_table_lookup (acfg->plt_offset_to_entry, GUINT_TO_POINTER (i));
                ji = plt_entry->ji;
 
-               if (acfg->llvm) {
-                       /*
-                        * If the target is directly callable, alias the plt symbol to point to
-                        * the method code.
-                        * FIXME: Use this to simplify emit_and_reloc_code ().
-                        * FIXME: Avoid the got slot.
-                        * FIXME: Add support to the binary writer.
-                        */
-                       if (ji && is_direct_callable (acfg, NULL, ji) && !acfg->use_bin_writer) {
-                               MonoCompile *callee_cfg = g_hash_table_lookup (acfg->method_to_cfg, ji->data.method);
-
-                               if (callee_cfg) {
-                                       if (acfg->thumb_mixed && !callee_cfg->compile_llvm) {
-                                               /* LLVM calls the PLT entries using bl, so emit a stub */
-                                               emit_set_thumb_mode (acfg);
-                                               fprintf (acfg->fp, "\n.thumb_func\n");
-                                               emit_label (acfg, plt_entry->llvm_symbol);
-                                               fprintf (acfg->fp, "bx pc\n");
-                                               fprintf (acfg->fp, "nop\n");
-                                               emit_set_arm_mode (acfg);
-                                               fprintf (acfg->fp, "b %s\n", callee_cfg->asm_symbol);
-                                       } else {
-                                               fprintf (acfg->fp, "\n.set %s, %s\n", plt_entry->llvm_symbol, callee_cfg->asm_symbol);
-                                       }
-                                       continue;
-                               }
-                       }
-               }
-
                debug_sym = plt_entry->debug_sym;
 
                if (acfg->thumb_mixed && !plt_entry->jit_used)
                        /* Emit only a thumb version */
                        continue;
 
+               /* Skip plt entries not actually called */
+               if (!plt_entry->jit_used && !plt_entry->llvm_used)
+                       continue;
+
                if (acfg->llvm && !acfg->thumb_mixed)
                        emit_label (acfg, plt_entry->llvm_symbol);
 
@@ -5849,9 +5819,6 @@ emit_plt (MonoAotCompile *acfg)
                        plt_entry = g_hash_table_lookup (acfg->plt_offset_to_entry, GUINT_TO_POINTER (i));
                        ji = plt_entry->ji;
 
-                       if (ji && is_direct_callable (acfg, NULL, ji) && !acfg->use_bin_writer)
-                               continue;
-
                        /* Skip plt entries not actually called by LLVM code */
                        if (!plt_entry->llvm_used)
                                continue;
@@ -6464,9 +6431,10 @@ add_token_info_hash (gpointer key, gpointer value, gpointer user_data)
 {
        MonoMethod *method = (MonoMethod*)key;
        MonoJumpInfoToken *ji = (MonoJumpInfoToken*)value;
-       MonoJumpInfoToken *new_ji = g_new0 (MonoJumpInfoToken, 1);
        MonoAotCompile *acfg = user_data;
+       MonoJumpInfoToken *new_ji;
 
+       new_ji = mono_mempool_alloc0 (acfg->mempool, sizeof (MonoJumpInfoToken));
        new_ji->image = ji->image;
        new_ji->token = ji->token;
        g_hash_table_insert (acfg->token_info_hash, method, new_ji);
@@ -6685,6 +6653,8 @@ compile_method (MonoAotCompile *acfg, MonoMethod *method)
        mono_acfg_lock (acfg);
        g_hash_table_foreach (cfg->token_info_hash, add_token_info_hash, acfg);
        mono_acfg_unlock (acfg);
+       g_hash_table_destroy (cfg->token_info_hash);
+       cfg->token_info_hash = NULL;
 
        /*
         * Check for absolute addresses.
@@ -7023,6 +6993,21 @@ mono_aot_get_method_name (MonoCompile *cfg)
                return get_debug_sym (cfg->orig_method, "", llvm_acfg->method_label_hash);
 }
 
+gboolean
+mono_aot_is_direct_callable (MonoJumpInfo *patch_info)
+{
+       return is_direct_callable (llvm_acfg, NULL, patch_info);
+}
+
+void
+mono_aot_mark_unused_llvm_plt_entry (MonoJumpInfo *patch_info)
+{
+       MonoPltEntry *plt_entry;
+
+       plt_entry = get_plt_entry (llvm_acfg, patch_info);
+       plt_entry->llvm_used = FALSE;
+}
+
 char*
 mono_aot_get_plt_symbol (MonoJumpInfoType type, gconstpointer data)
 {
@@ -7118,7 +7103,7 @@ emit_llvm_file (MonoAotCompile *acfg)
 
 
        tempbc = g_strdup_printf ("%s.bc", acfg->tmpbasename);
-       mono_llvm_emit_aot_module (tempbc, acfg->final_got_size);
+       mono_llvm_emit_aot_module (tempbc, g_path_get_basename (acfg->image->name), acfg->final_got_size);
        g_free (tempbc);
 
        /*
@@ -8741,7 +8726,7 @@ acfg_create (MonoAssembly *ass, guint32 opts)
                acfg->patch_to_got_offset_by_type [i] = g_hash_table_new (mono_patch_info_hash, mono_patch_info_equal);
        acfg->got_patches = g_ptr_array_new ();
        acfg->method_to_cfg = g_hash_table_new (NULL, NULL);
-       acfg->token_info_hash = g_hash_table_new_full (NULL, NULL, NULL, g_free);
+       acfg->token_info_hash = g_hash_table_new_full (NULL, NULL, NULL, NULL);
        acfg->method_to_pinvoke_import = g_hash_table_new_full (NULL, NULL, NULL, g_free);
        acfg->image_hash = g_hash_table_new (NULL, NULL);
        acfg->image_table = g_ptr_array_new ();