Sat Jan 8 19:03:26 CET 2005 Paolo Molaro <lupus@ximian.com>
[mono.git] / mono / metadata / reflection.c
index 26b095d9a3140be9f31a421765b404e01f365d5f..6f2ed9414154c65f78769320161a773c299c1440 100644 (file)
@@ -43,6 +43,7 @@ typedef struct {
        MonoReflectionType *rtype;
        MonoArray *parameters;
        MonoArray *generic_params;
+       MonoGenericContainer *generic_container;
        MonoArray *pinfo;
        MonoArray *opt_types;
        guint32 attrs;
@@ -219,7 +220,6 @@ string_heap_init (MonoDynamicStream *sh)
        string_heap_insert (sh, "");
 }
 
-#if 0 /* never used */
 static void
 string_heap_free (MonoDynamicStream *sh)
 {
@@ -227,7 +227,6 @@ string_heap_free (MonoDynamicStream *sh)
        g_hash_table_foreach (sh->hash, (GHFunc)g_free, NULL);
        g_hash_table_destroy (sh->hash);
 }
-#endif
 
 static guint32
 mono_image_add_stream_data (MonoDynamicStream *stream, const char *data, guint32 len)
@@ -307,13 +306,13 @@ add_to_blob_cached (MonoDynamicImage *assembly, char *b1, int s1, char *b2, int
        copy = g_malloc (s1+s2);
        memcpy (copy, b1, s1);
        memcpy (copy + s1, b2, s2);
-       if (mono_g_hash_table_lookup_extended (assembly->blob_cache, copy, &oldkey, &oldval)) {
+       if (g_hash_table_lookup_extended (assembly->blob_cache, copy, &oldkey, &oldval)) {
                g_free (copy);
                idx = GPOINTER_TO_UINT (oldval);
        } else {
                idx = mono_image_add_stream_data (&assembly->blob, b1, s1);
                mono_image_add_stream_data (&assembly->blob, b2, s2);
-               mono_g_hash_table_insert (assembly->blob_cache, copy, GUINT_TO_POINTER (idx));
+               g_hash_table_insert (assembly->blob_cache, copy, GUINT_TO_POINTER (idx));
        }
        return idx;
 }
@@ -453,20 +452,20 @@ default_class_from_mono_type (MonoType *type)
 }
 
 static void
-encode_generic_inst (MonoDynamicImage *assembly, MonoGenericInst *ginst, char *p, char **endbuf)
+encode_generic_class (MonoDynamicImage *assembly, MonoGenericClass *gclass, char *p, char **endbuf)
 {
        int i;
 
-       if (!ginst) {
+       if (!gclass) {
                g_assert_not_reached ();
                return;
        }
 
        mono_metadata_encode_value (MONO_TYPE_GENERICINST, p, &p);
-       encode_type (assembly, ginst->generic_type, p, &p);
-       mono_metadata_encode_value (ginst->type_argc, p, &p);
-       for (i = 0; i < ginst->type_argc; ++i)
-               encode_type (assembly, ginst->type_argv [i], p, &p);
+       encode_type (assembly, &gclass->container_class->byval_arg, p, &p);
+       mono_metadata_encode_value (gclass->inst->type_argc, p, &p);
+       for (i = 0; i < gclass->inst->type_argc; ++i)
+               encode_type (assembly, gclass->inst->type_argv [i], p, &p);
 
        *endbuf = p;
 }
@@ -531,7 +530,7 @@ encode_type (MonoDynamicImage *assembly, MonoType *type, char *p, char **endbuf)
                mono_metadata_encode_value (0, p, &p);
                break;
        case MONO_TYPE_GENERICINST:
-               encode_generic_inst (assembly, type->data.generic_inst, p, &p);
+               encode_generic_class (assembly, type->data.generic_class, p, &p);
                break;
        case MONO_TYPE_VAR:
        case MONO_TYPE_MVAR:
@@ -585,19 +584,19 @@ encode_custom_modifiers (MonoDynamicImage *assembly, MonoArray *modreq, MonoArra
 }
 
 static guint32
-generic_inst_get_signature_size (MonoGenericInst *ginst)
+generic_class_get_signature_size (MonoGenericClass *gclass)
 {
        guint32 size = 0;
        int i;
 
-       if (!ginst) {
+       if (!gclass) {
                g_assert_not_reached ();
        }
 
-       size += 1 + type_get_signature_size (ginst->generic_type);
+       size += 1 + type_get_signature_size (&gclass->container_class->byval_arg);
        size += 4;
-       for (i = 0; i < ginst->type_argc; ++i)
-               size += type_get_signature_size (ginst->type_argv [i]);
+       for (i = 0; i < gclass->inst->type_argc; ++i)
+               size += type_get_signature_size (gclass->inst->type_argv [i]);
 
        return size;
 }
@@ -644,7 +643,7 @@ type_get_signature_size (MonoType *type)
        case MONO_TYPE_ARRAY:
                return size + 7 + type_get_signature_size (&type->data.array->eklass->byval_arg);
        case MONO_TYPE_GENERICINST:
-               return size + generic_inst_get_signature_size (type->data.generic_inst);
+               return size + generic_class_get_signature_size (type->data.generic_class);
        case MONO_TYPE_VAR:
        case MONO_TYPE_MVAR:
                return size + 5;
@@ -1218,7 +1217,7 @@ mono_image_basic_method (ReflectionMethodBuilder *mb, MonoDynamicImage *assembly
        /* room in this table is already allocated */
        table = &assembly->tables [MONO_TABLE_METHOD];
        *mb->table_idx = table->next_idx ++;
-       mono_g_hash_table_insert (assembly->method_to_table_idx, mb->mhandle, GUINT_TO_POINTER ((*mb->table_idx)));
+       g_hash_table_insert (assembly->method_to_table_idx, mb->mhandle, GUINT_TO_POINTER ((*mb->table_idx)));
        values = table->values + *mb->table_idx * MONO_METHOD_SIZE;
        name = mono_string_to_utf8 (mb->name);
        values [MONO_METHOD_NAME] = string_heap_insert (&assembly->sheap, name);
@@ -1293,6 +1292,7 @@ reflection_methodbuilder_from_method_builder (ReflectionMethodBuilder *rmb, Mono
        rmb->rtype = mb->rtype;
        rmb->parameters = mb->parameters;
        rmb->generic_params = mb->generic_params;
+       rmb->generic_container = mb->generic_container;
        rmb->opt_types = NULL;
        rmb->pinfo = mb->pinfo;
        rmb->attrs = mb->attrs;
@@ -1313,9 +1313,9 @@ reflection_methodbuilder_from_method_builder (ReflectionMethodBuilder *rmb, Mono
        rmb->refs = NULL;
 
        if (mb->dll) {
-               rmb->charset = rmb->charset & 0xf;
-               rmb->lasterr = rmb->charset & 0x40;
-               rmb->native_cc = rmb->native_cc;
+               rmb->charset = mb->charset & 0xf;
+               rmb->lasterr = mb->charset & 0x40;
+               rmb->native_cc = mb->native_cc;
                rmb->dllentry = mb->dllentry;
                rmb->dll = mb->dll;
        }
@@ -1330,6 +1330,7 @@ reflection_methodbuilder_from_ctor_builder (ReflectionMethodBuilder *rmb, MonoRe
        rmb->rtype = mono_type_get_object (mono_domain_get (), &mono_defaults.void_class->byval_arg);
        rmb->parameters = mb->parameters;
        rmb->generic_params = NULL;
+       rmb->generic_container = NULL;
        rmb->opt_types = NULL;
        rmb->pinfo = mb->pinfo;
        rmb->attrs = mb->attrs;
@@ -1357,6 +1358,7 @@ reflection_methodbuilder_from_dynamic_method (ReflectionMethodBuilder *rmb, Mono
        rmb->rtype = mb->rtype;
        rmb->parameters = mb->parameters;
        rmb->generic_params = NULL;
+       rmb->generic_container = NULL;
        rmb->opt_types = NULL;
        rmb->pinfo = NULL;
        rmb->attrs = mb->attrs;
@@ -1740,7 +1742,7 @@ mono_image_get_field_info (MonoReflectionFieldBuilder *fb, MonoDynamicImage *ass
                fb->attrs |= FIELD_ATTRIBUTE_HAS_DEFAULT;
        table = &assembly->tables [MONO_TABLE_FIELD];
        fb->table_idx = table->next_idx ++;
-       mono_g_hash_table_insert (assembly->field_to_table_idx, fb->handle, GUINT_TO_POINTER (fb->table_idx));
+       g_hash_table_insert (assembly->field_to_table_idx, fb->handle, GUINT_TO_POINTER (fb->table_idx));
        values = table->values + fb->table_idx * MONO_FIELD_SIZE;
        name = mono_string_to_utf8 (fb->name);
        values [MONO_FIELD_NAME] = string_heap_insert (&assembly->sheap, name);
@@ -1819,7 +1821,7 @@ property_encode_signature (MonoDynamicImage *assembly, MonoReflectionPropertyBui
                        MonoReflectionType *pt = mono_array_get (mb->parameters, MonoReflectionType*, i);
                        encode_reflection_type (assembly, pt, p, &p);
                }
-       } else {
+       } else if (smb) {
                /* the property type is the last param */
                encode_reflection_type (assembly, mono_array_get (smb->parameters, MonoReflectionType*, nparams), p, &p);
                for (i = 0; i < nparams; ++i) {
@@ -1827,6 +1829,10 @@ property_encode_signature (MonoDynamicImage *assembly, MonoReflectionPropertyBui
                        encode_reflection_type (assembly, pt, p, &p);
                }
        }
+       else {
+               encode_reflection_type (assembly, fb->type, p, &p);
+       }
+
        /* store length */
        g_assert (p - buf < size);
        mono_metadata_encode_value (p-buf, b, &b);
@@ -2188,9 +2194,9 @@ create_typespec (MonoDynamicImage *assembly, MonoType *type)
        case MONO_TYPE_CLASS:
        case MONO_TYPE_VALUETYPE: {
                MonoClass *k = mono_class_from_mono_type (type);
-               if (!k || !k->generic_inst)
+               if (!k || !k->generic_class)
                        return 0;
-               encode_generic_inst (assembly, k->generic_inst, p, &p);
+               encode_generic_class (assembly, k->generic_class, p, &p);
                break;
        }
        default:
@@ -2422,7 +2428,7 @@ encode_generic_method_sig (MonoDynamicImage *assembly, MonoGenericMethod *gmetho
        char *buf;
        char *p;
        int i;
-       guint32 nparams =  gmethod->mtype_argc;
+       guint32 nparams =  gmethod->inst->type_argc;
        guint32 size = 10 + nparams * 10;
        guint32 idx;
        char blob_size [6];
@@ -2439,7 +2445,7 @@ encode_generic_method_sig (MonoDynamicImage *assembly, MonoGenericMethod *gmetho
        mono_metadata_encode_value (nparams, p, &p);
 
        for (i = 0; i < nparams; i++)
-               encode_type (assembly, gmethod->mtype_argv [i], p, &p);
+               encode_type (assembly, gmethod->inst->type_argv [i], p, &p);
 
        /* store length */
        g_assert (p - buf < size);
@@ -2460,7 +2466,8 @@ method_encode_methodspec (MonoDynamicImage *assembly, MonoMethod *method)
 
        table = &assembly->tables [MONO_TABLE_METHODSPEC];
 
-       g_assert (method->signature->is_inflated);
+       g_assert (method->is_inflated);
+       method = mono_get_inflated_method (method);
        imethod = (MonoMethodInflated *) method;
        declaring = imethod->declaring;
 
@@ -2506,7 +2513,8 @@ mono_image_get_methodspec_token (MonoDynamicImage *assembly, MonoMethod *m)
        if (token)
                return token;
 
-       g_assert (m->signature->is_inflated);
+       g_assert (m->is_inflated);
+       m = mono_get_inflated_method (m);
        imethod = (MonoMethodInflated *) m;
 
        if (imethod->declaring->signature->generic_param_count) {
@@ -3184,6 +3192,14 @@ mono_image_fill_export_table_from_module (MonoDomain *domain, MonoReflectionModu
                        (p) += 4 - (__diff & 3);\
        } while (0)
 
+static int
+compare_constants (const void *a, const void *b)
+{
+       const guint32 *a_values = a;
+       const guint32 *b_values = b;
+       return a_values [MONO_CONSTANT_PARENT] - b_values [MONO_CONSTANT_PARENT];
+}
+
 static int
 compare_semantics (const void *a, const void *b)
 {
@@ -3228,7 +3244,12 @@ compare_genericparam (const void *a, const void *b)
        const GenericParamTableEntry **a_entry = (const GenericParamTableEntry **) a;
        const GenericParamTableEntry **b_entry = (const GenericParamTableEntry **) b;
 
-       return (*b_entry)->owner - (*a_entry)->owner;
+       if ((*b_entry)->owner == (*a_entry)->owner)
+               return 
+                       (*a_entry)->gparam->type.type->data.generic_param->num - 
+                       (*b_entry)->gparam->type.type->data.generic_param->num;
+       else
+               return (*a_entry)->owner - (*b_entry)->owner;
 }
 
 static int
@@ -3422,6 +3443,9 @@ build_compressed_metadata (MonoDynamicImage *assembly)
        p = (unsigned char*)int32val;
 
        /* sort the tables that still need sorting */
+       table = &assembly->tables [MONO_TABLE_CONSTANT];
+       if (table->rows)
+               qsort (table->values + MONO_CONSTANT_SIZE, table->rows, sizeof (guint32) * MONO_CONSTANT_SIZE, compare_constants);
        table = &assembly->tables [MONO_TABLE_METHODSEMANTICS];
        if (table->rows)
                qsort (table->values + MONO_METHOD_SEMA_SIZE, table->rows, sizeof (guint32) * MONO_METHOD_SEMA_SIZE, compare_semantics);
@@ -3514,7 +3538,7 @@ fixup_method (MonoReflectionILGen *ilgen, gpointer value, MonoDynamicImage *asse
                                idx = field->table_idx;
                        } else if (!strcmp (iltoken->member->vtable->klass->name, "MonoField")) {
                                MonoClassField *f = ((MonoReflectionField*)iltoken->member)->field;
-                               idx = GPOINTER_TO_UINT (mono_g_hash_table_lookup (assembly->field_to_table_idx, f));
+                               idx = GPOINTER_TO_UINT (g_hash_table_lookup (assembly->field_to_table_idx, f));
                        } else {
                                g_assert_not_reached ();
                        }
@@ -3529,7 +3553,7 @@ fixup_method (MonoReflectionILGen *ilgen, gpointer value, MonoDynamicImage *asse
                        } else if (!strcmp (iltoken->member->vtable->klass->name, "MonoMethod") || 
                                           !strcmp (iltoken->member->vtable->klass->name, "MonoCMethod")) {
                                MonoMethod *m = ((MonoReflectionMethod*)iltoken->member)->method;
-                               idx = GPOINTER_TO_UINT (mono_g_hash_table_lookup (assembly->method_to_table_idx, m));
+                               idx = GPOINTER_TO_UINT (g_hash_table_lookup (assembly->method_to_table_idx, m));
                        } else {
                                g_assert_not_reached ();
                        }
@@ -3545,9 +3569,11 @@ fixup_method (MonoReflectionILGen *ilgen, gpointer value, MonoDynamicImage *asse
                                am = (MonoReflectionArrayMethod*)iltoken->member;
                                idx = am->table_idx;
                        } else if (!strcmp (iltoken->member->vtable->klass->name, "MonoMethod") ||
-                                  !strcmp (iltoken->member->vtable->klass->name, "MonoCMethod")) {
+                                  !strcmp (iltoken->member->vtable->klass->name, "MonoCMethod") ||
+                                  !strcmp (iltoken->member->vtable->klass->name, "MonoGenericMethod") ||
+                                  !strcmp (iltoken->member->vtable->klass->name, "MonoGenericCMethod")) {
                                MonoMethod *m = ((MonoReflectionMethod*)iltoken->member)->method;
-                               g_assert (m->klass->generic_inst);
+                               g_assert (m->klass->generic_class || m->klass->generic_container);
                                continue;
                        } else if (!strcmp (iltoken->member->vtable->klass->name, "FieldBuilder")) {
                                continue;
@@ -3562,7 +3588,7 @@ fixup_method (MonoReflectionILGen *ilgen, gpointer value, MonoDynamicImage *asse
                        }
                        break;
                case MONO_TABLE_METHODSPEC:
-                       if (!strcmp (iltoken->member->vtable->klass->name, "MonoMethod")) {
+                       if (!strcmp (iltoken->member->vtable->klass->name, "MonoGenericMethod")) {
                                MonoMethod *m = ((MonoReflectionMethod*)iltoken->member)->method;
                                g_assert (m->signature->generic_param_count);
                                continue;
@@ -3607,7 +3633,7 @@ fixup_cattrs (MonoDynamicImage *assembly)
 
                        if (!strcmp (ctor->vtable->klass->name, "MonoCMethod")) {
                                MonoMethod *m = ((MonoReflectionMethod*)ctor)->method;
-                               idx = GPOINTER_TO_UINT (mono_g_hash_table_lookup (assembly->method_to_table_idx, m));
+                               idx = GPOINTER_TO_UINT (g_hash_table_lookup (assembly->method_to_table_idx, m));
                                values [MONO_CUSTOM_ATTR_TYPE] = (idx << MONO_CUSTOM_ATTR_TYPE_BITS) | MONO_CUSTOM_ATTR_TYPE_METHODDEF;
                        }
                }
@@ -4104,20 +4130,22 @@ mono_image_create_token (MonoDynamicImage *assembly, MonoObject *obj, gboolean c
                MonoReflectionType *tb = (MonoReflectionType *)obj;
                token = mono_metadata_token_from_dor (
                        mono_image_typedef_or_ref (assembly, tb->type));
-       } else if (strcmp (klass->name, "MonoGenericInst") == 0) {
+       } else if (strcmp (klass->name, "MonoGenericClass") == 0) {
                MonoReflectionType *tb = (MonoReflectionType *)obj;
                token = mono_metadata_token_from_dor (
                        mono_image_typedef_or_ref (assembly, tb->type));
        } else if (strcmp (klass->name, "MonoCMethod") == 0 ||
-                       strcmp (klass->name, "MonoMethod") == 0) {
+                  strcmp (klass->name, "MonoMethod") == 0 ||
+                  strcmp (klass->name, "MonoGenericMethod") == 0 ||
+                  strcmp (klass->name, "MonoGenericCMethod") == 0) {
                MonoReflectionMethod *m = (MonoReflectionMethod *)obj;
-               if (m->method->signature->is_inflated) {
+               if (m->method->is_inflated) {
                        if (create_methodspec)
                                token = mono_image_get_methodspec_token (assembly, m->method);
                        else
                                token = mono_image_get_inflated_method_token (assembly, m->method);
                } else if ((m->method->klass->image == &assembly->image) &&
-                        !m->method->klass->generic_inst) {
+                        !m->method->klass->generic_class) {
                        static guint32 method_table_idx = 0xffffff;
                        if (m->method->klass->wastypebuilder) {
                                /* we use the same token as the one that was assigned
@@ -4206,14 +4234,14 @@ create_dynamic_mono_image (MonoDynamicAssembly *assembly, char *assembly_name, c
        mono_image_init (&image->image);
 
        image->token_fixups = mono_g_hash_table_new (NULL, NULL);
-       image->method_to_table_idx = mono_g_hash_table_new (NULL, NULL);
-       image->field_to_table_idx = mono_g_hash_table_new (NULL, NULL);
-       image->method_aux_hash = mono_g_hash_table_new (NULL, NULL);
+       image->method_to_table_idx = g_hash_table_new (NULL, NULL);
+       image->field_to_table_idx = g_hash_table_new (NULL, NULL);
+       image->method_aux_hash = g_hash_table_new (NULL, NULL);
        image->handleref = g_hash_table_new (NULL, NULL);
        image->tokens = mono_g_hash_table_new (NULL, NULL);
        image->typespec = g_hash_table_new ((GHashFunc)mono_metadata_type_hash, (GCompareFunc)mono_metadata_type_equal);
        image->typeref = g_hash_table_new ((GHashFunc)mono_metadata_type_hash, (GCompareFunc)mono_metadata_type_equal);
-       image->blob_cache = mono_g_hash_table_new ((GHashFunc)mono_blob_entry_hash, (GCompareFunc)mono_blob_entry_equal);
+       image->blob_cache = g_hash_table_new ((GHashFunc)mono_blob_entry_hash, (GCompareFunc)mono_blob_entry_equal);
        image->gen_params = g_ptr_array_new ();
 
        string_heap_init (&image->sheap);
@@ -4270,6 +4298,7 @@ mono_image_basic_init (MonoReflectionAssemblyBuilder *assemblyb)
 #endif
 
        assembly->assembly.dynamic = TRUE;
+       assembly->assembly.corlib_internal = assemblyb->corlib_internal;
        assemblyb->assembly.assembly = (MonoAssembly*)assembly;
        assembly->assembly.basedir = mono_string_to_utf8 (assemblyb->dir);
        if (assemblyb->culture)
@@ -4785,7 +4814,7 @@ mono_image_create_pefile (MonoReflectionModuleBuilder *mb, HANDLE file) {
                        MonoReflectionMethodBuilder *methodb = (MonoReflectionMethodBuilder*)assemblyb->entry_point;
                        table_idx = methodb->table_idx;
                } else {
-                       table_idx = GPOINTER_TO_UINT (mono_g_hash_table_lookup (assembly->method_to_table_idx, assemblyb->entry_point->method));
+                       table_idx = GPOINTER_TO_UINT (g_hash_table_lookup (assembly->method_to_table_idx, assemblyb->entry_point->method));
                }
                cli_header->ch_entry_point = GUINT32_FROM_LE (table_idx | MONO_TOKEN_METHOD_DEF);
        } else {
@@ -4901,7 +4930,10 @@ mono_image_create_pefile (MonoReflectionModuleBuilder *mb, HANDLE file) {
        mono_dynamic_stream_reset (&assembly->us);
        mono_dynamic_stream_reset (&assembly->blob);
        mono_dynamic_stream_reset (&assembly->guid);
-       mono_dynamic_stream_reset (&assembly->sheap);
+       string_heap_free (&assembly->sheap);
+
+       g_hash_table_foreach (assembly->blob_cache, (GHFunc)g_free, NULL);
+       g_hash_table_destroy (assembly->blob_cache);
 }
 
 MonoReflectionModule *
@@ -5062,6 +5094,7 @@ mono_assembly_get_object (MonoDomain *domain, MonoAssembly *assembly)
                        mono_defaults.corlib, "System.Reflection", "Assembly");
        res = (MonoReflectionAssembly *)mono_object_new (domain, System_Reflection_Assembly);
        res->assembly = assembly;
+
        CACHE_OBJECT (assembly, res, NULL);
        return res;
 }
@@ -5190,12 +5223,13 @@ mymono_metadata_type_equal (MonoType *t1, MonoType *t2)
                return t1->data.array->eklass == t2->data.array->eklass;
        case MONO_TYPE_GENERICINST: {
                int i;
-               if (t1->data.generic_inst->type_argc != t2->data.generic_inst->type_argc)
+               if (t1->data.generic_class->inst->type_argc != t2->data.generic_class->inst->type_argc)
                        return FALSE;
-               if (!mono_metadata_type_equal (t1->data.generic_inst->generic_type, t2->data.generic_inst->generic_type))
+               if (!mono_metadata_type_equal (&t1->data.generic_class->container_class->byval_arg,
+                                              &t2->data.generic_class->container_class->byval_arg))
                        return FALSE;
-               for (i = 0; i < t1->data.generic_inst->type_argc; ++i) {
-                       if (!mono_metadata_type_equal (t1->data.generic_inst->type_argv [i], t2->data.generic_inst->type_argv [i]))
+               for (i = 0; i < t1->data.generic_class->inst->type_argc; ++i) {
+                       if (!mono_metadata_type_equal (t1->data.generic_class->inst->type_argv [i], t2->data.generic_class->inst->type_argv [i]))
                                return FALSE;
                }
                return TRUE;
@@ -5231,32 +5265,32 @@ mymono_metadata_type_hash (MonoType *t1)
        return hash;
 }
 
-static MonoReflectionGenericInst*
-mono_generic_inst_get_object (MonoDomain *domain, MonoType *geninst)
+static MonoReflectionGenericClass*
+mono_generic_class_get_object (MonoDomain *domain, MonoType *geninst)
 {
-       static MonoClass *System_Reflection_MonoGenericInst;
-       MonoReflectionGenericInst *res;
-       MonoGenericInst *ginst;
+       static MonoClass *System_Reflection_MonoGenericClass;
+       MonoReflectionGenericClass *res;
+       MonoGenericClass *gclass;
        MonoClass *gklass;
 
-       if (!System_Reflection_MonoGenericInst) {
-               System_Reflection_MonoGenericInst = mono_class_from_name (
-                       mono_defaults.corlib, "System.Reflection", "MonoGenericInst");
-               g_assert (System_Reflection_MonoGenericInst);
+       if (!System_Reflection_MonoGenericClass) {
+               System_Reflection_MonoGenericClass = mono_class_from_name (
+                       mono_defaults.corlib, "System.Reflection", "MonoGenericClass");
+               g_assert (System_Reflection_MonoGenericClass);
        }
 
-       ginst = geninst->data.generic_inst;
-       gklass = mono_class_from_mono_type (ginst->generic_type);
+       gclass = geninst->data.generic_class;
+       gklass = gclass->container_class;
 
-       mono_class_init (ginst->klass);
+       mono_class_init (gclass->klass);
 
-       res = (MonoReflectionGenericInst *) mono_object_new (domain, System_Reflection_MonoGenericInst);
+       res = (MonoReflectionGenericClass *) mono_object_new (domain, System_Reflection_MonoGenericClass);
 
        res->type.type = geninst;
        if (gklass->wastypebuilder && gklass->reflection_info)
                res->generic_type = gklass->reflection_info;
        else
-               res->generic_type = mono_type_get_object (domain, ginst->generic_type);
+               res->generic_type = mono_type_get_object (domain, &gclass->container_class->byval_arg);
 
        return res;
 }
@@ -5282,8 +5316,8 @@ mono_type_get_object (MonoDomain *domain, MonoType *type)
                mono_domain_unlock (domain);
                return res;
        }
-       if ((type->type == MONO_TYPE_GENERICINST) && type->data.generic_inst->is_dynamic) {
-               res = (MonoReflectionType *)mono_generic_inst_get_object (domain, type);
+       if ((type->type == MONO_TYPE_GENERICINST) && type->data.generic_class->is_dynamic) {
+               res = (MonoReflectionType *)mono_generic_class_get_object (domain, type);
                mono_g_hash_table_insert (domain->type_hash, type, res);
                mono_domain_unlock (domain);
                return res;
@@ -5323,6 +5357,25 @@ mono_method_get_object (MonoDomain *domain, MonoMethod *method, MonoClass *refcl
        MonoClass *klass;
        MonoReflectionMethod *ret;
 
+       if (method->is_inflated) {
+               MonoReflectionGenericMethod *gret;
+
+               refclass = method->klass;
+               CHECK_OBJECT (MonoReflectionMethod *, method, refclass);
+               if ((*method->name == '.') && (!strcmp (method->name, ".ctor") || !strcmp (method->name, ".cctor")))
+                       cname = "MonoGenericCMethod";
+               else
+                       cname = "MonoGenericMethod";
+               klass = mono_class_from_name (mono_defaults.corlib, "System.Reflection", cname);
+
+               gret = (MonoReflectionGenericMethod*)mono_object_new (domain, klass);
+               gret->method.method = method;
+               gret->method.name = mono_string_new (domain, method->name);
+               gret->method.reftype = mono_type_get_object (domain, &refclass->byval_arg);
+               CACHE_OBJECT (method, gret, refclass);
+               return (MonoReflectionMethod *) gret;
+       }
+
        if (!refclass)
                refclass = method->klass;
 
@@ -5586,14 +5639,14 @@ get_default_param_value_blobs (MonoMethod *method, char **blobs)
        if (!methodsig->param_count)
                return;
 
-       if (klass->generic_inst) {
+       if (klass->generic_class) {
                return; /* FIXME - ??? */
        }
 
        mono_class_init (klass);
 
        if (klass->image->dynamic) {
-               MonoReflectionMethodAux *aux = mono_g_hash_table_lookup (((MonoDynamicImage*)method->klass->image)->method_aux_hash, method);
+               MonoReflectionMethodAux *aux = g_hash_table_lookup (((MonoDynamicImage*)method->klass->image)->method_aux_hash, method);
                if (aux && aux->param_defaults)
                        memcpy (blobs, &(aux->param_defaults [1]), methodsig->param_count * sizeof (char*));
                return;
@@ -5676,7 +5729,7 @@ assembly_name_to_aname (MonoAssemblyName *assembly, char *p) {
        while (*p && (isalnum (*p) || *p == '.' || *p == '-' || *p == '_' || *p == '$' || *p == '@'))
                p++;
        found_sep = 0;
-       while (*p == ' ' || *p == ',') {
+       while (g_ascii_isspace (*p) || *p == ',') {
                *p++ = 0;
                found_sep = 1;
                continue;
@@ -5734,7 +5787,7 @@ assembly_name_to_aname (MonoAssemblyName *assembly, char *p) {
                                p++;
                }
                found_sep = 0;
-               while (*p == ' ' || *p == ',') {
+               while (g_ascii_isspace (*p) || *p == ',') {
                        *p++ = 0;
                        found_sep = 1;
                        continue;
@@ -5755,8 +5808,10 @@ assembly_name_to_aname (MonoAssemblyName *assembly, char *p) {
  * extracted in the info structure.
  * the name param will be mangled, so, make a copy before passing it to this function.
  * The fields in info will be valid until the memory pointed to by name is valid.
- * Returns 0 on parse error.
+ *
  * See also mono_type_get_name () below.
+ *
+ * Returns: 0 on parse error.
  */
 int
 mono_reflection_parse_type (char *name, MonoTypeNameParse *info) {
@@ -5855,7 +5910,7 @@ mono_reflection_parse_type (char *name, MonoTypeNameParse *info) {
                case ',':
                        *p++ = 0;
                        while (*p) {
-                               if (*p == ' ') {
+                               if (g_ascii_isspace (*p)) {
                                        ++p;
                                        continue;
                                }
@@ -6108,11 +6163,11 @@ mono_reflection_get_token (MonoObject *obj)
        } else if (strcmp (klass->name, "MonoCMethod") == 0 ||
                        strcmp (klass->name, "MonoMethod") == 0) {
                MonoReflectionMethod *m = (MonoReflectionMethod *)obj;
-               if (m->method->signature->is_inflated) {
+               if (m->method->is_inflated) {
                        g_assert_not_reached ();
                } else if (m->method->signature->generic_param_count) {
                        g_assert_not_reached ();
-               } else if (m->method->klass->generic_inst) {
+               } else if (m->method->klass->generic_class) {
                        g_assert_not_reached ();
                } else {
                        token = m->method->token;
@@ -6693,7 +6748,7 @@ mono_custom_attrs_from_param (MonoMethod *method, guint32 param)
        MonoReflectionMethodAux *aux;
 
        if (method->klass->image->dynamic) {
-               aux = mono_g_hash_table_lookup (((MonoDynamicImage*)method->klass->image)->method_aux_hash, method);
+               aux = g_hash_table_lookup (((MonoDynamicImage*)method->klass->image)->method_aux_hash, method);
                if (!aux || !aux->param_cattr)
                        return NULL;
                return aux->param_cattr [param];
@@ -6703,8 +6758,7 @@ mono_custom_attrs_from_param (MonoMethod *method, guint32 param)
        method_index = find_method_index (method);
        ca = &image->tables [MONO_TABLE_METHOD];
 
-       if (method->klass->generic_inst || method->klass->generic_container ||
-           method->signature->generic_param_count) {
+       if (method->klass->generic_class || method->signature->generic_param_count) {
                /* FIXME FIXME FIXME */
                return NULL;
        }
@@ -6772,6 +6826,9 @@ mono_reflection_get_custom_attrs (MonoObject *obj)
        } else if ((strcmp ("MonoMethod", klass->name) == 0) || (strcmp ("MonoCMethod", klass->name) == 0)) {
                MonoReflectionMethod *rmethod = (MonoReflectionMethod*)obj;
                cinfo = mono_custom_attrs_from_method (rmethod->method);
+       } else if ((strcmp ("MonoGenericMethod", klass->name) == 0) || (strcmp ("MonoGenericCMethod", klass->name) == 0)) {
+               MonoMethod *method = mono_get_inflated_method (((MonoReflectionMethod*)obj)->method);
+               cinfo = mono_custom_attrs_from_method (method);
        } else if (strcmp ("ParameterInfo", klass->name) == 0) {
                MonoReflectionParameter *param = (MonoReflectionParameter*)obj;
                MonoReflectionMethod *rmethod = (MonoReflectionMethod*)param->MemberImpl;
@@ -7028,10 +7085,18 @@ handle_type:
        }
        /* it may be a boxed value or a Type */
        case MONO_TYPE_OBJECT: {
-               MonoClass *klass = mono_object_class (arg);
+               MonoClass *klass;
                char *str;
                guint32 slen;
+
+               if (arg == NULL) {
+                       *p++ = MONO_TYPE_STRING;        // It's same hack as MS uses
+                       *p++ = 0xFF;
+                       break;
+               }
                
+               klass = mono_object_class (arg);
+
                if (mono_object_isinst (arg, mono_defaults.monotype_class)) {
                        *p++ = 0x50;
                        goto handle_type;
@@ -7343,8 +7408,7 @@ mono_reflection_setup_generic_class (MonoReflectionTypeBuilder *tb)
        tb->generic_container = g_new0 (MonoGenericContainer, 1);
        tb->generic_container->klass = klass;
 
-       tb->generic_container->context = g_new0 (MonoGenericContext, 1);
-       tb->generic_container->context->container = tb->generic_container;
+       tb->generic_container->context.container = tb->generic_container;
 }
 
 /*
@@ -7380,6 +7444,8 @@ mono_reflection_create_generic_class (MonoReflectionTypeBuilder *tb)
                klass->generic_container->type_params [i] = *gparam->type.type->data.generic_param;
                g_assert (klass->generic_container->type_params [i].owner);
        }
+
+       klass->generic_container->context.gclass = mono_get_shared_generic_class (klass->generic_container, TRUE);
 }
 
 /*
@@ -7555,7 +7621,7 @@ reflection_methodbuilder_to_mono_method (MonoClass *klass,
                ((MonoMethodPInvoke*)m)->piflags = (rmb->native_cc << 8) | (rmb->charset ? (rmb->charset - 1) * 2 : 1) | rmb->lasterr;
 
                if (klass->image->dynamic)
-                       mono_g_hash_table_insert (((MonoDynamicImage*)klass->image)->method_aux_hash, m, method_aux);
+                       g_hash_table_insert (((MonoDynamicImage*)klass->image)->method_aux_hash, m, method_aux);
 
                return m;
        } else if (!m->klass->dummy && 
@@ -7619,7 +7685,7 @@ reflection_methodbuilder_to_mono_method (MonoClass *klass,
                int count = mono_array_length (rmb->generic_params);
                MonoGenericContainer *container;
 
-               pm->generic_container = container = g_new0 (MonoGenericContainer, 1);
+               pm->generic_container = container = rmb->generic_container;
                container->type_argc = count;
                container->type_params = g_new0 (MonoGenericParam, count);
 
@@ -7704,7 +7770,7 @@ reflection_methodbuilder_to_mono_method (MonoClass *klass,
        }
 
        if (klass->image->dynamic && method_aux)
-               mono_g_hash_table_insert (((MonoDynamicImage*)klass->image)->method_aux_hash, m, method_aux);
+               g_hash_table_insert (((MonoDynamicImage*)klass->image)->method_aux_hash, m, method_aux);
 
        return m;
 }      
@@ -7797,15 +7863,17 @@ static MonoType*
 do_mono_reflection_bind_generic_parameters (MonoReflectionType *type, int type_argc, MonoType **types,
                                            MonoType *parent)
 {
-       MonoClass *klass, *gklass;
+       MonoClass *klass;
        MonoReflectionTypeBuilder *tb = NULL;
-       MonoGenericInst *ginst, *cached;
+       MonoGenericClass *gclass, *cached;
+       MonoDynamicGenericClass *dgclass = NULL;
+       gboolean is_dynamic = FALSE;
        MonoDomain *domain;
        MonoType *geninst;
        int icount, i;
 
        klass = mono_class_from_mono_type (type->type);
-       if (!klass->generic_container && !klass->generic_inst &&
+       if (!klass->generic_container && !klass->generic_class &&
            !(klass->nested_in && klass->nested_in->generic_container))
                return NULL;
 
@@ -7813,85 +7881,98 @@ do_mono_reflection_bind_generic_parameters (MonoReflectionType *type, int type_a
 
        domain = mono_object_domain (type);
 
-       ginst = g_new0 (MonoGenericInst, 1);
+       if (!strcmp (((MonoObject *) type)->vtable->klass->name, "TypeBuilder")) {
+               tb = (MonoReflectionTypeBuilder *) type;
 
-       ginst->type_argc = type_argc;
-       ginst->type_argv = types;
+               icount = tb->interfaces ? mono_array_length (tb->interfaces) : 0;
+               is_dynamic = TRUE;
+       } else if (!strcmp (((MonoObject *) type)->vtable->klass->name, "MonoGenericClass")) {
+               MonoReflectionGenericClass *rgi = (MonoReflectionGenericClass *) type;
+               MonoReflectionType *rgt = rgi->generic_type;
 
-       for (i = 0; i < ginst->type_argc; ++i) {
-               if (!ginst->is_open)
-                       ginst->is_open = mono_class_is_open_constructed_type (types [i]);
+               g_assert (!strcmp (((MonoObject *) rgt)->vtable->klass->name, "TypeBuilder"));
+               tb = (MonoReflectionTypeBuilder *) rgt;
+
+               icount = tb->interfaces ? mono_array_length (tb->interfaces) : 0;
+               is_dynamic = TRUE;
+       } else {
+               icount = klass->interface_count;
        }
 
-       ginst->generic_type = &klass->byval_arg;
+       if (is_dynamic) {
+               dgclass = g_new0 (MonoDynamicGenericClass, 1);
+               gclass = &dgclass->generic_class;
+               gclass->is_dynamic = TRUE;
+       } else
+               gclass = g_new0 (MonoGenericClass, 1);
+
+       gclass->inst = g_new0 (MonoGenericInst, 1);
+
+       gclass->inst->type_argc = type_argc;
+       gclass->inst->type_argv = types;
+
+       for (i = 0; i < gclass->inst->type_argc; ++i) {
+               if (!gclass->inst->is_open)
+                       gclass->inst->is_open = mono_class_is_open_constructed_type (types [i]);
+       }
+
+       gclass->container_class = klass;
+
+       if (klass->generic_class) {
+               MonoGenericClass *kgclass = klass->generic_class;
+               MonoGenericClass *ogclass = gclass;
 
-       if (klass->generic_inst) {
-               MonoGenericInst *kginst = klass->generic_inst;
-               MonoGenericInst *oginst = ginst;
+               ogclass->context = g_new0 (MonoGenericContext, 1);
+               ogclass->context->container = ogclass->container_class->generic_container;
+               ogclass->context->gclass = ogclass;
 
-               oginst->context = g_new0 (MonoGenericContext, 1);
-               oginst->context->ginst = oginst;
+               if (is_dynamic) {
+                       dgclass = g_new0 (MonoDynamicGenericClass, 1);
+                       gclass = &dgclass->generic_class;
+                       gclass->is_dynamic = TRUE;
+               } else
+                       gclass = g_new0 (MonoGenericClass, 1);
 
-               ginst = g_new0 (MonoGenericInst, 1);
+               gclass->inst = g_new0 (MonoGenericInst, 1);
 
-               ginst->type_argc = kginst->type_argc;
-               ginst->type_argv = g_new0 (MonoType *, ginst->type_argc);
+               gclass->inst->type_argc = kgclass->inst->type_argc;
+               gclass->inst->type_argv = g_new0 (MonoType *, gclass->inst->type_argc);
 
-               for (i = 0; i < ginst->type_argc; i++) {
-                       MonoType *t = kginst->type_argv [i];
+               for (i = 0; i < gclass->inst->type_argc; i++) {
+                       MonoType *t = kgclass->inst->type_argv [i];
 
-                       t = mono_class_inflate_generic_type (t, oginst->context);
+                       t = mono_class_inflate_generic_type (t, ogclass->context);
 
-                       if (!ginst->is_open)
-                               ginst->is_open = mono_class_is_open_constructed_type (t);
+                       if (!gclass->inst->is_open)
+                               gclass->inst->is_open = mono_class_is_open_constructed_type (t);
 
-                       ginst->type_argv [i] = t;
+                       gclass->inst->type_argv [i] = t;
                }
 
-               ginst->generic_type = kginst->generic_type;
+               gclass->container_class = kgclass->container_class;
        }
 
        geninst = g_new0 (MonoType, 1);
        geninst->type = MONO_TYPE_GENERICINST;
 
-       cached = g_hash_table_lookup (klass->image->generic_inst_cache, ginst);
+       cached = mono_metadata_lookup_generic_class (gclass);
        if (cached) {
-               g_free (ginst);
+               g_free (gclass);
                mono_loader_unlock ();
-               geninst->data.generic_inst = cached;
+               geninst->data.generic_class = cached;
                return geninst;
        }
 
-       gklass = mono_class_from_mono_type (ginst->generic_type);
-       g_assert ((ginst->container = gklass->generic_container) != NULL);
-
-       geninst->data.generic_inst = ginst;
+       geninst->data.generic_class = gclass;
 
-       ginst->parent = parent;
+       gclass->parent = parent;
 
-       ginst->context = g_new0 (MonoGenericContext, 1);
-       ginst->context->ginst = ginst;
+       gclass->context = g_new0 (MonoGenericContext, 1);
+       gclass->context->container = gclass->container_class->generic_container;
+       gclass->context->gclass = gclass;
 
-       if (!strcmp (((MonoObject *) type)->vtable->klass->name, "TypeBuilder")) {
-               tb = (MonoReflectionTypeBuilder *) type;
-
-               icount = tb->interfaces ? mono_array_length (tb->interfaces) : 0;
-               ginst->is_dynamic = TRUE;
-       } else if (!strcmp (((MonoObject *) type)->vtable->klass->name, "MonoGenericInst")) {
-               MonoReflectionGenericInst *rgi = (MonoReflectionGenericInst *) type;
-               MonoReflectionType *rgt = rgi->generic_type;
-
-               g_assert (!strcmp (((MonoObject *) rgt)->vtable->klass->name, "TypeBuilder"));
-               tb = (MonoReflectionTypeBuilder *) rgt;
-
-               icount = tb->interfaces ? mono_array_length (tb->interfaces) : 0;
-               ginst->is_dynamic = TRUE;
-       } else {
-               icount = klass->interface_count;
-       }
-
-       ginst->ifaces = g_new0 (MonoType *, icount);
-       ginst->count_ifaces = icount;
+       gclass->ifaces = g_new0 (MonoType *, icount);
+       gclass->count_ifaces = icount;
 
        for (i = 0; i < icount; i++) {
                MonoReflectionType *itype;
@@ -7900,15 +7981,13 @@ do_mono_reflection_bind_generic_parameters (MonoReflectionType *type, int type_a
                        itype = mono_array_get (tb->interfaces, MonoReflectionType *, i);
                else
                        itype = mono_type_get_object (domain, &klass->interfaces [i]->byval_arg);
-               ginst->ifaces [i] = mono_reflection_bind_generic_parameters (itype, type_argc, types);
-               if (!ginst->ifaces [i])
-                       ginst->ifaces [i] = itype->type;
+               gclass->ifaces [i] = mono_reflection_bind_generic_parameters (itype, type_argc, types);
+               if (!gclass->ifaces [i])
+                       gclass->ifaces [i] = itype->type;
        }
 
-       mono_class_create_generic (ginst);
-       mono_class_create_generic_2 (ginst);
-
-       g_hash_table_insert (klass->image->generic_inst_cache, ginst, ginst);
+       mono_class_create_generic (gclass);
+       mono_class_create_generic_2 (gclass);
 
        mono_loader_unlock ();
 
@@ -7922,7 +8001,7 @@ mono_reflection_bind_generic_parameters (MonoReflectionType *type, int type_argc
        MonoReflectionType *parent = NULL;
        MonoType *the_parent = NULL, *geninst;
        MonoReflectionTypeBuilder *tb = NULL;
-       MonoGenericInst *ginst;
+       MonoGenericClass *gclass;
        MonoDomain *domain;
 
        domain = mono_object_domain (type);
@@ -7939,31 +8018,44 @@ mono_reflection_bind_generic_parameters (MonoReflectionType *type, int type_argc
                pklass = klass->parent;
                if (pklass)
                        parent = mono_type_get_object (domain, &pklass->byval_arg);
-               else if (klass->generic_inst && klass->generic_inst->parent) {
-                       parent = mono_type_get_object (domain, klass->generic_inst->parent);
-                       pklass = mono_class_from_mono_type (klass->generic_inst->parent);
+               else if (klass->generic_class && klass->generic_class->parent) {
+                       parent = mono_type_get_object (domain, klass->generic_class->parent);
+                       pklass = mono_class_from_mono_type (klass->generic_class->parent);
                }
        }
 
-       if (pklass && pklass->generic_inst)
+       if (pklass && pklass->generic_class)
                the_parent = mono_reflection_bind_generic_parameters (parent, type_argc, types);
 
        geninst = do_mono_reflection_bind_generic_parameters (type, type_argc, types, the_parent);
        if (!geninst)
                return NULL;
 
-       ginst = geninst->data.generic_inst;
+       gclass = geninst->data.generic_class;
 
        return geninst;
 }
 
+static MonoType*
+dup_type (const MonoType *original)
+{
+       MonoType *r = g_new0 (MonoType, 1);
+       *r = *original;
+       r->attrs = original->attrs;
+       r->byref = original->byref;
+       mono_stats.generics_metadata_size += sizeof (MonoType);
+       return r;
+}
+
 MonoReflectionMethod*
 mono_reflection_bind_generic_method_parameters (MonoReflectionMethod *rmethod, MonoArray *types)
 {
        MonoMethod *method, *inflated;
        MonoReflectionMethodBuilder *mb = NULL;
+       MonoGenericContainer *container;
        MonoGenericMethod *gmethod;
        MonoGenericContext *context;
+       MonoGenericInst *ginst;
        int count, i;
 
        MONO_ARCH_SAVE_REGS;
@@ -7984,59 +8076,85 @@ mono_reflection_bind_generic_method_parameters (MonoReflectionMethod *rmethod, M
        if (count != mono_array_length (types))
                return NULL;
 
-       gmethod = g_new0 (MonoGenericMethod, 1);
-       gmethod->mtype_argc = count;
-       gmethod->mtype_argv = g_new0 (MonoType *, count);
+       container = ((MonoMethodNormal*) method)->generic_container;
+       g_assert (container);
+
+       if (!container->method_hash)
+               container->method_hash = g_hash_table_new (
+                       (GHashFunc) mono_metadata_generic_method_hash,
+                       (GCompareFunc) mono_metadata_generic_method_equal);
+
+       ginst = g_new0 (MonoGenericInst,1 );
+       ginst->type_argc = count;
+       ginst->type_argv = g_new0 (MonoType *, count);
        for (i = 0; i < count; i++) {
                MonoReflectionType *garg = mono_array_get (types, gpointer, i);
-               gmethod->mtype_argv [i] = garg->type;
+               ginst->type_argv [i] = dup_type (garg->type);
+
+               if (!ginst->is_open)
+                       ginst->is_open = mono_class_is_open_constructed_type (ginst->type_argv [i]);
+       }
+       ginst = mono_metadata_lookup_generic_inst (ginst);
+
+       gmethod = g_new0 (MonoGenericMethod, 1);
+       gmethod->container = container;
+       gmethod->inst = ginst;
+
+       inflated = g_hash_table_lookup (container->method_hash, gmethod);
+       if (inflated) {
+               g_free (gmethod);
+
+               return mono_method_get_object (mono_object_domain (rmethod), inflated, NULL);
        }
 
        gmethod->reflection_info = rmethod;
 
        context = g_new0 (MonoGenericContext, 1);
-       context->ginst = method->klass->generic_inst;
+       context->container = container;
+       context->gclass = method->klass->generic_class;
        context->gmethod = gmethod;
 
        inflated = mono_class_inflate_generic_method (method, context, NULL);
+       g_hash_table_insert (container->method_hash, gmethod, inflated);
 
-       return mono_method_get_object (
-               mono_object_domain (rmethod), inflated, NULL);
+       return mono_method_get_object (mono_object_domain (rmethod), inflated, NULL);
 }
 
 static MonoMethod *
-inflate_mono_method (MonoReflectionGenericInst *type, MonoMethod *method, MonoObject *obj)
+inflate_mono_method (MonoReflectionGenericClass *type, MonoMethod *method, MonoObject *obj)
 {
        MonoGenericMethod *gmethod;
-       MonoGenericInst *ginst;
+       MonoGenericClass *gclass;
        MonoGenericContext *context;
        int i;
 
-       ginst = type->type.type->data.generic_inst;
+       gclass = type->type.type->data.generic_class;
 
        gmethod = g_new0 (MonoGenericMethod, 1);
+       gmethod->inst = g_new0 (MonoGenericInst, 1);
        gmethod->reflection_info = obj;
 
-       gmethod->mtype_argc = method->signature->generic_param_count;
-       gmethod->mtype_argv = g_new0 (MonoType *, gmethod->mtype_argc);
+       gmethod->inst->type_argc = method->signature->generic_param_count;
+       gmethod->inst->type_argv = g_new0 (MonoType *, gmethod->inst->type_argc);
 
-       for (i = 0; i < gmethod->mtype_argc; i++) {
+       for (i = 0; i < gmethod->inst->type_argc; i++) {
                MonoMethodNormal *mn = (MonoMethodNormal *) method;
                MonoGenericParam *gparam = &mn->generic_container->type_params [i];
 
                g_assert (gparam->pklass);
-               gmethod->mtype_argv [i] = &gparam->pklass->byval_arg;
+               gmethod->inst->type_argv [i] = &gparam->pklass->byval_arg;
        }
 
        context = g_new0 (MonoGenericContext, 1);
-       context->ginst = ginst;
+       context->container = gclass->container_class->generic_container;
+       context->gclass = gclass;
        context->gmethod = gmethod;
 
-       return mono_class_inflate_generic_method (method, context, ginst->klass);
+       return mono_class_inflate_generic_method (method, context, gclass->klass);
 }
 
 static MonoMethod *
-inflate_method (MonoReflectionGenericInst *type, MonoObject *obj)
+inflate_method (MonoReflectionGenericClass *type, MonoObject *obj)
 {
        MonoMethod *method;
        MonoClass *klass;
@@ -8058,59 +8176,61 @@ inflate_method (MonoReflectionGenericInst *type, MonoObject *obj)
 }
 
 void
-mono_reflection_generic_inst_initialize (MonoReflectionGenericInst *type, MonoArray *methods, 
-       MonoArray *ctors, MonoArray *fields, MonoArray *properties, MonoArray *events)
+mono_reflection_generic_class_initialize (MonoReflectionGenericClass *type, MonoArray *methods, 
+                                         MonoArray *ctors, MonoArray *fields, MonoArray *properties,
+                                         MonoArray *events)
 {
-       MonoGenericInst *ginst;
-       MonoDynamicGenericInst *dginst;
+       MonoGenericClass *gclass;
+       MonoDynamicGenericClass *dgclass;
        MonoClass *klass, *gklass, *pklass;
        int i;
 
        MONO_ARCH_SAVE_REGS;
 
        klass = mono_class_from_mono_type (type->type.type);
-       ginst = type->type.type->data.generic_inst;
+       gclass = type->type.type->data.generic_class;
 
-       if (ginst->initialized)
+       if (gclass->initialized)
                return;
 
-       dginst = ginst->dynamic_info = g_new0 (MonoDynamicGenericInst, 1);
+       g_assert (gclass->is_dynamic);
+       dgclass = (MonoDynamicGenericClass *) gclass;
 
-       gklass = mono_class_from_mono_type (ginst->generic_type);
+       gklass = gclass->container_class;
        mono_class_init (gklass);
 
-       if (ginst->parent)
-               pklass = mono_class_from_mono_type (ginst->parent);
+       if (gclass->parent)
+               pklass = mono_class_from_mono_type (gclass->parent);
        else
                pklass = gklass->parent;
 
        mono_class_setup_parent (klass, pklass);
 
-       dginst->count_methods = methods ? mono_array_length (methods) : 0;
-       dginst->count_ctors = ctors ? mono_array_length (ctors) : 0;
-       dginst->count_fields = fields ? mono_array_length (fields) : 0;
-       dginst->count_properties = properties ? mono_array_length (properties) : 0;
-       dginst->count_events = events ? mono_array_length (events) : 0;
+       dgclass->count_methods = methods ? mono_array_length (methods) : 0;
+       dgclass->count_ctors = ctors ? mono_array_length (ctors) : 0;
+       dgclass->count_fields = fields ? mono_array_length (fields) : 0;
+       dgclass->count_properties = properties ? mono_array_length (properties) : 0;
+       dgclass->count_events = events ? mono_array_length (events) : 0;
 
-       dginst->methods = g_new0 (MonoMethod *, dginst->count_methods);
-       dginst->ctors = g_new0 (MonoMethod *, dginst->count_ctors);
-       dginst->fields = g_new0 (MonoClassField, dginst->count_fields);
-       dginst->properties = g_new0 (MonoProperty, dginst->count_properties);
-       dginst->events = g_new0 (MonoEvent, dginst->count_events);
+       dgclass->methods = g_new0 (MonoMethod *, dgclass->count_methods);
+       dgclass->ctors = g_new0 (MonoMethod *, dgclass->count_ctors);
+       dgclass->fields = g_new0 (MonoClassField, dgclass->count_fields);
+       dgclass->properties = g_new0 (MonoProperty, dgclass->count_properties);
+       dgclass->events = g_new0 (MonoEvent, dgclass->count_events);
 
-       for (i = 0; i < dginst->count_methods; i++) {
+       for (i = 0; i < dgclass->count_methods; i++) {
                MonoObject *obj = mono_array_get (methods, gpointer, i);
 
-               dginst->methods [i] = inflate_method (type, obj);
+               dgclass->methods [i] = inflate_method (type, obj);
        }
 
-       for (i = 0; i < dginst->count_ctors; i++) {
+       for (i = 0; i < dgclass->count_ctors; i++) {
                MonoObject *obj = mono_array_get (ctors, gpointer, i);
 
-               dginst->ctors [i] = inflate_method (type, obj);
+               dgclass->ctors [i] = inflate_method (type, obj);
        }
 
-       for (i = 0; i < dginst->count_fields; i++) {
+       for (i = 0; i < dgclass->count_fields; i++) {
                MonoObject *obj = mono_array_get (fields, gpointer, i);
                MonoClassField *field;
                MonoInflatedField *ifield;
@@ -8128,14 +8248,14 @@ mono_reflection_generic_inst_initialize (MonoReflectionGenericInst *type, MonoAr
                ifield->generic_type = field->type;
                ifield->reflection_info = obj;
 
-               dginst->fields [i] = *field;
-               dginst->fields [i].generic_info = ifield;
-               dginst->fields [i].type = mono_class_inflate_generic_type (field->type, ginst->context);
+               dgclass->fields [i] = *field;
+               dgclass->fields [i].generic_info = ifield;
+               dgclass->fields [i].type = mono_class_inflate_generic_type (field->type, gclass->context);
        }
 
-       for (i = 0; i < dginst->count_properties; i++) {
+       for (i = 0; i < dgclass->count_properties; i++) {
                MonoObject *obj = mono_array_get (properties, gpointer, i);
-               MonoProperty *property = &dginst->properties [i];
+               MonoProperty *property = &dgclass->properties [i];
 
                if (!strcmp (obj->vtable->klass->name, "PropertyBuilder")) {
                        MonoReflectionPropertyBuilder *pb = (MonoReflectionPropertyBuilder *) obj;
@@ -8158,9 +8278,9 @@ mono_reflection_generic_inst_initialize (MonoReflectionGenericInst *type, MonoAr
                        g_assert_not_reached ();
        }
 
-       for (i = 0; i < dginst->count_events; i++) {
+       for (i = 0; i < dgclass->count_events; i++) {
                MonoObject *obj = mono_array_get (events, gpointer, i);
-               MonoEvent *event = &dginst->events [i];
+               MonoEvent *event = &dgclass->events [i];
 
                if (!strcmp (obj->vtable->klass->name, "EventBuilder")) {
                        MonoReflectionEventBuilder *eb = (MonoReflectionEventBuilder *) obj;
@@ -8183,7 +8303,7 @@ mono_reflection_generic_inst_initialize (MonoReflectionGenericInst *type, MonoAr
                        g_assert_not_reached ();
        }
 
-       ginst->initialized = TRUE;
+       gclass->initialized = TRUE;
 }
 
 static void
@@ -8608,7 +8728,7 @@ mono_reflection_create_dynamic_method (MonoReflectionDynamicMethod *mb)
 /**
  * mono_reflection_lookup_dynamic_token:
  *
- *  Finish the Builder object pointed to by TOKEN and return the corresponding
+ * Finish the Builder object pointed to by TOKEN and return the corresponding
  * runtime structure.
  */
 gpointer
@@ -8654,7 +8774,7 @@ resolve_object (MonoImage *image, MonoObject *obj)
                         * Hopefully this has been filled in by calling CreateType() on the
                         * TypeBuilder.
                         */
-                       /**
+                       /*
                         * TODO: This won't work if the application finishes another 
                         * TypeBuilder instance instead of this one.
                         */
@@ -8735,3 +8855,281 @@ resolve_object (MonoImage *image, MonoObject *obj)
        return result;
 }
 
+
+/* SECURITY_ACTION_* are defined in mono/metadata/tabledefs.h */
+const static guint32 declsec_flags_map[] = {
+       0x00000000,                                     /* empty */
+       MONO_DECLSEC_FLAG_REQUEST,                      /* SECURITY_ACTION_REQUEST                      (x01) */
+       MONO_DECLSEC_FLAG_DEMAND,                       /* SECURITY_ACTION_DEMAND                       (x02) */
+       MONO_DECLSEC_FLAG_ASSERT,                       /* SECURITY_ACTION_ASSERT                       (x03) */
+       MONO_DECLSEC_FLAG_DENY,                         /* SECURITY_ACTION_DENY                         (x04) */
+       MONO_DECLSEC_FLAG_PERMITONLY,                   /* SECURITY_ACTION_PERMITONLY                   (x05) */
+       MONO_DECLSEC_FLAG_LINKDEMAND,                   /* SECURITY_ACTION_LINKDEMAND                   (x06) */
+       MONO_DECLSEC_FLAG_INHERITANCEDEMAND,            /* SECURITY_ACTION_INHERITANCEDEMAND            (x07) */
+       MONO_DECLSEC_FLAG_REQUEST_MINIMUM,              /* SECURITY_ACTION_REQUEST_MINIMUM              (x08) */
+       MONO_DECLSEC_FLAG_REQUEST_OPTIONAL,             /* SECURITY_ACTION_REQUEST_OPTIONAL             (x09) */
+       MONO_DECLSEC_FLAG_REQUEST_REFUSE,               /* SECURITY_ACTION_REQUEST_REFUSE               (x0A) */
+       MONO_DECLSEC_FLAG_PREJIT_GRANT,                 /* SECURITY_ACTION_PREJIT_GRANT                 (x0B) */
+       MONO_DECLSEC_FLAG_PREJIT_DENY,                  /* SECURITY_ACTION_PREJIT_DENY                  (x0C) */
+       MONO_DECLSEC_FLAG_NONCAS_DEMAND,                /* SECURITY_ACTION_NONCAS_DEMAND                (x0D) */
+       MONO_DECLSEC_FLAG_NONCAS_LINKDEMAND,            /* SECURITY_ACTION_NONCAS_LINKDEMAND            (x0E) */
+       MONO_DECLSEC_FLAG_NONCAS_INHERITANCEDEMAND,     /* SECURITY_ACTION_NONCAS_INHERITANCEDEMAND     (x0F) */
+       MONO_DECLSEC_FLAG_LINKDEMAND_CHOICE,            /* SECURITY_ACTION_LINKDEMAND_CHOICE            (x10) */
+       MONO_DECLSEC_FLAG_INHERITANCEDEMAND_CHOICE,     /* SECURITY_ACTION_INHERITANCEDEMAND_CHOICE     (x11) */
+       MONO_DECLSEC_FLAG_DEMAND_CHOICE,                /* SECURITY_ACTION_DEMAND_CHOICE                (x12) */
+};
+
+/*
+ * Returns flags that includes all available security action associated to the handle.
+ * @token: metadata token (either for a class or a method)
+ * @image: image where resides the metadata.
+ */
+static guint32
+mono_declsec_get_flags (MonoImage *image, guint32 token)
+{
+       guint32 index = mono_metadata_declsec_from_index (image, token);
+       MonoTableInfo *t = &image->tables [MONO_TABLE_DECLSECURITY];
+       guint32 result = 0;
+       guint32 action;
+       int i;
+
+       for (i = index; i < t->rows; i++) {
+               guint32 cols [MONO_DECL_SECURITY_SIZE];
+
+               mono_metadata_decode_row (t, i, cols, MONO_DECL_SECURITY_SIZE);
+               if (cols [MONO_DECL_SECURITY_PARENT] != token)
+                       break;
+
+               action = cols [MONO_DECL_SECURITY_ACTION];
+               if ((action >= MONO_DECLSEC_ACTION_MIN) && (action <= MONO_DECLSEC_ACTION_MAX)) {
+                       result |= declsec_flags_map [action];
+               } else {
+                       g_assert_not_reached ();
+               }
+       }
+       return result;
+}
+
+/*
+ * Get the security actions (in the form of flags) associated with the specified method.
+ *
+ * @method: The method for which we want the declarative security flags.
+ * Return the declarative security flags for the method (only).
+ *
+ * Note: To keep MonoMethod size down we do not cache the declarative security flags
+ *       (except for the stack modifiers which are kept in the MonoJitInfo structure)
+ */
+guint32
+mono_declsec_flags_from_method (MonoMethod *method)
+{
+       if (method->flags & METHOD_ATTRIBUTE_HAS_SECURITY) {
+               /* FIXME: No cache (for the moment) */
+               guint32 idx = find_method_index (method);
+               idx <<= MONO_HAS_DECL_SECURITY_BITS;
+               idx |= MONO_HAS_DECL_SECURITY_METHODDEF;
+               return mono_declsec_get_flags (method->klass->image, idx);
+       }
+       return 0;
+}
+
+/*
+ * Get the security actions (in the form of flags) associated with the specified class.
+ *
+ * @klass: The class for which we want the declarative security flags.
+ * Return the declarative security flags for the class.
+ *
+ * Note: We cache the flags inside the MonoClass structure as this will get 
+ *       called very often (at least for each method).
+ */
+guint32
+mono_declsec_flags_from_class (MonoClass *klass)
+{
+       if (klass->flags & TYPE_ATTRIBUTE_HAS_SECURITY) {
+               if (!klass->declsec_flags) {
+                       guint32 idx = mono_metadata_token_index (klass->type_token);
+                       idx <<= MONO_HAS_DECL_SECURITY_BITS;
+                       idx |= MONO_HAS_DECL_SECURITY_TYPEDEF;
+                       /* we cache the flags on classes */
+                       klass->declsec_flags = mono_declsec_get_flags (klass->image, idx);
+               }
+               return klass->declsec_flags;
+       }
+       return 0;
+}
+
+/*
+ * Get the security actions (in the form of flags) associated with the specified assembly.
+ *
+ * @assembly: The assembly for which we want the declarative security flags.
+ * Return the declarative security flags for the assembly.
+ */
+guint32
+mono_declsec_flags_from_assembly (MonoAssembly *assembly)
+{
+       guint32 idx = 1; /* there is only one assembly */
+       idx <<= MONO_HAS_DECL_SECURITY_BITS;
+       idx |= MONO_HAS_DECL_SECURITY_ASSEMBLY;
+       return mono_declsec_get_flags (assembly->image, idx);
+}
+
+
+/*
+ * Fill actions for the specific index (which may either be an encoded class token or
+ * an encoded method token) from the metadata image.
+ * Returns TRUE if some actions requiring code generation are present, FALSE otherwise.
+ */
+static MonoBoolean
+fill_actions_from_index (MonoImage *image, guint32 token, MonoDeclSecurityActions* actions)
+{
+       MonoBoolean result = FALSE;
+       MonoTableInfo *t;
+       guint32 cols [MONO_DECL_SECURITY_SIZE];
+       int index = mono_metadata_declsec_from_index (image, token);
+       int i;
+
+       t  = &image->tables [MONO_TABLE_DECLSECURITY];
+       for (i = index; i < t->rows; i++) {
+               mono_metadata_decode_row (t, i, cols, MONO_DECL_SECURITY_SIZE);
+
+               if (cols [MONO_DECL_SECURITY_PARENT] != token)
+                       return result;
+
+               /* if present only replace (class) permissions with method permissions */
+               /* if empty accept either class or method permissions */
+               switch (cols [MONO_DECL_SECURITY_ACTION]) {
+               case SECURITY_ACTION_DEMAND:
+                       if (!actions->demand.blob) {
+                               const char *blob = mono_metadata_blob_heap (image, cols [MONO_DECL_SECURITY_PERMISSIONSET]);
+                               actions->demand.blob = (char*) (blob + 2);
+                               actions->demand.size = mono_metadata_decode_blob_size (blob, &blob);
+                               result = TRUE;
+                       }
+                       break;
+               case SECURITY_ACTION_NONCASDEMAND:
+                       if (!actions->noncasdemand.blob) {
+                               const char *blob = mono_metadata_blob_heap (image, cols [MONO_DECL_SECURITY_PERMISSIONSET]);
+                               actions->noncasdemand.blob = (char*) (blob + 2);
+                               actions->noncasdemand.size = mono_metadata_decode_blob_size (blob, &blob);
+                               result = TRUE;
+                       }
+                       break;
+               case SECURITY_ACTION_DEMANDCHOICE:
+                       if (!actions->demandchoice.blob) {
+                               const char *blob = mono_metadata_blob_heap (image, cols [MONO_DECL_SECURITY_PERMISSIONSET]);
+                               actions->demandchoice.blob = (char*) (blob + 2);
+                               actions->demandchoice.size = mono_metadata_decode_blob_size (blob, &blob);
+                               result = TRUE;
+                       }
+                       break;
+               }
+       }
+
+       return result;
+}
+
+/*
+ * Collect all actions (that requires to generate code in mini) assigned for
+ * the specified method.
+ * Note: Don't use the content of actions if the function return FALSE.
+ */
+MonoBoolean
+mono_declsec_get_demands (MonoMethod *method, MonoDeclSecurityActions* demands)
+{
+       MonoImage *image = method->klass->image;
+       MonoBoolean result = FALSE;
+       guint32 flags;
+
+       /* quick exit if no declarative security is present in the metadata */
+       if (!image->tables [MONO_TABLE_DECLSECURITY].rows)
+               return FALSE;
+
+       memset (demands, 0, sizeof (MonoDeclSecurityActions));
+
+       /* First we look for method-level attributes */
+       if (method->flags & METHOD_ATTRIBUTE_HAS_SECURITY) {
+               guint32 idx = find_method_index (method);
+               idx <<= MONO_HAS_DECL_SECURITY_BITS;
+               idx |= MONO_HAS_DECL_SECURITY_METHODDEF;
+               result = fill_actions_from_index (image, idx, demands);
+       }
+
+       /* Next we fill holes with class-level attributes */
+       /* Here we use (or create) the class declarative cache to look for demands */
+       flags = mono_declsec_flags_from_class (method->klass);
+       if (flags & (MONO_DECLSEC_FLAG_DEMAND | MONO_DECLSEC_FLAG_NONCAS_DEMAND | MONO_DECLSEC_FLAG_DEMAND_CHOICE)) {
+               guint32 idx = mono_metadata_token_index (method->klass->type_token);
+               idx <<= MONO_HAS_DECL_SECURITY_BITS;
+               idx |= MONO_HAS_DECL_SECURITY_TYPEDEF;
+               result |= fill_actions_from_index (image, idx, demands);
+       }
+
+       /* The boolean return value is used as a shortcut in case nothing needs to
+          be generated (e.g. LinkDemand[Choice] and InheritanceDemand[Choice]) */
+       return result;
+}
+
+static MonoBoolean
+get_declsec_action (MonoImage *image, guint32 token, guint32 action, MonoDeclSecurityEntry *entry)
+{
+       guint32 cols [MONO_DECL_SECURITY_SIZE];
+       MonoTableInfo *t;
+       int i;
+
+       int index = mono_metadata_declsec_from_index (image, token);
+       if (index == -1)
+               return FALSE;
+
+       t =  &image->tables [MONO_TABLE_DECLSECURITY];
+       for (i = index; i < t->rows; i++) {
+               mono_metadata_decode_row (t, i, cols, MONO_DECL_SECURITY_SIZE);
+
+               /* shortcut - index are ordered */
+               if (token != cols [MONO_DECL_SECURITY_PARENT])
+                       return FALSE;
+
+               if (cols [MONO_DECL_SECURITY_ACTION] == action) {
+                       const char *metadata = mono_metadata_blob_heap (image, cols [MONO_DECL_SECURITY_PERMISSIONSET]);
+                       entry->blob = (char*) (metadata + 2);
+                       entry->size = mono_metadata_decode_blob_size (metadata, &metadata);
+                       return TRUE;
+               }
+       }
+
+       return FALSE;
+}
+
+MonoBoolean
+mono_declsec_get_method_action (MonoMethod *method, guint32 action, MonoDeclSecurityEntry *entry)
+{
+       if (method->flags & METHOD_ATTRIBUTE_HAS_SECURITY) {
+               guint32 idx = find_method_index (method);
+               idx <<= MONO_HAS_DECL_SECURITY_BITS;
+               idx |= MONO_HAS_DECL_SECURITY_METHODDEF;
+               return get_declsec_action (method->klass->image, idx, action, entry);
+       }
+       return FALSE;
+}
+
+MonoBoolean
+mono_declsec_get_class_action (MonoClass *klass, guint32 action, MonoDeclSecurityEntry *entry)
+{
+       /* use cache */
+       guint32 flags = mono_declsec_flags_from_class (klass);
+       if (declsec_flags_map [action] & flags) {
+               guint32 idx = mono_metadata_token_index (klass->type_token);
+               idx <<= MONO_HAS_DECL_SECURITY_BITS;
+               idx |= MONO_HAS_DECL_SECURITY_TYPEDEF;
+               return get_declsec_action (klass->image, idx, action, entry);
+       }
+       return FALSE;
+}
+
+MonoBoolean
+mono_declsec_get_assembly_action (MonoAssembly *assembly, guint32 action, MonoDeclSecurityEntry *entry)
+{
+       guint32 idx = 1; /* there is only one assembly */
+       idx <<= MONO_HAS_DECL_SECURITY_BITS;
+       idx |= MONO_HAS_DECL_SECURITY_ASSEMBLY;
+
+       return get_declsec_action (assembly->image, idx, action, entry);
+}