-/*
- * mempool.c: efficient memory allocation
+/**
+ * \file
+ * efficient memory allocation
*
* MonoMemPool is for fast allocation of memory. We free
* all memory when the pool is destroyed.
#include "mempool.h"
#include "mempool-internals.h"
+#include "utils/mono-compiler.h"
/*
* MonoMemPool is for fast allocation of memory. We free
/**
* mono_mempool_new_size:
- * @initial_size: the amount of memory to initially reserve for the memory pool.
*
- * Returns: a new memory pool with a specific initial memory reservation.
+ * clang's ThreadSanitizer detects races of total_bytes_allocated and pool->d.allocated throughout the functions
+ * * mono_mempool_alloc
+ * * mono_mempool_new_size
+ * * mono_mempool_destroy
+ * while these races could lead to wrong values, total_bytes_allocated is just used for debugging / reporting and since
+ * the mempool.c functions are called quite often, a discussion led the the conclusion of ignoring these races:
+ * https://bugzilla.xamarin.com/show_bug.cgi?id=57936
+ *
+ * \param initial_size the amount of memory to initially reserve for the memory pool.
+ * \returns a new memory pool with a specific initial memory reservation.
*/
+MONO_NO_SANITIZE_THREAD
MonoMemPool *
mono_mempool_new_size (int initial_size)
{
/**
* mono_mempool_destroy:
- * @pool: the memory pool to destroy
+ *
+ * clang's ThreadSanitizer detects races of total_bytes_allocated and pool->d.allocated throughout the functions
+ * * mono_mempool_alloc
+ * * mono_mempool_new_size
+ * * mono_mempool_destroy
+ * while these races could lead to wrong values, total_bytes_allocated is just used for debugging / reporting and since
+ * the mempool.c functions are called quite often, a discussion led the the conclusion of ignoring these races:
+ * https://bugzilla.xamarin.com/show_bug.cgi?id=57936
+ *
+ * \param pool the memory pool to destroy
*
* Free all memory associated with this pool.
*/
+MONO_NO_SANITIZE_THREAD
void
mono_mempool_destroy (MonoMemPool *pool)
{
/**
* mono_mempool_invalidate:
- * @pool: the memory pool to invalidate
+ * \param pool the memory pool to invalidate
*
* Fill the memory associated with this pool to 0x2a (42). Useful for debugging.
*/
/**
* mono_mempool_stats:
- * @pool: the momory pool we need stats for
+ * \param pool the memory pool we need stats for
*
* Print a few stats about the mempool:
* - Total memory allocated (malloced) by mem pool
{
MonoMemPool *p;
int count = 0;
- guint32 still_free = pool->end - pool->pos;
+ guint32 still_free;
p = pool;
while (p) {
count++;
}
if (pool) {
+ still_free = pool->end - pool->pos;
g_print ("Mempool %p stats:\n", pool);
g_print ("Total mem allocated: %d\n", pool->d.allocated);
g_print ("Num chunks: %d\n", count);
static void
mono_backtrace (int size)
{
- void *array[BACKTRACE_DEPTH];
- char **names;
- int i, symbols;
- static gboolean inited;
-
- if (!inited) {
- mono_os_mutex_init_recursive (&mempool_tracing_lock);
- inited = TRUE;
- }
-
- mono_os_mutex_lock (&mempool_tracing_lock);
- g_print ("Allocating %d bytes\n", size);
- symbols = backtrace (array, BACKTRACE_DEPTH);
- names = backtrace_symbols (array, symbols);
- for (i = 1; i < symbols; ++i) {
- g_print ("\t%s\n", names [i]);
- }
- free (names);
- mono_os_mutex_unlock (&mempool_tracing_lock);
+ void *array[BACKTRACE_DEPTH];
+ char **names;
+ int i, symbols;
+ static gboolean inited;
+
+ if (!inited) {
+ mono_os_mutex_init_recursive (&mempool_tracing_lock);
+ inited = TRUE;
+ }
+
+ mono_os_mutex_lock (&mempool_tracing_lock);
+ g_print ("Allocating %d bytes\n", size);
+ MONO_ENTER_GC_SAFE;
+ symbols = backtrace (array, BACKTRACE_DEPTH);
+ names = backtrace_symbols (array, symbols);
+ MONO_EXIT_GC_SAFE;
+ for (i = 1; i < symbols; ++i) {
+ g_print ("\t%s\n", names [i]);
+ }
+ g_free (names);
+ mono_os_mutex_unlock (&mempool_tracing_lock);
}
#endif
/**
- * mono_mempool_alloc:
+ * get_next_size:
* @pool: the memory pool to use
* @size: size of the memory entity we are trying to allocate
*
/**
* mono_mempool_alloc:
- * @pool: the memory pool to use
- * @size: size of the memory block
*
- * Allocates a new block of memory in @pool.
+ * clang's ThreadSanitizer detects races of total_bytes_allocated and pool->d.allocated throughout the functions
+ * * mono_mempool_alloc
+ * * mono_mempool_new_size
+ * * mono_mempool_destroy
+ * while these races could lead to wrong values, total_bytes_allocated is just used for debugging / reporting and since
+ * the mempool.c functions are called quite often, a discussion led the the conclusion of ignoring these races:
+ * https://bugzilla.xamarin.com/show_bug.cgi?id=57936
+ *
+ * \param pool the memory pool to use
+ * \param size size of the memory block
*
- * Returns: the address of a newly allocated memory block.
+ * Allocates a new block of memory in \p pool .
+ *
+ * \returns the address of a newly allocated memory block.
*/
+MONO_NO_SANITIZE_THREAD
gpointer
mono_mempool_alloc (MonoMemPool *pool, guint size)
{
/**
* mono_mempool_alloc0:
*
- * same as mono_mempool_alloc, but fills memory with zero.
+ * same as \c mono_mempool_alloc, but fills memory with zero.
*/
gpointer
mono_mempool_alloc0 (MonoMemPool *pool, guint size)
/**
* mono_mempool_contains_addr:
*
- * Determines whenever ADDR is inside the memory used by the mempool.
+ * Determines whether \p addr is inside the memory used by the mempool.
*/
gboolean
mono_mempool_contains_addr (MonoMemPool *pool,
return res;
}
+char*
+mono_mempool_strdup_vprintf (MonoMemPool *pool, const char *format, va_list args)
+{
+ size_t buflen;
+ char *buf;
+ va_list args2;
+ va_copy (args2, args);
+ int len = vsnprintf (NULL, 0, format, args2);
+ va_end (args2);
+
+ if (len >= 0 && (buf = (char*)mono_mempool_alloc (pool, (buflen = (size_t) (len + 1)))) != NULL) {
+ vsnprintf (buf, buflen, format, args);
+ } else {
+ buf = NULL;
+ }
+ return buf;
+}
+
+char*
+mono_mempool_strdup_printf (MonoMemPool *pool, const char *format, ...)
+{
+ char *buf;
+ va_list args;
+ va_start (args, format);
+ buf = mono_mempool_strdup_vprintf (pool, format, args);
+ va_end (args);
+ return buf;
+}
+
/**
* mono_mempool_get_allocated:
*
projects / mono.git / blobdiff