* domain lock.
*/
static CRITICAL_SECTION loader_mutex;
+static gboolean loader_lock_inited;
/* Statistics */
static guint32 inflated_signatures_size;
static guint32 memberref_sig_cache_size;
+static guint32 methods_size;
+static guint32 signatures_size;
/*
* This TLS variable contains the last type load error encountered by the loader.
*/
guint32 loader_lock_nest_id;
+static void dllmap_cleanup (void);
+
void
mono_loader_init ()
{
if (!inited) {
InitializeCriticalSection (&loader_mutex);
+ loader_lock_inited = TRUE;
loader_error_thread_id = TlsAlloc ();
loader_lock_nest_id = TlsAlloc ();
MONO_COUNTER_GENERICS | MONO_COUNTER_INT, &inflated_signatures_size);
mono_counters_register ("Memberref signature cache size",
MONO_COUNTER_METADATA | MONO_COUNTER_INT, &memberref_sig_cache_size);
+ mono_counters_register ("MonoMethod size",
+ MONO_COUNTER_METADATA | MONO_COUNTER_INT, &methods_size);
+ mono_counters_register ("MonoMethodSignature size",
+ MONO_COUNTER_METADATA | MONO_COUNTER_INT, &signatures_size);
inited = TRUE;
}
void
mono_loader_cleanup (void)
{
+ dllmap_cleanup ();
+
TlsFree (loader_error_thread_id);
TlsFree (loader_lock_nest_id);
- /*DeleteCriticalSection (&loader_mutex);*/
+ DeleteCriticalSection (&loader_mutex);
+ loader_lock_inited = FALSE;
}
/*
* assert.
*/
if (ref_only)
- g_warning ("Cannot resolve dependency to assembly '%s' because it has not been preloaded. When using the ReflectionOnly APIs, dependent assemblies must be pre-loaded or loaded on demand through the ReflectionOnlyAssemblyResolve event.", assembly_name);
+ mono_trace (G_LOG_LEVEL_WARNING, MONO_TRACE_ASSEMBLY, "Cannot resolve dependency to assembly '%s' because it has not been preloaded. When using the ReflectionOnly APIs, dependent assemblies must be pre-loaded or loaded on demand through the ReflectionOnlyAssemblyResolve event.", assembly_name);
else
- g_warning ("Could not load file or assembly '%s' or one of its dependencies.", assembly_name);
+ mono_trace (G_LOG_LEVEL_WARNING, MONO_TRACE_ASSEMBLY, "Could not load file or assembly '%s' or one of its dependencies.", assembly_name);
set_loader_error (error);
}
* can't deal with load errors, and this message is more helpful than an
* assert.
*/
- g_warning ("The class %s could not be loaded, used in %s", class_name, assembly_name);
+ mono_trace_warning (MONO_TRACE_TYPE, "The class %s could not be loaded, used in %s", class_name, assembly_name);
set_loader_error (error);
}
fname = mono_metadata_string_heap (image, cols [MONO_MEMBERREF_NAME]);
- if (!mono_verifier_verify_memberref_signature (image, cols [MONO_MEMBERREF_SIGNATURE], NULL)) {
+ if (!mono_verifier_verify_memberref_field_signature (image, cols [MONO_MEMBERREF_SIGNATURE], NULL)) {
mono_loader_set_error_bad_image (g_strdup_printf ("Bad field signature class token 0x%08x field name %s token 0x%08x on image %s", class, fname, token, image->name));
return NULL;
}
continue;
method = mono_get_method (klass->image, MONO_TOKEN_METHOD_DEF | (klass->method.first + i + 1), klass);
- other_sig = mono_method_signature (method);
- if (method && other_sig && (sig->call_convention != MONO_CALL_VARARG) && mono_metadata_signature_equal (sig, other_sig))
- return method;
+ if (method) {
+ other_sig = mono_method_signature (method);
+ if (other_sig && (sig->call_convention != MONO_CALL_VARARG) && mono_metadata_signature_equal (sig, other_sig))
+ return method;
+ }
}
}
MonoMethod *m = klass->methods [i];
MonoMethodSignature *msig;
+ /* We must cope with failing to load some of the types. */
+ if (!m)
+ continue;
+
if (!((fqname && !strcmp (m->name, fqname)) ||
(qname && !strcmp (m->name, qname)) ||
(name && !strcmp (m->name, name))))
if (name [0] == '.' && (!strcmp (name, ".ctor") || !strcmp (name, ".cctor")))
break;
- g_assert (from_class->interface_offsets_count == in_class->interface_offsets_count);
+ /*
+ * This happens when we fail to lazily load the interfaces of one of the types.
+ * On such case we can't just bail out since user code depends on us trying harder.
+ */
+ if (from_class->interface_offsets_count != in_class->interface_offsets_count) {
+ in_class = in_class->parent;
+ from_class = from_class->parent;
+ continue;
+ }
+
for (i = 0; i < in_class->interface_offsets_count; i++) {
MonoClass *in_ic = in_class->interfaces_packed [i];
MonoClass *from_ic = from_class->interfaces_packed [i];
}
static MonoMethodSignature*
-inflate_generic_signature (MonoImage *image, MonoMethodSignature *sig, MonoGenericContext *context)
+inflate_generic_signature_checked (MonoImage *image, MonoMethodSignature *sig, MonoGenericContext *context, MonoError *error)
{
MonoMethodSignature *res;
gboolean is_open;
int i;
+ mono_error_init (error);
if (!context)
return sig;
res = g_malloc0 (MONO_SIZEOF_METHOD_SIGNATURE + ((gint32)sig->param_count) * sizeof (MonoType*));
res->param_count = sig->param_count;
res->sentinelpos = -1;
- res->ret = mono_class_inflate_generic_type (sig->ret, context);
+ res->ret = mono_class_inflate_generic_type_checked (sig->ret, context, error);
+ if (!mono_error_ok (error))
+ goto fail;
is_open = mono_class_is_open_constructed_type (res->ret);
for (i = 0; i < sig->param_count; ++i) {
- res->params [i] = mono_class_inflate_generic_type (sig->params [i], context);
+ res->params [i] = mono_class_inflate_generic_type_checked (sig->params [i], context, error);
+ if (!mono_error_ok (error))
+ goto fail;
+
if (!is_open)
is_open = mono_class_is_open_constructed_type (res->params [i]);
}
res->has_type_parameters = is_open;
res->is_inflated = 1;
return res;
+
+fail:
+ if (res->ret)
+ mono_metadata_free_type (res->ret);
+ for (i = 0; i < sig->param_count; ++i) {
+ if (res->params [i])
+ mono_metadata_free_type (res->params [i]);
+ }
+ g_free (res);
+ return NULL;
}
static MonoMethodHeader*
if (method->klass->generic_class)
return mono_method_signature (method);
- if (image->dynamic)
- /* FIXME: This might be incorrect for vararg methods */
- return mono_method_signature (method);
+ if (image->dynamic) {
+ sig = mono_reflection_lookup_signature (image, method, token);
+ } else {
+ mono_metadata_decode_row (&image->tables [MONO_TABLE_MEMBERREF], idx-1, cols, MONO_MEMBERREF_SIZE);
+ sig_idx = cols [MONO_MEMBERREF_SIGNATURE];
- mono_metadata_decode_row (&image->tables [MONO_TABLE_MEMBERREF], idx-1, cols, MONO_MEMBERREF_SIZE);
- sig_idx = cols [MONO_MEMBERREF_SIGNATURE];
+ sig = find_cached_memberref_sig (image, sig_idx);
+ if (!sig) {
+ if (!mono_verifier_verify_memberref_method_signature (image, sig_idx, NULL)) {
+ guint32 class = cols [MONO_MEMBERREF_CLASS] & MONO_MEMBERREF_PARENT_MASK;
+ const char *fname = mono_metadata_string_heap (image, cols [MONO_MEMBERREF_NAME]);
- sig = find_cached_memberref_sig (image, sig_idx);
- if (!sig) {
- if (!mono_verifier_verify_memberref_signature (image, sig_idx, NULL)) {
+ mono_loader_set_error_bad_image (g_strdup_printf ("Bad method signature class token 0x%08x field name %s token 0x%08x on image %s", class, fname, token, image->name));
+ return NULL;
+ }
+
+ ptr = mono_metadata_blob_heap (image, sig_idx);
+ mono_metadata_decode_blob_size (ptr, &ptr);
+ sig = mono_metadata_parse_method_signature (image, 0, ptr, NULL);
+ if (!sig)
+ return NULL;
+ sig = cache_memberref_sig (image, sig_idx, sig);
+ }
+ /* FIXME: we probably should verify signature compat in the dynamic case too*/
+ if (!mono_verifier_is_sig_compatible (image, method, sig)) {
guint32 class = cols [MONO_MEMBERREF_CLASS] & MONO_MEMBERREF_PARENT_MASK;
const char *fname = mono_metadata_string_heap (image, cols [MONO_MEMBERREF_NAME]);
- mono_loader_set_error_bad_image (g_strdup_printf ("Bad method signature class token 0x%08x field name %s token 0x%08x on image %s", class, fname, token, image->name));
+ mono_loader_set_error_bad_image (g_strdup_printf ("Incompatible method signature class token 0x%08x field name %s token 0x%08x on image %s", class, fname, token, image->name));
return NULL;
}
-
- ptr = mono_metadata_blob_heap (image, sig_idx);
- mono_metadata_decode_blob_size (ptr, &ptr);
- sig = mono_metadata_parse_method_signature (image, 0, ptr, NULL);
- if (!sig)
- return NULL;
- sig = cache_memberref_sig (image, sig_idx, sig);
}
- if (!mono_verifier_is_sig_compatible (image, method, sig)) {
- guint32 class = cols [MONO_MEMBERREF_CLASS] & MONO_MEMBERREF_PARENT_MASK;
- const char *fname = mono_metadata_string_heap (image, cols [MONO_MEMBERREF_NAME]);
-
- mono_loader_set_error_bad_image (g_strdup_printf ("Incompatible method signature class token 0x%08x field name %s token 0x%08x on image %s", class, fname, token, image->name));
- return NULL;
- }
if (context) {
+ MonoError error;
MonoMethodSignature *cached;
/* This signature is not owned by a MonoMethod, so need to cache */
- sig = inflate_generic_signature (image, sig, context);
+ sig = inflate_generic_signature_checked (image, sig, context, &error);
+ if (!mono_error_ok (&error)) {/*XXX bubble up this and kill one use of loader errors */
+ mono_loader_set_error_bad_image (g_strdup_printf ("Could not inflate signature %s", mono_error_get_message (&error)));
+ mono_error_cleanup (&error);
+ return NULL;
+ }
+
cached = mono_metadata_get_inflated_signature (sig, context);
if (cached != sig)
mono_metadata_free_inflated_signature (sig);
sig_idx = cols [MONO_MEMBERREF_SIGNATURE];
- if (!mono_verifier_verify_memberref_signature (image, sig_idx, NULL)) {
+ if (!mono_verifier_verify_memberref_method_signature (image, sig_idx, NULL)) {
mono_loader_set_error_method_load (klass->name, mname);
return NULL;
}
g_assert (param_count);
inst = mono_metadata_parse_generic_inst (image, NULL, param_count, ptr, &ptr);
+ if (!inst)
+ return NULL;
+
if (context && inst->is_open) {
inst = mono_metadata_inflate_generic_inst (inst, context, &error);
if (!mono_error_ok (&error)) {
mono_loader_unlock ();
}
+static void
+free_dllmap (MonoDllMap *map)
+{
+ while (map) {
+ MonoDllMap *next = map->next;
+
+ g_free (map->dll);
+ g_free (map->target);
+ g_free (map->func);
+ g_free (map->target_func);
+ g_free (map);
+ map = next;
+ }
+}
+
+static void
+dllmap_cleanup (void)
+{
+ free_dllmap (global_dll_map);
+ global_dll_map = NULL;
+}
+
static GHashTable *global_module_map;
static MonoDl*
mono_loader_unlock ();
return res;
}
- res = mono_dl_open (name, flags, NULL);
+ res = mono_dl_open (name, flags, err);
if (res)
g_hash_table_insert (global_module_map, g_strdup (name), res);
mono_loader_unlock ();
orig_scope = method_aux->dll;
}
else {
- if (!piinfo->implmap_idx)
+ if (!piinfo->implmap_idx || piinfo->implmap_idx > im->rows)
return NULL;
mono_metadata_decode_row (im, piinfo->implmap_idx - 1, im_cols, MONO_IMPLMAP_SIZE);
+ if (!im_cols [MONO_IMPLMAP_SCOPE] || im_cols [MONO_IMPLMAP_SCOPE] > mr->rows)
+ return NULL;
+
piinfo->piflags = im_cols [MONO_IMPLMAP_FLAGS];
import = mono_metadata_string_heap (image, im_cols [MONO_IMPLMAP_NAME]);
scope_token = mono_metadata_decode_row_col (mr, im_cols [MONO_IMPLMAP_SCOPE] - 1, MONO_MODULEREF_NAME);
if (!module) {
void *iter = NULL;
- while ((full_name = mono_dl_build_path (NULL, file_name, &iter))) {
+ char *mdirname = g_path_get_dirname (image->name);
+ while ((full_name = mono_dl_build_path (mdirname, file_name, &iter))) {
mono_trace (G_LOG_LEVEL_INFO, MONO_TRACE_DLLIMPORT,
- "DllImport loading location: '%s'.", full_name);
+ "DllImport loading library: '%s'.", full_name);
module = cached_module_load (full_name, MONO_DL_LAZY, &error_msg);
if (!module) {
mono_trace (G_LOG_LEVEL_INFO, MONO_TRACE_DLLIMPORT,
- "DllImport error loading library: '%s'.",
- error_msg);
+ "DllImport error loading library '%s'.",
+ error_msg);
g_free (error_msg);
}
g_free (full_name);
if (module)
break;
}
+ g_free (mdirname);
}
if (!module) {
void *iter = NULL;
- while ((full_name = mono_dl_build_path (".", file_name, &iter))) {
+ while ((full_name = mono_dl_build_path (NULL, file_name, &iter))) {
mono_trace (G_LOG_LEVEL_INFO, MONO_TRACE_DLLIMPORT,
- "DllImport loading library: '%s'.", full_name);
+ "DllImport loading location: '%s'.", full_name);
module = cached_module_load (full_name, MONO_DL_LAZY, &error_msg);
if (!module) {
mono_trace (G_LOG_LEVEL_INFO, MONO_TRACE_DLLIMPORT,
- "DllImport error loading library '%s'.",
- error_msg);
+ "DllImport error loading library: '%s'.",
+ error_msg);
g_free (error_msg);
}
g_free (full_name);
return NULL;
}
+#ifdef TARGET_WIN32
+ if (import && import [0] == '#' && isdigit (import [1])) {
+ char *end;
+ long id;
+
+ id = strtol (import + 1, &end, 10);
+ if (id > 0 && *end == '\0')
+ import++;
+ }
+#endif
mono_trace (G_LOG_LEVEL_INFO, MONO_TRACE_DLLIMPORT,
"Searching for '%s'.", import);
"Probing '%s'.", mangled_name2);
error_msg = mono_dl_symbol (module, mangled_name2, &piinfo->addr);
+ g_free (error_msg);
+ error_msg = NULL;
if (piinfo->addr)
mono_trace (G_LOG_LEVEL_INFO, MONO_TRACE_DLLIMPORT,
mono_metadata_decode_row (&image->tables [MONO_TABLE_METHOD], idx - 1, cols, 6);
if ((cols [2] & METHOD_ATTRIBUTE_PINVOKE_IMPL) ||
- (cols [1] & METHOD_IMPL_ATTRIBUTE_INTERNAL_CALL))
+ (cols [1] & METHOD_IMPL_ATTRIBUTE_INTERNAL_CALL)) {
result = (MonoMethod *)mono_image_alloc0 (image, sizeof (MonoMethodPInvoke));
- else
+ } else {
result = (MonoMethod *)mono_image_alloc0 (image, sizeof (MonoMethod));
+ methods_size += sizeof (MonoMethod);
+ }
mono_stats.method_count ++;
mono_class_init (constrained_class);
method = *cil_method;
original_sig = sig = mono_method_signature (method);
- if (sig == NULL)
+ if (sig == NULL) {
+ mono_loader_unlock ();
return NULL;
+ }
if (method->is_inflated && sig->generic_param_count) {
MonoMethodInflated *imethod = (MonoMethodInflated *) method;
* any type argument which a concrete type. See #325283.
*/
if (method_context->class_inst) {
+ MonoError error;
MonoGenericContext ctx;
ctx.method_inst = NULL;
ctx.class_inst = method_context->class_inst;
-
- sig = inflate_generic_signature (method->klass->image, sig, &ctx);
- if (sig == NULL)
+ /*Fixme, property propagate this error*/
+ sig = inflate_generic_signature_checked (method->klass->image, sig, &ctx, &error);
+ if (!mono_error_ok (&error)) {
+ mono_loader_unlock ();
+ mono_error_cleanup (&error);
return NULL;
+ }
}
}
for (i = 0; i < signature->param_count + 1; ++i)
if (dyn_specs [i]) {
mspecs [i] = g_new0 (MonoMarshalSpec, 1);
+ memcpy (mspecs [i], dyn_specs [i], sizeof (MonoMarshalSpec));
mspecs [i]->data.custom_data.custom_name = g_strdup (dyn_specs [i]->data.custom_data.custom_name);
mspecs [i]->data.custom_data.cookie = g_strdup (dyn_specs [i]->data.custom_data.cookie);
}
return GPOINTER_TO_UINT (TlsGetValue (loader_lock_nest_id)) > 0;
}
+/*
+ * mono_loader_lock_if_inited:
+ *
+ * Acquire the loader lock if it has been initialized, no-op otherwise. This can
+ * be used in runtime initialization code which can be executed before mono_loader_init ().
+ */
+void
+mono_loader_lock_if_inited (void)
+{
+ if (loader_lock_inited)
+ mono_loader_lock ();
+}
+
+void
+mono_loader_unlock_if_inited (void)
+{
+ if (loader_lock_inited)
+ mono_loader_unlock ();
+}
+
/**
* mono_method_signature:
*
* Return the signature of the method M. On failure, returns NULL, and ERR is set.
*/
MonoMethodSignature*
-mono_method_signature_checked (MonoMethod *m, MonoError *err)
+mono_method_signature_checked (MonoMethod *m, MonoError *error)
{
int idx;
int size;
/* We need memory barriers below because of the double-checked locking pattern */
+ mono_error_init (error);
+
if (m->signature)
return m->signature;
MonoMethodInflated *imethod = (MonoMethodInflated *) m;
/* the lock is recursive */
signature = mono_method_signature (imethod->declaring);
- signature = inflate_generic_signature (imethod->declaring->klass->image, signature, mono_method_get_context (m));
+ signature = inflate_generic_signature_checked (imethod->declaring->klass->image, signature, mono_method_get_context (m), error);
+ if (!mono_error_ok (error)) {
+ mono_loader_unlock ();
+ return NULL;
+ }
inflated_signatures_size += mono_metadata_signature_size (signature);
if (!signature) {
const char *sig_body;
/*TODO we should cache the failure result somewhere*/
- if (!mono_verifier_verify_method_signature (img, sig_offset, NULL)) {
+ if (!mono_verifier_verify_method_signature (img, sig_offset, error)) {
mono_loader_unlock ();
- mono_error_set_method_load (err, m->klass, m->name, "");
return NULL;
}
signature = mono_metadata_parse_method_signature_full (img, container, idx, sig_body, NULL);
if (!signature) {
+ mono_loader_clear_error ();
mono_loader_unlock ();
- mono_error_set_method_load (err, m->klass, m->name, "");
+ mono_error_set_method_load (error, m->klass, m->name, "");
return NULL;
}
if (can_cache_signature)
g_hash_table_insert (img->method_signatures, (gpointer)sig, signature);
+
+ signatures_size += mono_metadata_signature_size (signature);
}
/* Verify metadata consistency */
if (signature->generic_param_count) {
if (!container || !container->is_method) {
mono_loader_unlock ();
- mono_error_set_method_load (err, m->klass, m->name, "Signature claims method has generic parameters, but generic_params table says it doesn't for method 0x%08x from image %s", idx, img->name);
+ mono_error_set_method_load (error, m->klass, m->name, "Signature claims method has generic parameters, but generic_params table says it doesn't for method 0x%08x from image %s", idx, img->name);
return NULL;
}
if (container->type_argc != signature->generic_param_count) {
mono_loader_unlock ();
- mono_error_set_method_load (err, m->klass, m->name, "Inconsistent generic parameter count. Signature says %d, generic_params table says %d for method 0x%08x from image %s", signature->generic_param_count, container->type_argc, idx, img->name);
+ mono_error_set_method_load (error, m->klass, m->name, "Inconsistent generic parameter count. Signature says %d, generic_params table says %d for method 0x%08x from image %s", signature->generic_param_count, container->type_argc, idx, img->name);
return NULL;
}
} else if (container && container->is_method && container->type_argc) {
mono_loader_unlock ();
- mono_error_set_method_load (err, m->klass, m->name, "generic_params table claims method has generic parameters, but signature says it doesn't for method 0x%08x from image %s", idx, img->name);
+ mono_error_set_method_load (error, m->klass, m->name, "generic_params table claims method has generic parameters, but signature says it doesn't for method 0x%08x from image %s", idx, img->name);
return NULL;
}
if (m->iflags & METHOD_IMPL_ATTRIBUTE_INTERNAL_CALL)
case PINVOKE_ATTRIBUTE_CALL_CONV_GENERICINST:
default:
mono_loader_unlock ();
- mono_error_set_method_load (err, m->klass, m->name, "unsupported calling convention : 0x%04x for method 0x%08x from image %s", piinfo->piflags, idx, img->name);
+ mono_error_set_method_load (error, m->klass, m->name, "unsupported calling convention : 0x%04x for method 0x%08x from image %s", piinfo->piflags, idx, img->name);
return NULL;
}
signature->call_convention = conv;
MonoMethodSignature*
mono_method_signature (MonoMethod *m)
{
- MonoError err;
+ MonoError error;
MonoMethodSignature *sig;
- mono_error_init (&err);
-
- sig = mono_method_signature_checked (m, &err);
+ sig = mono_method_signature_checked (m, &error);
if (!sig) {
- g_warning ("Could not load signature due to: %s", mono_error_get_message (&err));
- mono_error_cleanup (&err);
+ char *type_name = mono_type_get_full_name (m->klass);
+ g_warning ("Could not load signature of %s:%s due to: %s", type_name, m->name, mono_error_get_message (&error));
+ g_free (type_name);
+ mono_error_cleanup (&error);
}
return sig;
if ((method->flags & METHOD_ATTRIBUTE_ABSTRACT) || (method->iflags & METHOD_IMPL_ATTRIBUTE_RUNTIME) || (method->iflags & METHOD_IMPL_ATTRIBUTE_INTERNAL_CALL) || (method->flags & METHOD_ATTRIBUTE_PINVOKE_IMPL))
return NULL;
- if (method->wrapper_type != MONO_WRAPPER_NONE || method->sre_method) {
- MonoMethodWrapper *mw = (MonoMethodWrapper *)method;
- g_assert (mw->header);
- return mw->header;
- }
-
if (method->is_inflated) {
MonoMethodInflated *imethod = (MonoMethodInflated *) method;
MonoMethodHeader *header;
}
header = mono_method_get_header (imethod->declaring);
+ if (!header) {
+ mono_loader_unlock ();
+ return NULL;
+ }
imethod->header = inflate_generic_header (header, mono_method_get_context (method));
mono_loader_unlock ();
return imethod->header;
}
+ if (method->wrapper_type != MONO_WRAPPER_NONE || method->sre_method) {
+ MonoMethodWrapper *mw = (MonoMethodWrapper *)method;
+ g_assert (mw->header);
+ return mw->header;
+ }
+
/*
* We don't need locks here: the new header is allocated from malloc memory
* and is not stored anywhere in the runtime, the user needs to free it.
MonoClass *klass = method->klass;
int i;
+ if (klass->rank)
+ /* constructed array methods are not in the MethodDef table */
+ return 0;
+
if (method->token)
return mono_metadata_token_index (method->token);
projects / mono.git / blobdiff