Fri Sep 14 14:04:31 CEST 2007 Paolo Molaro <lupus@ximian.com>
[mono.git] / mono / metadata / class.c
index 7abb1a925b4b7e84c5f36b804791db6963a81d5e..c927d3fb8bc2147d8c83c4470e60249909342a6f 100644 (file)
@@ -18,7 +18,6 @@
 #endif
 #include <mono/metadata/image.h>
 #include <mono/metadata/assembly.h>
-#include <mono/metadata/cil-coff.h>
 #include <mono/metadata/metadata.h>
 #include <mono/metadata/metadata-internals.h>
 #include <mono/metadata/tabledefs.h>
@@ -32,6 +31,7 @@
 #include <mono/metadata/exception.h>
 #include <mono/metadata/security-manager.h>
 #include <mono/metadata/security-core-clr.h>
+#include <mono/metadata/attrdefs.h>
 #include <mono/os/gc_wrapper.h>
 #include <mono/utils/mono-counters.h>
 
@@ -1201,15 +1201,18 @@ mono_class_layout_fields (MonoClass *class)
                break;
        }
 
+#if NO_UNALIGNED_ACCESS
        if (layout != TYPE_ATTRIBUTE_EXPLICIT_LAYOUT) {
                /*
                 * For small structs, set min_align to at least the struct size, since the
                 * JIT memset/memcpy code assumes this and generates unaligned accesses
                 * otherwise. See #78990 for a testcase.
+                * FIXME: Fix the memset/memcpy code instead.
                 */
                if (class->instance_size <= sizeof (MonoObject) + sizeof (gpointer))
                        class->min_align = MAX (class->min_align, class->instance_size - sizeof (MonoObject));
        }
+#endif
 
        class->size_inited = 1;
 
@@ -4147,7 +4150,7 @@ mono_class_get_full (MonoImage *image, guint32 type_token, MonoGenericContext *c
        MonoClass *class = NULL;
 
        if (image->dynamic)
-               return mono_lookup_dynamic_token (image, type_token);
+               return mono_lookup_dynamic_token (image, type_token, context);
 
        switch (type_token & 0xff000000){
        case MONO_TOKEN_TYPE_DEF:
@@ -4191,7 +4194,7 @@ mono_type_get_full (MonoImage *image, guint32 type_token, MonoGenericContext *co
 
        //FIXME: this will not fix the very issue for which mono_type_get_full exists -but how to do it then?
        if (image->dynamic)
-               return mono_class_get_type (mono_lookup_dynamic_token (image, type_token));
+               return mono_class_get_type (mono_lookup_dynamic_token (image, type_token, context));
 
        if ((type_token & 0xff000000) != MONO_TOKEN_TYPE_SPEC) {
                MonoClass *class = mono_class_get_full (image, type_token, context);
@@ -4548,6 +4551,24 @@ mono_class_is_subclass_of (MonoClass *klass, MonoClass *klassc,
        return FALSE;
 }
 
+static gboolean
+mono_class_has_variant_generic_params (MonoClass *klass)
+{
+       int i;
+       MonoGenericContainer *container;
+
+       if (!klass->generic_class)
+               return FALSE;
+
+       container = klass->generic_class->container_class->generic_container;
+
+       for (i = 0; i < container->type_argc; ++i)
+               if (container->type_params [i].flags & (MONO_GEN_PARAM_VARIANT|MONO_GEN_PARAM_COVARIANT))
+                       return TRUE;
+
+       return FALSE;
+}
+
 gboolean
 mono_class_is_assignable_from (MonoClass *klass, MonoClass *oklass)
 {
@@ -4574,6 +4595,52 @@ mono_class_is_assignable_from (MonoClass *klass, MonoClass *oklass)
 
                if (MONO_CLASS_IMPLEMENTS_INTERFACE (oklass, klass->interface_id))
                        return TRUE;
+
+               if (mono_class_has_variant_generic_params (klass)) {
+                       if (oklass->generic_class) {
+                               int i;
+                               gboolean match = FALSE;
+                               MonoClass *container_class1 = klass->generic_class->container_class;
+                               MonoClass *container_class2 = oklass->generic_class->container_class;
+
+                               /* 
+                                * Check whenever the generic definition of oklass implements the 
+                                * generic definition of klass. The IMPLEMENTS_INTERFACE stuff is not usable
+                                * here since the relevant tables are not set up.
+                                */
+                               for (i = 0; i < container_class2->interface_offsets_count; ++i)
+                                       if ((container_class2->interfaces_packed [i] == container_class1) || (container_class2->interfaces_packed [i]->generic_class && (container_class2->interfaces_packed [i]->generic_class->container_class == container_class1)))
+                                               match = TRUE;
+
+                               if (match) {
+                                       MonoGenericContainer *container;
+
+                                       container = klass->generic_class->container_class->generic_container;
+
+                                       match = TRUE;
+                                       for (i = 0; i < container->type_argc; ++i) {
+                                               MonoClass *param1_class = mono_class_from_mono_type (klass->generic_class->context.class_inst->type_argv [i]);
+                                               MonoClass *param2_class = mono_class_from_mono_type (oklass->generic_class->context.class_inst->type_argv [i]);
+
+                                               /*
+                                                * The _VARIANT and _COVARIANT constants should read _COVARIANT and
+                                                * _CONTRAVARIANT, but they are in a public header so we can't fix it.
+                                                */
+                                               if (param1_class != param2_class) {
+                                                       if ((container->type_params [i].flags & MONO_GEN_PARAM_VARIANT) && mono_class_is_assignable_from (param1_class, param2_class))
+                                                               ;
+                                                       else if (((container->type_params [i].flags & MONO_GEN_PARAM_COVARIANT) && mono_class_is_assignable_from (param2_class, param1_class)))
+                                                               ;
+                                                       else
+                                                               match = FALSE;
+                                               }
+                                       }
+
+                                       if (match)
+                                               return TRUE;
+                               }
+                       }
+               }
        } else if (klass->rank) {
                MonoClass *eclass, *eoclass;
 
@@ -4744,7 +4811,7 @@ mono_ldtoken (MonoImage *image, guint32 token, MonoClass **handle_class,
 {
        if (image->dynamic) {
                MonoClass *tmp_handle_class;
-               gpointer obj = mono_lookup_dynamic_token_class (image, token, &tmp_handle_class);
+               gpointer obj = mono_lookup_dynamic_token_class (image, token, &tmp_handle_class, context);
 
                g_assert (tmp_handle_class);
                if (handle_class)
@@ -4829,17 +4896,17 @@ mono_install_lookup_dynamic_token (MonoLookupDynamicToken func)
 }
 
 gpointer
-mono_lookup_dynamic_token (MonoImage *image, guint32 token)
+mono_lookup_dynamic_token (MonoImage *image, guint32 token, MonoGenericContext *context)
 {
        MonoClass *handle_class;
 
-       return lookup_dynamic (image, token, &handle_class);
+       return lookup_dynamic (image, token, &handle_class, context);
 }
 
 gpointer
-mono_lookup_dynamic_token_class (MonoImage *image, guint32 token, MonoClass **handle_class)
+mono_lookup_dynamic_token_class (MonoImage *image, guint32 token, MonoClass **handle_class, MonoGenericContext *context)
 {
-       return lookup_dynamic (image, token, handle_class);
+       return lookup_dynamic (image, token, handle_class, context);
 }
 
 static MonoGetCachedClassInfo get_cached_class_info = NULL;
@@ -5744,14 +5811,31 @@ can_access_internals (MonoAssembly *accessing, MonoAssembly* accessed)
        return FALSE;
 }
 
+/*
+ * If klass is a generic type or if it is derived from a generic type, return the
+ * MonoClass of the generic definition
+ * Returns NULL if not found
+ */
+static MonoClass*
+get_generic_definition_class (MonoClass *klass)
+{
+       while (klass) {
+               if (klass->generic_class && klass->generic_class->container_class)
+                       return klass->generic_class->container_class;
+               klass = klass->parent;
+       }
+       return NULL;
+}
+
 /* FIXME: check visibility of type, too */
 static gboolean
 can_access_member (MonoClass *access_klass, MonoClass *member_klass, int access_level)
 {
-       if (access_klass->generic_class && member_klass->generic_class &&
-           access_klass->generic_class->container_class && member_klass->generic_class->container_class) {
+       MonoClass *member_generic_def;
+       if (access_klass->generic_class && access_klass->generic_class->container_class && 
+                       (member_generic_def = get_generic_definition_class (member_klass))) {
                if (can_access_member (access_klass->generic_class->container_class,
-                                      member_klass->generic_class->container_class, access_level))
+                                      member_generic_def, access_level))
                        return TRUE;
        }