2004-05-09 Miguel de Icaza <miguel@ximian.com>
[mono.git] / mcs / mcs / typemanager.cs
index c907a3d718b35f714a048491e2344938aae6606b..6c896e788e4c1cc113daf6db057a567c1e024a8b 100755 (executable)
@@ -84,27 +84,33 @@ public class TypeManager {
        static public object obsolete_attribute_type;
        static public object conditional_attribute_type;
        static public Type in_attribute_type;
+       static public Type cls_compliant_attribute_type;
+       static public Type typed_reference_type;
+       static public Type arg_iterator_type;
+       static public Type mbr_type;
 
        //
        // An empty array of types
        //
        static public Type [] NoTypes;
+       static public TypeExpr [] NoTypeExprs;
 
 
        // 
        // Expressions representing the internal types.  Used during declaration
        // definition.
        //
-       static public Expression system_object_expr, system_string_expr; 
-       static public Expression system_boolean_expr, system_decimal_expr;
-       static public Expression system_single_expr, system_double_expr;
-       static public Expression system_sbyte_expr, system_byte_expr;
-       static public Expression system_int16_expr, system_uint16_expr;
-       static public Expression system_int32_expr, system_uint32_expr;
-       static public Expression system_int64_expr, system_uint64_expr;
-       static public Expression system_char_expr, system_void_expr;
-       static public Expression system_asynccallback_expr;
-       static public Expression system_iasyncresult_expr;
+       static public TypeExpr system_object_expr, system_string_expr; 
+       static public TypeExpr system_boolean_expr, system_decimal_expr;
+       static public TypeExpr system_single_expr, system_double_expr;
+       static public TypeExpr system_sbyte_expr, system_byte_expr;
+       static public TypeExpr system_int16_expr, system_uint16_expr;
+       static public TypeExpr system_int32_expr, system_uint32_expr;
+       static public TypeExpr system_int64_expr, system_uint64_expr;
+       static public TypeExpr system_char_expr, system_void_expr;
+       static public TypeExpr system_asynccallback_expr;
+       static public TypeExpr system_iasyncresult_expr;
+       static public TypeExpr system_valuetype_expr;
 
        //
        // This is only used when compiling corlib
@@ -133,7 +139,10 @@ public class TypeManager {
        static public MethodInfo string_concat_string_string;
        static public MethodInfo string_concat_string_string_string;
        static public MethodInfo string_concat_string_string_string_string;
+       static public MethodInfo string_concat_string_dot_dot_dot;
        static public MethodInfo string_concat_object_object;
+       static public MethodInfo string_concat_object_object_object;
+       static public MethodInfo string_concat_object_dot_dot_dot;
        static public MethodInfo string_isinterneted_string;
        static public MethodInfo system_type_get_type_from_handle;
        static public MethodInfo object_getcurrent_void;
@@ -173,10 +182,10 @@ public class TypeManager {
        static Assembly [] assemblies;
 
        // <remarks>
-       //  Keeps a list of module builders. We used this to do lookups
-       //  on the modulebuilder using GetType -- needed for arrays
+       //  Keeps a list of modules. We used this to do lookups
+       //  on the module using GetType -- needed for arrays
        // </remarks>
-       static ModuleBuilder [] modules;
+       static Module [] modules;
 
        // <remarks>
        //   This is the type_cache from the assemblies to avoid
@@ -234,10 +243,45 @@ public class TypeManager {
 
        static Hashtable builder_to_method;
 
+       // <remarks>
+       //  Contains all public types from referenced assemblies.
+       //  This member is used only if CLS Compliance verification is required.
+       // </remarks>
+       public static Hashtable all_imported_types;
+
        struct Signature {
                public string name;
                public Type [] args;
        }
+       
+       public static void CleanUp ()
+       {
+               // Lets get everything clean so that we can collect before generating code
+               assemblies = null;
+               modules = null;
+               types = null;
+               typecontainers = null;
+               user_types = null;
+               builder_to_declspace = null;
+               builder_to_ifaces = null;
+               method_arguments = null;
+               indexer_arguments = null;
+               method_internal_params = null;
+               builder_to_attr = null;
+               builder_to_method = null;
+               
+               fields = null;
+               references = null;
+               negative_hits = null;
+               attr_to_allowmult = null;
+               builder_to_constant = null;
+               fieldbuilders_to_fields = null;
+               events = null;
+               priv_fields_events = null;
+               properties = null;
+               
+               TypeHandle.CleanUp ();
+       }
 
        /// <summary>
        ///   A filter for Findmembers that uses the Signature object to
@@ -306,8 +350,9 @@ public class TypeManager {
                system_void_expr    = new TypeLookupExpression ("System.Void");
                system_asynccallback_expr = new TypeLookupExpression ("System.AsyncCallback");
                system_iasyncresult_expr = new TypeLookupExpression ("System.IAsyncResult");
+               system_valuetype_expr  = new TypeLookupExpression ("System.ValueType");
        }
-       
+
        static TypeManager ()
        {
                assemblies = new Assembly [0];
@@ -326,6 +371,7 @@ public class TypeManager {
                builder_to_ifaces = new PtrHashtable ();
                
                NoTypes = new Type [0];
+               NoTypeExprs = new TypeExpr [0];
 
                signature_filter = new MemberFilter (SignatureFilter);
                InitExpressionTypes ();
@@ -344,7 +390,6 @@ public class TypeManager {
                        return;
                }
                
-               Location l;
                tc = builder_to_declspace [t] as TypeContainer;
                if (tc != null){
                        Report.Warning (
@@ -361,7 +406,7 @@ public class TypeManager {
                types.Add (name, t);
        }
        
-       public static void AddUserType (string name, TypeBuilder t, Type [] ifaces)
+       public static void AddUserType (string name, TypeBuilder t, TypeExpr[] ifaces)
        {
                try {
                        types.Add (name, t);
@@ -377,13 +422,13 @@ public class TypeManager {
        //
        // This entry point is used by types that we define under the covers
        // 
-       public static void RegisterBuilder (TypeBuilder tb, Type [] ifaces)
+       public static void RegisterBuilder (TypeBuilder tb, TypeExpr [] ifaces)
        {
                if (ifaces != null)
                        builder_to_ifaces [tb] = ifaces;
        }
        
-       public static void AddUserType (string name, TypeBuilder t, TypeContainer tc, Type [] ifaces)
+       public static void AddUserType (string name, TypeBuilder t, TypeContainer tc, TypeExpr [] ifaces)
        {
                builder_to_declspace.Add (t, tc);
                typecontainers.Add (name, tc);
@@ -411,7 +456,7 @@ public class TypeManager {
                builder_to_declspace.Add (t, en);
        }
 
-       public static void AddUserInterface (string name, TypeBuilder t, Interface i, Type [] ifaces)
+       public static void AddUserInterface (string name, TypeBuilder t, Interface i, TypeExpr [] ifaces)
        {
                AddUserType (name, t, ifaces);
                builder_to_declspace.Add (t, i);
@@ -481,6 +526,11 @@ public class TypeManager {
        /// </summary>
        public static void AddAssembly (Assembly a)
        {
+               foreach (Assembly assembly in assemblies) {
+                       if (a == assembly)
+                               return;
+               }
+
                int top = assemblies.Length;
                Assembly [] n = new Assembly [top + 1];
 
@@ -493,10 +543,10 @@ public class TypeManager {
        /// <summary>
        ///  Registers a module builder to lookup types from
        /// </summary>
-       public static void AddModule (ModuleBuilder mb)
+       public static void AddModule (Module mb)
        {
                int top = modules != null ? modules.Length : 0;
-               ModuleBuilder [] n = new ModuleBuilder [top + 1];
+               Module [] n = new Module [top + 1];
 
                if (modules != null)
                        modules.CopyTo (n, 0);
@@ -504,6 +554,12 @@ public class TypeManager {
                modules = n;
        }
 
+       public static Module[] Modules {
+               get {
+                       return modules;
+               }
+       }
+
        static Hashtable references = new Hashtable ();
        
        //
@@ -522,7 +578,7 @@ public class TypeManager {
                //
                if (ret == null){
                        if (references [t] == null)
-                               references [t] = CodeGen.ModuleBuilder.GetType (tname);
+                               references [t] = CodeGen.Module.Builder.GetType (tname);
                        ret = (Type) references [t];
                }
 
@@ -547,7 +603,7 @@ public class TypeManager {
                //
                if (ret == null){
                        if (pointers [t] == null)
-                               pointers [t] = CodeGen.ModuleBuilder.GetType (tname);
+                               pointers [t] = CodeGen.Module.Builder.GetType (tname);
                        
                        ret = (Type) pointers [t];
                }
@@ -567,21 +623,34 @@ public class TypeManager {
                        if (t == null)
                                continue;
 
-                       TypeAttributes ta = t.Attributes & TypeAttributes.VisibilityMask;
-                       if (ta == TypeAttributes.NotPublic ||
-                           ta == TypeAttributes.NestedPrivate ||
-                           ta == TypeAttributes.NestedAssembly ||
-                           ta == TypeAttributes.NestedFamANDAssem)
-                               continue;
-                       return t;
+                       do {
+                               TypeAttributes ta = t.Attributes & TypeAttributes.VisibilityMask;
+                               if (ta == TypeAttributes.NotPublic ||
+                                   ta == TypeAttributes.NestedPrivate ||
+                                   ta == TypeAttributes.NestedAssembly ||
+                                   ta == TypeAttributes.NestedFamANDAssem){
+                                       
+                                       //
+                                       // In .NET pointers turn out to be private, even if their
+                                       // element type is not
+                                       //
+                                       if (t.IsPointer){
+                                               t = t.GetElementType ();
+                                               continue;
+                                       } else
+                                               t = null;
+                               } else {
+                                       return t;
+                               }
+                       } while (t != null);
                }
 
-               foreach (ModuleBuilder mb in modules) {
+               foreach (Module mb in modules) {
                        t = mb.GetType (name);
-                       if (t != null){
+                       if (t != null) 
                                return t;
-                       }
                }
+                        
                return null;
        }
 
@@ -608,6 +677,8 @@ public class TypeManager {
                types [name] = t;
                return t;
        }
+       
+       static readonly char [] dot_array = { '.' };
 
        /// <summary>
        ///   Returns the Type associated with @name, takes care of the fact that
@@ -630,7 +701,8 @@ public class TypeManager {
                if (negative_hits.Contains (name))
                        return null;
 
-               string [] elements = name.Split ('.');
+               // Sadly, split takes a param array, so this ends up allocating *EVERY TIME*
+               string [] elements = name.Split (dot_array);
                int count = elements.Length;
 
                for (int n = 1; n <= count; n++){
@@ -644,7 +716,7 @@ public class TypeManager {
                        if (t == null){
                                t = LookupTypeReflection (top_level_type);
                                if (t == null){
-                                       negative_hits [top_level_type] = true;
+                                       negative_hits [top_level_type] = null;
                                        continue;
                                }
                        }
@@ -665,12 +737,12 @@ public class TypeManager {
                        //Console.WriteLine ("Looking up: " + newt + " " + name);
                        t = LookupTypeReflection (newt);
                        if (t == null)
-                               negative_hits [name] = true;
+                               negative_hits [name] = null;
                        else
                                types [name] = t;
                        return t;
                }
-               negative_hits [name] = true;
+               negative_hits [name] = null;
                return null;
        }
 
@@ -679,14 +751,13 @@ public class TypeManager {
        /// </summary>
        public static void ComputeNamespaces ()
        {
-               MethodInfo assembly_get_namespaces = typeof (Assembly).GetMethod ("GetNamespaces");
+               MethodInfo assembly_get_namespaces = typeof (Assembly).GetMethod ("GetNamespaces", BindingFlags.Instance|BindingFlags.NonPublic);
 
                //
                // First add the assembly namespaces
                //
                if (assembly_get_namespaces != null){
                        int count = assemblies.Length;
-                       int total;
 
                        for (int i = 0; i < count; i++){
                                Assembly a = assemblies [i];
@@ -698,19 +769,38 @@ public class TypeManager {
                                }
                        }
                } else {
-                       foreach (Assembly a in assemblies){
-                               foreach (Type t in a.GetTypes ()){
+                       Hashtable cache = new Hashtable ();
+                       cache.Add ("", null);
+                       foreach (Assembly a in assemblies) {
+                               foreach (Type t in a.GetExportedTypes ()) {
                                        string ns = t.Namespace;
-
-                                       // t.Namespace returns null for <PrivateImplDetails>
-                                       if (ns == ""|| ns == null)
+                                       if (ns == null || cache.Contains (ns))
                                                continue;
+
                                        Namespace.LookupNamespace (ns, true);
+                                       cache.Add (ns, null);
                                }
                        }
                }
        }
 
+       /// <summary>
+       /// Fills static table with exported types from all referenced assemblies.
+       /// This information is required for CLS Compliance tests.
+       /// </summary>
+       public static void LoadAllImportedTypes ()
+       {
+               if (!CodeGen.Assembly.IsClsCompliant)
+                       return;
+
+               all_imported_types = new Hashtable ();
+               foreach (Assembly a in assemblies) {
+                       foreach (Type t in a.GetExportedTypes ()) {
+                               all_imported_types [t.FullName] = t;
+                       }
+               }
+       }
+
        public static bool NamespaceClash (string name, Location loc)
        {
                if (Namespace.LookupNamespace (name, false) == null)
@@ -749,6 +839,33 @@ public class TypeManager {
                + match.Groups [2].Captures [0].Value;
        }
 
+        /// <summary>
+       ///  Returns the signature of the method with full namespace classification
+       /// </summary>
+       static public string GetFullNameSignature (MemberInfo mi)
+       {
+               string n = mi.Name;
+               if (n == ".ctor")
+                       n = mi.DeclaringType.Name;
+               
+               return mi.DeclaringType.FullName.Replace ('+', '.') + '.' + n;
+       }
+
+       /// <summary>
+       ///   Returns the signature of the property and indexer
+       /// </summary>
+       static public string CSharpSignature (PropertyBuilder pb, bool is_indexer) 
+       {
+               if (!is_indexer) {
+                       return GetFullNameSignature (pb);
+               }
+
+               MethodBase mb = pb.GetSetMethod (true) != null ? pb.GetSetMethod (true) : pb.GetGetMethod (true);
+               string signature = GetFullNameSignature (mb);
+               string arg = TypeManager.LookupParametersByBuilder (mb).ParameterDesc (0);
+               return String.Format ("{0}.this[{1}]", signature.Substring (0, signature.LastIndexOf ('.')), arg);
+       }
+
         /// <summary>
         ///   Returns the signature of the method
         /// </summary>
@@ -775,7 +892,7 @@ public class TypeManager {
                 }
                 sig += ")";
 
-                return mb.DeclaringType.Name + "." + mb.Name + sig;
+                return GetFullNameSignature (mb) + sig;
         }
 
        /// <summary>
@@ -788,7 +905,7 @@ public class TypeManager {
 
                if (t == null){
                        Report.Error (518, "The predefined type `" + name + "' is not defined or imported");
-                       Environment.Exit (0);
+                       Environment.Exit (1);
                }
 
                return t;
@@ -798,16 +915,19 @@ public class TypeManager {
        ///   Returns the MethodInfo for a method named `name' defined
        ///   in type `t' which takes arguments of types `args'
        /// </summary>
-       static MethodInfo GetMethod (Type t, string name, Type [] args, bool report_errors)
+       static MethodInfo GetMethod (Type t, string name, Type [] args, bool is_private, bool report_errors)
        {
                MemberList list;
                Signature sig;
+               BindingFlags flags = instance_and_static | BindingFlags.Public;
 
                sig.name = name;
                sig.args = args;
-               
-               list = FindMembers (t, MemberTypes.Method, instance_and_static | BindingFlags.Public,
-                                   signature_filter, sig);
+
+               if (is_private)
+                       flags |= BindingFlags.NonPublic;
+
+               list = FindMembers (t, MemberTypes.Method, flags, signature_filter, sig);
                if (list.Count == 0) {
                        if (report_errors)
                                Report.Error (-19, "Can not find the core function `" + name + "'");
@@ -824,6 +944,11 @@ public class TypeManager {
                return mi;
        }
 
+       static MethodInfo GetMethod (Type t, string name, Type [] args, bool report_errors)
+       {
+               return GetMethod (t, name, args, false, report_errors);
+       }
+
        static MethodInfo GetMethod (Type t, string name, Type [] args)
        {
                return GetMethod (t, name, args, true);
@@ -919,6 +1044,9 @@ public class TypeManager {
                marshal_as_attr_type = CoreLookupType ("System.Runtime.InteropServices.MarshalAsAttribute");
                param_array_type     = CoreLookupType ("System.ParamArrayAttribute");
                in_attribute_type    = CoreLookupType ("System.Runtime.InteropServices.InAttribute");
+               typed_reference_type = CoreLookupType ("System.TypedReference");
+               arg_iterator_type    = CoreLookupType ("System.ArgIterator");
+               mbr_type             = CoreLookupType ("System.MarshalByRefObject");
 
                //
                // Sigh. Remove this before the release.  Wonder what versions of Mono
@@ -940,6 +1068,7 @@ public class TypeManager {
                //
                obsolete_attribute_type = CoreLookupType ("System.ObsoleteAttribute");
                conditional_attribute_type = CoreLookupType ("System.Diagnostics.ConditionalAttribute");
+               cls_compliant_attribute_type = CoreLookupType ("System.CLSCompliantAttribute");
 
                //
                // When compiling corlib, store the "real" types here.
@@ -977,7 +1106,7 @@ public class TypeManager {
 
                        MethodInfo set_corlib_type_builders = GetMethod (
                                system_assemblybuilder_type, "SetCorlibTypeBuilders",
-                               system_4_type_arg, false);
+                               system_4_type_arg, true, false);
 
                        if (set_corlib_type_builders != null) {
                                object[] args = new object [4];
@@ -986,12 +1115,12 @@ public class TypeManager {
                                args [2] = enum_type;
                                args [3] = void_type;
                                
-                               set_corlib_type_builders.Invoke (CodeGen.AssemblyBuilder, args);
+                               set_corlib_type_builders.Invoke (CodeGen.Assembly.Builder, args);
                        } else {
                                // Compatibility for an older version of the class libs.
                                set_corlib_type_builders = GetMethod (
                                        system_assemblybuilder_type, "SetCorlibTypeBuilders",
-                                       system_3_type_arg, true);
+                                       system_3_type_arg, true, true);
 
                                if (set_corlib_type_builders == null) {
                                        Report.Error (-26, "Corlib compilation is not supported in Microsoft.NET due to bugs in it");
@@ -1003,9 +1132,29 @@ public class TypeManager {
                                args [1] = value_type;
                                args [2] = enum_type;
                                
-                               set_corlib_type_builders.Invoke (CodeGen.AssemblyBuilder, args);
+                               set_corlib_type_builders.Invoke (CodeGen.Assembly.Builder, args);
                        }
                }
+
+               system_object_expr.Type = object_type;
+               system_string_expr.Type = string_type;
+               system_boolean_expr.Type = bool_type;
+               system_decimal_expr.Type = decimal_type;
+               system_single_expr.Type = float_type;
+               system_double_expr.Type = double_type;
+               system_sbyte_expr.Type = sbyte_type;
+               system_byte_expr.Type = byte_type;
+               system_int16_expr.Type = short_type;
+               system_uint16_expr.Type = ushort_type;
+               system_int32_expr.Type = int32_type;
+               system_uint32_expr.Type = uint32_type;
+               system_int64_expr.Type = int64_type;
+               system_uint64_expr.Type = uint64_type;
+               system_char_expr.Type = char_type;
+               system_void_expr.Type = void_type;
+               system_asynccallback_expr.Type = asynccallback_type;
+               system_iasyncresult_expr.Type = iasyncresult_type;
+               system_valuetype_expr.Type = value_type;
        }
 
        //
@@ -1025,10 +1174,19 @@ public class TypeManager {
                Type [] string_string_string_string = { string_type, string_type, string_type, string_type };
                string_concat_string_string_string_string = GetMethod (
                        string_type, "Concat", string_string_string_string);
+               Type[] params_string = { TypeManager.LookupType ("System.String[]") };
+               string_concat_string_dot_dot_dot = GetMethod (
+                       string_type, "Concat", params_string);
 
                Type [] object_object = { object_type, object_type };
                string_concat_object_object = GetMethod (
                        string_type, "Concat", object_object);
+               Type [] object_object_object = { object_type, object_type, object_type };
+               string_concat_object_object_object = GetMethod (
+                       string_type, "Concat", object_object_object);
+               Type[] params_object = { TypeManager.LookupType ("System.Object[]") };
+               string_concat_object_dot_dot_dot = GetMethod (
+                       string_type, "Concat", params_object);
 
                Type [] string_ = { string_type };
                string_isinterneted_string = GetMethod (
@@ -1136,8 +1294,6 @@ public class TypeManager {
 
        const BindingFlags instance_and_static = BindingFlags.Static | BindingFlags.Instance;
 
-       static Hashtable type_hash = new Hashtable ();
-
        /// <remarks>
        ///   This is the "old", non-cache based FindMembers() function.  We cannot use
        ///   the cache here because there is no member name argument.
@@ -1210,7 +1366,7 @@ public class TypeManager {
        ///   our return value will already contain all inherited members and the caller don't need
        ///   to check base classes and interfaces anymore.
        /// </summary>
-       private static MemberList MemberLookup_FindMembers (Type t, MemberTypes mt, BindingFlags bf,
+       private static MemberInfo [] MemberLookup_FindMembers (Type t, MemberTypes mt, BindingFlags bf,
                                                            string name, out bool used_cache)
        {
                //
@@ -1243,14 +1399,16 @@ public class TypeManager {
                        }
 
                        // If there is no MemberCache, we need to use the "normal" FindMembers.
-
+                       // Note, this is a VERY uncommon route!
+                       
                        MemberList list;
                        Timer.StartTimer (TimerType.FindMembers);
                        list = decl.FindMembers (mt, bf | BindingFlags.DeclaredOnly,
                                                 FilterWithClosure_delegate, name);
                        Timer.StopTimer (TimerType.FindMembers);
                        used_cache = false;
-                       return list;
+                        
+                       return (MemberInfo []) list;
                }
 
                //
@@ -1275,6 +1433,11 @@ public class TypeManager {
                        return false;
        }
 
+       public static bool IsBuiltinType (TypeContainer tc)
+       {
+               return IsBuiltinType (tc.TypeBuilder);
+       }
+
        //
        // This is like IsBuiltinType, but lacks decimal_type, we should also clean up
        // the pieces in the code where we use IsBuiltinType and special case decimal_type.
@@ -1305,6 +1468,16 @@ public class TypeManager {
                else
                        return false;
        }
+       public static bool IsBuiltinOrEnum (Type t)
+       {
+               if (IsBuiltinType (t))
+                       return true;
+               
+               if (IsEnumType (t))
+                       return true;
+
+               return false;
+       }
 
        //
        // Whether a type is unmanaged.  This is used by the unsafe code (25.2)
@@ -1324,12 +1497,15 @@ public class TypeManager {
                        if (t is TypeBuilder){
                                TypeContainer tc = LookupTypeContainer (t);
 
-                               foreach (Field f in tc.Fields){
-                                       if (f.FieldBuilder.IsStatic)
-                                               continue;
-                                       if (!IsUnmanagedType (f.FieldBuilder.FieldType))
-                                               return false;
-                               }
+                               if (tc.Fields != null){
+                                       foreach (Field f in tc.Fields){
+                                               if (f.FieldBuilder.IsStatic)
+                                                       continue;
+                                               if (!IsUnmanagedType (f.FieldBuilder.FieldType))
+                                                       return false;
+                                       }
+                               } else
+                                       return true;
                        } else {
                                FieldInfo [] fields = t.GetFields ();
 
@@ -1399,6 +1575,18 @@ public class TypeManager {
                return false;
        }
 
+        //
+        // Do the right thing when returning the element type of an
+        // array type based on whether we are compiling corlib or not
+        //
+        public static Type GetElementType (Type t)
+        {
+                if (RootContext.StdLib)
+                        return t.GetElementType ();
+                else
+                        return TypeToCoreType (t.GetElementType ());
+        }
+
        /// <summary>
        ///   Returns the User Defined Types
        /// </summary>
@@ -1585,6 +1773,11 @@ public class TypeManager {
                return true;
        }
 
+       //
+       // The return value can be null;  This will be the case for
+       // auxiliary FieldBuilders created by the compiler that have no
+       // real field being declared on the source code
+       //
        static public FieldBase GetField (FieldInfo fb)
        {
                return (FieldBase) fieldbuilders_to_fields [fb];
@@ -1663,7 +1856,8 @@ public class TypeManager {
                return true;
        }
 
-       static public bool RegisterIndexer (PropertyBuilder pb, MethodBase get, MethodBase set, Type[] args)
+       static public bool RegisterIndexer (PropertyBuilder pb, MethodBase get,
+                                            MethodBase set, Type[] args)
        {
                if (!RegisterProperty (pb, get,set))
                        return false;
@@ -1673,6 +1867,64 @@ public class TypeManager {
                return true;
        }
 
+       public static bool CheckStructCycles (TypeContainer tc, Hashtable seen)
+       {
+               Hashtable hash = new Hashtable ();
+               return CheckStructCycles (tc, seen, hash);
+       }
+
+       public static bool CheckStructCycles (TypeContainer tc, Hashtable seen,
+                                             Hashtable hash)
+       {
+               if (!(tc is Struct) || IsBuiltinType (tc))
+                       return true;
+
+               //
+               // `seen' contains all types we've already visited.
+               //
+               if (seen.Contains (tc))
+                       return true;
+               seen.Add (tc, null);
+
+               if (tc.Fields == null)
+                       return true;
+
+               foreach (Field field in tc.Fields) {
+                       if (field.FieldBuilder.IsStatic)
+                               continue;
+
+                       Type ftype = field.FieldBuilder.FieldType;
+                       TypeContainer ftc = LookupTypeContainer (ftype);
+                       if (ftc == null)
+                               continue;
+
+                       if (hash.Contains (ftc)) {
+                               Report.Error (523, tc.Location,
+                                             "Struct member `{0}.{1}' of type `{2}' " +
+                                             "causes a cycle in the struct layout",
+                                             tc.Name, field.Name, ftc.Name);
+                               return false;
+                       }
+
+                       //
+                       // `hash' contains all types in the current path.
+                       //
+                       hash.Add (tc, null);
+
+                       bool ok = CheckStructCycles (ftc, seen, hash);
+
+                       hash.Remove (tc);
+
+                       if (!ok)
+                               return false;
+
+                       if (!seen.Contains (ftc))
+                               seen.Add (ftc, null);
+               }
+
+               return true;
+       }
+
        /// <summary>
        ///   Given an array of interface types, expand and eliminate repeated ocurrences
        ///   of an interface.  
@@ -1682,32 +1934,39 @@ public class TypeManager {
        ///   This expands in context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
        ///   be IA, IB, IC.
        /// </remarks>
-       public static Type [] ExpandInterfaces (Type [] base_interfaces)
+       public static TypeExpr[] ExpandInterfaces (TypeExpr [] base_interfaces)
        {
                ArrayList new_ifaces = new ArrayList ();
                
-               foreach (Type iface in base_interfaces){
+               foreach (TypeExpr iface in base_interfaces){
                        if (!new_ifaces.Contains (iface))
                                new_ifaces.Add (iface);
                        
-                       Type [] implementing = TypeManager.GetInterfaces (iface);
+                       TypeExpr [] implementing = iface.GetInterfaces ();
                        
-                       foreach (Type imp in implementing){
+                       foreach (TypeExpr imp in implementing){
                                if (!new_ifaces.Contains (imp))
                                        new_ifaces.Add (imp);
                        }
                }
-               Type [] ret = new Type [new_ifaces.Count];
+               TypeExpr [] ret = new TypeExpr [new_ifaces.Count];
                new_ifaces.CopyTo (ret, 0);
                return ret;
        }
+       
+       static PtrHashtable iface_cache = new PtrHashtable ();
                
        /// <summary>
        ///   This function returns the interfaces in the type `t'.  Works with
        ///   both types and TypeBuilders.
        /// </summary>
-       public static Type [] GetInterfaces (Type t)
+       public static TypeExpr [] GetInterfaces (Type t)
        {
+               
+               TypeExpr [] cached = iface_cache [t] as TypeExpr [];
+               if (cached != null)
+                       return cached;
+               
                //
                // The reason for catching the Array case is that Reflection.Emit
                // will not return a TypeBuilder for Array types of TypeBuilder types,
@@ -1722,24 +1981,43 @@ public class TypeManager {
                        t = TypeManager.array_type;
                
                if (t is TypeBuilder){
-                       Type [] parent_ifaces;
+                       TypeExpr [] parent_ifaces;
                        
                        if (t.BaseType == null)
-                               parent_ifaces = NoTypes;
+                               parent_ifaces = NoTypeExprs;
                        else
                                parent_ifaces = GetInterfaces (t.BaseType);
-                       Type [] type_ifaces = (Type []) builder_to_ifaces [t];
+                       TypeExpr [] type_ifaces = (TypeExpr []) builder_to_ifaces [t];
                        if (type_ifaces == null)
-                               type_ifaces = NoTypes;
+                               type_ifaces = NoTypeExprs;
 
                        int parent_count = parent_ifaces.Length;
-                       Type [] result = new Type [parent_count + type_ifaces.Length];
+                       TypeExpr [] result = new TypeExpr [parent_count + type_ifaces.Length];
                        parent_ifaces.CopyTo (result, 0);
                        type_ifaces.CopyTo (result, parent_count);
 
+                       iface_cache [t] = result;
                        return result;
-               } else
-                       return t.GetInterfaces ();
+               } else {
+                       Type [] ifaces = t.GetInterfaces ();
+                       if (ifaces.Length == 0)
+                               return NoTypeExprs;
+
+                       TypeExpr [] result = new TypeExpr [ifaces.Length];
+                       for (int i = 0; i < ifaces.Length; i++)
+                               result [i] = new TypeExpression (ifaces [i], Location.Null);
+                       
+                       iface_cache [t] = result;
+                       return result;
+               }
+       }
+       
+       //
+       // gets the interfaces that are declared explicitly on t
+       //
+       public static TypeExpr [] GetExplicitInterfaces (TypeBuilder t)
+       {
+               return (TypeExpr []) builder_to_ifaces [t];
        }
        
        /// <remarks>
@@ -1748,7 +2026,7 @@ public class TypeManager {
        /// </remarks>
        public static bool ImplementsInterface (Type t, Type iface)
        {
-               Type [] interfaces;
+               TypeExpr [] interfaces;
 
                //
                // FIXME OPTIMIZATION:
@@ -1761,8 +2039,8 @@ public class TypeManager {
                        interfaces = GetInterfaces (t);
 
                        if (interfaces != null){
-                               foreach (Type i in interfaces){
-                                       if (i == iface)
+                               foreach (TypeExpr i in interfaces){
+                                       if (i.Type == iface)
                                                return true;
                                }
                        }
@@ -1773,19 +2051,19 @@ public class TypeManager {
                return false;
        }
 
+       static NumberFormatInfo nf_provider = CultureInfo.CurrentCulture.NumberFormat;
+
        // This is a custom version of Convert.ChangeType() which works
        // with the TypeBuilder defined types when compiling corlib.
        public static object ChangeType (object value, Type conversionType, out bool error)
        {
-               if (!(value is IConvertible)){
+               IConvertible convert_value = value as IConvertible;
+               
+               if (convert_value == null){
                        error = true;
                        return null;
                }
                
-               IConvertible convertValue = (IConvertible) value;
-               CultureInfo ci = CultureInfo.CurrentCulture;
-               NumberFormatInfo provider = ci.NumberFormat;
-
                //
                // We must use Type.Equals() here since `conversionType' is
                // the TypeBuilder created version of a system type and not
@@ -1795,35 +2073,35 @@ public class TypeManager {
                error = false;
                try {
                        if (conversionType.Equals (typeof (Boolean)))
-                               return (object)(convertValue.ToBoolean (provider));
+                               return (object)(convert_value.ToBoolean (nf_provider));
                        else if (conversionType.Equals (typeof (Byte)))
-                               return (object)(convertValue.ToByte (provider));
+                               return (object)(convert_value.ToByte (nf_provider));
                        else if (conversionType.Equals (typeof (Char)))
-                               return (object)(convertValue.ToChar (provider));
+                               return (object)(convert_value.ToChar (nf_provider));
                        else if (conversionType.Equals (typeof (DateTime)))
-                               return (object)(convertValue.ToDateTime (provider));
+                               return (object)(convert_value.ToDateTime (nf_provider));
                        else if (conversionType.Equals (typeof (Decimal)))
-                               return (object)(convertValue.ToDecimal (provider));
+                               return (object)(convert_value.ToDecimal (nf_provider));
                        else if (conversionType.Equals (typeof (Double)))
-                               return (object)(convertValue.ToDouble (provider));
+                               return (object)(convert_value.ToDouble (nf_provider));
                        else if (conversionType.Equals (typeof (Int16)))
-                               return (object)(convertValue.ToInt16 (provider));
+                               return (object)(convert_value.ToInt16 (nf_provider));
                        else if (conversionType.Equals (typeof (Int32)))
-                               return (object)(convertValue.ToInt32 (provider));
+                               return (object)(convert_value.ToInt32 (nf_provider));
                        else if (conversionType.Equals (typeof (Int64)))
-                               return (object)(convertValue.ToInt64 (provider));
+                               return (object)(convert_value.ToInt64 (nf_provider));
                        else if (conversionType.Equals (typeof (SByte)))
-                               return (object)(convertValue.ToSByte (provider));
+                               return (object)(convert_value.ToSByte (nf_provider));
                        else if (conversionType.Equals (typeof (Single)))
-                               return (object)(convertValue.ToSingle (provider));
+                               return (object)(convert_value.ToSingle (nf_provider));
                        else if (conversionType.Equals (typeof (String)))
-                               return (object)(convertValue.ToString (provider));
+                               return (object)(convert_value.ToString (nf_provider));
                        else if (conversionType.Equals (typeof (UInt16)))
-                               return (object)(convertValue.ToUInt16 (provider));
+                               return (object)(convert_value.ToUInt16 (nf_provider));
                        else if (conversionType.Equals (typeof (UInt32)))
-                               return (object)(convertValue.ToUInt32 (provider));
+                               return (object)(convert_value.ToUInt32 (nf_provider));
                        else if (conversionType.Equals (typeof (UInt64)))
-                               return (object)(convertValue.ToUInt64 (provider));
+                               return (object)(convert_value.ToUInt64 (nf_provider));
                        else if (conversionType.Equals (typeof (Object)))
                                return (object)(value);
                        else 
@@ -1851,15 +2129,15 @@ public class TypeManager {
                if (t is TypeBuilder) {
                        // slow path needed to compile corlib
                        if (t == TypeManager.bool_type ||
-                                       t == TypeManager.byte_type ||
-                                       t == TypeManager.sbyte_type ||
-                                       t == TypeManager.char_type ||
-                                       t == TypeManager.short_type ||
-                                       t == TypeManager.ushort_type ||
-                                       t == TypeManager.int32_type ||
-                                       t == TypeManager.uint32_type ||
-                                       t == TypeManager.int64_type ||
-                                       t == TypeManager.uint64_type)
+                           t == TypeManager.byte_type ||
+                           t == TypeManager.sbyte_type ||
+                           t == TypeManager.char_type ||
+                           t == TypeManager.short_type ||
+                           t == TypeManager.ushort_type ||
+                           t == TypeManager.int32_type ||
+                           t == TypeManager.uint32_type ||
+                           t == TypeManager.int64_type ||
+                           t == TypeManager.uint64_type)
                                return t;
                        throw new Exception ("Unhandled typecode in enum " + " from " + t.AssemblyQualifiedName);
                }
@@ -1922,6 +2200,10 @@ public class TypeManager {
                        return TypeManager.int64_type;
                case TypeCode.UInt64:
                        return TypeManager.uint64_type;
+                case TypeCode.Single:
+                        return TypeManager.float_type;
+                case TypeCode.Double:
+                        return TypeManager.double_type;
                case TypeCode.String:
                        return TypeManager.string_type;
                default:
@@ -1931,6 +2213,8 @@ public class TypeManager {
                                return TypeManager.object_type;
                        if (t == typeof (System.Type))
                                return TypeManager.type_type;
+                       if (t == typeof (System.IntPtr))
+                               return TypeManager.intptr_type;
                        return t;
                }
        }
@@ -2001,26 +2285,39 @@ public class TypeManager {
                return "Item";
        }
 
+       static MethodInfo pinned_method = null;
        public static void MakePinned (LocalBuilder builder)
        {
-               //
-               // FIXME: Flag the "LocalBuilder" type as being
-               // pinned.  Figure out API.
-               //
+               if (pinned_method == null) {
+                       pinned_method = typeof (LocalBuilder).GetMethod ("MakePinned", BindingFlags.Instance | BindingFlags.NonPublic);
+                       if (pinned_method == null) {
+                               Report.Warning (-24, new Location (-1), "Microsoft.NET does not support making pinned variables." +
+                                       "This code may cause errors on a runtime with a moving GC");
+                               
+                               return;
+                       }
+               }
+               
+               pinned_method.Invoke (builder, null);
        }
 
 
        //
        // Returns whether the array of memberinfos contains the given method
        //
-       static bool ArrayContainsMethod (MemberInfo [] array, MethodBase new_method)
+       public static bool ArrayContainsMethod (MemberInfo [] array, MethodBase new_method)
        {
                Type [] new_args = TypeManager.GetArgumentTypes (new_method);
                
-               foreach (MethodBase method in array){
+               foreach (MethodBase method in array) {
                        if (method.Name != new_method.Name)
                                continue;
-                       
+
+                        if (method is MethodInfo && new_method is MethodInfo)
+                                if (((MethodInfo) method).ReturnType != ((MethodInfo) new_method).ReturnType)
+                                        continue;
+
+                        
                        Type [] old_args = TypeManager.GetArgumentTypes (method);
                        int old_count = old_args.Length;
                        int i;
@@ -2037,6 +2334,7 @@ public class TypeManager {
 
                        return true;
                }
+                
                return false;
        }
        
@@ -2046,7 +2344,7 @@ public class TypeManager {
        //
        // The name is assumed to be the same.
        //
-       public static ArrayList CopyNewMethods (ArrayList target_list, MemberList new_members)
+       public static ArrayList CopyNewMethods (ArrayList target_list, IList new_members)
        {
                if (target_list == null){
                        target_list = new ArrayList ();
@@ -2073,8 +2371,8 @@ public class TypeManager {
        [Flags]
        public enum MethodFlags {
                IsObsolete = 1,
-               IsObsoleteError = 2,
-               ShouldIgnore = 3
+               IsObsoleteError = 1 << 1,
+               ShouldIgnore = 1 << 2
        }
        
        //
@@ -2138,11 +2436,6 @@ public class TypeManager {
        
 #region MemberLookup implementation
        
-       //
-       // Name of the member
-       //
-       static string   closure_name;
-
        //
        // Whether we allow private members in the result (since FindMembers
        // uses NonPublic for both protected and private), we need to distinguish.
@@ -2153,7 +2446,6 @@ public class TypeManager {
        // Who is invoking us and which type is being queried currently.
        //
        static Type     closure_invocation_type;
-       static Type     closure_queried_type;
        static Type     closure_qualifier_type;
 
        //
@@ -2227,7 +2519,8 @@ public class TypeManager {
                                // it cannot do so through an instance of the base class (CS1540).
                                if (!mb.IsStatic && (closure_invocation_type != closure_qualifier_type) &&
                                    (closure_qualifier_type != null) &&
-                                   closure_invocation_type.IsSubclassOf (closure_qualifier_type))
+                                   closure_invocation_type.IsSubclassOf (closure_qualifier_type) &&
+                                   !TypeManager.IsNestedChildOf (closure_invocation_type, closure_qualifier_type))
                                        return false;
 
                                return true;
@@ -2276,7 +2569,8 @@ public class TypeManager {
                                // it cannot do so through an instance of the base class (CS1540).
                                if (!fi.IsStatic && (closure_invocation_type != closure_qualifier_type) &&
                                    (closure_qualifier_type != null) &&
-                                   closure_invocation_type.IsSubclassOf (closure_qualifier_type))
+                                   closure_invocation_type.IsSubclassOf (closure_qualifier_type) &&
+                                   !TypeManager.IsNestedChildOf (closure_invocation_type, closure_qualifier_type))
                                        return false;
 
                                return true;
@@ -2350,7 +2644,6 @@ public class TypeManager {
                bool skip_iface_check = true, used_cache = false;
                bool always_ok_flag = false;
 
-               closure_name = name;
                closure_invocation_type = invocation_type;
                closure_invocation_assembly = invocation_type != null ? invocation_type.Assembly : null;
                closure_qualifier_type = qualifier_type;
@@ -2374,8 +2667,14 @@ public class TypeManager {
                        }
                }
                
+               // This is from the first time we find a method
+               // in most cases, we do not actually find a method in the base class
+               // so we can just ignore it, and save the arraylist allocation
+               MemberInfo [] first_members_list = null;
+               bool use_first_members_list = false;
+               
                do {
-                       MemberList list;
+                       MemberInfo [] list;
 
                        //
                        // `NonPublic' is lame, because it includes both protected and
@@ -2395,7 +2694,6 @@ public class TypeManager {
                                bf = original_bf;
 
                        closure_private_ok = (original_bf & BindingFlags.NonPublic) != 0;
-                       closure_queried_type = current_type;
 
                        Timer.StopTimer (TimerType.MemberLookup);
 
@@ -2430,7 +2728,7 @@ public class TypeManager {
                                        current_type = TypeManager.object_type;
                        }
                        
-                       if (list.Count == 0)
+                       if (list.Length == 0)
                                continue;
 
                        //
@@ -2438,8 +2736,8 @@ public class TypeManager {
                        // searches, which means that our above FindMembers will
                        // return two copies of the same.
                        //
-                       if (list.Count == 1 && !(list [0] is MethodBase)){
-                               return (MemberInfo []) list;
+                       if (list.Length == 1 && !(list [0] is MethodBase)){
+                               return list;
                        }
 
                        //
@@ -2447,14 +2745,14 @@ public class TypeManager {
                        // name
                        //
                        if (list [0] is PropertyInfo)
-                               return (MemberInfo []) list;
+                               return list;
 
                        //
                        // We found an event: the cache lookup returns both the event and
                        // its private field.
                        //
                        if (list [0] is EventInfo) {
-                               if ((list.Count == 2) && (list [1] is FieldInfo))
+                               if ((list.Length == 2) && (list [1] is FieldInfo))
                                        return new MemberInfo [] { list [0] };
 
                                // Oooops
@@ -2466,13 +2764,33 @@ public class TypeManager {
                        // mode.
                        //
 
-                       method_list = CopyNewMethods (method_list, list);
-                       mt &= (MemberTypes.Method | MemberTypes.Constructor);
+                       if (first_members_list != null) {
+                               if (use_first_members_list) {
+                                       method_list = CopyNewMethods (method_list, first_members_list);
+                                       use_first_members_list = false;
+                               }
+                               
+                               method_list = CopyNewMethods (method_list, list);
+                       } else {
+                               first_members_list = list;
+                               use_first_members_list = true;
+                               mt &= (MemberTypes.Method | MemberTypes.Constructor);
+                       }
                } while (searching);
+               
+               if (use_first_members_list) {
+                       foreach (MemberInfo mi in first_members_list) {
+                               if (! (mi is MethodBase)) {
+                                       method_list = CopyNewMethods (method_list, first_members_list);
+                                       return (MemberInfo []) method_list.ToArray (typeof (MemberInfo));
+                               }
+                       }
+                       return (MemberInfo []) first_members_list;
+               }
 
                if (method_list != null && method_list.Count > 0)
-                       return (MemberInfo []) method_list.ToArray (typeof (MemberInfo));
-
+                        return (MemberInfo []) method_list.ToArray (typeof (MemberInfo));
+                
                //
                // This happens if we already used the cache in the first iteration, in this case
                // the cache already looked in all interfaces.
@@ -2490,14 +2808,14 @@ public class TypeManager {
                if (queried_type.IsArray)
                        queried_type = TypeManager.array_type;
                
-               Type [] ifaces = GetInterfaces (queried_type);
+               TypeExpr [] ifaces = GetInterfaces (queried_type);
                if (ifaces == null)
                        return null;
                
-               foreach (Type itype in ifaces){
+               foreach (TypeExpr itype in ifaces){
                        MemberInfo [] x;
 
-                       x = MemberLookup (null, null, itype, mt, bf, name);
+                       x = MemberLookup (null, null, itype.Type, mt, bf, name);
                        if (x != null)
                                return x;
                }
@@ -2615,6 +2933,11 @@ public sealed class TypeHandle : IMemberContainer {
                type_hash.Add (t, handle);
                return handle;
        }
+       
+       public static void CleanUp ()
+       {
+               type_hash = null;
+       }
 
        /// <summary>
        ///   Returns the TypeHandle for TypeManager.object_type.
@@ -2658,8 +2981,7 @@ public sealed class TypeHandle : IMemberContainer {
                this.type = type;
                if (type.BaseType != null)
                        BaseType = GetTypeHandle (type.BaseType);
-               else if ((type != TypeManager.object_type) && (type != typeof (object)))
-                       is_interface = true;
+               this.is_interface = type.IsInterface;
                this.member_cache = new MemberCache (this);
        }
 
@@ -2691,11 +3013,15 @@ public sealed class TypeHandle : IMemberContainer {
 
        public MemberList GetMembers (MemberTypes mt, BindingFlags bf)
        {
+                MemberInfo [] members;
                if (mt == MemberTypes.Event)
-                       return new MemberList (type.GetEvents (bf | BindingFlags.DeclaredOnly));
-               else
-                       return new MemberList (type.FindMembers (mt, bf | BindingFlags.DeclaredOnly,
-                                                                null, null));
+                        members = type.GetEvents (bf | BindingFlags.DeclaredOnly);
+                else
+                        members = type.FindMembers (mt, bf | BindingFlags.DeclaredOnly,
+                                                    null, null);
+                Array.Reverse (members);
+
+                return new MemberList (members);
        }
 
        // IMemberFinder methods
@@ -2703,7 +3029,7 @@ public sealed class TypeHandle : IMemberContainer {
        public MemberList FindMembers (MemberTypes mt, BindingFlags bf, string name,
                                       MemberFilter filter, object criteria)
        {
-               return member_cache.FindMembers (mt, bf, name, filter, criteria);
+               return new MemberList (member_cache.FindMembers (mt, bf, name, filter, criteria));
        }
 
        public MemberCache MemberCache {