[660553] Fixed delegate name hiding.
[mono.git] / mcs / mcs / method.cs
index 7da5949969da8de0627c4894e49ccddca1b5cacd..ed9e7152b8908ca0cc43af205bb13ee9ae7521f9 100644 (file)
 
 using System;
 using System.Collections.Generic;
-using System.Reflection;
-using System.Reflection.Emit;
-using System.Runtime.CompilerServices;
-using System.Runtime.InteropServices;
 using System.Security;
 using System.Security.Permissions;
 using System.Text;
@@ -28,6 +24,18 @@ using XmlElement = System.Object;
 using System.Xml;
 #endif
 
+#if STATIC
+using MetaType = IKVM.Reflection.Type;
+using SecurityType = System.Collections.Generic.List<IKVM.Reflection.Emit.CustomAttributeBuilder>;
+using IKVM.Reflection;
+using IKVM.Reflection.Emit;
+#else
+using MetaType = System.Type;
+using SecurityType = System.Collections.Generic.Dictionary<System.Security.Permissions.SecurityAction, System.Security.PermissionSet>;
+using System.Reflection;
+using System.Reflection.Emit;
+#endif
+
 using Mono.CompilerServices.SymbolWriter;
 
 namespace Mono.CSharp {
@@ -143,11 +151,14 @@ namespace Mono.CSharp {
 
                public override bool EnableOverloadChecks (MemberCore overload)
                {
-                       if (overload is MethodCore || overload is AbstractPropertyEventMethod) {
+                       if (overload is MethodCore) {
                                caching_flags |= Flags.MethodOverloadsExist;
                                return true;
                        }
 
+                       if (overload is AbstractPropertyEventMethod)
+                               return true;
+
                        return base.EnableOverloadChecks (overload);
                }
 
@@ -182,9 +193,9 @@ namespace Mono.CSharp {
 //             MethodInfo MakeGenericMethod (TypeSpec[] targs);
        }
 
-       public class MethodSpec : MemberSpec, IParametersMember
+       public sealed class MethodSpec : MemberSpec, IParametersMember
        {
-               MethodBase metaInfo;
+               MethodBase metaInfo, inflatedMetaInfo;
                AParametersCollection parameters;
                TypeSpec returnType;
 
@@ -290,28 +301,44 @@ namespace Mono.CSharp {
 
                public MethodBase GetMetaInfo ()
                {
-                       if ((state & StateFlags.PendingMetaInflate) != 0) {
-                               if (DeclaringType.IsTypeBuilder) {
-                                       if (IsConstructor)
-                                               metaInfo = TypeBuilder.GetConstructor (DeclaringType.GetMetaInfo (), (ConstructorInfo) metaInfo);
-                                       else
-                                               metaInfo = TypeBuilder.GetMethod (DeclaringType.GetMetaInfo (), (MethodInfo) metaInfo);
+                       //
+                       // inflatedMetaInfo is extra field needed for cases where we
+                       // inflate method but another nested type can later inflate
+                       // again (the cache would be build with inflated metaInfo) and
+                       // TypeBuilder can work with method definitions only
+                       //
+                       if (inflatedMetaInfo == null) {
+                               if ((state & StateFlags.PendingMetaInflate) != 0) {
+                                       if (DeclaringType.IsTypeBuilder) {
+                                               if (IsConstructor)
+                                                       inflatedMetaInfo = TypeBuilder.GetConstructor (DeclaringType.GetMetaInfo (), (ConstructorInfo) metaInfo);
+                                               else
+                                                       inflatedMetaInfo = TypeBuilder.GetMethod (DeclaringType.GetMetaInfo (), (MethodInfo) metaInfo);
+                                       } else {
+#if STATIC
+                                       // it should not be reached
+                                       throw new NotImplementedException ();
+#else
+                                               inflatedMetaInfo = MethodInfo.GetMethodFromHandle (metaInfo.MethodHandle, DeclaringType.GetMetaInfo ().TypeHandle);
+#endif
+                                       }
+
+                                       state &= ~StateFlags.PendingMetaInflate;
                                } else {
-                                       metaInfo = MethodInfo.GetMethodFromHandle (metaInfo.MethodHandle, DeclaringType.GetMetaInfo ().TypeHandle);
+                                       inflatedMetaInfo = metaInfo;
                                }
-
-                               state &= ~StateFlags.PendingMetaInflate;
                        }
 
                        if ((state & StateFlags.PendingMakeMethod) != 0) {
-                               metaInfo = ((MethodInfo) metaInfo).MakeGenericMethod (targs.Select (l => l.GetMetaInfo ()).ToArray ());
+                               var sre_targs = new MetaType[targs.Length];
+                               for (int i = 0; i < sre_targs.Length; ++i)
+                                       sre_targs[i] = targs[i].GetMetaInfo ();
+
+                               inflatedMetaInfo = ((MethodInfo) inflatedMetaInfo).MakeGenericMethod (sre_targs);
                                state &= ~StateFlags.PendingMakeMethod;
                        }
 
-                       if (Kind == MemberKind.FakeMethod)
-                               throw new InternalErrorException ("Emitting fake method");
-
-                       return metaInfo;
+                       return inflatedMetaInfo;
                }
 
                public override string GetSignatureForError ()
@@ -354,10 +381,11 @@ namespace Mono.CSharp {
                public override MemberSpec InflateMember (TypeParameterInflator inflator)
                {
                        var ms = (MethodSpec) base.InflateMember (inflator);
+                       ms.inflatedMetaInfo = null;
                        ms.returnType = inflator.Inflate (returnType);
                        ms.parameters = parameters.Inflate (inflator);
                        if (IsGeneric)
-                               ms.constraints = TypeParameterSpec.InflateConstraints (inflator, GenericDefinition.TypeParameters);
+                               ms.constraints = TypeParameterSpec.InflateConstraints (inflator, Constraints);
 
                        return ms;
                }
@@ -406,9 +434,7 @@ namespace Mono.CSharp {
 
                        var ms = (MethodSpec) MemberwiseClone ();
                        if (decl != DeclaringType) {
-                               // Gets back MethodInfo in case of metaInfo was inflated
-                               ms.metaInfo = MemberCache.GetMember (DeclaringType.GetDefinition (), this).metaInfo;
-
+                               ms.inflatedMetaInfo = null;
                                ms.declaringType = decl;
                                ms.state |= StateFlags.PendingMetaInflate;
                        }
@@ -434,7 +460,7 @@ namespace Mono.CSharp {
        {
                public MethodBuilder MethodBuilder;
                ReturnParameter return_attributes;
-               Dictionary<SecurityAction, PermissionSet> declarative_security;
+               SecurityType declarative_security;
                protected MethodData MethodData;
 
                static string[] attribute_targets = new string [] { "method", "return" };
@@ -457,8 +483,8 @@ namespace Mono.CSharp {
                                return;
                        }
 
-                       if (a.IsInternalMethodImplAttribute) {
-                               is_external_implementation = true;
+                       if (a.Type == pa.MethodImpl) {
+                               is_external_implementation = a.IsInternalCall ();
                        }
 
                        if (a.Type == pa.DllImport) {
@@ -470,9 +496,7 @@ namespace Mono.CSharp {
                        }
 
                        if (a.IsValidSecurityAttribute ()) {
-                               if (declarative_security == null)
-                                       declarative_security = new Dictionary<SecurityAction, PermissionSet> ();
-                               a.ExtractSecurityPermissionSet (declarative_security);
+                               a.ExtractSecurityPermissionSet (ctor, ref declarative_security);
                                return;
                        }
 
@@ -576,23 +600,16 @@ namespace Mono.CSharp {
                public override void Emit ()
                {
                        if ((ModFlags & Modifiers.COMPILER_GENERATED) != 0 && !Parent.IsCompilerGenerated)
-                               PredefinedAttributes.Get.CompilerGenerated.EmitAttribute (MethodBuilder);
+                               Module.PredefinedAttributes.CompilerGenerated.EmitAttribute (MethodBuilder);
                        if ((ModFlags & Modifiers.DEBUGGER_HIDDEN) != 0)
-                               PredefinedAttributes.Get.DebuggerHidden.EmitAttribute (MethodBuilder);
+                               Module.PredefinedAttributes.DebuggerHidden.EmitAttribute (MethodBuilder);
 
                        if (ReturnType == InternalType.Dynamic) {
                                return_attributes = new ReturnParameter (this, MethodBuilder, Location);
-                               PredefinedAttributes.Get.Dynamic.EmitAttribute (return_attributes.Builder);
-                       } else {
-                               var trans_flags = TypeManager.HasDynamicTypeUsed (ReturnType);
-                               if (trans_flags != null) {
-                                       var pa = PredefinedAttributes.Get.DynamicTransform;
-                                       if (pa.Constructor != null || pa.ResolveConstructor (Location, ArrayContainer.MakeType (TypeManager.bool_type))) {
-                                               return_attributes = new ReturnParameter (this, MethodBuilder, Location);
-                                               return_attributes.Builder.SetCustomAttribute (
-                                                       new CustomAttributeBuilder (pa.Constructor, new object [] { trans_flags }));
-                                       }
-                               }
+                               Module.PredefinedAttributes.Dynamic.EmitAttribute (return_attributes.Builder);
+                       } else if (ReturnType.HasDynamicElement) {
+                               return_attributes = new ReturnParameter (this, MethodBuilder, Location);
+                               Module.PredefinedAttributes.Dynamic.EmitAttribute (return_attributes.Builder, ReturnType, Location);
                        }
 
                        if (OptAttributes != null)
@@ -600,7 +617,11 @@ namespace Mono.CSharp {
 
                        if (declarative_security != null) {
                                foreach (var de in declarative_security) {
+#if STATIC
+                                       MethodBuilder.__AddDeclarativeSecurity (de);
+#else
                                        MethodBuilder.AddDeclarativeSecurity (de.Key, de.Value);
+#endif
                                }
                        }
 
@@ -670,7 +691,7 @@ namespace Mono.CSharp {
                                if (OptAttributes == null)
                                        return null;
 
-                               Attribute[] attrs = OptAttributes.SearchMulti (PredefinedAttributes.Get.Conditional);
+                               Attribute[] attrs = OptAttributes.SearchMulti (Module.PredefinedAttributes.Conditional);
                                if (attrs == null)
                                        return null;
 
@@ -718,12 +739,17 @@ namespace Mono.CSharp {
 
                public int Token {
                        get {
-                               if (method is MethodBuilder)
-                                       return ((MethodBuilder) method).GetToken ().Token;
-                               else if (method is ConstructorBuilder)
-                                       return ((ConstructorBuilder) method).GetToken ().Token;
+                               MethodToken token;
+                               var mb = method as MethodBuilder;
+                               if (mb != null)
+                                       token = mb.GetToken ();
                                else
-                                       throw new NotSupportedException ();
+                                       token = ((ConstructorBuilder) method).GetToken ();
+#if STATIC
+                               if (token.IsPseudoToken)
+                                       return ((ModuleBuilder) method.Module).ResolvePseudoToken (token.Token);
+#endif
+                               return token.Token;
                        }
                }
 
@@ -759,33 +785,15 @@ namespace Mono.CSharp {
 
        public class Method : MethodOrOperator, IGenericMethodDefinition
        {
-               /// <summary>
-               ///   Modifiers allowed in a class declaration
-               /// </summary>
-               const Modifiers AllowedModifiers =
-                       Modifiers.NEW |
-                       Modifiers.PUBLIC |
-                       Modifiers.PROTECTED |
-                       Modifiers.INTERNAL |
-                       Modifiers.PRIVATE |
-                       Modifiers.STATIC |
-                       Modifiers.VIRTUAL |
-                       Modifiers.SEALED |
-                       Modifiers.OVERRIDE |
-                       Modifiers.ABSTRACT |
-                       Modifiers.UNSAFE |
-                       Modifiers.EXTERN;
-
-               const Modifiers AllowedInterfaceModifiers = 
-                       Modifiers.NEW | Modifiers.UNSAFE;
-
                Method partialMethodImplementation;
 
                public Method (DeclSpace parent, GenericMethod generic,
                               FullNamedExpression return_type, Modifiers mod,
                               MemberName name, ParametersCompiled parameters, Attributes attrs)
                        : base (parent, generic, return_type, mod,
-                               parent.PartialContainer.Kind == MemberKind.Interface ? AllowedInterfaceModifiers : AllowedModifiers,
+                               parent.PartialContainer.Kind == MemberKind.Interface ? AllowedModifiersInterface :
+                               parent.PartialContainer.Kind == MemberKind.Struct ? AllowedModifiersStruct :
+                               AllowedModifiersClass,
                                name, attrs, parameters)
                {
                }
@@ -796,7 +804,7 @@ namespace Mono.CSharp {
                {
                }
 
-#region Properties
+               #region Properties
 
                public override TypeParameter[] CurrentTypeParameters {
                        get {
@@ -826,6 +834,7 @@ namespace Mono.CSharp {
 
                public TypeParameterSpec[] TypeParameters {
                        get {
+                               // TODO: Cache this
                                return CurrentTypeParameters.Select (l => l.Type).ToArray ();
                        }
                }
@@ -847,7 +856,7 @@ namespace Mono.CSharp {
                {
                        Report.Error (17, b.Location,
                                "Program `{0}' has more than one entry point defined: `{1}'",
-                               CodeGen.FileName, b.GetSignatureForError ());
+                               b.Module.Builder.ScopeName, b.GetSignatureForError ());
                }
 
                bool IsEntryPoint ()
@@ -889,13 +898,13 @@ namespace Mono.CSharp {
                                        return;
                                }
 
-                               if (ReturnType != TypeManager.void_type) {
-                                       Report.Error (578, Location, "Conditional not valid on `{0}' because its return type is not void", GetSignatureForError ());
+                               if ((ModFlags & Modifiers.OVERRIDE) != 0) {
+                                       Report.Error (243, Location, "Conditional not valid on `{0}' because it is an override method", GetSignatureForError ());
                                        return;
                                }
 
-                               if ((ModFlags & Modifiers.OVERRIDE) != 0) {
-                                       Report.Error (243, Location, "Conditional not valid on `{0}' because it is an override method", GetSignatureForError ());
+                               if (ReturnType != TypeManager.void_type) {
+                                       Report.Error (578, Location, "Conditional not valid on `{0}' because its return type is not void", GetSignatureForError ());
                                        return;
                                }
 
@@ -927,42 +936,49 @@ namespace Mono.CSharp {
                        base.ApplyAttributeBuilder (a, ctor, cdata, pa);
                }
 
-               protected override bool CheckForDuplications ()
-               {
-                       if (!base.CheckForDuplications ())
-                               return false;
-
-                       var ar = Parent.PartialContainer.Properties;
-                       if (ar != null) {
-                               for (int i = 0; i < ar.Count; ++i) {
-                                       PropertyBase pb = (PropertyBase) ar [i];
-                                       if (pb.AreAccessorsDuplicateImplementation (this))
-                                               return false;
-                               }
-                       }
-
-                       ar = Parent.PartialContainer.Indexers;
-                       if (ar != null) {
-                               for (int i = 0; i < ar.Count; ++i) {
-                                       PropertyBase pb = (PropertyBase) ar [i];
-                                       if (pb.AreAccessorsDuplicateImplementation (this))
-                                               return false;
-                               }
-                       }
-
-                       return true;
-               }
-
                protected virtual void DefineTypeParameters ()
                {
                        var tparams = CurrentTypeParameters;
 
                        TypeParameterSpec[] base_tparams = null;
+                       TypeParameterSpec[] base_decl_tparams = TypeParameterSpec.EmptyTypes;
+                       TypeSpec[] base_targs = TypeSpec.EmptyTypes;
                        if (((ModFlags & Modifiers.OVERRIDE) != 0 || IsExplicitImpl)) {
-                               if (base_method != null)
+                               if (base_method != null) {
                                        base_tparams = base_method.GenericDefinition.TypeParameters;
-                               else if (MethodData.implementing != null)
+                               
+                                       if (base_method.DeclaringType.IsGeneric) {
+                                               base_decl_tparams = base_method.DeclaringType.MemberDefinition.TypeParameters;
+
+                                               var base_type_parent = CurrentType;
+                                               while (base_type_parent.BaseType != base_method.DeclaringType) {
+                                                       base_type_parent = base_type_parent.BaseType;
+                                               }
+
+                                               base_targs = base_type_parent.BaseType.TypeArguments;
+                                       }
+
+                                       if (base_method.IsGeneric) {
+                                               if (base_decl_tparams.Length != 0) {
+                                                       base_decl_tparams = base_decl_tparams.Concat (base_tparams).ToArray ();
+                                                       base_targs = base_targs.Concat (tparams.Select<TypeParameter, TypeSpec> (l => l.Type)).ToArray ();
+                                               } else {
+                                                       base_decl_tparams = base_tparams;
+                                                       base_targs = tparams.Select (l => l.Type).ToArray ();
+                                               }
+                                       }
+                               } else if (MethodData.implementing != null) {
                                        base_tparams = MethodData.implementing.GenericDefinition.TypeParameters;
+                                       if (MethodData.implementing.DeclaringType.IsGeneric) {
+                                               base_decl_tparams = MethodData.implementing.DeclaringType.MemberDefinition.TypeParameters;
+                                               foreach (var iface in Parent.CurrentType.Interfaces) {
+                                                       if (iface == MethodData.implementing.DeclaringType) {
+                                                               base_targs = iface.TypeArguments;
+                                                               break;
+                                                       }
+                                               }
+                                       }
+                               }
                        }
 
                        for (int i = 0; i < tparams.Length; ++i) {
@@ -976,15 +992,38 @@ namespace Mono.CSharp {
                                //
                                if (base_tparams != null) {
                                        var base_tparam = base_tparams[i];
-                                       tp.Type.SpecialConstraint = base_tparam.SpecialConstraint;
-                                       tp.Type.TypeArguments = base_tparam.TypeArguments;
+                                       var local_tparam = tp.Type;
+                                       local_tparam.SpecialConstraint = base_tparam.SpecialConstraint;
 
-                                       // TODO MemberCache: Inflate with different MVAR ?
-                                       if (base_tparam.InterfacesDefined != null)
-                                               tp.Type.Interfaces = new List<TypeSpec> (base_tparam.InterfacesDefined);
+                                       var inflator = new TypeParameterInflator (CurrentType, base_decl_tparams, base_targs);
+                                       base_tparam.InflateConstraints (inflator, local_tparam);
 
-                                       tp.Type.BaseType = base_tparam.BaseType;
-                               } else if (MethodData.implementing != null) {
+                                       //
+                                       // Check all type argument constraints for possible collision
+                                       // introduced by inflating inherited constraints in this context
+                                       //
+                                       // Conflict example:
+                                       //
+                                       // class A<T> { virtual void Foo<U> () where U : class, T {} }
+                                       // class B : A<int> { override void Foo<U> {} }
+                                       //
+                                       var local_tparam_targs = local_tparam.TypeArguments;
+                                       if (local_tparam_targs != null) {                                       
+                                               for (int ii = 0; ii < local_tparam_targs.Length; ++ii) {
+                                                       var ta = local_tparam_targs [ii];
+                                                       if (!ta.IsClass && !ta.IsStruct)
+                                                               continue;
+
+                                                       if (Constraints.CheckConflictingInheritedConstraint (local_tparam, ta, this, Location)) {
+                                                               local_tparam.ChangeTypeArgumentToBaseType (ii);
+                                                       }
+                                               }
+                                       }
+
+                                       continue;
+                               }
+                               
+                               if (MethodData.implementing != null) {
                                        var base_tp = MethodData.implementing.Constraints[i];
                                        if (!tp.Type.HasSameConstraintsImplementation (base_tp)) {
                                                Report.SymbolRelatedToPreviousError (MethodData.implementing);
@@ -1028,7 +1067,7 @@ namespace Mono.CSharp {
                                DefineTypeParameters ();
                        }
 
-                       if (block != null && block.IsIterator && !(Parent is IteratorStorey)) {
+                       if (block != null && block.IsIterator) {
                                //
                                // Current method is turned into automatically generated
                                // wrapper which creates an instance of iterator
@@ -1046,7 +1085,7 @@ namespace Mono.CSharp {
                                                Report.Error (1109, Location, "`{0}': Extension methods cannot be defined in a nested class",
                                                        GetSignatureForError ());
 
-                                       PredefinedAttribute pa = PredefinedAttributes.Get.Extension;
+                                       PredefinedAttribute pa = Module.PredefinedAttributes.Extension;
                                        if (!pa.IsDefined) {
                                                Report.Error (1110, Location,
                                                        "`{0}': Extension methods cannot be declared without a reference to System.Core.dll assembly. Add the assembly reference or remove `this' modifer from the first parameter",
@@ -1056,7 +1095,7 @@ namespace Mono.CSharp {
                                        ModFlags |= Modifiers.METHOD_EXTENSION;
                                        Parent.PartialContainer.ModFlags |= Modifiers.METHOD_EXTENSION;
                                        Spec.DeclaringType.SetExtensionMethodContainer ();
-                                       CodeGen.Assembly.HasExtensionMethods = true;
+                                       Parent.Module.HasExtensionMethod = true;
                                } else {
                                        Report.Error (1106, Location, "`{0}': Extension methods must be defined in a non-generic static class",
                                                GetSignatureForError ());
@@ -1072,16 +1111,16 @@ namespace Mono.CSharp {
                                RootContext.MainClass == Parent.TypeBuilder.FullName)){
                                if (IsEntryPoint ()) {
 
-                                       if (RootContext.EntryPoint == null) {
+                                       if (Parent.DeclaringAssembly.EntryPoint == null) {
                                                if (Parent.IsGeneric || MemberName.IsGeneric) {
                                                        Report.Warning (402, 4, Location, "`{0}': an entry point cannot be generic or in a generic type",
                                                                GetSignatureForError ());
                                                } else {
                                                        SetIsUsed ();
-                                                       RootContext.EntryPoint = this;
+                                                       Parent.DeclaringAssembly.EntryPoint = this;
                                                }
                                        } else {
-                                               Error_DuplicateEntryPoint (RootContext.EntryPoint);
+                                               Error_DuplicateEntryPoint (Parent.DeclaringAssembly.EntryPoint);
                                                Error_DuplicateEntryPoint (this);
                                        }
                                } else {
@@ -1099,16 +1138,18 @@ namespace Mono.CSharp {
                public override void Emit ()
                {
                        try {
-                               Report.Debug (64, "METHOD EMIT", this, MethodBuilder, Location, Block, MethodData);
                                if (IsPartialDefinition) {
                                        //
                                        // Use partial method implementation builder for partial method declaration attributes
                                        //
                                        if (partialMethodImplementation != null) {
                                                MethodBuilder = partialMethodImplementation.MethodBuilder;
-                                               return;
                                        }
-                               } else if ((ModFlags & Modifiers.PARTIAL) != 0 && (caching_flags & Flags.PartialDefinitionExists) == 0) {
+
+                                       return;
+                               }
+                               
+                               if ((ModFlags & Modifiers.PARTIAL) != 0 && (caching_flags & Flags.PartialDefinitionExists) == 0) {
                                        Report.Error (759, Location, "A partial method `{0}' implementation is missing a partial method declaration",
                                                GetSignatureForError ());
                                }
@@ -1134,7 +1175,7 @@ namespace Mono.CSharp {
                                base.Emit ();
                                
                                if ((ModFlags & Modifiers.METHOD_EXTENSION) != 0)
-                                       PredefinedAttributes.Get.Extension.EmitAttribute (MethodBuilder);
+                                       Module.PredefinedAttributes.Extension.EmitAttribute (MethodBuilder);
                        } catch {
                                Console.WriteLine ("Internal compiler error at {0}: exception caught while emitting {1}",
                                                   Location, MethodBuilder);
@@ -1195,7 +1236,7 @@ namespace Mono.CSharp {
        public abstract class ConstructorInitializer : ExpressionStatement
        {
                Arguments argument_list;
-               MethodGroupExpr base_constructor_group;
+               MethodSpec base_ctor;
 
                public ConstructorInitializer (Arguments argument_list, Location loc)
                {
@@ -1221,65 +1262,47 @@ namespace Mono.CSharp {
                        // FIXME: Hack
                        var caller_builder = (Constructor) ec.MemberContext;
 
-                       if (argument_list != null) {
-                               bool dynamic;
-
-                               //
-                               // Spec mandates that constructor initializer will not have `this' access
-                               //
-                               using (ec.Set (ResolveContext.Options.BaseInitializer)) {
+                       //
+                       // Spec mandates that constructor initializer will not have `this' access
+                       //
+                       using (ec.Set (ResolveContext.Options.BaseInitializer)) {
+                               if (argument_list != null) {
+                                       bool dynamic;
                                        argument_list.Resolve (ec, out dynamic);
-                               }
 
-                               if (dynamic) {
-                                       ec.Report.Error (1975, loc,
-                                               "The constructor call cannot be dynamically dispatched within constructor initializer");
+                                       if (dynamic) {
+                                               ec.Report.Error (1975, loc,
+                                                       "The constructor call cannot be dynamically dispatched within constructor initializer");
 
-                                       return null;
+                                               return null;
+                                       }
                                }
-                       }
 
-                       type = ec.CurrentType;
-                       if (this is ConstructorBaseInitializer) {
-                               if (ec.CurrentType.BaseType == null)
-                                       return this;
+                               type = ec.CurrentType;
+                               if (this is ConstructorBaseInitializer) {
+                                       if (ec.CurrentType.BaseType == null)
+                                               return this;
 
-                               type = ec.CurrentType.BaseType;
-                               if (ec.CurrentType.IsStruct) {
-                                       ec.Report.Error (522, loc,
-                                               "`{0}': Struct constructors cannot call base constructors", caller_builder.GetSignatureForError ());
-                                       return this;
+                                       type = ec.CurrentType.BaseType;
+                                       if (ec.CurrentType.IsStruct) {
+                                               ec.Report.Error (522, loc,
+                                                       "`{0}': Struct constructors cannot call base constructors", caller_builder.GetSignatureForError ());
+                                               return this;
+                                       }
+                               } else {
+                                       //
+                                       // It is legal to have "this" initializers that take no arguments
+                                       // in structs, they are just no-ops.
+                                       //
+                                       // struct D { public D (int a) : this () {}
+                                       //
+                                       if (TypeManager.IsStruct (ec.CurrentType) && argument_list == null)
+                                               return this;
                                }
-                       } else {
-                               //
-                               // It is legal to have "this" initializers that take no arguments
-                               // in structs, they are just no-ops.
-                               //
-                               // struct D { public D (int a) : this () {}
-                               //
-                               if (TypeManager.IsStruct (ec.CurrentType) && argument_list == null)
-                                       return this;                    
-                       }
-
-                       base_constructor_group = MemberLookupFinal (
-                               ec, null, type, ConstructorBuilder.ConstructorName, 0, MemberKind.Constructor,
-                               BindingRestriction.AccessibleOnly | BindingRestriction.DeclaredOnly,
-                               loc) as MethodGroupExpr;
-                       
-                       if (base_constructor_group == null)
-                               return this;
-                       
-                       base_constructor_group = base_constructor_group.OverloadResolve (
-                               ec, ref argument_list, false, loc);
-                       
-                       if (base_constructor_group == null)
-                               return this;
-
-                       if (!ec.IsStatic)
-                               base_constructor_group.InstanceExpression = ec.GetThis (loc);
-                       
-                       var base_ctor = base_constructor_group.BestCandidate;
 
+                               base_ctor = ConstructorLookup (ec, type, ref argument_list, loc);
+                       }
+       
                        // TODO MemberCache: Does it work for inflated types ?
                        if (base_ctor == caller_builder.Spec){
                                ec.Report.Error (516, loc, "Constructor `{0}' cannot call itself",
@@ -1292,12 +1315,12 @@ namespace Mono.CSharp {
                public override void Emit (EmitContext ec)
                {
                        // It can be null for static initializers
-                       if (base_constructor_group == null)
+                       if (base_ctor == null)
                                return;
                        
                        ec.Mark (loc);
 
-                       base_constructor_group.EmitCall (ec, argument_list);
+                       Invocation.EmitCall (ec, new CompilerGeneratedThis (type, loc), base_ctor, argument_list, loc);
                }
 
                public override void EmitStatement (EmitContext ec)
@@ -1330,7 +1353,7 @@ namespace Mono.CSharp {
        public class Constructor : MethodCore, IMethodData {
                public ConstructorBuilder ConstructorBuilder;
                public ConstructorInitializer Initializer;
-               Dictionary<SecurityAction, PermissionSet> declarative_security;
+               SecurityType declarative_security;
                bool has_compliant_args;
 
                // <summary>
@@ -1347,6 +1370,9 @@ namespace Mono.CSharp {
 
                static readonly string[] attribute_targets = new string [] { "method" };
 
+               public static readonly string ConstructorName = ".ctor";
+               public static readonly string TypeConstructorName = ".cctor";
+
                //
                // The spec claims that static is not permitted, but
                // my very own code has static constructors.
@@ -1383,15 +1409,12 @@ namespace Mono.CSharp {
                public override void ApplyAttributeBuilder (Attribute a, MethodSpec ctor, byte[] cdata, PredefinedAttributes pa)
                {
                        if (a.IsValidSecurityAttribute ()) {
-                               if (declarative_security == null) {
-                                       declarative_security = new Dictionary<SecurityAction, PermissionSet> ();
-                               }
-                               a.ExtractSecurityPermissionSet (declarative_security);
+                               a.ExtractSecurityPermissionSet (ctor, ref declarative_security);
                                return;
                        }
 
-                       if (a.IsInternalMethodImplAttribute) {
-                               is_external_implementation = true;
+                       if (a.Type == pa.MethodImpl) {
+                               is_external_implementation = a.IsInternalCall ();
                        }
 
                        ConstructorBuilder.SetCustomAttribute ((ConstructorInfo) ctor.GetMetaInfo (), cdata);
@@ -1478,11 +1501,15 @@ namespace Mono.CSharp {
                                        Report.Error (669, Location, "`{0}': A class with the ComImport attribute cannot have a user-defined constructor",
                                                Parent.GetSignatureForError ());
                                }
+
+                               // Set as internal implementation and reset block data
+                               // to ensure no IL is generated
                                ConstructorBuilder.SetImplementationFlags (MethodImplAttributes.InternalCall);
+                               block = null;
                        }
 
                        if ((ModFlags & Modifiers.DEBUGGER_HIDDEN) != 0)
-                               PredefinedAttributes.Get.DebuggerHidden.EmitAttribute (ConstructorBuilder);
+                               Module.PredefinedAttributes.DebuggerHidden.EmitAttribute (ConstructorBuilder);
 
                        if (OptAttributes != null)
                                OptAttributes.Emit ();
@@ -1507,7 +1534,7 @@ namespace Mono.CSharp {
                                // initializer, it must initialize all of the struct's fields.
                                if ((Parent.PartialContainer.Kind == MemberKind.Struct) &&
                                        ((ModFlags & Modifiers.STATIC) == 0) && (Initializer == null))
-                                       block.AddThisVariable (Parent, Location);
+                                       block.AddThisVariable (bc, Parent, Location);
 
                                if (block != null && (ModFlags & Modifiers.STATIC) == 0){
                                        if (Parent.PartialContainer.Kind == MemberKind.Class && Initializer == null)
@@ -1519,12 +1546,12 @@ namespace Mono.CSharp {
                                }
                        }
 
-                       parameters.ApplyAttributes (ConstructorBuilder);
+                       parameters.ApplyAttributes (this, ConstructorBuilder);
 
                        SourceMethod source = SourceMethod.Create (Parent, ConstructorBuilder, block);
 
                        if (block != null) {
-                               if (block.Resolve (null, bc, parameters, this)) {
+                               if (block.Resolve (null, bc, this)) {
                                        EmitContext ec = new EmitContext (this, ConstructorBuilder.GetILGenerator (), bc.ReturnType);
                                        ec.With (EmitContext.Options.ConstructorScope, true);
 
@@ -1542,7 +1569,11 @@ namespace Mono.CSharp {
 
                        if (declarative_security != null) {
                                foreach (var de in declarative_security) {
+#if STATIC
+                                       ConstructorBuilder.__AddDeclarativeSecurity (de);
+#else
                                        ConstructorBuilder.AddDeclarativeSecurity (de.Key, de.Value);
+#endif
                                }
                        }
 
@@ -1741,14 +1772,13 @@ namespace Mono.CSharp {
                                                                Report.SymbolRelatedToPreviousError (implementing);
                                                                Report.Error (686, method.Location, "Accessor `{0}' cannot implement interface member `{1}' for type `{2}'. Use an explicit interface implementation",
                                                                        method.GetSignatureForError (), TypeManager.CSharpSignature (implementing), container.GetSignatureForError ());
-                                                               return false;
-                                                       }
-                                                       PropertyBase.PropertyMethod pm = prop_method as PropertyBase.PropertyMethod;
-                                                       if (pm != null && pm.HasCustomAccessModifier && (pm.ModFlags & Modifiers.PUBLIC) == 0) {
-                                                               Report.SymbolRelatedToPreviousError (implementing);
-                                                               Report.Error (277, method.Location, "Accessor `{0}' must be declared public to implement interface member `{1}'",
-                                                                       method.GetSignatureForError (), implementing.GetSignatureForError ());
-                                                               return false;
+                                                       } else {
+                                                               PropertyBase.PropertyMethod pm = prop_method as PropertyBase.PropertyMethod;
+                                                               if (pm != null && pm.HasCustomAccessModifier && (pm.ModFlags & Modifiers.PUBLIC) == 0) {
+                                                                       Report.SymbolRelatedToPreviousError (implementing);
+                                                                       Report.Error (277, method.Location, "Accessor `{0}' must be declared public to implement interface member `{1}'",
+                                                                               method.GetSignatureForError (), implementing.GetSignatureForError ());
+                                                               }
                                                        }
                                                }
                                        }
@@ -1772,7 +1802,6 @@ namespace Mono.CSharp {
                                                Report.SymbolRelatedToPreviousError (implementing);
                                                Report.Error (466, method.Location, "`{0}': the explicit interface implementation cannot introduce the params modifier",
                                                        method.GetSignatureForError ());
-                                               return false;
                                        }
                                } else {
                                        if (implementing.DeclaringType.IsInterface) {
@@ -1876,6 +1905,9 @@ namespace Mono.CSharp {
                        builder.SetParameters (p_types);
                        builder.SetReturnType (return_type);
                        if (builder.Attributes != flags) {
+#if STATIC
+                               builder.__SetAttributes (flags);
+#else
                                try {
                                        if (methodbuilder_attrs_field == null)
                                                methodbuilder_attrs_field = typeof (MethodBuilder).GetField ("attrs", BindingFlags.NonPublic | BindingFlags.Instance);
@@ -1883,6 +1915,7 @@ namespace Mono.CSharp {
                                } catch {
                                        container.Compiler.Report.RuntimeMissingSupport (method.Location, "Generic method MethodAttributes");
                                }
+#endif
                        }
                }
 
@@ -1894,14 +1927,16 @@ namespace Mono.CSharp {
                        if (GenericMethod != null)
                                GenericMethod.EmitAttributes ();
 
-                       method.ParameterInfo.ApplyAttributes (MethodBuilder);
+                       var mc = (IMemberContext) method;
+
+                       method.ParameterInfo.ApplyAttributes (mc, MethodBuilder);
 
                        SourceMethod source = SourceMethod.Create (parent, MethodBuilder, method.Block);
 
                        ToplevelBlock block = method.Block;
                        if (block != null) {
-                               BlockContext bc = new BlockContext ((IMemberContext) method, block, method.ReturnType);
-                               if (block.Resolve (null, bc, method.ParameterInfo, method)) {
+                               BlockContext bc = new BlockContext (mc, block, method.ReturnType);
+                               if (block.Resolve (null, bc, method)) {
                                        EmitContext ec = method.CreateEmitContext (MethodBuilder.GetILGenerator ());
                                        if (!ec.HasReturnLabel && bc.HasReturnLabel) {
                                                ec.ReturnLabel = bc.ReturnLabel;
@@ -1953,22 +1988,21 @@ namespace Mono.CSharp {
                        return true;
                }
 
-               public override void  Emit()
+               public override void Emit()
                {
                        var base_type = Parent.PartialContainer.BaseType;
                        if (base_type != null && Block != null) {
-                               MethodGroupExpr method_expr = Expression.MethodLookup (Parent.Module.Compiler, Parent.Definition, base_type, MemberKind.Destructor, MetadataName, 0, Location);
-                               if (method_expr == null)
-                                       throw new NotImplementedException ();
+                               var base_dtor = MemberCache.FindMember (base_type,
+                                       new MemberFilter (MetadataName, 0, MemberKind.Destructor, null, null), BindingRestriction.InstanceOnly) as MethodSpec;
 
-                               method_expr.QueriedBaseType = base_type;
-                               method_expr.InstanceExpression = new CompilerGeneratedThis (Parent.Definition, Location);
+                               if (base_dtor == null)
+                                       throw new NotImplementedException ();
 
-                               ToplevelBlock new_block = new ToplevelBlock (Compiler, Block.StartLocation);
-                               new_block.EndLocation = Block.EndLocation;
+                               MethodGroupExpr method_expr = MethodGroupExpr.CreatePredefined (base_dtor, base_type, Location);
+                               method_expr.InstanceExpression = new BaseThis (base_type, Location);
 
-                               Block finaly_block = new ExplicitBlock (new_block, Location, Location);
-                               Block try_block = new Block (new_block, block);
+                               var try_block = new ExplicitBlock (block, block.StartLocation, block.EndLocation);
+                               var finaly_block = new ExplicitBlock (block, Location, Location);
 
                                //
                                // 0-size arguments to avoid CS0250 error
@@ -1976,9 +2010,9 @@ namespace Mono.CSharp {
                                // debugger scope
                                //
                                finaly_block.AddStatement (new StatementExpression (new Invocation (method_expr, new Arguments (0))));
-                               new_block.AddStatement (new TryFinally (try_block, finaly_block, Location));
 
-                               block = new_block;
+                               var tf = new TryFinally (try_block, finaly_block, Location);
+                               block.WrapIntoDestructor (tf, try_block);
                        }
 
                        base.Emit ();
@@ -2007,31 +2041,16 @@ namespace Mono.CSharp {
        public abstract class AbstractPropertyEventMethod : MemberCore, IMethodData {
                protected MethodData method_data;
                protected ToplevelBlock block;
-               protected Dictionary<SecurityAction, PermissionSet> declarative_security;
-
-               // The accessor are created even if they are not wanted.
-               // But we need them because their names are reserved.
-               // Field says whether accessor will be emited or not
-               public readonly bool IsDummy;
+               protected SecurityType declarative_security;
 
                protected readonly string prefix;
 
                ReturnParameter return_attributes;
 
-               public AbstractPropertyEventMethod (PropertyBasedMember member, string prefix)
-                       : base (member.Parent, SetupName (prefix, member, member.Location), null)
-               {
-                       this.prefix = prefix;
-                       IsDummy = true;
-               }
-
-               public AbstractPropertyEventMethod (InterfaceMemberBase member, Accessor accessor,
-                                                   string prefix)
-                       : base (member.Parent, SetupName (prefix, member, accessor.Location),
-                               accessor.Attributes)
+               public AbstractPropertyEventMethod (InterfaceMemberBase member, string prefix, Attributes attrs, Location loc)
+                       : base (member.Parent, SetupName (prefix, member, loc), attrs)
                {
                        this.prefix = prefix;
-                       this.block = accessor.Block;
                }
 
                static MemberName SetupName (string prefix, InterfaceMemberBase member, Location loc)
@@ -2105,9 +2124,7 @@ namespace Mono.CSharp {
                        }
 
                        if (a.IsValidSecurityAttribute ()) {
-                               if (declarative_security == null)
-                                       declarative_security = new Dictionary<SecurityAction, PermissionSet> ();
-                               a.ExtractSecurityPermissionSet (declarative_security);
+                               a.ExtractSecurityPermissionSet (ctor, ref declarative_security);
                                return;
                        }
 
@@ -2143,23 +2160,16 @@ namespace Mono.CSharp {
                        method_data.Emit (parent);
 
                        if ((ModFlags & Modifiers.COMPILER_GENERATED) != 0 && !Parent.IsCompilerGenerated)
-                               PredefinedAttributes.Get.CompilerGenerated.EmitAttribute (method_data.MethodBuilder);
+                               Module.PredefinedAttributes.CompilerGenerated.EmitAttribute (method_data.MethodBuilder);
                        if (((ModFlags & Modifiers.DEBUGGER_HIDDEN) != 0))
-                               PredefinedAttributes.Get.DebuggerHidden.EmitAttribute (method_data.MethodBuilder);
+                               Module.PredefinedAttributes.DebuggerHidden.EmitAttribute (method_data.MethodBuilder);
 
                        if (ReturnType == InternalType.Dynamic) {
                                return_attributes = new ReturnParameter (this, method_data.MethodBuilder, Location);
-                               PredefinedAttributes.Get.Dynamic.EmitAttribute (return_attributes.Builder);
-                       } else {
-                               var trans_flags = TypeManager.HasDynamicTypeUsed (ReturnType);
-                               if (trans_flags != null) {
-                                       var pa = PredefinedAttributes.Get.DynamicTransform;
-                                       if (pa.Constructor != null || pa.ResolveConstructor (Location, ArrayContainer.MakeType (TypeManager.bool_type))) {
-                                               return_attributes = new ReturnParameter (this, method_data.MethodBuilder, Location);
-                                               return_attributes.Builder.SetCustomAttribute (
-                                                       new CustomAttributeBuilder (pa.Constructor, new object [] { trans_flags }));
-                                       }
-                               }
+                               Module.PredefinedAttributes.Dynamic.EmitAttribute (return_attributes.Builder);
+                       } else if (ReturnType.HasDynamicElement) {
+                               return_attributes = new ReturnParameter (this, method_data.MethodBuilder, Location);
+                               Module.PredefinedAttributes.Dynamic.EmitAttribute (return_attributes.Builder, ReturnType, Location);
                        }
 
                        if (OptAttributes != null)
@@ -2167,7 +2177,11 @@ namespace Mono.CSharp {
 
                        if (declarative_security != null) {
                                foreach (var de in declarative_security) {
+#if STATIC
+                                       method_data.MethodBuilder.__AddDeclarativeSecurity (de);
+#else
                                        method_data.MethodBuilder.AddDeclarativeSecurity (de.Key, de.Value);
+#endif
                                }
                        }
 
@@ -2176,15 +2190,16 @@ namespace Mono.CSharp {
 
                public override bool EnableOverloadChecks (MemberCore overload)
                {
+                       if (overload is MethodCore) {
+                               caching_flags |= Flags.MethodOverloadsExist;
+                               return true;
+                       }
+
                        // This can only happen with indexers and it will
                        // be catched as indexer difference
                        if (overload is AbstractPropertyEventMethod)
                                return true;
 
-                       if (overload is MethodCore) {
-                               caching_flags |= Flags.MethodOverloadsExist;
-                               return true;
-                       }
                        return false;
                }
 
@@ -2193,35 +2208,6 @@ namespace Mono.CSharp {
                        return false;
                }
 
-               public bool IsDuplicateImplementation (MethodCore method)
-               {
-                       if (!MemberName.Equals (method.MemberName))
-                               return false;
-
-                       TypeSpec[] param_types = method.ParameterTypes;
-
-                       if (param_types == null || param_types.Length != ParameterTypes.Length)
-                               return false;
-
-                       for (int i = 0; i < param_types.Length; i++)
-                               if (param_types [i] != ParameterTypes [i])
-                                       return false;
-
-                       Report.SymbolRelatedToPreviousError (method);
-                       Report.Error (82, Location, "A member `{0}' is already reserved",
-                               method.GetSignatureForError ());
-                       return true;
-               }
-
-               public override bool IsUsed {
-                       get {
-                               if (IsDummy)
-                                       return false;
-
-                               return base.IsUsed;
-                       }
-               }
-
                public MethodSpec Spec { get; protected set; }
 
                //
@@ -2349,7 +2335,7 @@ namespace Mono.CSharp {
                        if (!base.Define ())
                                return false;
 
-                       if (block != null && block.IsIterator && !(Parent is IteratorStorey)) {
+                       if (block != null && block.IsIterator) {
                                //
                                // Current method is turned into automatically generated
                                // wrapper which creates an instance of iterator
@@ -2376,57 +2362,52 @@ namespace Mono.CSharp {
                        if (TypeManager.IsNullableType (return_type))
                                return_type_unwrap = TypeManager.GetTypeArguments (return_type) [0];
 
-                       if (return_type == InternalType.Dynamic || first_arg_type == InternalType.Dynamic) {
-                               Report.Error (1964, Location,
-                                       "User-defined operator `{0}' cannot convert to or from the dynamic type",
-                                       GetSignatureForError ());
-
-                               return false;
-                       }
-
                        //
                        // Rules for conversion operators
                        //
                        if (OperatorType == OpType.Implicit || OperatorType == OpType.Explicit) {
-                               if (first_arg_type_unwrap == return_type_unwrap && first_arg_type_unwrap == declaring_type){
+                               if (first_arg_type_unwrap == return_type_unwrap && first_arg_type_unwrap == declaring_type) {
                                        Report.Error (555, Location,
                                                "User-defined operator cannot take an object of the enclosing type and convert to an object of the enclosing type");
                                        return false;
                                }
-                               
+
                                TypeSpec conv_type;
-                               if (TypeManager.IsEqual (declaring_type, return_type) || declaring_type == return_type_unwrap) {
+                               if (declaring_type == return_type || declaring_type == return_type_unwrap) {
                                        conv_type = first_arg_type;
-                               } else if (TypeManager.IsEqual (declaring_type, first_arg_type) || declaring_type == first_arg_type_unwrap) {
+                               } else if (declaring_type == first_arg_type || declaring_type == first_arg_type_unwrap) {
                                        conv_type = return_type;
                                } else {
-                                       Report.Error (556, Location, 
+                                       Report.Error (556, Location,
                                                "User-defined conversion must convert to or from the enclosing type");
                                        return false;
                                }
 
-                               //
-                               // Because IsInterface and IsClass are not supported
-                               //
-                               if (!TypeManager.IsGenericParameter (conv_type)) {
-                                       if (conv_type.IsInterface) {
-                                               Report.Error (552, Location, "User-defined conversion `{0}' cannot convert to or from an interface type",
+                               if (conv_type == InternalType.Dynamic) {
+                                       Report.Error (1964, Location,
+                                               "User-defined conversion `{0}' cannot convert to or from the dynamic type",
+                                               GetSignatureForError ());
+
+                                       return false;
+                               }
+
+                               if (conv_type.IsInterface) {
+                                       Report.Error (552, Location, "User-defined conversion `{0}' cannot convert to or from an interface type",
+                                               GetSignatureForError ());
+                                       return false;
+                               }
+
+                               if (conv_type.IsClass) {
+                                       if (TypeSpec.IsBaseClass (declaring_type, conv_type, true)) {
+                                               Report.Error (553, Location, "User-defined conversion `{0}' cannot convert to or from a base class",
                                                        GetSignatureForError ());
                                                return false;
                                        }
 
-                                       if (conv_type.IsClass) {
-                                               if (TypeManager.IsSubclassOf (declaring_type, conv_type)) {
-                                                       Report.Error (553, Location, "User-defined conversion `{0}' cannot convert to or from a base class",
-                                                               GetSignatureForError ());
-                                                       return false;
-                                               }
-
-                                               if (TypeManager.IsSubclassOf (conv_type, declaring_type)) {
-                                                       Report.Error (554, Location, "User-defined conversion `{0}' cannot convert to or from a derived class",
-                                                               GetSignatureForError ());
-                                                       return false;
-                                               }
+                                       if (TypeSpec.IsBaseClass (conv_type, declaring_type, false)) {
+                                               Report.Error (554, Location, "User-defined conversion `{0}' cannot convert to or from a derived class",
+                                                       GetSignatureForError ());
+                                               return false;
                                        }
                                }
                        } else if (OperatorType == OpType.LeftShift || OperatorType == OpType.RightShift) {
@@ -2438,7 +2419,7 @@ namespace Mono.CSharp {
                                // Checks for Unary operators
 
                                if (OperatorType == OpType.Increment || OperatorType == OpType.Decrement) {
-                                       if (return_type != declaring_type && !TypeManager.IsSubclassOf (return_type, declaring_type)) {
+                                       if (return_type != declaring_type && !TypeSpec.IsBaseClass (return_type, declaring_type, false)) {
                                                Report.Error (448, Location,
                                                        "The return type for ++ or -- operator must be the containing type or derived from the containing type");
                                                return false;
@@ -2449,15 +2430,15 @@ namespace Mono.CSharp {
                                                return false;
                                        }
                                }
-                               
-                               if (!TypeManager.IsEqual (first_arg_type_unwrap, declaring_type)){
+
+                               if (first_arg_type_unwrap != declaring_type) {
                                        Report.Error (562, Location,
                                                "The parameter type of a unary operator must be the containing type");
                                        return false;
                                }
-                               
+
                                if (OperatorType == OpType.True || OperatorType == OpType.False) {
-                                       if (return_type != TypeManager.bool_type){
+                                       if (return_type != TypeManager.bool_type) {
                                                Report.Error (
                                                        215, Location,
                                                        "The return type of operator True or False " +
@@ -2465,15 +2446,15 @@ namespace Mono.CSharp {
                                                return false;
                                        }
                                }
-                               
-                       } else if (!TypeManager.IsEqual (first_arg_type_unwrap, declaring_type)) {
+
+                       } else if (first_arg_type_unwrap != declaring_type) {
                                // Checks for Binary operators
 
-                               var second_arg_type = ParameterTypes [1];
+                               var second_arg_type = ParameterTypes[1];
                                if (TypeManager.IsNullableType (second_arg_type))
-                                       second_arg_type = TypeManager.GetTypeArguments (second_arg_type) [0];
+                                       second_arg_type = TypeManager.GetTypeArguments (second_arg_type)[0];
 
-                               if (!TypeManager.IsEqual (second_arg_type, declaring_type)) {
+                               if (second_arg_type != declaring_type) {
                                        Report.Error (563, Location,
                                                "One of the parameters of a binary operator must be the containing type");
                                        return false;