[mcs] Reachability and flow analysis rewrite to work on resolved statements and expre...
[mono.git] / mcs / mcs / iterators.cs
index 5d6e4d294269e05eed758e40a2c930e5eec040f1..4f2a3429713c45db806d83c5520e8cc2c76e183e 100644 (file)
@@ -8,14 +8,12 @@
 // Dual licensed under the terms of the MIT X11 or GNU GPL
 // Copyright 2003 Ximian, Inc.
 // Copyright 2003-2008 Novell, Inc.
-//
-
-// TODO:
-//    Flow analysis for Yield.
+// Copyright 2011 Xamarin Inc.
 //
 
 using System;
 using System.Collections.Generic;
+using Mono.CompilerServices.SymbolWriter;
 
 #if STATIC
 using IKVM.Reflection.Emit;
@@ -23,65 +21,121 @@ using IKVM.Reflection.Emit;
 using System.Reflection.Emit;
 #endif
 
-namespace Mono.CSharp {
-
-       public class Yield : ResumableStatement {
-               Expression expr;
-               bool unwind_protect;
-               Iterator iterator;
+namespace Mono.CSharp
+{
+       public abstract class YieldStatement<T> : ResumableStatement where T : StateMachineInitializer
+       {
+               protected Expression expr;
+               protected bool unwind_protect;
+               protected T machine_initializer;
                int resume_pc;
+               ExceptionStatement inside_try_block;
 
-               public Yield (Expression expr, Location l)
+               protected YieldStatement (Expression expr, Location l)
                {
                        this.expr = expr;
                        loc = l;
                }
 
-               public static bool CheckContext (ResolveContext ec, Location loc)
+               public Expression Expr {
+                       get { return this.expr; }
+               }
+               
+               protected override void CloneTo (CloneContext clonectx, Statement t)
+               {
+                       var target = (YieldStatement<T>) t;
+                       target.expr = expr.Clone (clonectx);
+               }
+
+               protected override void DoEmit (EmitContext ec)
+               {
+                       machine_initializer.InjectYield (ec, expr, resume_pc, unwind_protect, resume_point);
+               }
+
+               protected override bool DoFlowAnalysis (FlowAnalysisContext fc)
+               {
+                       expr.FlowAnalysis (fc);
+
+                       RegisterResumePoint ();
+
+                       return false;
+               }
+
+               public override bool Resolve (BlockContext bc)
+               {
+                       expr = expr.Resolve (bc);
+                       if (expr == null)
+                               return false;
+
+                       machine_initializer = bc.CurrentAnonymousMethod as T;
+                       inside_try_block = bc.CurrentTryBlock;
+                       return true;
+               }
+
+               public void RegisterResumePoint ()
+               {
+                       if (inside_try_block == null) {
+                               resume_pc = machine_initializer.AddResumePoint (this);
+                       } else {
+                               resume_pc = inside_try_block.AddResumePoint (this, resume_pc, machine_initializer);
+                               unwind_protect = true;
+                               inside_try_block = null;
+                       }
+               }
+       }
+
+       public class Yield : YieldStatement<Iterator>
+       {
+               public Yield (Expression expr, Location loc)
+                       : base (expr, loc)
+               {
+               }
+
+               public static bool CheckContext (BlockContext bc, Location loc)
                {
-                       if (!ec.CurrentAnonymousMethod.IsIterator) {
-                               ec.Report.Error (1621, loc,
-                                             "The yield statement cannot be used inside " +
-                                             "anonymous method blocks");
+                       if (!bc.CurrentAnonymousMethod.IsIterator) {
+                               bc.Report.Error (1621, loc,
+                                       "The yield statement cannot be used inside anonymous method blocks");
+                               return false;
+                       }
+
+                       if (bc.HasSet (ResolveContext.Options.FinallyScope)) {
+                               bc.Report.Error (1625, loc, "Cannot yield in the body of a finally clause");
                                return false;
                        }
 
                        return true;
                }
 
-               public override bool Resolve (BlockContext ec)
+               public override bool Resolve (BlockContext bc)
                {
-                       expr = expr.Resolve (ec);
-                       if (expr == null)
+                       if (!CheckContext (bc, loc))
                                return false;
 
-                       if (!CheckContext (ec, loc))
+                       if (bc.HasAny (ResolveContext.Options.TryWithCatchScope)) {
+                               bc.Report.Error (1626, loc, "Cannot yield a value in the body of a try block with a catch clause");
+                       }
+
+                       if (bc.HasSet (ResolveContext.Options.CatchScope)) {
+                               bc.Report.Error (1631, loc, "Cannot yield a value in the body of a catch clause");
+                       }
+
+                       if (!base.Resolve (bc))
                                return false;
 
-                       iterator = ec.CurrentIterator;
-                       if (expr.Type != iterator.OriginalIteratorType) {
-                               expr = Convert.ImplicitConversionRequired (
-                                       ec, expr, iterator.OriginalIteratorType, loc);
+                       var otype = bc.CurrentIterator.OriginalIteratorType;
+                       if (expr.Type != otype) {
+                               expr = Convert.ImplicitConversionRequired (bc, expr, otype, loc);
                                if (expr == null)
                                        return false;
                        }
 
-                       if (!ec.CurrentBranching.CurrentUsageVector.IsUnreachable)
-                               unwind_protect = ec.CurrentBranching.AddResumePoint (this, loc, out resume_pc);
-
                        return true;
                }
-
-               protected override void DoEmit (EmitContext ec)
-               {
-                       iterator.MarkYield (ec, expr, resume_pc, unwind_protect, resume_point);
-               }
-
-               protected override void CloneTo (CloneContext clonectx, Statement t)
+               
+               public override object Accept (StructuralVisitor visitor)
                {
-                       Yield target = (Yield) t;
-
-                       target.expr = expr.Clone (clonectx);
+                       return visitor.Visit (this);
                }
        }
 
@@ -94,9 +148,10 @@ namespace Mono.CSharp {
                        loc = l;
                }
 
-               public override void Error_FinallyClause (Report Report)
-               {
-                       Report.Error (1625, loc, "Cannot yield in the body of a finally clause");
+               protected override bool IsLocalExit {
+                       get {
+                               return false;
+                       }
                }
 
                protected override void CloneTo (CloneContext clonectx, Statement target)
@@ -104,30 +159,106 @@ namespace Mono.CSharp {
                        throw new NotSupportedException ();
                }
 
-               protected override bool DoResolve (BlockContext ec)
+               protected override bool DoResolve (BlockContext bc)
                {
-                       iterator = ec.CurrentIterator;
-                       return Yield.CheckContext (ec, loc);
+                       iterator = bc.CurrentIterator;
+                       return Yield.CheckContext (bc, loc);
                }
 
                protected override void DoEmit (EmitContext ec)
                {
                        iterator.EmitYieldBreak (ec, unwind_protect);
                }
+
+               protected override bool DoFlowAnalysis (FlowAnalysisContext fc)
+               {
+                       return true;
+               }
+
+               public override Reachability MarkReachable (Reachability rc)
+               {
+                       base.MarkReachable (rc);
+                       return Reachability.CreateUnreachable ();
+               }
+               
+               public override object Accept (StructuralVisitor visitor)
+               {
+                       return visitor.Visit (this);
+               }
        }
 
-       public class IteratorStorey : AnonymousMethodStorey
+       public abstract class StateMachine : AnonymousMethodStorey
        {
-               class GetEnumeratorMethod : IteratorMethod
+               public enum State
+               {
+                       Running = -3, // Used only in CurrentPC, never stored into $PC
+                       Uninitialized = -2,
+                       After = -1,
+                       Start = 0
+               }
+
+               Field pc_field;
+               StateMachineMethod method;
+               int local_name_idx;
+
+               protected StateMachine (ParametersBlock block, TypeDefinition parent, MemberBase host, TypeParameters tparams, string name, MemberKind kind)
+                       : base (block, parent, host, tparams, name, kind)
+               {
+               }
+
+               #region Properties
+
+               public StateMachineMethod StateMachineMethod {
+                       get {
+                               return method;
+                       }
+               }
+
+               public Field PC {
+                       get {
+                               return pc_field;
+                       }
+               }
+
+               #endregion
+
+               public void AddEntryMethod (StateMachineMethod method)
+               {
+                       if (this.method != null)
+                               throw new InternalErrorException ();
+
+                       this.method = method;
+                       Members.Add (method);
+               }
+
+               protected override bool DoDefineMembers ()
+               {
+                       pc_field = AddCompilerGeneratedField ("$PC", new TypeExpression (Compiler.BuiltinTypes.Int, Location));
+
+                       return base.DoDefineMembers ();
+               }
+
+               protected override string GetVariableMangledName (LocalVariable local_info)
+               {
+                       if (local_info.IsCompilerGenerated)
+                               return base.GetVariableMangledName (local_info);
+
+                       return "<" + local_info.Name + ">__" + local_name_idx++.ToString ("X");
+               }
+       }
+
+       class IteratorStorey : StateMachine
+       {
+               class GetEnumeratorMethod : StateMachineMethod
                {
                        sealed class GetEnumeratorStatement : Statement
                        {
-                               IteratorStorey host;
-                               IteratorMethod host_method;
+                               readonly IteratorStorey host;
+                               readonly StateMachineMethod host_method;
 
                                Expression new_storey;
 
-                               public GetEnumeratorStatement (IteratorStorey host, IteratorMethod host_method)
+                               public GetEnumeratorStatement (IteratorStorey host, StateMachineMethod host_method)
                                {
                                        this.host = host;
                                        this.host_method = host_method;
@@ -156,8 +287,8 @@ namespace Mono.CSharp {
                                                        init = new List<Expression> (host.HoistedParameters.Count);
 
                                                for (int i = 0; i < host.hoisted_params.Count; ++i) {
-                                                       HoistedParameter hp = (HoistedParameter) host.hoisted_params [i];
-                                                       HoistedParameter hp_cp = (HoistedParameter) host.hoisted_params_copy [i];
+                                                       HoistedParameter hp = host.hoisted_params [i];
+                                                       HoistedParameter hp_cp = host.hoisted_params_copy [i] ?? hp;
 
                                                        FieldExpr from = new FieldExpr (hp_cp.Field, loc);
                                                        from.InstanceExpression = new CompilerGeneratedThis (ec.CurrentType, loc);
@@ -177,7 +308,6 @@ namespace Mono.CSharp {
                                        if (new_storey != null)
                                                new_storey = Convert.ImplicitConversionRequired (ec, new_storey, host_method.MemberType, loc);
 
-                                       ec.CurrentBranching.CurrentUsageVector.Goto ();
                                        return true;
                                }
 
@@ -185,19 +315,19 @@ namespace Mono.CSharp {
                                {
                                        Label label_init = ec.DefineLabel ();
 
-                                       ec.Emit (OpCodes.Ldarg_0);
+                                       ec.EmitThis ();
                                        ec.Emit (OpCodes.Ldflda, host.PC.Spec);
-                                       ec.EmitInt ((int) Iterator.State.Start);
-                                       ec.EmitInt ((int) Iterator.State.Uninitialized);
+                                       ec.EmitInt ((int) State.Start);
+                                       ec.EmitInt ((int) State.Uninitialized);
 
                                        var m = ec.Module.PredefinedMembers.InterlockedCompareExchange.Resolve (loc);
                                        if (m != null)
                                                ec.Emit (OpCodes.Call, m);
 
-                                       ec.EmitInt ((int) Iterator.State.Uninitialized);
+                                       ec.EmitInt ((int) State.Uninitialized);
                                        ec.Emit (OpCodes.Bne_Un_S, label_init);
 
-                                       ec.Emit (OpCodes.Ldarg_0);
+                                       ec.EmitThis ();
                                        ec.Emit (OpCodes.Ret);
 
                                        ec.MarkLabel (label_init);
@@ -205,16 +335,39 @@ namespace Mono.CSharp {
                                        new_storey.Emit (ec);
                                        ec.Emit (OpCodes.Ret);
                                }
+
+                               protected override bool DoFlowAnalysis (FlowAnalysisContext fc)
+                               {
+                                       throw new NotImplementedException ();
+                               }
+
+                               public override Reachability MarkReachable (Reachability rc)
+                               {
+                                       base.MarkReachable (rc);
+                                       return Reachability.CreateUnreachable ();
+                               }
+                       }
+
+                       GetEnumeratorMethod (IteratorStorey host, FullNamedExpression returnType, MemberName name)
+                               : base (host, null, returnType, Modifiers.DEBUGGER_HIDDEN, name, ToplevelBlock.Flags.CompilerGenerated | ToplevelBlock.Flags.NoFlowAnalysis)
+                       {
+                       }
+
+                       public static GetEnumeratorMethod Create (IteratorStorey host, FullNamedExpression returnType, MemberName name)
+                       {
+                               return Create (host, returnType, name, null);
                        }
 
-                       public GetEnumeratorMethod (IteratorStorey host, FullNamedExpression returnType, MemberName name)
-                               : base (host, returnType, Modifiers.DEBUGGER_HIDDEN, name)
+                       public static GetEnumeratorMethod Create (IteratorStorey host, FullNamedExpression returnType, MemberName name, Statement statement)
                        {
-                               Block.AddStatement (new GetEnumeratorStatement (host, this));
+                               var m = new GetEnumeratorMethod (host, returnType, name);
+                               var stmt = statement ?? new GetEnumeratorStatement (host, m);
+                               m.block.AddStatement (stmt);
+                               return m;
                        }
                }
 
-               class DisposeMethod : IteratorMethod
+               class DisposeMethod : StateMachineMethod
                {
                        sealed class DisposeMethodStatement : Statement
                        {
@@ -238,15 +391,21 @@ namespace Mono.CSharp {
 
                                protected override void DoEmit (EmitContext ec)
                                {
+                                       ec.CurrentAnonymousMethod = iterator;
                                        iterator.EmitDispose (ec);
                                }
+
+                               protected override bool DoFlowAnalysis (FlowAnalysisContext fc)
+                               {
+                                       throw new NotImplementedException ();
+                               }
                        }
 
                        public DisposeMethod (IteratorStorey host)
-                               : base (host, new TypeExpression (host.Compiler.BuiltinTypes.Void, host.Location), Modifiers.PUBLIC | Modifiers.DEBUGGER_HIDDEN,
-                                       new MemberName ("Dispose", host.Location))
+                               : base (host, null, new TypeExpression (host.Compiler.BuiltinTypes.Void, host.Location), Modifiers.PUBLIC | Modifiers.DEBUGGER_HIDDEN,
+                                       new MemberName ("Dispose", host.Location), ToplevelBlock.Flags.CompilerGenerated | ToplevelBlock.Flags.NoFlowAnalysis)
                        {
-                               host.AddMethod (this);
+                               host.Members.Add (this);
 
                                Block.AddStatement (new DisposeMethodStatement (host.Iterator));
                        }
@@ -296,30 +455,25 @@ namespace Mono.CSharp {
 
                public readonly Iterator Iterator;
 
+               List<HoistedParameter> hoisted_params_copy;
+
                TypeExpr iterator_type_expr;
-               Field pc_field;
                Field current_field;
                Field disposing_field;
 
-               TypeExpr enumerator_type;
-               TypeExpr enumerable_type;
-               TypeArguments generic_args;
-               TypeExpr generic_enumerator_type;
-               TypeExpr generic_enumerable_type;
-
-               List<HoistedParameter> hoisted_params_copy;
-               int local_name_idx;
+               TypeSpec generic_enumerator_type;
+               TypeSpec generic_enumerable_type;
 
                public IteratorStorey (Iterator iterator)
                        : base (iterator.Container.ParametersBlock, iterator.Host,
-                         iterator.OriginalMethod as MemberBase, iterator.GenericMethod == null ? null : iterator.GenericMethod.CurrentTypeParameters, "Iterator")
+                         iterator.OriginalMethod as MemberBase, iterator.OriginalMethod.CurrentTypeParameters, "Iterator", MemberKind.Class)
                {
                        this.Iterator = iterator;
                }
 
-               public Field PC {
+               public Field CurrentField {
                        get {
-                               return pc_field;
+                               return current_field;
                        }
                }
 
@@ -329,14 +483,17 @@ namespace Mono.CSharp {
                        }
                }
 
-               public Field CurrentField {
-                       get { return current_field; }
-               }
-
                public IList<HoistedParameter> HoistedParameters {
                        get { return hoisted_params; }
                }
 
+               protected override Constructor DefineDefaultConstructor (bool is_static)
+               {
+                       var ctor = base.DefineDefaultConstructor (is_static);
+                       ctor.ModFlags |= Modifiers.DEBUGGER_HIDDEN;
+                       return ctor;
+               }
+
                protected override TypeSpec[] ResolveBaseTypes (out FullNamedExpression base_class)
                {
                        var mtype = Iterator.OriginalIteratorType;
@@ -344,63 +501,57 @@ namespace Mono.CSharp {
                                mtype = Mutator.Mutate (mtype);
 
                        iterator_type_expr = new TypeExpression (mtype, Location);
-                       generic_args = new TypeArguments (iterator_type_expr);
 
-                       var list = new List<FullNamedExpression> ();
+                       var ifaces = new List<TypeSpec> (5);
                        if (Iterator.IsEnumerable) {
-                               enumerable_type = new TypeExpression (Compiler.BuiltinTypes.IEnumerable, Location);
-                               list.Add (enumerable_type);
+                               ifaces.Add (Compiler.BuiltinTypes.IEnumerable);
 
                                if (Module.PredefinedTypes.IEnumerableGeneric.Define ()) {
-                                       generic_enumerable_type = new GenericTypeExpr (Module.PredefinedTypes.IEnumerableGeneric.TypeSpec, generic_args, Location);
-                                       list.Add (generic_enumerable_type);
+                                       generic_enumerable_type = Module.PredefinedTypes.IEnumerableGeneric.TypeSpec.MakeGenericType (Module, new[] { mtype });
+                                       ifaces.Add (generic_enumerable_type);
                                }
                        }
 
-                       enumerator_type = new TypeExpression (Compiler.BuiltinTypes.IEnumerator, Location);
-                       list.Add (enumerator_type);
-
-                       list.Add (new TypeExpression (Compiler.BuiltinTypes.IDisposable, Location));
+                       ifaces.Add (Compiler.BuiltinTypes.IEnumerator);
+                       ifaces.Add (Compiler.BuiltinTypes.IDisposable);
 
                        var ienumerator_generic = Module.PredefinedTypes.IEnumeratorGeneric;
                        if (ienumerator_generic.Define ()) {
-                               generic_enumerator_type = new GenericTypeExpr (ienumerator_generic.TypeSpec, generic_args, Location);
-                               list.Add (generic_enumerator_type);
+                               generic_enumerator_type = ienumerator_generic.TypeSpec.MakeGenericType (Module, new [] { mtype });
+                               ifaces.Add (generic_enumerator_type);
                        }
 
-                       type_bases = list;
-
-                       return base.ResolveBaseTypes (out base_class);
-               }
+                       base_class = null;
 
-               protected override string GetVariableMangledName (LocalVariable local_info)
-               {
-                       return "<" + local_info.Name + ">__" + local_name_idx++.ToString ();
+                       base_type = Compiler.BuiltinTypes.Object;
+                       return ifaces.ToArray ();
                }
 
                protected override bool DoDefineMembers ()
                {
-                       DefineIteratorMembers ();
-                       return base.DoDefineMembers ();
-               }
-
-               void DefineIteratorMembers ()
-               {
-                       pc_field = AddCompilerGeneratedField ("$PC", new TypeExpression (Compiler.BuiltinTypes.Int, Location));
                        current_field = AddCompilerGeneratedField ("$current", iterator_type_expr);
                        disposing_field = AddCompilerGeneratedField ("$disposing", new TypeExpression (Compiler.BuiltinTypes.Bool, Location));
 
-                       if (hoisted_params != null) {
+                       if (Iterator.IsEnumerable && hoisted_params != null) {
                                //
                                // Iterators are independent, each GetEnumerator call has to
                                // create same enumerator therefore we have to keep original values
                                // around for re-initialization
                                //
-                               // TODO: Do it for assigned/modified parameters only
-                               //
                                hoisted_params_copy = new List<HoistedParameter> (hoisted_params.Count);
                                foreach (HoistedParameter hp in hoisted_params) {
-                                       hoisted_params_copy.Add (new HoistedParameter (hp, "<$>" + hp.Field.Name));
+
+                                       //
+                                       // Don't create field copy for unmodified captured parameters
+                                       //
+                                       HoistedParameter hp_copy;
+                                       if (hp.IsAssigned) {
+                                               hp_copy = new HoistedParameter (hp, "<$>" + hp.Field.Name);
+                                       } else {
+                                               hp_copy = null;
+                                       }
+
+                                       hoisted_params_copy.Add (hp_copy);
                                }
                        }
 
@@ -412,77 +563,67 @@ namespace Mono.CSharp {
                        Define_Reset ();
 
                        if (Iterator.IsEnumerable) {
-                               MemberName name = new MemberName (QualifiedAliasMember.GlobalAlias, "System", null, Location);
-                               name = new MemberName (name, "Collections", Location);
-                               name = new MemberName (name, "IEnumerable", Location);
-                               name = new MemberName (name, "GetEnumerator", Location);
+                               FullNamedExpression explicit_iface = new TypeExpression (Compiler.BuiltinTypes.IEnumerable, Location);
+                               var name = new MemberName ("GetEnumerator", null, explicit_iface, Location.Null);
 
                                if (generic_enumerator_type != null) {
-                                       Method get_enumerator = new IteratorMethod (this, enumerator_type, 0, name);
-
-                                       name = new MemberName (name.Left.Left, "Generic", Location);
-                                       name = new MemberName (name, "IEnumerable", generic_args, Location);
-                                       name = new MemberName (name, "GetEnumerator", Location);
-                                       Method gget_enumerator = new GetEnumeratorMethod (this, generic_enumerator_type, name);
+                                       explicit_iface = new TypeExpression (generic_enumerable_type, Location);
+                                       var gname = new MemberName ("GetEnumerator", null, explicit_iface, Location.Null);
+                                       Method gget_enumerator = GetEnumeratorMethod.Create (this, new TypeExpression (generic_enumerator_type, Location), gname);
 
                                        //
                                        // Just call generic GetEnumerator implementation
                                        //
-                                       get_enumerator.Block.AddStatement (
-                                               new Return (new Invocation (new DynamicMethodGroupExpr (gget_enumerator, Location), null), Location));
+                                       var stmt = new Return (new Invocation (new DynamicMethodGroupExpr (gget_enumerator, Location), null), Location);
+                                       Method get_enumerator = GetEnumeratorMethod.Create (this, new TypeExpression (Compiler.BuiltinTypes.IEnumerator, Location), name, stmt);
 
-                                       AddMethod (get_enumerator);
-                                       AddMethod (gget_enumerator);
+                                       Members.Add (get_enumerator);
+                                       Members.Add (gget_enumerator);
                                } else {
-                                       AddMethod (new GetEnumeratorMethod (this, enumerator_type, name));
+                                       Members.Add (GetEnumeratorMethod.Create (this, new TypeExpression (Compiler.BuiltinTypes.IEnumerator, Location), name));
                                }
                        }
-               }
 
-               protected override void EmitHoistedParameters (EmitContext ec, IList<HoistedParameter> hoisted)
-               {
-                       base.EmitHoistedParameters (ec, hoisted);
-                       base.EmitHoistedParameters (ec, hoisted_params_copy);
+                       return base.DoDefineMembers ();
                }
 
                void Define_Current (bool is_generic)
                {
                        TypeExpr type;
-
-                       MemberName name = new MemberName (QualifiedAliasMember.GlobalAlias, "System", null, Location);
-                       name = new MemberName (name, "Collections", Location);
+                       FullNamedExpression explicit_iface;
 
                        if (is_generic) {
-                               name = new MemberName (name, "Generic", Location);
-                               name = new MemberName (name, "IEnumerator", generic_args, Location);
+                               explicit_iface = new TypeExpression (generic_enumerator_type, Location);
                                type = iterator_type_expr;
                        } else {
-                               name = new MemberName (name, "IEnumerator");
+                               explicit_iface = new TypeExpression (Module.Compiler.BuiltinTypes.IEnumerator, Location);
                                type = new TypeExpression (Compiler.BuiltinTypes.Object, Location);
                        }
 
-                       name = new MemberName (name, "Current", Location);
+                       var name = new MemberName ("Current", null, explicit_iface, Location);
 
-                       ToplevelBlock get_block = new ToplevelBlock (Compiler, Location);
+                       ToplevelBlock get_block = new ToplevelBlock (Compiler, ParametersCompiled.EmptyReadOnlyParameters, Location,
+                               Block.Flags.CompilerGenerated | Block.Flags.NoFlowAnalysis);
                        get_block.AddStatement (new Return (new DynamicFieldExpr (CurrentField, Location), Location));
                                
-                       Property current = new Property (this, type, Modifiers.DEBUGGER_HIDDEN, name, null);
-                       current.Get = new Property.GetMethod (current, 0, null, Location);
+                       Property current = new Property (this, type, Modifiers.DEBUGGER_HIDDEN | Modifiers.COMPILER_GENERATED, name, null);
+                       current.Get = new Property.GetMethod (current, Modifiers.COMPILER_GENERATED, null, Location);
                        current.Get.Block = get_block;
 
-                       AddProperty (current);
+                       Members.Add (current);
                }
 
                void Define_Reset ()
                {
                        Method reset = new Method (
-                               this, null, new TypeExpression (Compiler.BuiltinTypes.Void, Location),
-                               Modifiers.PUBLIC | Modifiers.DEBUGGER_HIDDEN,
+                               this, new TypeExpression (Compiler.BuiltinTypes.Void, Location),
+                               Modifiers.PUBLIC | Modifiers.DEBUGGER_HIDDEN | Modifiers.COMPILER_GENERATED,
                                new MemberName ("Reset", Location),
                                ParametersCompiled.EmptyReadOnlyParameters, null);
-                       AddMethod (reset);
+                       Members.Add (reset);
 
-                       reset.Block = new ToplevelBlock (Compiler, Location);
+                       reset.Block = new ToplevelBlock (Compiler, reset.ParameterInfo, Location,
+                               Block.Flags.CompilerGenerated | Block.Flags.NoFlowAnalysis);
 
                        TypeSpec ex_type = Module.PredefinedTypes.NotSupportedException.Resolve ();
                        if (ex_type == null)
@@ -490,43 +631,50 @@ namespace Mono.CSharp {
 
                        reset.Block.AddStatement (new Throw (new New (new TypeExpression (ex_type, Location), null, Location), Location));
                }
+
+               protected override void EmitHoistedParameters (EmitContext ec, List<HoistedParameter> hoisted)
+               {
+                       base.EmitHoistedParameters (ec, hoisted);
+                       if (hoisted_params_copy != null)
+                               base.EmitHoistedParameters (ec, hoisted_params_copy);
+               }
        }
 
-       class IteratorMethod : Method
+       public class StateMachineMethod : Method
        {
-               readonly IteratorStorey host;
+               readonly StateMachineInitializer expr;
 
-               public IteratorMethod (IteratorStorey host, FullNamedExpression returnType, Modifiers mod, MemberName name)
-                       : base (host, null, returnType, mod | Modifiers.COMPILER_GENERATED,
+               public StateMachineMethod (StateMachine host, StateMachineInitializer expr, FullNamedExpression returnType,
+                       Modifiers mod, MemberName name, ToplevelBlock.Flags blockFlags)
+                       : base (host, returnType, mod | Modifiers.COMPILER_GENERATED,
                          name, ParametersCompiled.EmptyReadOnlyParameters, null)
                {
-                       this.host = host;
-
-                       Block = new ToplevelBlock (host.Compiler, ParametersCompiled.EmptyReadOnlyParameters, Location);
+                       this.expr = expr;
+                       Block = new ToplevelBlock (host.Compiler, ParametersCompiled.EmptyReadOnlyParameters, Location.Null, blockFlags);
                }
 
-               public override EmitContext CreateEmitContext (ILGenerator ig)
+               public override EmitContext CreateEmitContext (ILGenerator ig, SourceMethodBuilder sourceMethod)
                {
-                       EmitContext ec = new EmitContext (this, ig, MemberType);
+                       EmitContext ec = new EmitContext (this, ig, MemberType, sourceMethod);
+                       ec.CurrentAnonymousMethod = expr;
+
+                       if (expr is AsyncInitializer)
+                               ec.With (BuilderContext.Options.AsyncBody, true);
 
-                       ec.CurrentAnonymousMethod = host.Iterator;
                        return ec;
                }
        }
 
-       //
-       // Iterators are implemented as hidden anonymous block
-       //
-       public class Iterator : AnonymousExpression
+       public abstract class StateMachineInitializer : AnonymousExpression
        {
-               sealed class MoveNextMethodStatement : Statement
+               sealed class MoveNextBodyStatement : Statement
                {
-                       Iterator iterator;
+                       readonly StateMachineInitializer state_machine;
 
-                       public MoveNextMethodStatement (Iterator iterator)
+                       public MoveNextBodyStatement (StateMachineInitializer stateMachine)
                        {
-                               this.iterator = iterator;
-                               this.loc = iterator.Location;
+                               this.state_machine = stateMachine;
+                               this.loc = stateMachine.Location;
                        }
 
                        protected override void CloneTo (CloneContext clonectx, Statement target)
@@ -541,72 +689,156 @@ namespace Mono.CSharp {
 
                        protected override void DoEmit (EmitContext ec)
                        {
-                               iterator.EmitMoveNext (ec);
+                               state_machine.EmitMoveNext (ec);
+                       }
+
+                       public override void Emit (EmitContext ec)
+                       {
+                               // Don't create sequence point
+                               DoEmit (ec);
+                       }
+
+                       protected override bool DoFlowAnalysis (FlowAnalysisContext fc)
+                       {
+                               return state_machine.ReturnType.Kind != MemberKind.Void;
+                       }
+
+                       public override Reachability MarkReachable (Reachability rc)
+                       {
+                               base.MarkReachable (rc);
+
+                               if (state_machine.ReturnType.Kind != MemberKind.Void)
+                                       rc = Reachability.CreateUnreachable ();
+
+                               return rc;
                        }
                }
 
-               public readonly IMethodData OriginalMethod;
-               public readonly TypeContainer Host;
-               public readonly bool IsEnumerable;
-               List<ResumableStatement> resume_points;
+               public readonly TypeDefinition Host;
+               protected StateMachine storey;
 
                //
-               // The state as we generate the iterator
+               // The state as we generate the machine
                //
-               Label move_next_ok, move_next_error;
-               LocalBuilder skip_finally, current_pc;
+               Label move_next_ok;
+               Label iterator_body_end;
+               protected Label move_next_error;
+               LocalBuilder skip_finally;
+               protected LocalBuilder current_pc;
+               protected List<ResumableStatement> resume_points;
+
+               protected StateMachineInitializer (ParametersBlock block, TypeDefinition host, TypeSpec returnType)
+                       : base (block, returnType, block.StartLocation)
+               {
+                       this.Host = host;
+               }
+
+               #region Properties
+
+               public Label BodyEnd {
+                       get {
+                               return iterator_body_end;
+                       }
+               }
+
+               public LocalBuilder CurrentPC
+               {
+                       get {
+                               return current_pc;
+                       }
+               }
 
                public LocalBuilder SkipFinally {
-                       get { return skip_finally; }
+                       get {
+                               return skip_finally;
+                       }
                }
 
-               public LocalBuilder CurrentPC {
-                       get { return current_pc; }
+               public override AnonymousMethodStorey Storey {
+                       get {
+                               return storey;
+                       }
                }
 
-               public Block Container {
-                       get { return OriginalMethod.Block; }
+               #endregion
+
+               public int AddResumePoint (ResumableStatement stmt)
+               {
+                       if (resume_points == null)
+                               resume_points = new List<ResumableStatement> ();
+
+                       resume_points.Add (stmt);
+                       return resume_points.Count;
                }
 
-               public GenericMethod GenericMethod {
-                       get { return OriginalMethod.GenericMethod; }
+               public override Expression CreateExpressionTree (ResolveContext ec)
+               {
+                       throw new NotSupportedException ("ET");
                }
 
-               public readonly TypeSpec OriginalIteratorType;
+               protected virtual BlockContext CreateBlockContext (BlockContext bc)
+               {
+                       var ctx = new BlockContext (bc, block, bc.ReturnType);
+                       ctx.CurrentAnonymousMethod = this;
 
-               IteratorStorey IteratorHost;
+                       ctx.AssignmentInfoOffset = bc.AssignmentInfoOffset;
+                       ctx.EnclosingLoop = bc.EnclosingLoop;
+                       ctx.EnclosingLoopOrSwitch = bc.EnclosingLoopOrSwitch;
+                       ctx.Switch = bc.Switch;
 
-               public enum State {
-                       Running = -3, // Used only in CurrentPC, never stored into $PC
-                       Uninitialized = -2,
-                       After = -1,
-                       Start = 0
+                       return ctx;
                }
 
-               public void EmitYieldBreak (EmitContext ec, bool unwind_protect)
+               protected override Expression DoResolve (ResolveContext rc)
                {
-                       ec.Emit (unwind_protect ? OpCodes.Leave : OpCodes.Br, move_next_error);
+                       var ctx = CreateBlockContext ((BlockContext) rc);
+
+                       Block.Resolve (ctx);
+
+                       if (!rc.IsInProbingMode) {
+                               var move_next = new StateMachineMethod (storey, this, new TypeExpression (ReturnType, loc), Modifiers.PUBLIC, new MemberName ("MoveNext", loc), 0);
+                               move_next.Block.AddStatement (new MoveNextBodyStatement (this));
+                               storey.AddEntryMethod (move_next);
+                       }
+
+                       eclass = ExprClass.Value;
+                       return this;
                }
 
-               void EmitMoveNext_NoResumePoints (EmitContext ec, Block original_block)
+               public override void Emit (EmitContext ec)
                {
-                       ec.Emit (OpCodes.Ldarg_0);
-                       ec.Emit (OpCodes.Ldfld, IteratorHost.PC.Spec);
+                       //
+                       // Load state machine instance
+                       //
+                       storey.Instance.Emit (ec);
+               }
 
-                       ec.Emit (OpCodes.Ldarg_0);
-                       ec.EmitInt ((int) State.After);
-                       ec.Emit (OpCodes.Stfld, IteratorHost.PC.Spec);
+               void EmitMoveNext_NoResumePoints (EmitContext ec)
+               {
+                       ec.EmitThis ();
+                       ec.Emit (OpCodes.Ldfld, storey.PC.Spec);
+
+                       ec.EmitThis ();
+                       ec.EmitInt ((int) IteratorStorey.State.After);
+                       ec.Emit (OpCodes.Stfld, storey.PC.Spec);
 
                        // We only care if the PC is zero (start executing) or non-zero (don't do anything)
                        ec.Emit (OpCodes.Brtrue, move_next_error);
 
-                       SymbolWriter.StartIteratorBody (ec);
-                       original_block.Emit (ec);
-                       SymbolWriter.EndIteratorBody (ec);
+                       iterator_body_end = ec.DefineLabel ();
+
+                       block.EmitEmbedded (ec);
+
+                       ec.MarkLabel (iterator_body_end);
+
+                       EmitMoveNextEpilogue (ec);
 
                        ec.MarkLabel (move_next_error);
-                       ec.Emit (OpCodes.Ldc_I4_0);
-                       ec.Emit (OpCodes.Ret);
+
+                       if (ReturnType.Kind != MemberKind.Void) {
+                               ec.EmitInt (0);
+                               ec.Emit (OpCodes.Ret);
+                       }
                }
 
                void EmitMoveNext (EmitContext ec)
@@ -615,174 +847,200 @@ namespace Mono.CSharp {
                        move_next_error = ec.DefineLabel ();
 
                        if (resume_points == null) {
-                               EmitMoveNext_NoResumePoints (ec, block);
+                               EmitMoveNext_NoResumePoints (ec);
                                return;
                        }
-
+                       
                        current_pc = ec.GetTemporaryLocal (ec.BuiltinTypes.UInt);
-                       ec.Emit (OpCodes.Ldarg_0);
-                       ec.Emit (OpCodes.Ldfld, IteratorHost.PC.Spec);
+                       ec.EmitThis ();
+                       ec.Emit (OpCodes.Ldfld, storey.PC.Spec);
                        ec.Emit (OpCodes.Stloc, current_pc);
 
                        // We're actually in state 'running', but this is as good a PC value as any if there's an abnormal exit
-                       ec.Emit (OpCodes.Ldarg_0);
-                       ec.EmitInt ((int) State.After);
-                       ec.Emit (OpCodes.Stfld, IteratorHost.PC.Spec);
+                       ec.EmitThis ();
+                       ec.EmitInt ((int) IteratorStorey.State.After);
+                       ec.Emit (OpCodes.Stfld, storey.PC.Spec);
 
-                       Label [] labels = new Label [1 + resume_points.Count];
-                       labels [0] = ec.DefineLabel ();
+                       Label[] labels = new Label[1 + resume_points.Count];
+                       labels[0] = ec.DefineLabel ();
 
                        bool need_skip_finally = false;
                        for (int i = 0; i < resume_points.Count; ++i) {
-                               ResumableStatement s = resume_points [i];
+                               ResumableStatement s = resume_points[i];
                                need_skip_finally |= s is ExceptionStatement;
-                               labels [i+1] = s.PrepareForEmit (ec);
+                               labels[i + 1] = s.PrepareForEmit (ec);
                        }
 
                        if (need_skip_finally) {
                                skip_finally = ec.GetTemporaryLocal (ec.BuiltinTypes.Bool);
-                               ec.Emit (OpCodes.Ldc_I4_0);
+                               ec.EmitInt (0);
                                ec.Emit (OpCodes.Stloc, skip_finally);
                        }
 
-                       SymbolWriter.StartIteratorDispatcher (ec);
+                       var async_init = this as AsyncInitializer;
+                       if (async_init != null)
+                               ec.BeginExceptionBlock ();
+
                        ec.Emit (OpCodes.Ldloc, current_pc);
                        ec.Emit (OpCodes.Switch, labels);
 
-                       ec.Emit (OpCodes.Br, move_next_error);
-                       SymbolWriter.EndIteratorDispatcher (ec);
+                       ec.Emit (async_init != null ? OpCodes.Leave : OpCodes.Br, move_next_error);
 
-                       ec.MarkLabel (labels [0]);
+                       ec.MarkLabel (labels[0]);
 
-                       SymbolWriter.StartIteratorBody (ec);
-                       block.Emit (ec);
-                       SymbolWriter.EndIteratorBody (ec);
+                       iterator_body_end = ec.DefineLabel ();
 
-                       SymbolWriter.StartIteratorDispatcher (ec);
+                       block.EmitEmbedded (ec);
 
-                       ec.Emit (OpCodes.Ldarg_0);
-                       ec.EmitInt ((int) State.After);
-                       ec.Emit (OpCodes.Stfld, IteratorHost.PC.Spec);
+                       ec.MarkLabel (iterator_body_end);
 
-                       ec.MarkLabel (move_next_error);
-                       ec.EmitInt (0);
-                       ec.Emit (OpCodes.Ret);
-
-                       ec.MarkLabel (move_next_ok);
-                       ec.Emit (OpCodes.Ldc_I4_1);
-                       ec.Emit (OpCodes.Ret);
+                       if (async_init != null) {
+                               var catch_value = LocalVariable.CreateCompilerGenerated (ec.Module.Compiler.BuiltinTypes.Exception, block, Location);
 
-                       SymbolWriter.EndIteratorDispatcher (ec);
-               }
+                               ec.BeginCatchBlock (catch_value.Type);
+                               catch_value.EmitAssign (ec);
 
-               public void EmitDispose (EmitContext ec)
-               {
-                       Label end = ec.DefineLabel ();
+                               ec.EmitThis ();
+                               ec.EmitInt ((int) IteratorStorey.State.After);
+                               ec.Emit (OpCodes.Stfld, storey.PC.Spec);
 
-                       Label [] labels = null;
-                       int n_resume_points = resume_points == null ? 0 : resume_points.Count;
-                       for (int i = 0; i < n_resume_points; ++i) {
-                               ResumableStatement s = resume_points [i];
-                               Label ret = s.PrepareForDispose (ec, end);
-                               if (ret.Equals (end) && labels == null)
-                                       continue;
-                               if (labels == null) {
-                                       labels = new Label [resume_points.Count + 1];
-                                       for (int j = 0; j <= i; ++j)
-                                               labels [j] = end;
-                               }
+                               ((AsyncTaskStorey) async_init.Storey).EmitSetException (ec, new LocalVariableReference (catch_value, Location));
 
-                               labels [i+1] = ret;
+                               ec.Emit (OpCodes.Leave, move_next_ok);
+                               ec.EndExceptionBlock ();
                        }
 
-                       if (labels != null) {
-                               current_pc = ec.GetTemporaryLocal (ec.BuiltinTypes.UInt);
-                               ec.Emit (OpCodes.Ldarg_0);
-                               ec.Emit (OpCodes.Ldfld, IteratorHost.PC.Spec);
-                               ec.Emit (OpCodes.Stloc, current_pc);
-                       }
+                       ec.Mark (Block.Original.EndLocation);
+                       ec.EmitThis ();
+                       ec.EmitInt ((int) IteratorStorey.State.After);
+                       ec.Emit (OpCodes.Stfld, storey.PC.Spec);
 
-                       ec.Emit (OpCodes.Ldarg_0);
-                       ec.EmitInt (1);
-                       ec.Emit (OpCodes.Stfld, IteratorHost.DisposingField.Spec);
+                       EmitMoveNextEpilogue (ec);
 
-                       ec.Emit (OpCodes.Ldarg_0);
-                       ec.EmitInt ((int) State.After);
-                       ec.Emit (OpCodes.Stfld, IteratorHost.PC.Spec);
+                       ec.MarkLabel (move_next_error);
+                       
+                       if (ReturnType.Kind != MemberKind.Void) {
+                               ec.EmitInt (0);
+                               ec.Emit (OpCodes.Ret);
+                       }
 
-                       if (labels != null) {
-                               //SymbolWriter.StartIteratorDispatcher (ec.ig);
-                               ec.Emit (OpCodes.Ldloc, current_pc);
-                               ec.Emit (OpCodes.Switch, labels);
-                               //SymbolWriter.EndIteratorDispatcher (ec.ig);
+                       ec.MarkLabel (move_next_ok);
 
-                               foreach (ResumableStatement s in resume_points)
-                                       s.EmitForDispose (ec, this, end, true);
+                       if (ReturnType.Kind != MemberKind.Void) {
+                               ec.EmitInt (1);
+                               ec.Emit (OpCodes.Ret);
                        }
-
-                       ec.MarkLabel (end);
                }
 
-               public int AddResumePoint (ResumableStatement stmt)
+               protected virtual void EmitMoveNextEpilogue (EmitContext ec)
                {
-                       if (resume_points == null)
-                               resume_points = new List<ResumableStatement> ();
+               }
 
-                       resume_points.Add (stmt);
-                       return resume_points.Count;
+               public void EmitLeave (EmitContext ec, bool unwind_protect)
+               {
+                       // Return ok
+                       ec.Emit (unwind_protect ? OpCodes.Leave : OpCodes.Br, move_next_ok);
                }
 
                //
-               // Called back from Yield
+               // Called back from YieldStatement
                //
-               public void MarkYield (EmitContext ec, Expression expr, int resume_pc, bool unwind_protect, Label resume_point)
+               public virtual void InjectYield (EmitContext ec, Expression expr, int resume_pc, bool unwind_protect, Label resume_point)
                {
-                       // Store the new current
-                       ec.Emit (OpCodes.Ldarg_0);
-                       expr.Emit (ec);
-                       ec.Emit (OpCodes.Stfld, IteratorHost.CurrentField.Spec);
-
                        //
                        // Guard against being disposed meantime
                        //
                        Label disposed = ec.DefineLabel ();
-                       ec.Emit (OpCodes.Ldarg_0);
-                       ec.Emit (OpCodes.Ldfld, IteratorHost.DisposingField.Spec);
-                       ec.Emit (OpCodes.Brtrue_S, disposed);
+                       var iterator = storey as IteratorStorey;
+                       if (iterator != null) {
+                               ec.EmitThis ();
+                               ec.Emit (OpCodes.Ldfld, iterator.DisposingField.Spec);
+                               ec.Emit (OpCodes.Brtrue_S, disposed);
+                       }
 
                        //
                        // store resume program-counter
                        //
-                       ec.Emit (OpCodes.Ldarg_0);
+                       ec.EmitThis ();
                        ec.EmitInt (resume_pc);
-                       ec.Emit (OpCodes.Stfld, IteratorHost.PC.Spec);
-                       ec.MarkLabel (disposed);
+                       ec.Emit (OpCodes.Stfld, storey.PC.Spec);
+
+                       if (iterator != null) {
+                               ec.MarkLabel (disposed);
+                       }
 
                        // mark finally blocks as disabled
                        if (unwind_protect && skip_finally != null) {
                                ec.EmitInt (1);
                                ec.Emit (OpCodes.Stloc, skip_finally);
                        }
+               }
 
-                       // Return ok
-                       ec.Emit (unwind_protect ? OpCodes.Leave : OpCodes.Br, move_next_ok);
+               public void SetStateMachine (StateMachine stateMachine)
+               {
+                       this.storey = stateMachine;
+               }
+       }
 
-                       ec.MarkLabel (resume_point);
+       //
+       // Iterators are implemented as state machine blocks
+       //
+       public class Iterator : StateMachineInitializer
+       {
+               sealed class TryFinallyBlockProxyStatement : Statement
+               {
+                       TryFinallyBlock block;
+                       Iterator iterator;
+
+                       public TryFinallyBlockProxyStatement (Iterator iterator, TryFinallyBlock block)
+                       {
+                               this.iterator = iterator;
+                               this.block = block;
+                       }
+
+                       protected override void CloneTo (CloneContext clonectx, Statement target)
+                       {
+                               throw new NotSupportedException ();
+                       }
+
+                       protected override bool DoFlowAnalysis (FlowAnalysisContext fc)
+                       {
+                               throw new NotSupportedException ();
+                       }
+
+                       protected override void DoEmit (EmitContext ec)
+                       {
+                               //
+                               // Restore redirection for any captured variables
+                               //
+                               ec.CurrentAnonymousMethod = iterator;
+
+                               using (ec.With (BuilderContext.Options.OmitDebugInfo, !ec.HasMethodSymbolBuilder)) {
+                                       block.EmitFinallyBody (ec);
+                               }
+                       }
                }
 
-               //
-               // Our constructor
-               //
-               public Iterator (ParametersBlock block, IMethodData method, TypeContainer host, TypeSpec iterator_type, bool is_enumerable)
-                       : base (block, host.Compiler.BuiltinTypes.Bool, block.StartLocation)
+               public readonly IMethodData OriginalMethod;
+               public readonly bool IsEnumerable;
+               public readonly TypeSpec OriginalIteratorType;
+               int finally_hosts_counter;
+
+               public Iterator (ParametersBlock block, IMethodData method, TypeDefinition host, TypeSpec iterator_type, bool is_enumerable)
+                       : base (block, host, host.Compiler.BuiltinTypes.Bool)
                {
                        this.OriginalMethod = method;
                        this.OriginalIteratorType = iterator_type;
                        this.IsEnumerable = is_enumerable;
-                       this.Host = host;
                        this.type = method.ReturnType;
                }
 
+               #region Properties
+
+               public ToplevelBlock Container {
+                       get { return OriginalMethod.Block; }
+               }
+
                public override string ContainerType {
                        get { return "iterator"; }
                }
@@ -791,33 +1049,32 @@ namespace Mono.CSharp {
                        get { return true; }
                }
 
-               public override AnonymousMethodStorey Storey {
-                       get { return IteratorHost; }
-               }
+               #endregion
 
-               public override string GetSignatureForError ()
+               public Method CreateFinallyHost (TryFinallyBlock block)
                {
-                       return OriginalMethod.GetSignatureForError ();
-               }
+                       var method = new Method (storey, new TypeExpression (storey.Compiler.BuiltinTypes.Void, loc),
+                               Modifiers.COMPILER_GENERATED, new MemberName (CompilerGeneratedContainer.MakeName (null, null, "Finally", finally_hosts_counter++), loc),
+                               ParametersCompiled.EmptyReadOnlyParameters, null);
 
-               protected override Expression DoResolve (ResolveContext ec)
-               {
-                       IteratorHost = (IteratorStorey) block.TopBlock.AnonymousMethodStorey;
+                       method.Block = new ToplevelBlock (method.Compiler, method.ParameterInfo, loc,
+                               ToplevelBlock.Flags.CompilerGenerated | ToplevelBlock.Flags.NoFlowAnalysis);
+                       method.Block.AddStatement (new TryFinallyBlockProxyStatement (this, block));
 
-                       BlockContext ctx = new BlockContext (ec, block, ReturnType);
-                       ctx.CurrentAnonymousMethod = this;
+                       // Cannot it add to storey because it'd be emitted before nested
+                       // anonoymous methods which could capture shared variable
 
-                       ctx.StartFlowBranching (this, ec.CurrentBranching);
-                       Block.Resolve (ctx);
-                       ctx.EndFlowBranching ();
+                       return method;
+               }
 
-                       var move_next = new IteratorMethod (IteratorHost, new TypeExpression (ec.BuiltinTypes.Bool, loc),
-                               Modifiers.PUBLIC, new MemberName ("MoveNext", Location));
-                       move_next.Block.AddStatement (new MoveNextMethodStatement (this));
-                       IteratorHost.AddMethod (move_next);
+               public void EmitYieldBreak (EmitContext ec, bool unwind_protect)
+               {
+                       ec.Emit (unwind_protect ? OpCodes.Leave : OpCodes.Br, move_next_error);
+               }
 
-                       eclass = ExprClass.Value;
-                       return this;
+               public override string GetSignatureForError ()
+               {
+                       return OriginalMethod.GetSignatureForError ();
                }
 
                public override void Emit (EmitContext ec)
@@ -825,17 +1082,17 @@ namespace Mono.CSharp {
                        //
                        // Load Iterator storey instance
                        //
-                       IteratorHost.Instance.Emit (ec);
+                       storey.Instance.Emit (ec);
 
                        //
                        // Initialize iterator PC when it's unitialized
                        //
                        if (IsEnumerable) {
                                ec.Emit (OpCodes.Dup);
-                               ec.EmitInt ((int)State.Uninitialized);
+                               ec.EmitInt ((int)IteratorStorey.State.Uninitialized);
 
-                               var field = IteratorHost.PC.Spec;
-                               if (Storey.MemberName.IsGeneric) {
+                               var field = storey.PC.Spec;
+                               if (storey.MemberName.IsGeneric) {
                                        field = MemberCache.GetMember (Storey.Instance.Type, field);
                                }
 
@@ -843,12 +1100,76 @@ namespace Mono.CSharp {
                        }
                }
 
-               public override Expression CreateExpressionTree (ResolveContext ec)
+               public void EmitDispose (EmitContext ec)
                {
-                       throw new NotSupportedException ("ET");
+                       if (resume_points == null)
+                               return;
+
+                       Label end = ec.DefineLabel ();
+
+                       Label[] labels = null;
+                       for (int i = 0; i < resume_points.Count; ++i) {
+                               ResumableStatement s = resume_points[i];
+                               Label ret = s.PrepareForDispose (ec, end);
+                               if (ret.Equals (end) && labels == null)
+                                       continue;
+                               if (labels == null) {
+                                       labels = new Label[resume_points.Count + 1];
+                                       for (int j = 0; j <= i; ++j)
+                                               labels[j] = end;
+                               }
+
+                               labels[i + 1] = ret;
+                       }
+
+                       if (labels != null) {
+                               current_pc = ec.GetTemporaryLocal (ec.BuiltinTypes.UInt);
+                               ec.EmitThis ();
+                               ec.Emit (OpCodes.Ldfld, storey.PC.Spec);
+                               ec.Emit (OpCodes.Stloc, current_pc);
+                       }
+
+                       ec.EmitThis ();
+                       ec.EmitInt (1);
+                       ec.Emit (OpCodes.Stfld, ((IteratorStorey) storey).DisposingField.Spec);
+
+                       ec.EmitThis ();
+                       ec.EmitInt ((int) IteratorStorey.State.After);
+                       ec.Emit (OpCodes.Stfld, storey.PC.Spec);
+
+                       if (labels != null) {
+                               //SymbolWriter.StartIteratorDispatcher (ec.ig);
+                               ec.Emit (OpCodes.Ldloc, current_pc);
+                               ec.Emit (OpCodes.Switch, labels);
+                               //SymbolWriter.EndIteratorDispatcher (ec.ig);
+
+                               foreach (ResumableStatement s in resume_points)
+                                       s.EmitForDispose (ec, current_pc, end, true);
+                       }
+
+                       ec.MarkLabel (end);
+               }
+
+               public override void EmitStatement (EmitContext ec)
+               {
+                       throw new NotImplementedException ();
+               }
+
+               public override void InjectYield (EmitContext ec, Expression expr, int resume_pc, bool unwind_protect, Label resume_point)
+               {
+                       // Store the new value into current
+                       var fe = new FieldExpr (((IteratorStorey) storey).CurrentField, loc);
+                       fe.InstanceExpression = new CompilerGeneratedThis (storey.CurrentType, loc);
+                       fe.EmitAssign (ec, expr, false, false);
+
+                       base.InjectYield (ec, expr, resume_pc, unwind_protect, resume_point);
+
+                       EmitLeave (ec, unwind_protect);
+
+                       ec.MarkLabel (resume_point);
                }
 
-               public static void CreateIterator (IMethodData method, TypeContainer parent, Modifiers modifiers)
+               public static void CreateIterator (IMethodData method, TypeDefinition parent, Modifiers modifiers)
                {
                        bool is_enumerable;
                        TypeSpec iterator_type;
@@ -862,7 +1183,7 @@ namespace Mono.CSharp {
                                              "The body of `{0}' cannot be an iterator block " +
                                              "because `{1}' is not an iterator interface type",
                                              method.GetSignatureForError (),
-                                             TypeManager.CSharpName (ret));
+                                             ret.GetSignatureForError ());
                                return;
                        }
 
@@ -870,7 +1191,7 @@ namespace Mono.CSharp {
                        for (int i = 0; i < parameters.Count; i++) {
                                Parameter p = parameters [i];
                                Parameter.Modifier mod = p.ModFlags;
-                               if ((mod & Parameter.Modifier.ISBYREF) != 0) {
+                               if ((mod & Parameter.Modifier.RefOutMask) != 0) {
                                        parent.Compiler.Report.Error (1623, p.Location,
                                                "Iterators cannot have ref or out parameters");
                                        return;
@@ -884,8 +1205,7 @@ namespace Mono.CSharp {
 
                                if (parameters.Types [i].IsPointer) {
                                        parent.Compiler.Report.Error (1637, p.Location,
-                                                         "Iterators cannot have unsafe parameters or " +
-                                                         "yield types");
+                                               "Iterators cannot have unsafe parameters or yield types");
                                        return;
                                }
                        }
@@ -894,7 +1214,7 @@ namespace Mono.CSharp {
                                parent.Compiler.Report.Error (1629, method.Location, "Unsafe code may not appear in iterators");
                        }
 
-                       method.Block.WrapIntoIterator (method, parent, iterator_type, is_enumerable);
+                       method.Block = method.Block.ConvertToIterator (method, parent, iterator_type, is_enumerable);
                }
 
                static bool CheckType (TypeSpec ret, TypeContainer parent, out TypeSpec original_iterator_type, out bool is_enumerable)