// Miguel de Icaza (miguel@ximian.com)
// Marek Safar (marek.safar@seznam.cz)
//
-// (C) 2001, 2002, 2003 Ximian, Inc.
+// Copyright 2001, 2002, 2003 Ximian, Inc.
+// Copyright 2003-2008 Novell, Inc.
//
//
void AddressOf (EmitContext ec, AddressOp mode);
}
- /// <summary>
- /// This interface is implemented by variables
- /// </summary>
+ // TODO: Rename to something meaningful, this is flow-analysis interface only
public interface IVariable {
- VariableInfo VariableInfo {
- get;
- }
-
- bool VerifyFixed ();
+ VariableInfo VariableInfo { get; }
+ bool IsFixed { get; }
}
/// <remarks>
return;
}
- if (Type != TypeManager.string_type && this is Constant && !(this is EmptyConstantCast)) {
- Report.Error (31, loc, "Constant value `{0}' cannot be converted to a `{1}'",
- ((Constant)(this)).GetValue ().ToString (), TypeManager.CSharpName (target));
- return;
- }
-
Report.Error (29, loc, "Cannot implicitly convert type `{0}' to `{1}'",
TypeManager.CSharpName (type),
TypeManager.CSharpName (target));
/// </remarks>
public abstract void Emit (EmitContext ec);
+ // Emit code to branch to @target if this expression is equivalent to @on_true.
+ // The default implementation is to emit the value, and then emit a brtrue or brfalse.
+ // Subclasses can provide more efficient implementations, but those MUST be equivalent,
+ // including the use of conditional branches. Note also that a branch MUST be emitted
public virtual void EmitBranchable (EmitContext ec, Label target, bool on_true)
{
Emit (ec);
ec.ig.Emit (on_true ? OpCodes.Brtrue : OpCodes.Brfalse, target);
}
+ // Emit this expression for its side effects, not for its value.
+ // The default implementation is to emit the value, and then throw it away.
+ // Subclasses can provide more efficient implementations, but those MUST be equivalent
public virtual void EmitSideEffect (EmitContext ec)
{
Emit (ec);
throw new NotImplementedException ();
}
+ protected void Error_PointerInsideExpressionTree ()
+ {
+ Report.Error (1944, loc, "An expression tree cannot contain an unsafe pointer operation");
+ }
+
/// <summary>
/// Returns an expression that can be used to invoke operator true
/// on the expression if it exists.
static Expression GetOperatorTrueOrFalse (EmitContext ec, Expression e, bool is_true, Location loc)
{
MethodGroupExpr operator_group;
- operator_group = MethodLookup (ec.ContainerType, e.Type, is_true ? "op_True" : "op_False", loc) as MethodGroupExpr;
+ string mname = Operator.GetMetadataName (is_true ? Operator.OpType.True : Operator.OpType.False);
+ operator_group = MethodLookup (ec.ContainerType, e.Type, mname, loc) as MethodGroupExpr;
if (operator_group == null)
return null;
return cloned;
}
- public virtual Expression CreateExpressionTree (EmitContext ec)
- {
- throw new NotImplementedException (
- "Expression tree conversion not implemented for " + GetType ());
- }
+ //
+ // Implementation of expression to expression tree conversion
+ //
+ public abstract Expression CreateExpressionTree (EmitContext ec);
protected Expression CreateExpressionFactoryCall (string name, ArrayList args)
{
return texpr;
}
+
+ public virtual void MutateHoistedGenericType (AnonymousMethodStorey storey)
+ {
+ // TODO: It should probably be type = storey.MutateType (type);
+ }
}
/// <summary>
/// </summary>
public abstract class TypeCast : Expression
{
- protected Expression child;
+ protected readonly Expression child;
protected TypeCast (Expression child, Type return_type)
{
ArrayList args = new ArrayList (2);
args.Add (new Argument (child.CreateExpressionTree (ec)));
args.Add (new Argument (new TypeOf (new TypeExpression (type, loc), loc)));
+
+ if (type.IsPointer || child.Type.IsPointer)
+ Error_PointerInsideExpressionTree ();
+
return CreateExpressionFactoryCall (ec.CheckState ? "ConvertChecked" : "Convert", args);
}
return child.GetAttributableValue (value_type, out value);
}
+ public override void MutateHoistedGenericType (AnonymousMethodStorey storey)
+ {
+ child.MutateHoistedGenericType (storey);
+ }
+
protected override void CloneTo (CloneContext clonectx, Expression t)
{
- TypeCast target = (TypeCast) t;
+ // Nothing to clone
+ }
- target.child = child.Clone (clonectx);
+ public override bool IsNull {
+ get { return child.IsNull; }
}
}
: base (child, target_type)
{
}
-
+
public static Expression Create (Expression child, Type type)
{
Constant c = child as Constant;
if (c != null)
return new EmptyConstantCast (c, type);
+ EmptyCast e = child as EmptyCast;
+ if (e != null)
+ return new EmptyCast (e.child, type);
+
return new EmptyCast (child, type);
}
{
child.EmitSideEffect (ec);
}
-
}
/// <summary>
ArrayList args = new ArrayList (2);
args.Add (new Argument (child.CreateExpressionTree (ec)));
args.Add (new Argument (new TypeOf (new TypeExpression (type, loc), loc)));
+ if (type.IsPointer)
+ Error_PointerInsideExpressionTree ();
+
return CreateExpressionFactoryCall ("Convert", args);
}
child.Emit (ec);
}
+ public override void EmitBranchable (EmitContext ec, Label label, bool on_true)
+ {
+ child.EmitBranchable (ec, label, on_true);
+ }
+
+ public override void EmitSideEffect (EmitContext ec)
+ {
+ child.EmitSideEffect (ec);
+ }
+
public override Constant ConvertImplicitly (Type target_type)
{
// FIXME: Do we need to check user conversions?
Child.Emit (ec);
}
+ public override void EmitBranchable (EmitContext ec, Label label, bool on_true)
+ {
+ Child.EmitBranchable (ec, label, on_true);
+ }
+
+ public override void EmitSideEffect (EmitContext ec)
+ {
+ Child.EmitSideEffect (ec);
+ }
+
public override bool GetAttributableValue (Type value_type, out object value)
{
value = GetTypedValue ();
ec.ig.Emit (OpCodes.Box, child.Type);
}
- public override void EmitBranchable (EmitContext ec, Label label, bool on_true)
- {
- if (child.Type.IsValueType &&
- (type == TypeManager.object_type || type == TypeManager.value_type)) {
- // 'Box' involves runtime checks for interface types, so we can't unconditionally assume we'll get a non-null here
- child.EmitSideEffect (ec);
- if (on_true)
- ec.ig.Emit (OpCodes.Br, label);
- return;
- }
- base.EmitBranchable (ec, label, on_true);
- }
-
public override void EmitSideEffect (EmitContext ec)
{
+ // boxing is side-effectful, since it involves runtime checks, except when boxing to Object or ValueType
+ // so, we need to emit the box+pop instructions in most cases
if (child.Type.IsValueType &&
- (type == TypeManager.object_type || type == TypeManager.value_type)) {
+ (type == TypeManager.object_type || type == TypeManager.value_type))
child.EmitSideEffect (ec);
- return;
- }
- // boxing is side-effectful, since it involves runtime checks
- base.EmitSideEffect (ec);
+ else
+ base.EmitSideEffect (ec);
}
}
LoadFromPtr (ig, t);
}
}
+
+ public override void MutateHoistedGenericType (AnonymousMethodStorey storey)
+ {
+ type = storey.MutateType (type);
+ }
}
/// <summary>
}
public class OpcodeCast : TypeCast {
- OpCode op, op2;
- bool second_valid;
+ readonly OpCode op;
public OpcodeCast (Expression child, Type return_type, OpCode op)
: base (child, return_type)
-
{
this.op = op;
- second_valid = false;
- }
-
- public OpcodeCast (Expression child, Type return_type, OpCode op, OpCode op2)
- : base (child, return_type)
-
- {
- this.op = op;
- this.op2 = op2;
- second_valid = true;
}
public override Expression DoResolve (EmitContext ec)
{
base.Emit (ec);
ec.ig.Emit (op);
-
- if (second_valid)
- ec.ig.Emit (op2);
}
public Type UnderlyingType {
/// This kind of cast is used to encapsulate a child and cast it
/// to the class requested
/// </summary>
- public class ClassCast : TypeCast {
+ public sealed class ClassCast : TypeCast {
+ Type child_generic_parameter;
+
public ClassCast (Expression child, Type return_type)
: base (child, return_type)
{
+ if (TypeManager.IsGenericParameter (child.Type))
+ child_generic_parameter = child.Type;
}
public override Expression DoResolve (EmitContext ec)
{
base.Emit (ec);
- if (TypeManager.IsGenericParameter (child.Type))
- ec.ig.Emit (OpCodes.Box, child.Type);
+ if (child_generic_parameter != null)
+ ec.ig.Emit (OpCodes.Box, child_generic_parameter);
#if GMCS_SOURCE
if (type.IsGenericParameter)
#endif
ec.ig.Emit (OpCodes.Castclass, type);
}
+
+ public override void MutateHoistedGenericType (AnonymousMethodStorey storey)
+ {
+ type = storey.MutateType (type);
+ if (child_generic_parameter != null)
+ child_generic_parameter = storey.MutateGenericArgument (child_generic_parameter);
+
+ base.MutateHoistedGenericType (storey);
+ }
}
//
expr.EmitBranchable (ec, target, on_true);
}
}
+
+ //
+ // Unresolved type name expressions
+ //
+ public abstract class ATypeNameExpression : FullNamedExpression
+ {
+ public readonly string Name;
+ protected TypeArguments targs;
+
+ protected ATypeNameExpression (string name, Location l)
+ {
+ Name = name;
+ loc = l;
+ }
+
+ protected ATypeNameExpression (string name, TypeArguments targs, Location l)
+ {
+ Name = name;
+ this.targs = targs;
+ loc = l;
+ }
+
+ public bool HasTypeArguments {
+ get {
+ return targs != null;
+ }
+ }
+
+ public override string GetSignatureForError ()
+ {
+ if (targs != null) {
+ return TypeManager.RemoveGenericArity (Name) + "<" +
+ targs.GetSignatureForError () + ">";
+ }
+
+ return Name;
+ }
+ }
/// <summary>
/// SimpleName expressions are formed of a single word and only happen at the beginning
/// of a dotted-name.
/// </summary>
- public class SimpleName : Expression {
- public readonly string Name;
- public readonly TypeArguments Arguments;
+ public class SimpleName : ATypeNameExpression {
bool in_transit;
public SimpleName (string name, Location l)
+ : base (name, l)
{
- Name = name;
- loc = l;
}
public SimpleName (string name, TypeArguments args, Location l)
+ : base (name, args, l)
{
- Name = name;
- Arguments = args;
- loc = l;
}
public SimpleName (string name, TypeParameter[] type_params, Location l)
+ : base (name, l)
{
- Name = name;
- loc = l;
-
- Arguments = new TypeArguments (l);
+ targs = new TypeArguments (l);
foreach (TypeParameter type_param in type_params)
- Arguments.Add (new TypeParameterExpr (type_param, l));
+ targs.Add (new TypeParameterExpr (type_param, l));
}
public static string RemoveGenericArity (string name)
public SimpleName GetMethodGroup ()
{
- return new SimpleName (RemoveGenericArity (Name), Arguments, loc);
+ return new SimpleName (RemoveGenericArity (Name), targs, loc);
}
public static void Error_ObjectRefRequired (EmitContext ec, Location l, string name)
Type[] gen_params = TypeManager.GetTypeArguments (t);
- int arg_count = Arguments != null ? Arguments.Count : 0;
+ int arg_count = targs != null ? targs.Count : 0;
for (; (ds != null) && ds.IsGeneric; ds = ds.Parent) {
if (arg_count + ds.CountTypeParameters == gen_params.Length) {
foreach (TypeParameter param in ds.TypeParameters)
new_args.Add (new TypeParameterExpr (param, loc));
- if (Arguments != null)
- new_args.Add (Arguments);
+ if (targs != null)
+ new_args.Add (targs);
return new ConstructedType (t, new_args, loc);
}
if (nested != null)
return nested.ResolveAsTypeStep (ec, false);
- if (Arguments != null) {
- ConstructedType ct = new ConstructedType (fne, Arguments, loc);
+ if (targs != null) {
+ ConstructedType ct = new ConstructedType (fne, targs, loc);
return ct.ResolveAsTypeStep (ec, false);
}
return;
}
- if (Arguments != null) {
+ if (targs != null) {
FullNamedExpression retval = ec.DeclContainer.LookupNamespaceOrType (SimpleName.RemoveGenericArity (Name), loc, true);
if (retval != null) {
Namespace.Error_TypeArgumentsCannotBeUsed (retval.Type, loc);
if (current_block != null){
LocalInfo vi = current_block.GetLocalInfo (Name);
if (vi != null){
- if (Arguments != null) {
+ if (targs != null) {
Report.Error (307, loc,
"The variable `{0}' cannot be used with type arguments",
Name);
ParameterReference pref = current_block.Toplevel.GetParameterReference (Name, loc);
if (pref != null) {
- if (Arguments != null) {
+ if (targs != null) {
Report.Error (307, loc,
"The variable `{0}' cannot be used with type arguments",
Name);
}
if (e is TypeExpr) {
- if (Arguments == null)
+ if (targs == null)
return e;
ConstructedType ct = new ConstructedType (
- (FullNamedExpression) e, Arguments, loc);
+ e.Type, targs, loc);
return ct.ResolveAsTypeStep (ec, false);
}
if (me == null)
return null;
- if (Arguments != null) {
- Arguments.Resolve (ec);
- me.SetTypeArguments (Arguments);
+ if (targs != null) {
+ targs.Resolve (ec);
+ me.SetTypeArguments (targs);
}
if (!me.IsStatic && (me.InstanceExpression != null) &&
return e;
}
- public override void Emit (EmitContext ec)
- {
- throw new InternalErrorException ("The resolve phase was not executed");
- }
-
- public override string ToString ()
- {
- return Name;
- }
-
- public override string GetSignatureForError ()
- {
- if (Arguments != null) {
- return TypeManager.RemoveGenericArity (Name) + "<" +
- Arguments.GetSignatureForError () + ">";
- }
-
- return Name;
- }
-
protected override void CloneTo (CloneContext clonectx, Expression target)
{
// CloneTo: Nothing, we do not keep any state on this expression
/// section 10.8.1 (Fully Qualified Names).
/// </summary>
public abstract class FullNamedExpression : Expression {
+
+ public override Expression CreateExpressionTree (EmitContext ec)
+ {
+ throw new NotSupportedException ("ET");
+ }
+
public override FullNamedExpression ResolveAsTypeStep (IResolveContext ec, bool silent)
{
return this;
}
- public abstract string FullName {
- get;
+ public override void Emit (EmitContext ec)
+ {
+ throw new InternalErrorException ("FullNamedExpression `{0}' found in resolved tree",
+ GetSignatureForError ());
}
}
return ResolveAsTypeTerminal (ec, false);
}
- override public void Emit (EmitContext ec)
- {
- throw new Exception ("Should never be called");
- }
-
public virtual bool CheckAccessLevel (DeclSpace ds)
{
return ds.CheckAccessLevel (Type);
protected abstract TypeExpr DoResolveAsTypeStep (IResolveContext ec);
- public abstract string Name {
- get;
- }
-
public override bool Equals (object obj)
{
TypeExpr tobj = obj as TypeExpr;
{
return Type.GetHashCode ();
}
-
- public override string ToString ()
+
+ public override void MutateHoistedGenericType (AnonymousMethodStorey storey)
{
- return Name;
+ type = storey.MutateType (type);
}
}
{
return this;
}
-
- public override string Name {
- get { return Type.ToString (); }
- }
-
- public override string FullName {
- get { return Type.FullName; }
- }
}
/// <summary>
return this;
}
- public override string Name {
- get { return name; }
- }
-
- public override string FullName {
- get { return name; }
- }
-
protected override void CloneTo (CloneContext clonectx, Expression target)
{
// CloneTo: Nothing, we do not keep any state on this expression
loc = l;
}
+ protected override void CloneTo (CloneContext clonectx, Expression target)
+ {
+ // Nothing to clone
+ }
+
protected override TypeExpr DoResolveAsTypeStep (IResolveContext ec)
{
Expression expr;
type = fne.Type;
return new TypeExpression (type, loc);
}
-
- public override string Name {
- get { return name.PrettyName; }
- }
-
- public override string FullName {
- get { return name.FullyQualifiedName; }
- }
- }
-
- public class TypeAliasExpression : TypeExpr {
- FullNamedExpression alias;
- TypeExpr texpr;
- TypeArguments args;
- string name;
-
- public TypeAliasExpression (FullNamedExpression alias, TypeArguments args, Location l)
- {
- this.alias = alias;
- this.args = args;
- loc = l;
-
- eclass = ExprClass.Type;
- if (args != null)
- name = alias.FullName + "<" + args.ToString () + ">";
- else
- name = alias.FullName;
- }
-
- public override string Name {
- get { return alias.FullName; }
- }
-
- public override string FullName {
- get { return name; }
- }
-
- protected override TypeExpr DoResolveAsTypeStep (IResolveContext ec)
- {
- texpr = alias.ResolveAsTypeTerminal (ec, false);
- if (texpr == null)
- return null;
-
- Type type = texpr.Type;
- int num_args = TypeManager.GetNumberOfTypeArguments (type);
-
- if (args != null) {
- if (num_args == 0) {
- Report.Error (308, loc,
- "The non-generic type `{0}' cannot " +
- "be used with type arguments.",
- TypeManager.CSharpName (type));
- return null;
- }
-
- ConstructedType ctype = new ConstructedType (type, args, loc);
- return ctype.ResolveAsTypeTerminal (ec, false);
- } else if (num_args > 0) {
- Report.Error (305, loc,
- "Using the generic type `{0}' " +
- "requires {1} type arguments",
- TypeManager.CSharpName (type), num_args.ToString ());
- return null;
- }
-
- return texpr;
- }
-
- public override bool CheckAccessLevel (DeclSpace ds)
- {
- return texpr.CheckAccessLevel (ds);
- }
-
- public override bool AsAccessible (DeclSpace ds)
- {
- return texpr.AsAccessible (ds);
- }
-
- public override bool IsClass {
- get { return texpr.IsClass; }
- }
-
- public override bool IsValueType {
- get { return texpr.IsValueType; }
- }
-
- public override bool IsInterface {
- get { return texpr.IsInterface; }
- }
-
- public override bool IsSealed {
- get { return texpr.IsSealed; }
- }
}
/// <summary>
"with an instance reference, qualify it with a type name instead", name);
}
+ public static void Error_BaseAccessInExpressionTree (Location loc)
+ {
+ Report.Error (831, loc, "An expression tree may not contain a base access");
+ }
+
+ public override void MutateHoistedGenericType (AnonymousMethodStorey storey)
+ {
+ if (InstanceExpression != null)
+ InstanceExpression.MutateHoistedGenericType (storey);
+ }
+
// TODO: possible optimalization
// Cache resolved constant result in FieldBuilder <-> expression map
public virtual MemberExpr ResolveMemberAccess (EmitContext ec, Expression left, Location loc,
return base.OverloadResolve (ec, ref arguments, false, loc);
e.ExtensionExpression = ExtensionExpression;
+ e.SetTypeArguments (type_arguments);
return e.ResolveOverloadExtensions (ec, arguments, e.namespace_entry, loc);
}
}
//
if (TypeManager.DropGenericTypeArguments (p) == TypeManager.expression_type) {
p = TypeManager.GetTypeArguments (p) [0];
+ }
+ if (TypeManager.DropGenericTypeArguments (q) == TypeManager.expression_type) {
q = TypeManager.GetTypeArguments (q) [0];
}
+
p = Delegate.GetInvokeMethod (null, p).ReturnType;
q = Delegate.GetInvokeMethod (null, q).ReturnType;
+ if (p == TypeManager.void_type && q != TypeManager.void_type)
+ return 2;
+ if (q == TypeManager.void_type && p != TypeManager.void_type)
+ return 1;
} else {
if (argument_type == p)
return 1;
public override Expression CreateExpressionTree (EmitContext ec)
{
- Type t = best_candidate.IsConstructor ?
- typeof (ConstructorInfo) : typeof (MethodInfo);
+ if (best_candidate == null) {
+ Report.Error (1953, loc, "An expression tree cannot contain an expression with method group");
+ return null;
+ }
+
+ if (best_candidate.IsConstructor)
+ return new TypeOfConstructorInfo (best_candidate, loc);
- return new Cast (new TypeExpression (t, loc), new TypeOfMethod (best_candidate, loc));
+ IMethodData md = TypeManager.GetMethod (best_candidate);
+ if (md != null && md.IsExcluded ())
+ Report.Error (765, loc,
+ "Partial methods with only a defining declaration or removed conditional methods cannot be used in an expression tree");
+
+ return new TypeOfMethodInfo (best_candidate, loc);
}
override public Expression DoResolve (EmitContext ec)
protected virtual void Error_InvalidArguments (EmitContext ec, Location loc, int idx, MethodBase method,
Argument a, ParameterData expected_par, Type paramType)
{
+ ExtensionMethodGroupExpr emg = this as ExtensionMethodGroupExpr;
+
if (a is CollectionElementInitializer.ElementInitializerArgument) {
Report.SymbolRelatedToPreviousError (method);
if ((expected_par.ParameterModifier (idx) & Parameter.Modifier.ISBYREF) != 0) {
TypeManager.CSharpSignature (method));
} else if (delegate_type == null) {
Report.SymbolRelatedToPreviousError (method);
- Report.Error (1502, loc, "The best overloaded method match for `{0}' has some invalid arguments",
- TypeManager.CSharpSignature (method));
+ if (emg != null) {
+ Report.Error (1928, loc,
+ "Type `{0}' does not contain a member `{1}' and the best extension method overload `{2}' has some invalid arguments",
+ emg.ExtensionExpression.GetSignatureForError (),
+ emg.Name, TypeManager.CSharpSignature (method));
+ } else {
+ Report.Error (1502, loc, "The best overloaded method match for `{0}' has some invalid arguments",
+ TypeManager.CSharpSignature (method));
+ }
} else
Report.Error (1594, loc, "Delegate `{0}' has some invalid arguments",
TypeManager.CSharpName (delegate_type));
if (((mod & (Parameter.Modifier.REF | Parameter.Modifier.OUT)) ^
(a.Modifier & (Parameter.Modifier.REF | Parameter.Modifier.OUT))) != 0) {
if ((mod & Parameter.Modifier.ISBYREF) == 0)
- Report.Error (1615, loc, "Argument `{0}' should not be passed with the `{1}' keyword",
+ Report.Error (1615, loc, "Argument `#{0}' does not require `{1}' modifier. Consider removing `{1}' modifier",
index, Parameter.GetModifierSignature (a.Modifier));
else
- Report.Error (1620, loc, "Argument `{0}' must be passed with the `{1}' keyword",
+ Report.Error (1620, loc, "Argument `#{0}' is missing `{1}' modifier",
index, Parameter.GetModifierSignature (mod));
} else {
string p1 = a.GetSignatureForError ();
Report.SymbolRelatedToPreviousError (a.Expr.Type);
Report.SymbolRelatedToPreviousError (paramType);
}
- Report.Error (1503, loc, "Argument {0}: Cannot convert type `{1}' to `{2}'", index, p1, p2);
+
+ if (idx == 0 && emg != null) {
+ Report.Error (1929, loc,
+ "Extension method instance type `{0}' cannot be converted to `{1}'", p1, p2);
+ } else {
+ Report.Error (1503, loc,
+ "Argument `#{0}' cannot convert `{1}' expression to type `{2}'", index, p1, p2);
+ }
}
}
if (a_type != parameter)
return 2;
-
- return 0;
- }
-
- // FIXME: Kill this abomination (EmitContext.TempEc)
- EmitContext prevec = EmitContext.TempEc;
- EmitContext.TempEc = ec;
- try {
+ } else {
if (delegate_type != null ?
!Delegate.IsTypeCovariant (argument.Expr, parameter) :
!Convert.ImplicitConversionExists (ec, argument.Expr, parameter))
return 2;
-
- if (arg_mod != param_mod)
- return 1;
-
- } finally {
- EmitContext.TempEc = prevec;
}
+ if (arg_mod != param_mod)
+ return 1;
+
return 0;
}
return null;
}
+ public override void MutateHoistedGenericType (AnonymousMethodStorey storey)
+ {
+ base.MutateHoistedGenericType (storey);
+
+ MethodInfo mi = best_candidate as MethodInfo;
+ if (mi != null) {
+ best_candidate = storey.MutateGenericMethod (mi);
+ return;
+ }
+
+ best_candidate = storey.MutateConstructor ((ConstructorInfo) this);
+ }
+
/// <summary>
/// Find the Applicable Function Members (7.4.2.1)
///
}
Report.SetMessageRecorder (prev_recorder);
- if (msg_recorder != null && msg_recorder.PrintMessages ())
+ if (msg_recorder != null && !msg_recorder.IsEmpty) {
+ if (!may_fail)
+ msg_recorder.PrintMessages ();
+
return null;
+ }
int candidate_top = candidates.Count;
continue;
}
-
+
Expression conv;
if (TypeManager.IsEqual (a.Type, pt)) {
conv = a.Expr;
// Convert params arguments to an array initializer
//
if (params_initializers != null) {
- params_initializers.Add (conv);
+ // we choose to use 'a.Expr' rather than 'conv' so that
+ // we don't hide the kind of expression we have (esp. CompoundAssign.Helper)
+ params_initializers.Add (a.Expr);
arguments.RemoveAt (a_idx--);
--arg_count;
continue;
}
-
+
// Update the argument with the implicit conversion
a.Expr = conv;
}
public override Expression CreateExpressionTree (EmitContext ec)
{
- throw new NotSupportedException ();
+ throw new NotSupportedException ("ET");
}
public override Expression DoResolve (EmitContext ec)
/// Fully resolved expression that evaluates to a Field
/// </summary>
public class FieldExpr : MemberExpr, IAssignMethod, IMemoryLocation, IVariable {
- public readonly FieldInfo FieldInfo;
+ public FieldInfo FieldInfo;
+ readonly Type constructed_generic_type;
VariableInfo variable_info;
LocalTemporary temp;
loc = l;
}
+ public FieldExpr (FieldInfo fi, Type genericType, Location l)
+ : this (fi, l)
+ {
+ this.constructed_generic_type = genericType;
+ }
+
public override string Name {
get {
return FieldInfo.Name;
}
}
- AnonymousContainer am = ec.CurrentAnonymousMethod;
- if (am != null){
- if (!FieldInfo.IsStatic){
- if (!am.IsIterator && (ec.TypeContainer is Struct)){
- Report.Error (1673, loc,
- "Anonymous methods inside structs cannot access instance members of `{0}'. Consider copying `{0}' to a local variable outside the anonymous method and using the local instead",
- "this");
- return null;
- }
- }
- }
-
IFixedBuffer fb = AttributeTester.GetFixedBuffer (FieldInfo);
if (fb != null) {
if (!ec.InFixedInitializer && ec.ContainerType.IsValueType) {
// If the instance expression is a local variable or parameter.
IVariable var = InstanceExpression as IVariable;
- if ((var == null) || (var.VariableInfo == null))
+ if (var == null || var.VariableInfo == null)
return this;
VariableInfo vi = var.VariableInfo;
override public Expression DoResolveLValue (EmitContext ec, Expression right_side)
{
IVariable var = InstanceExpression as IVariable;
- if ((var != null) && (var.VariableInfo != null))
+ if (var != null && var.VariableInfo != null)
var.VariableInfo.SetFieldAssigned (ec, FieldInfo.Name);
bool lvalue_instance = !FieldInfo.IsStatic && FieldInfo.DeclaringType.IsValueType;
return this;
}
+ bool is_marshal_by_ref ()
+ {
+ return !IsStatic && Type.IsValueType && TypeManager.mbr_type != null && TypeManager.IsSubclassOf (DeclaringType, TypeManager.mbr_type);
+ }
+
public override void CheckMarshalByRefAccess (EmitContext ec)
{
- if (!IsStatic && Type.IsValueType && !(InstanceExpression is This) && TypeManager.mbr_type != null && TypeManager.IsSubclassOf (DeclaringType, TypeManager.mbr_type)) {
+ if (is_marshal_by_ref () && !(InstanceExpression is This)) {
Report.SymbolRelatedToPreviousError (DeclaringType);
Report.Warning (1690, 1, loc, "Cannot call methods, properties, or indexers on `{0}' because it is a value type member of a marshal-by-reference class",
GetSignatureForError ());
}
}
- public bool VerifyFixed ()
- {
- IVariable variable = InstanceExpression as IVariable;
- // A variable of the form V.I is fixed when V is a fixed variable of a struct type.
- // We defer the InstanceExpression check after the variable check to avoid a
- // separate null check on InstanceExpression.
- return variable != null && InstanceExpression.Type.IsValueType && variable.VerifyFixed ();
- }
-
public override int GetHashCode ()
{
return FieldInfo.GetHashCode ();
}
+
+ public bool IsFixed {
+ get {
+ IVariable variable = InstanceExpression as IVariable;
+ // A variable of the form V.I is fixed when V is a fixed variable of a struct type.
+ // We defer the InstanceExpression check after the variable check to avoid a
+ // separate null check on InstanceExpression.
+ return variable != null && InstanceExpression.Type.IsValueType && variable.IsFixed;
+ }
+ }
public override bool Equals (object obj)
{
if (FieldInfo.IsStatic){
if (is_volatile)
ig.Emit (OpCodes.Volatile);
-
- ig.Emit (OpCodes.Ldsfld, FieldInfo);
+
+ ig.Emit (OpCodes.Ldsfld, GetConstructedFieldInfo ());
} else {
if (!prepared)
EmitInstance (ec, false);
IFixedBuffer ff = AttributeTester.GetFixedBuffer (FieldInfo);
if (ff != null) {
- ig.Emit (OpCodes.Ldflda, FieldInfo);
+ ig.Emit (OpCodes.Ldflda, GetConstructedFieldInfo ());
ig.Emit (OpCodes.Ldflda, ff.Element);
} else {
if (is_volatile)
ig.Emit (OpCodes.Volatile);
- ig.Emit (OpCodes.Ldfld, FieldInfo);
+ ig.Emit (OpCodes.Ldfld, GetConstructedFieldInfo ());
}
}
return;
}
- //
- // String concatenation creates a new string instance
- //
- prepared = prepare_for_load && !(source is StringConcat);
+ prepared = prepare_for_load;
EmitInstance (ec, prepared);
source.Emit (ec);
}
if (is_static)
- ig.Emit (OpCodes.Stsfld, FieldInfo);
- else
- ig.Emit (OpCodes.Stfld, FieldInfo);
+ ig.Emit (OpCodes.Stsfld, GetConstructedFieldInfo ());
+ else
+ ig.Emit (OpCodes.Stfld, GetConstructedFieldInfo ());
if (temp != null) {
temp.Emit (ec);
temp.Release (ec);
+ temp = null;
}
}
Emit (ec, false);
}
+ public override void EmitSideEffect (EmitContext ec)
+ {
+ FieldBase f = TypeManager.GetField (FieldInfo);
+ bool is_volatile = f != null && (f.ModFlags & Modifiers.VOLATILE) != 0;
+
+ if (is_volatile || is_marshal_by_ref ())
+ base.EmitSideEffect (ec);
+ }
+
public void AddressOf (EmitContext ec, AddressOp mode)
{
ILGenerator ig = ec.ig;
if (FieldInfo.IsStatic){
- ig.Emit (OpCodes.Ldsflda, FieldInfo);
+ ig.Emit (OpCodes.Ldsflda, GetConstructedFieldInfo ());
} else {
if (!prepared)
EmitInstance (ec, false);
- ig.Emit (OpCodes.Ldflda, FieldInfo);
+ ig.Emit (OpCodes.Ldflda, GetConstructedFieldInfo ());
}
}
+
+ FieldInfo GetConstructedFieldInfo ()
+ {
+ if (constructed_generic_type == null)
+ return FieldInfo;
+#if GMCS_SOURCE
+ return TypeBuilder.GetField (constructed_generic_type, FieldInfo);
+#else
+ throw new NotSupportedException ();
+#endif
+ }
+
+ public override void MutateHoistedGenericType (AnonymousMethodStorey storey)
+ {
+ FieldInfo = storey.MutateField (FieldInfo);
+ base.MutateHoistedGenericType (storey);
+ }
}
public override Expression CreateExpressionTree (EmitContext ec)
{
+ ArrayList args;
if (IsSingleDimensionalArrayLength ()) {
- ArrayList args = new ArrayList (1);
+ args = new ArrayList (1);
args.Add (new Argument (InstanceExpression.CreateExpressionTree (ec)));
return CreateExpressionFactoryCall ("ArrayLength", args);
}
- // TODO: it's waiting for PropertyExpr refactoring
- //ArrayList args = new ArrayList (2);
- //args.Add (new Argument (InstanceExpression.CreateExpressionTree (ec)));
- //args.Add (getter expression);
- //return CreateExpressionFactoryCall ("Property", args);
- return base.CreateExpressionTree (ec);
+ if (is_base) {
+ Error_BaseAccessInExpressionTree (loc);
+ return null;
+ }
+
+ args = new ArrayList (2);
+ if (InstanceExpression == null)
+ args.Add (new Argument (new NullLiteral (loc)));
+ else
+ args.Add (new Argument (InstanceExpression.CreateExpressionTree (ec)));
+ args.Add (new Argument (new TypeOfMethodInfo (getter, loc)));
+ return CreateExpressionFactoryCall ("Property", args);
}
public Expression CreateSetterTypeOfExpression ()
{
- return new Cast (new TypeExpression (typeof (MethodInfo), loc), new TypeOfMethod (setter, loc));
+ return new TypeOfMethodInfo (setter, loc);
}
public override Type DeclaringType {
}
}
+ public override void MutateHoistedGenericType (AnonymousMethodStorey storey)
+ {
+ if (InstanceExpression != null)
+ InstanceExpression.MutateHoistedGenericType (storey);
+
+ type = storey.MutateType (type);
+ getter = storey.MutateGenericMethod (getter);
+ }
+
bool InstanceResolve (EmitContext ec, bool lvalue_instance, bool must_do_cs1540_check)
{
if (is_static) {
string t_name = InstanceExpression.Type.Name;
int t_name_len = t_name.Length;
- return t_name_len > 2 && t_name [t_name_len - 2] == '[' && t_name [t_name_len - 3] != ']';
+ return t_name_len > 2 && t_name [t_name_len - 2] == '[';
}
override public Expression DoResolve (EmitContext ec)
Expression my_source = source;
if (prepare_for_load) {
- if (source is StringConcat)
- EmitInstance (ec, false);
- else
- prepared = true;
-
+ prepared = true;
source.Emit (ec);
- prepared = true;
if (leave_copy) {
ec.ig.Emit (OpCodes.Dup);
if (!is_static) {
return base.ResolveMemberAccess (ec, left, loc, original);
}
-
bool InstanceResolve (EmitContext ec, bool must_do_cs1540_check)
{
if (is_static) {
public override Expression CreateExpressionTree (EmitContext ec)
{
- throw new NotSupportedException ();
+ throw new NotSupportedException ("ET");
}
public override Expression DoResolveLValue (EmitContext ec, Expression right_side)
{
- return DoResolve (ec);
+ // contexts where an LValue is valid have already devolved to FieldExprs
+ Error_CannotAssign ();
+ return null;
}
public override Expression DoResolve (EmitContext ec)
if (!InstanceResolve (ec, must_do_cs1540_check))
return null;
+
+ if (!ec.IsInCompoundAssignment) {
+ Error_CannotAssign ();
+ return null;
+ }
return this;
}
public override void Emit (EmitContext ec)
{
- Report.Error (70, loc, "The event `{0}' can only appear on the left hand side of += or -= "+
- "(except on the defining type)", GetSignatureForError ());
+ Error_CannotAssign ();
+ }
+
+ public void Error_CannotAssign ()
+ {
+ Report.Error (70, loc,
+ "The event `{0}' can only appear on the left hand side of += or -= when used outside of the type `{1}'",
+ GetSignatureForError (), TypeManager.CSharpName (EventInfo.DeclaringType));
}
public override string GetSignatureForError ()
return TypeManager.CSharpSignature (EventInfo);
}
- public void EmitAddOrRemove (EmitContext ec, Expression source)
+ public void EmitAddOrRemove (EmitContext ec, bool is_add, Expression source)
{
- BinaryDelegate source_del = source as BinaryDelegate;
- if (source_del == null) {
- Emit (ec);
- return;
- }
- Expression handler = source_del.Right;
-
- Argument arg = new Argument (handler, Argument.AType.Expression);
- ArrayList args = new ArrayList ();
-
- args.Add (arg);
-
- if (source_del.IsAddition)
- Invocation.EmitCall (
- ec, IsBase, InstanceExpression, add_accessor, args, loc);
- else
- Invocation.EmitCall (
- ec, IsBase, InstanceExpression, remove_accessor, args, loc);
+ ArrayList args = new ArrayList (1);
+ args.Add (new Argument (source, Argument.AType.Expression));
+ Invocation.EmitCall (ec, IsBase, InstanceExpression, is_add ? add_accessor : remove_accessor, args, loc);
}
}
- public class TemporaryVariable : Expression, IMemoryLocation
+ public class TemporaryVariable : VariableReference
{
LocalInfo li;
- Variable var;
-
+
public TemporaryVariable (Type type, Location loc)
{
this.type = type;
this.loc = loc;
- eclass = ExprClass.Value;
+ eclass = ExprClass.Variable;
}
-
+
+ public override Expression CreateExpressionTree (EmitContext ec)
+ {
+ throw new NotSupportedException ("ET");
+ }
+
public override Expression DoResolve (EmitContext ec)
{
if (li != null)
return this;
-
+
TypeExpr te = new TypeExpression (type, loc);
li = ec.CurrentBlock.AddTemporaryVariable (te, loc);
if (!li.Resolve (ec))
return null;
- if (ec.MustCaptureVariable (li)) {
- ScopeInfo scope = li.Block.CreateScopeInfo ();
- var = scope.AddLocal (li);
- type = var.Type;
+ if (ec.MustCaptureVariable (li) && !ec.IsInProbingMode) {
+ AnonymousMethodStorey storey = li.Block.Explicit.CreateAnonymousMethodStorey (ec);
+ storey.CaptureLocalVariable (ec, li);
}
-
- return this;
- }
- public Variable Variable {
- get { return var != null ? var : li.Variable; }
+ return this;
}
public override void Emit (EmitContext ec)
{
- Variable.EmitInstance (ec);
- Variable.Emit (ec);
+ Emit (ec, false);
}
-
- public void EmitLoadAddress (EmitContext ec)
+
+ public void EmitAssign (EmitContext ec, Expression source)
{
- Variable.EmitInstance (ec);
- Variable.EmitAddressOf (ec);
+ EmitAssign (ec, source, false, false);
}
-
- public void Store (EmitContext ec, Expression right_side)
- {
- Variable.EmitInstance (ec);
- right_side.Emit (ec);
- Variable.EmitAssign (ec);
+
+ public override HoistedVariable HoistedVariable {
+ get { return li.HoistedVariableReference; }
}
-
- public void EmitThis (EmitContext ec)
- {
- Variable.EmitInstance (ec);
+
+ public override bool IsFixed {
+ get { return true; }
}
-
- public void EmitStore (EmitContext ec)
- {
- Variable.EmitAssign (ec);
+
+ public override bool IsRef {
+ get { return false; }
}
-
- public void AddressOf (EmitContext ec, AddressOp mode)
- {
- EmitLoadAddress (ec);
+
+ protected override ILocalVariable Variable {
+ get { return li; }
+ }
+
+ public override VariableInfo VariableInfo {
+ get { throw new NotImplementedException (); }
}
}
}
}
- public override Expression DoResolveLValue (EmitContext ec, Expression right_side)
+ public bool InferType (EmitContext ec, Expression right_side)
{
if (type != null)
throw new InternalErrorException ("An implicitly typed local variable could not be redefined");
if (type == TypeManager.null_type || type == TypeManager.void_type || type == TypeManager.anonymous_method_type) {
Report.Error (815, loc, "An implicitly typed local variable declaration cannot be initialized with `{0}'",
right_side.GetSignatureForError ());
- return null;
+ return false;
}
eclass = ExprClass.Variable;
- return this;
+ return true;
}
protected override void Error_TypeOrNamespaceNotFound (IResolveContext ec)