Tue Nov 14 16:06:37 CET 2006 Paolo Molaro <lupus@ximian.com>
[mono.git] / mcs / mcs / doc.cs
index e7c4b259a0d2f6b30f9ef5b6cbb0f34297cedbed..90a9d1bb66f255d215ffcb3c66916412a5f54c0c 100644 (file)
@@ -9,7 +9,6 @@
 // (C) 2004 Novell, Inc.
 //
 //
-
 #if ! BOOTSTRAP_WITH_OLDLIB
 using System;
 using System.Collections;
@@ -31,8 +30,16 @@ namespace Mono.CSharp {
        //
        // Support class for XML documentation.
        //
+#if NET_2_0
+       static
+#else
+       abstract
+#endif
        public class DocUtil
        {
+#if !NET_2_0
+               private DocUtil () {}
+#endif
                // TypeContainer
 
                //
@@ -55,15 +62,9 @@ namespace Mono.CSharp {
                                foreach (TypeContainer tc in t.Types)
                                        tc.GenerateDocComment (t);
 
-                       if (t.Parts != null) {
-                               IDictionary comments = RootContext.Documentation.PartialComments;
-                               foreach (ClassPart cp in t.Parts) {
-                                       if (cp.DocComment == null)
-                                               continue;
-                                       comments [cp] = cp;
-                               }
-                       }
-
+                       if (t.Delegates != null)
+                               foreach (Delegate de in t.Delegates)
+                                       de.GenerateDocComment (t);
                        if (t.Enums != null)
                                foreach (Enum en in t.Enums)
                                        en.GenerateDocComment (t);
@@ -151,11 +152,19 @@ namespace Mono.CSharp {
 
                                XmlElement el = n as XmlElement;
                                if (el != null) {
-                                       mc.OnGenerateDocComment (ds, el);
+                                       mc.OnGenerateDocComment (el);
 
                                        // FIXME: it could be done with XmlReader
-                                       foreach (XmlElement inc in n.SelectNodes (".//include"))
-                                               HandleInclude (mc, inc);
+                                       XmlNodeList nl = n.SelectNodes (".//include");
+                                       if (nl.Count > 0) {
+                                               // It could result in current node removal, so prepare another list to iterate.
+                                               ArrayList al = new ArrayList (nl.Count);
+                                               foreach (XmlNode inc in nl)
+                                                       al.Add (inc);
+                                               foreach (XmlElement inc in al)
+                                                       if (!HandleInclude (mc, inc))
+                                                               inc.ParentNode.RemoveChild (inc);
+                                       }
 
                                        // FIXME: it could be done with XmlReader
                                        DeclSpace dsTarget = mc as DeclSpace;
@@ -172,7 +181,7 @@ namespace Mono.CSharp {
 
                                n.WriteTo (RootContext.Documentation.XmlCommentOutput);
                        }
-                       else if (mc.IsExposedFromAssembly (ds)) {
+                       else if (mc.IsExposedFromAssembly ()) {
                                Constructor c = mc as Constructor;
                                if (c == null || !c.IsDefault ())
                                        Report.Warning (1591, 4, mc.Location,
@@ -184,17 +193,20 @@ namespace Mono.CSharp {
                // Processes "include" element. Check included file and
                // embed the document content inside this documentation node.
                //
-               private static void HandleInclude (MemberCore mc, XmlElement el)
+               private static bool HandleInclude (MemberCore mc, XmlElement el)
                {
+                       bool keepIncludeNode = false;
                        string file = el.GetAttribute ("file");
                        string path = el.GetAttribute ("path");
                        if (file == "") {
                                Report.Warning (1590, 1, mc.Location, "Invalid XML `include' element. Missing `file' attribute");
                                el.ParentNode.InsertBefore (el.OwnerDocument.CreateComment (" Include tag is invalid "), el);
+                               keepIncludeNode = true;
                        }
-                       else if (path == "") {
+                       else if (path.Length == 0) {
                                Report.Warning (1590, 1, mc.Location, "Invalid XML `include' element. Missing `path' attribute");
                                el.ParentNode.InsertBefore (el.OwnerDocument.CreateComment (" Include tag is invalid "), el);
+                               keepIncludeNode = true;
                        }
                        else {
                                XmlDocument doc = RootContext.Documentation.StoredDocuments [file] as XmlDocument;
@@ -208,7 +220,6 @@ namespace Mono.CSharp {
                                                Report.Warning (1592, 1, mc.Location, "Badly formed XML in included comments file -- `{0}'", file);
                                        }
                                }
-                               bool keepIncludeNode = false;
                                if (doc != null) {
                                        try {
                                                XmlNodeList nl = doc.SelectNodes (path);
@@ -224,9 +235,8 @@ namespace Mono.CSharp {
                                                Report.Warning (1589, 1, mc.Location, "Unable to include XML fragment `{0}' of file `{1}' ({2})", path, file, ex.Message);
                                        }
                                }
-                               if (!keepIncludeNode)
-                                       el.ParentNode.RemoveChild (el);
                        }
+                       return keepIncludeNode;
                }
 
                //
@@ -351,7 +361,7 @@ namespace Mono.CSharp {
                        if (ml == null)
                                return empty_member_infos;
 
-                       return FilterOverridenMembersOut (type, (MemberInfo []) ml);
+                       return FilterOverridenMembersOut ((MemberInfo []) ml);
                }
 
                static bool IsOverride (PropertyInfo deriv_prop, PropertyInfo base_prop)
@@ -379,7 +389,7 @@ namespace Mono.CSharp {
                }
 
                private static MemberInfo [] FilterOverridenMembersOut (
-                       Type type, MemberInfo [] ml)
+                       MemberInfo [] ml)
                {
                        if (ml == null)
                                return empty_member_infos;
@@ -474,7 +484,7 @@ namespace Mono.CSharp {
                                        type, MemberTypes.All,
                                        BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Static | BindingFlags.Instance,
                                        memberName, null);
-                               mis = FilterOverridenMembersOut (type, mis);
+                               mis = FilterOverridenMembersOut (mis);
                                if (mis == null || mis.Length == 0)
                                        return null;
                                if (warn419 && IsAmbiguous (mis))
@@ -699,18 +709,12 @@ namespace Mono.CSharp {
                                // delegate must not be referenced with args
                                && (!type.IsSubclassOf (typeof (System.Delegate))
                                || parameterTypes == null)) {
-                               string result = type.FullName.Replace ("+", ".")
+                               string result = GetSignatureForDoc (type)
                                        + (bracePos < 0 ? String.Empty : signature.Substring (bracePos));
                                xref.SetAttribute ("cref", "T:" + result);
                                return; // a type
                        }
 
-                       // don't use identifier here. System[] is not alloed.
-                       if (RootNamespace.Global.IsNamespace (name)) {
-                               xref.SetAttribute ("cref", "N:" + name);
-                               return; // a namespace
-                       }
-
                        int period = name.LastIndexOf ('.');
                        if (period > 0) {
                                string typeName = name.Substring (0, period);
@@ -728,7 +732,7 @@ namespace Mono.CSharp {
                                                // to get its name, since mi
                                                // could be from DeclaringType
                                                // for nested types.
-                                               xref.SetAttribute ("cref", GetMemberDocHead (mi.MemberType) + fm.Type.FullName.Replace ("+", ".") + "." + memberName + GetParametersFormatted (mi));
+                                               xref.SetAttribute ("cref", GetMemberDocHead (mi.MemberType) + GetSignatureForDoc (fm.Type) + "." + memberName + GetParametersFormatted (mi));
                                                return; // a member of a type
                                        }
                                }
@@ -744,11 +748,22 @@ namespace Mono.CSharp {
                                        // to get its name, since mi
                                        // could be from DeclaringType
                                        // for nested types.
-                                       xref.SetAttribute ("cref", GetMemberDocHead (mi.MemberType) + fm.Type.FullName.Replace ("+", ".") + "." + name + GetParametersFormatted (mi));
+                                       xref.SetAttribute ("cref", GetMemberDocHead (mi.MemberType) + GetSignatureForDoc (fm.Type) + "." + name + GetParametersFormatted (mi));
                                        return; // local member name
                                }
                        }
 
+                       // It still might be part of namespace name.
+                       Namespace ns = ds.NamespaceEntry.NS.GetNamespace (name, false);
+                       if (ns != null) {
+                               xref.SetAttribute ("cref", "N:" + ns.FullName);
+                               return; // a namespace
+                       }
+                       if (RootNamespace.Global.IsNamespace (name)) {
+                               xref.SetAttribute ("cref", "N:" + name);
+                               return; // a namespace
+                       }
+
                        Report.Warning (1574, 1, mc.Location, "XML comment on `{0}' has cref attribute `{1}' that could not be resolved",
                                mc.GetSignatureForError (), cref);
 
@@ -782,7 +797,7 @@ namespace Mono.CSharp {
                                if (i > 0)
                                        sb.Append (',');
                                Type t = parameters.ParameterType (i);
-                               sb.Append (t.FullName.Replace ('+', '.').Replace ('&', '@'));
+                               sb.Append (GetSignatureForDoc (t));
                        }
                        sb.Append (')');
                        return sb.ToString ();
@@ -848,7 +863,7 @@ namespace Mono.CSharp {
                                StringBuilder psb = new StringBuilder ();
                                foreach (Parameter p in plist) {
                                        psb.Append (psb.Length != 0 ? "," : "(");
-                                       psb.Append (p.ExternalType ().FullName.Replace ("+", ".").Replace ('&', '@'));
+                                       psb.Append (GetSignatureForDoc (p.ExternalType ()));
                                }
                                paramSpec = psb.ToString ();
                        }
@@ -863,13 +878,20 @@ namespace Mono.CSharp {
                                switch (op.OperatorType) {
                                case Operator.OpType.Implicit:
                                case Operator.OpType.Explicit:
-                                       suffix = "~" + op.OperatorMethodBuilder.ReturnType.FullName.Replace ('+', '.');
+                                       suffix = "~" + GetSignatureForDoc (op.MethodBuilder.ReturnType);
                                        break;
                                }
                        }
                        return String.Concat (mc.DocCommentHeader, ds.Name, ".", name, paramSpec, suffix);
                }
 
+               static string GetSignatureForDoc (Type type)
+               {
+                       return TypeManager.IsGenericParameter (type) ?
+                               "`" + TypeManager.GenericParameterPosition (type) :
+                               type.FullName.Replace ("+", ".").Replace ('&', '@');
+               }
+
                //
                // Raised (and passed an XmlElement that contains the comment)
                // when GenerateDocComment is writing documentation expectedly.
@@ -878,13 +900,13 @@ namespace Mono.CSharp {
                // that means removal of DOM use.
                //
                internal static void OnMethodGenerateDocComment (
-                       MethodCore mc, DeclSpace ds, XmlElement el)
+                       MethodCore mc, XmlElement el)
                {
                        Hashtable paramTags = new Hashtable ();
                        foreach (XmlElement pelem in el.SelectNodes ("param")) {
                                int i;
                                string xname = pelem.GetAttribute ("name");
-                               if (xname == "")
+                               if (xname.Length == 0)
                                        continue; // really? but MS looks doing so
                                if (xname != "" && mc.Parameters.GetParameterByName (xname, out i) == null)
                                        Report.Warning (1572, 2, mc.Location, "XML comment on `{0}' has a param tag for `{1}', but there is no parameter by that name",
@@ -967,13 +989,6 @@ namespace Mono.CSharp {
                //
                public Hashtable StoredDocuments = new Hashtable ();
 
-               //
-               // Stores comments on partial types (should handle uniquely).
-               // Keys are PartialContainers, values are comment strings
-               // (didn't use StringBuilder; usually we have just 2 or more).
-               //
-               public IDictionary PartialComments = new ListDictionary ();
-
                //
                // Outputs XML documentation comment from tokenized comments.
                //
@@ -1013,7 +1028,7 @@ namespace Mono.CSharp {
                //
                public void GenerateDocComment ()
                {
-                       TypeContainer root = RootContext.Tree.Types;
+                       TypeContainer root = RootContext.ToplevelTypes;
                        if (root.Interfaces != null)
                                foreach (Interface i in root.Interfaces) 
                                        DocUtil.GenerateTypeDocComment (i, null);
@@ -1022,15 +1037,6 @@ namespace Mono.CSharp {
                                foreach (TypeContainer tc in root.Types)
                                        DocUtil.GenerateTypeDocComment (tc, null);
 
-                       if (root.Parts != null) {
-                               IDictionary comments = PartialComments;
-                               foreach (ClassPart cp in root.Parts) {
-                                       if (cp.DocComment == null)
-                                               continue;
-                                       comments [cp] = cp;
-                               }
-                       }
-
                        if (root.Delegates != null)
                                foreach (Delegate d in root.Delegates) 
                                        DocUtil.GenerateDocComment (d, null);
@@ -1039,18 +1045,7 @@ namespace Mono.CSharp {
                                foreach (Enum e in root.Enums)
                                        e.GenerateDocComment (null);
 
-                       IDictionary table = new ListDictionary ();
-                       foreach (ClassPart cp in PartialComments.Keys) {
-                               // FIXME: IDictionary does not guarantee that the keys will be
-                               //        accessed in the order they were added.
-                               table [cp.PartialContainer] += cp.DocComment;
-                       }
-                       foreach (PartialContainer pc in table.Keys) {
-                               pc.DocComment = table [pc] as string;
-                               DocUtil.GenerateDocComment (pc, null);
-                       }
                }
        }
 }
-
 #endif