namespace Mono.CSharp {
+ public class MemberName {
+ public string Name;
+ public readonly MemberName Left;
+
+ public static readonly MemberName Null = new MemberName ("");
+
+ public MemberName (string name)
+ {
+ this.Name = name;
+ }
+
+ public MemberName (MemberName left, string name)
+ : this (name)
+ {
+ this.Left = left;
+ }
+
+ public MemberName (MemberName left, MemberName right)
+ : this (left, right.Name)
+ {
+ }
+
+ public string GetName ()
+ {
+ return GetName (false);
+ }
+
+ public string GetName (bool is_generic)
+ {
+ string name = is_generic ? Basename : Name;
+ if (Left != null)
+ return Left.GetName (is_generic) + "." + name;
+ else
+ return name;
+ }
+
+ public string GetFullName ()
+ {
+ if (Left != null)
+ return Left.GetFullName () + "." + Name;
+ else
+ return Name;
+ }
+
+ public string GetTypeName ()
+ {
+ if (Left != null)
+ return Left.GetTypeName () + "." + Name;
+ else
+ return Name;
+ }
+
+ public Expression GetTypeExpression (Location loc)
+ {
+ if (Left != null) {
+ Expression lexpr = Left.GetTypeExpression (loc);
+
+ return new MemberAccess (lexpr, Name, loc);
+ } else {
+ return new SimpleName (Name, loc);
+ }
+ }
+
+ public MemberName Clone ()
+ {
+ if (Left != null)
+ return new MemberName (Left.Clone (), Name);
+ else
+ return new MemberName (Name);
+ }
+
+ public string Basename {
+ get {
+ return Name;
+ }
+ }
+
+ public override string ToString ()
+ {
+ return GetFullName ();
+ }
+ }
+
/// <summary>
/// Base representation for members. This is used to keep track
/// of Name, Location and Modifier flags, and handling Attributes.
/// <summary>
/// Public name
/// </summary>
- public string Name;
+ public string Name {
+ get {
+ // !(this is GenericMethod) && !(this is Method)
+ return MemberName.GetName (false);
+ }
+ }
+
+ public readonly MemberName MemberName;
/// <summary>
/// Modifier flags that the user specified in the source code
HasClsCompliantAttribute = 1 << 6, // Type has CLSCompliantAttribute
ClsCompliantAttributeTrue = 1 << 7, // Type has CLSCompliant (true)
Excluded_Undetected = 1 << 8, // Conditional attribute has not been detected yet
- Excluded = 1 << 9 // Method is conditional
-
+ Excluded = 1 << 9, // Method is conditional
+ TestMethodDuplication = 1 << 10 // Test for duplication must be performed
}
/// <summary>
/// MemberCore flags at first detected then cached
/// </summary>
- protected Flags caching_flags;
+ internal Flags caching_flags;
- public MemberCore (TypeContainer parent, string name, Attributes attrs,
+ public MemberCore (TypeContainer parent, MemberName name, Attributes attrs,
Location loc)
: base (attrs)
{
Parent = parent;
- Name = name;
+ MemberName = name;
Location = loc;
caching_flags = Flags.Obsolete_Undetected | Flags.ClsCompliance_Undetected | Flags.HasCompliantAttribute_Undetected | Flags.Excluded_Undetected;
}
return Name;
}
+ /// <summary>
+ /// Use this method when MethodBuilder is null
+ /// </summary>
+ public virtual string GetSignatureForError (TypeContainer tc)
+ {
+ return Name;
+ }
+
/// <summary>
/// Base Emit method. This is also entry point for CLS-Compliant verification.
/// </summary>
public virtual void Emit ()
{
- VerifyObsoleteAttribute ();
+ // Hack with Parent == null is for EnumMember
+ if (Parent == null || (GetObsoleteAttribute (Parent) == null && Parent.GetObsoleteAttribute (Parent) == null))
+ VerifyObsoleteAttribute ();
if (!RootContext.VerifyClsCompliance)
return;
}
}
- /// <summary>
- /// This method is used to testing error 3005 (Method or parameter name collision).
- /// </summary>
- protected abstract bool IsIdentifierClsCompliant (DeclSpace ds);
-
- /// <summary>
- /// Common helper method for identifier and parameters CLS-Compliant testing.
- /// When return false error 3005 is reported. True means no violation.
- /// And error 3006 tests are peformed here because of speed.
- /// </summary>
- protected bool IsIdentifierAndParamClsCompliant (DeclSpace ds, string name, MemberInfo methodBuilder, Type[] paramTypes)
- {
- MemberList ml = ds.FindMembers (MemberTypes.Event | MemberTypes.Field | MemberTypes.Method | MemberTypes.Property,
- BindingFlags.Public | BindingFlags.Static | BindingFlags.Instance, System.Type.FilterNameIgnoreCase, name);
-
- if (ml.Count < 2)
- return true;
-
- bool error3006 = false;
- for (int i = 0; i < ml.Count; ++i) {
- MemberInfo mi = ml [i];
- if (name == mi.Name) {
- MethodBase method = mi as MethodBase;
- if (method == null || method == methodBuilder || paramTypes == null || paramTypes.Length == 0)
- continue;
-
- if (AttributeTester.AreOverloadedMethodParamsClsCompliant (paramTypes, TypeManager.GetArgumentTypes (method))) {
- error3006 = false;
- continue;
- }
-
- error3006 = true;
- }
-
- // We need to test if member is not marked as CLSCompliant (false) and if type is not only internal
- // because BindingFlags.Public returns internal types too
- DeclSpace temp_ds = TypeManager.LookupDeclSpace (mi.DeclaringType);
-
- // Type is external, we can get attribute directly
- if (temp_ds == null) {
- object[] cls_attribute = mi.GetCustomAttributes (TypeManager.cls_compliant_attribute_type, false);
- if (cls_attribute.Length == 1 && (!((CLSCompliantAttribute)cls_attribute[0]).IsCompliant))
- continue;
- } else {
- string tmp_name = String.Concat (temp_ds.Name, '.', mi.Name);
-
- MemberCore mc = temp_ds.GetDefinition (tmp_name) as MemberCore;
- if (!mc.IsClsCompliaceRequired (ds))
- continue;
- }
-
- for (int ii = 0; ii < ml.Count; ++ii) {
- mi = ml [ii];
- if (name == mi.Name)
- continue;
- Report.SymbolRelatedToPreviousError (mi);
- }
-
- if (error3006)
- Report.Error_T (3006, Location, GetSignatureForError ());
-
- return error3006;
-
- }
- return true;
- }
/// <summary>
/// The main virtual method for CLS-Compliant verifications.
protected virtual bool VerifyClsCompliance (DeclSpace ds)
{
if (!IsClsCompliaceRequired (ds)) {
- if (HasClsCompliantAttribute && !IsExposedFromAssembly (ds)) {
- Report.Warning_T (3019, Location, GetSignatureForError ());
+ if ((RootContext.WarningLevel >= 2) && HasClsCompliantAttribute && !IsExposedFromAssembly (ds)) {
+ Report.Warning (3019, Location, "CLS compliance checking will not be performed on '{0}' because it is private or internal", GetSignatureForError ());
}
return false;
}
if (!CodeGen.Assembly.IsClsCompliant) {
if (HasClsCompliantAttribute) {
- Report.Error_T (3014, Location, GetSignatureForError ());
+ Report.Error (3014, Location, "'{0}' cannot be marked as CLS-compliant because the assembly does not have a CLSCompliant attribute", GetSignatureForError ());
}
+ return false;
}
int index = Name.LastIndexOf ('.');
if (Name [index > 0 ? index + 1 : 0] == '_') {
- Report.Error_T (3008, Location, GetSignatureForError () );
- }
-
- if (!IsIdentifierClsCompliant (ds)) {
- Report.Error_T (3005, Location, GetSignatureForError ());
+ Report.Error (3008, Location, "Identifier '{0}' is not CLS-compliant", GetSignatureForError () );
}
-
return true;
}
public string Basename;
- /// <summary>
- /// defined_names is used for toplevel objects
- /// </summary>
protected Hashtable defined_names;
static string[] attribute_targets = new string [] { "type" };
- public DeclSpace (NamespaceEntry ns, TypeContainer parent, string name, Attributes attrs, Location l)
+ public DeclSpace (NamespaceEntry ns, TypeContainer parent, MemberName name,
+ Attributes attrs, Location l)
: base (parent, name, attrs, l)
{
NamespaceEntry = ns;
- Basename = name.Substring (1 + name.LastIndexOf ('.'));
+ Basename = name.Name;
defined_names = new Hashtable ();
}
- public void RecordDecl ()
- {
- if ((NamespaceEntry != null) && (Parent == RootContext.Tree.Types))
- NamespaceEntry.DefineName (Basename, this);
- }
-
/// <summary>
- /// The result value from adding an declaration into
- /// a struct or a class
+ /// Adds the member to defined_names table. It tests for duplications and enclosing name conflicts
/// </summary>
- public enum AdditionResult {
- /// <summary>
- /// The declaration has been successfully
- /// added to the declation space.
- /// </summary>
- Success,
-
- /// <summary>
- /// The symbol has already been defined.
- /// </summary>
- NameExists,
-
- /// <summary>
- /// Returned if the declation being added to the
- /// name space clashes with its container name.
- ///
- /// The only exceptions for this are constructors
- /// and static constructors
- /// </summary>
- EnclosingClash,
-
- /// <summary>
- /// Returned if a constructor was created (because syntactically
- /// it looked like a constructor) but was not (because the name
- /// of the method is not the same as the container class
- /// </summary>
- NotAConstructor,
-
- /// <summary>
- /// This is only used by static constructors to emit the
- /// error 111, but this error for other things really
- /// happens at another level for other functions.
- /// </summary>
- MethodExists,
-
- /// <summary>
- /// Some other error.
- /// </summary>
- Error
- }
-
- /// <summary>
- /// Returns a status code based purely on the name
- /// of the member being added
- /// </summary>
- protected AdditionResult IsValid (string basename, string name)
+ protected bool AddToContainer (MemberCore symbol, bool is_method, string fullname, string basename)
{
- if (basename == Basename)
- return AdditionResult.EnclosingClash;
+ if (basename == Basename) {
+ Report.SymbolRelatedToPreviousError (this);
+ Report.Error (542, "'{0}': member names cannot be the same as their enclosing type", symbol.Location, symbol.GetSignatureForError ());
+ return false;
+ }
- if (defined_names.Contains (name))
- return AdditionResult.NameExists;
+ MemberCore mc = (MemberCore)defined_names [fullname];
- return AdditionResult.Success;
+ if (is_method && (mc is MethodCore || mc is IMethodData)) {
+ symbol.caching_flags |= Flags.TestMethodDuplication;
+ mc.caching_flags |= Flags.TestMethodDuplication;
+ return true;
+ }
+
+ if (mc != null) {
+ Report.SymbolRelatedToPreviousError (mc);
+ Report.Error (102, symbol.Location, "The type '{0}' already contains a definition for '{1}'", GetSignatureForError (), basename);
+ return false;
+ }
+
+ defined_names.Add (fullname, symbol);
+ return true;
}
- public static int length;
- public static int small;
-
- /// <summary>
- /// Introduce @name into this declaration space and
- /// associates it with the object @o. Note that for
- /// methods this will just point to the first method. o
- /// </summary>
- public void DefineName (string name, object o)
+ public void RecordDecl ()
{
- defined_names.Add (name, o);
-
-#if DEBUGME
- int p = name.LastIndexOf ('.');
- int l = name.Length;
- length += l;
- small += l -p;
-#endif
+ if ((NamespaceEntry != null) && (Parent == RootContext.Tree.Types))
+ NamespaceEntry.DefineName (MemberName.Basename, this);
}
/// <summary>
- /// Returns the object associated with a given name in the declaration
- /// space. This is the inverse operation of `DefineName'
+ /// Returns the MemberCore associated with a given name in the declaration
+ /// space. It doesn't return method based symbols !!
/// </summary>
- public object GetDefinition (string name)
+ ///
+ public MemberCore GetDefinition (string name)
{
- return defined_names [name];
+ return (MemberCore)defined_names [name];
}
bool in_transit = false;
}
if (!d.CheckAccessLevel (this)) {
- Report.Error_T (122, loc, d.Name);
+ Report.Error (122, loc, "'{0}' is inaccessible due to its protection level", d.Name);
return null;
}
return false;
}
-
- // Tests container name for CLS-Compliant name (differing only in case)
- // Possible optimalization: search in same namespace only
- protected override bool IsIdentifierClsCompliant (DeclSpace ds)
- {
- int l = Name.Length;
-
- if (Namespace.LookupNamespace (NamespaceEntry.FullName, false) != null) {
- // Seek through all imported types
- foreach (string type_name in TypeManager.all_imported_types.Keys)
- {
- if (l != type_name.Length)
- continue;
-
- if (String.Compare (Name, type_name, true, CultureInfo.InvariantCulture) == 0 &&
- AttributeTester.IsClsCompliant (TypeManager.all_imported_types [type_name] as Type)) {
- Report.SymbolRelatedToPreviousError ((Type)TypeManager.all_imported_types [type_name]);
- return false;
- }
- }
- }
-
- // Seek through generated types
- foreach (string name in RootContext.Tree.Decls.Keys) {
- if (l != name.Length)
- continue;
-
- if (String.Compare (Name, name, true, CultureInfo.InvariantCulture) == 0) {
-
- if (Name == name)
- continue;
-
- DeclSpace found_ds = RootContext.Tree.Decls[name] as DeclSpace;
- if (found_ds.IsClsCompliaceRequired (found_ds.Parent)) {
- Report.SymbolRelatedToPreviousError (found_ds.Location, found_ds.GetSignatureForError ());
- return false;
- }
- }
- }
-
- return true;
- }
-
- protected override string[] ValidAttributeTargets {
+ public override string[] ValidAttributeTargets {
get {
return attribute_targets;
}
/// This is used when creating the member cache for a class to get all
/// members from the parent class.
/// </summary>
- IMemberContainer Parent {
+ IMemberContainer ParentContainer {
get;
}
if (Container.IsInterface) {
MemberCache parent;
- if (Container.Parent != null)
- parent = Container.Parent.MemberCache;
+ if (Container.ParentContainer != null)
+ parent = Container.ParentContainer.MemberCache;
else
parent = TypeHandle.ObjectType.MemberCache;
member_hash = SetupCacheForInterface (parent);
- } else if (Container.Parent != null)
- member_hash = SetupCache (Container.Parent.MemberCache);
+ } else if (Container.ParentContainer != null)
+ member_hash = SetupCache (Container.ParentContainer.MemberCache);
else
member_hash = new Hashtable ();
return null;
}
+
+ /// <summary>
+ /// The method is looking for conflict with inherited symbols (errors CS0108, CS0109).
+ /// We handle two cases. The first is for types without parameters (events, field, properties).
+ /// The second are methods, indexers and this is why ignore_complex_types is here.
+ /// The latest param is temporary hack. See DoDefineMembers method for more info.
+ /// </summary>
+ public MemberInfo FindMemberWithSameName (string name, bool ignore_complex_types, MemberInfo ignore_member)
+ {
+ ArrayList applicable = null;
+
+ if (method_hash != null)
+ applicable = (ArrayList) method_hash [name];
+
+ if (applicable != null) {
+ for (int i = applicable.Count - 1; i >= 0; i--) {
+ CacheEntry entry = (CacheEntry) applicable [i];
+ if ((entry.EntryType & EntryType.Public) != 0)
+ return entry.Member;
+ }
+ }
+
+ if (member_hash == null)
+ return null;
+ applicable = (ArrayList) member_hash [name];
+
+ if (applicable != null) {
+ for (int i = applicable.Count - 1; i >= 0; i--) {
+ CacheEntry entry = (CacheEntry) applicable [i];
+ if ((entry.EntryType & EntryType.Public) != 0 & entry.Member != ignore_member) {
+ if (ignore_complex_types) {
+ if ((entry.EntryType & EntryType.Method) != 0)
+ continue;
+
+ // Does exist easier way how to detect indexer ?
+ if ((entry.EntryType & EntryType.Property) != 0) {
+ Type[] arg_types = TypeManager.GetArgumentTypes ((PropertyInfo)entry.Member);
+ if (arg_types.Length > 0)
+ continue;
+ }
+ }
+ return entry.Member;
+ }
+ }
+ }
+ return null;
+ }
+
+ Hashtable locase_table;
+
+ /// <summary>
+ /// Builds low-case table for CLS Compliance test
+ /// </summary>
+ public Hashtable GetPublicMembers ()
+ {
+ if (locase_table != null)
+ return locase_table;
+
+ locase_table = new Hashtable ();
+ foreach (DictionaryEntry entry in member_hash) {
+ ArrayList members = (ArrayList)entry.Value;
+ for (int ii = 0; ii < members.Count; ++ii) {
+ CacheEntry member_entry = (CacheEntry) members [ii];
+
+ if ((member_entry.EntryType & EntryType.Public) == 0)
+ continue;
+
+ // TODO: Does anyone know easier way how to detect that member is internal ?
+ switch (member_entry.EntryType & EntryType.MaskType) {
+ case EntryType.Constructor:
+ continue;
+
+ case EntryType.Field:
+ if ((((FieldInfo)member_entry.Member).Attributes & (FieldAttributes.Assembly | FieldAttributes.Public)) == FieldAttributes.Assembly)
+ continue;
+ break;
+
+ case EntryType.Method:
+ if ((((MethodInfo)member_entry.Member).Attributes & (MethodAttributes.Assembly | MethodAttributes.Public)) == MethodAttributes.Assembly)
+ continue;
+ break;
+
+ case EntryType.Property:
+ PropertyInfo pi = (PropertyInfo)member_entry.Member;
+ if (pi.GetSetMethod () == null && pi.GetGetMethod () == null)
+ continue;
+ break;
+
+ case EntryType.Event:
+ EventInfo ei = (EventInfo)member_entry.Member;
+ MethodInfo mi = ei.GetAddMethod ();
+ if ((mi.Attributes & (MethodAttributes.Assembly | MethodAttributes.Public)) == MethodAttributes.Assembly)
+ continue;
+ break;
+ }
+ string lcase = ((string)entry.Key).ToLower (System.Globalization.CultureInfo.InvariantCulture);
+ locase_table [lcase] = member_entry.Member;
+ break;
+ }
+ }
+ return locase_table;
+ }
+
+ public Hashtable Members {
+ get {
+ return member_hash;
+ }
+ }
+
+ /// <summary>
+ /// Cls compliance check whether methods or constructors parameters differing only in ref or out, or in array rank
+ /// </summary>
+ public void VerifyClsParameterConflict (ArrayList al, MethodCore method, MemberInfo this_builder)
+ {
+ EntryType tested_type = (method is Constructor ? EntryType.Constructor : EntryType.Method) | EntryType.Public;
+
+ for (int i = 0; i < al.Count; ++i) {
+ MemberCache.CacheEntry entry = (MemberCache.CacheEntry) al [i];
+
+ // skip itself
+ if (entry.Member == this_builder)
+ continue;
+
+ if ((entry.EntryType & tested_type) != tested_type)
+ continue;
+
+ MethodBase method_to_compare = (MethodBase)entry.Member;
+ if (AttributeTester.AreOverloadedMethodParamsClsCompliant (method.ParameterTypes, TypeManager.GetArgumentTypes (method_to_compare)))
+ continue;
+
+ IMethodData md = TypeManager.GetMethod (method_to_compare);
+
+ // TODO: now we are ignoring CLSCompliance(false) on method from other assembly which is buggy.
+ // However it is exactly what csc does.
+ if (md != null && !md.IsClsCompliaceRequired (method.Parent))
+ continue;
+
+ Report.SymbolRelatedToPreviousError (entry.Member);
+ Report.Error (3006, method.Location, "Overloaded method '{0}' differing only in ref or out, or in array rank, is not CLS-compliant", method.GetSignatureForError ());
+ }
+ }
}
}
projects / mono.git / blobdiff