Committing Miguel's type lookup patch.
[mono.git] / mcs / mcs / class.cs
index 014c900c5c40a377fd02a519ba881a9bc43e9c37..584826ba5b49a3117db292b1ff6cee00f969bb5a 100755 (executable)
@@ -281,13 +281,13 @@ namespace Mono.CSharp {
                {
                        AdditionResult res;
                        string name = field.Name;
-                       
+
                        if ((res = IsValid (name)) != AdditionResult.Success)
                                return res;
-
+                       
                        if (fields == null)
                                fields = new ArrayList ();
-
+                       
                        fields.Add (field);
                        
                        if (field.Initializer != null){
@@ -312,7 +312,7 @@ namespace Mono.CSharp {
 
                        if ((field.ModFlags & Modifiers.STATIC) == 0)
                                have_nonstatic_fields = true;
-                       
+
                        DefineName (name, field);
                        return AdditionResult.Success;
                }
@@ -429,6 +429,10 @@ namespace Mono.CSharp {
                        get {
                                return fields;
                        }
+
+                       set {
+                               fields = value;
+                       }
                }
 
                public ArrayList InstanceConstructors {
@@ -518,9 +522,7 @@ namespace Mono.CSharp {
                                if (init is Expression)
                                        e = (Expression) init;
                                else {
-                                       string base_type = f.Type.Substring (0, f.Type.IndexOf ("["));
-                                       string rank = f.Type.Substring (f.Type.IndexOf ("["));
-                                       e = new ArrayCreation (base_type, rank, (ArrayList)init, f.Location);
+                                       e = new ArrayCreation (f.Type, "", (ArrayList)init, f.Location);
                                }
 
                                Location l = f.Location;
@@ -630,14 +632,16 @@ namespace Mono.CSharp {
                        count = bases.Count;
 
                        if (is_class){
-                               string name = (string) bases [0];
-                               Type first = FindType (name);
+                               Expression name = (Expression) bases [0];
+                               name = ResolveTypeExpr (name, false, Location);
 
-                               if (first == null){
+                               if (name == null){
                                        error = true;
                                        return null;
                                }
 
+                               Type first = name.Type;
+
                                if (first.IsClass){
                                        parent = first;
                                        start = 1;
@@ -653,8 +657,10 @@ namespace Mono.CSharp {
                        Type [] ifaces = new Type [count-start];
                        
                        for (i = start, j = 0; i < count; i++, j++){
-                               string name = (string) bases [i];
-                               Type t = FindType (name);
+                               Expression name = (Expression) bases [i];
+                               Expression resolved = ResolveTypeExpr (name, false, Location);
+                               bases [i] = resolved;
+                               Type t = resolved.Type;
 
                                if (t == null){
                                        error = true;
@@ -795,6 +801,12 @@ namespace Mono.CSharp {
                                }
                        }
 
+                       // add interfaces that were not added at type creation (weird API issue)
+                       if (!is_class && !have_nonstatic_fields && (ifaces != null)) {
+                               foreach (Type i in ifaces)
+                                       TypeBuilder.AddInterfaceImplementation (i);
+                       }
+                       
                        //
                        // Finish the setup for the EmitContext
                        //
@@ -1015,17 +1027,6 @@ namespace Mono.CSharp {
                        return true;
                }
 
-               /// <summary>
-               ///   Looks up the alias for the name
-               /// </summary>
-               public string LookupAlias (string name)
-               {
-                       if (Namespace != null)
-                               return Namespace.LookupAlias (name);
-                       else
-                               return null;
-               }
-               
                /// <summary>
                ///   This function is based by a delegate to the FindMembers routine
                /// </summary>
@@ -1079,7 +1080,7 @@ namespace Mono.CSharp {
 
                        if (filter == null)
                                filter = accepting_filter; 
-                       
+
                        if ((mt & MemberTypes.Field) != 0) {
                                if (fields != null) {
                                        foreach (Field f in fields) {
@@ -1191,17 +1192,32 @@ namespace Mono.CSharp {
                        }
                        
                        if ((mt & MemberTypes.NestedType) != 0) {
+                               if (types != null){
+                                       foreach (TypeContainer t in types) {
+                                               TypeBuilder tb = t.TypeBuilder;
 
-                               if (Types != null)
-                                       foreach (TypeContainer t in Types)  
-                                               if (filter (t.TypeBuilder, criteria) == true)
-                                                       members.Add (t.TypeBuilder);
+                                               if (tb != null && (filter (tb, criteria) == true))
+                                                               members.Add (tb);
+                                       }
+                               }
 
-                               if (Enums != null)
-                                       foreach (Enum en in Enums)
-                                               if (filter (en.TypeBuilder, criteria) == true)
-                                                       members.Add (en.TypeBuilder);
+                               if (enums != null){
+                                       foreach (Enum en in enums){
+                                               TypeBuilder tb = en.TypeBuilder;
+
+                                               if (tb != null && (filter (tb, criteria) == true))
+                                                       members.Add (tb);
+                                       }
+                               }
                                
+                               if (delegates != null){
+                                       foreach (Delegate d in delegates){
+                                               TypeBuilder tb = d.TypeBuilder;
+                                               
+                                               if (tb != null && (filter (tb, criteria) == true))
+                                                       members.Add (tb);
+                                       }
+                               }
                        }
 
                        if ((mt & MemberTypes.Constructor) != 0){
@@ -1219,6 +1235,7 @@ namespace Mono.CSharp {
                                        ConstructorBuilder cb =
                                                default_static_constructor.ConstructorBuilder;
                                        
+                                       if (cb != null)
                                        if (filter (cb, criteria) == true)
                                                members.Add (cb);
                                }
@@ -1245,24 +1262,7 @@ namespace Mono.CSharp {
                        return null;
                }
 
-               public MemberInfo GetFieldFromEvent (EventExpr event_expr)
-               {
-                       if (events == null)
-                               return null;
-                       
-                       EventInfo ei = event_expr.EventInfo;
-
-                       foreach (Event e in events) { 
-
-                               if (e.FieldBuilder == null)
-                                       continue;
-                               
-                               if (Type.FilterName (e.FieldBuilder, ei.Name))
-                                       return e.FieldBuilder;
-                       }
-
-                       return null;
-               }
+               
 
                public static MemberInfo [] FindMembers (Type t, MemberTypes mt, BindingFlags bf,
                                                         MemberFilter filter, object criteria)
@@ -1455,6 +1455,7 @@ namespace Mono.CSharp {
                public bool MethodModifiersValid (int flags, string n, Location loc)
                {
                        const int vao = (Modifiers.VIRTUAL | Modifiers.ABSTRACT | Modifiers.OVERRIDE);
+                       const int va = (Modifiers.VIRTUAL | Modifiers.ABSTRACT);
                        const int nv = (Modifiers.NEW | Modifiers.VIRTUAL);
                        bool ok = true;
                        string name = MakeName (n);
@@ -1471,6 +1472,13 @@ namespace Mono.CSharp {
                                }
                        }
 
+                       if (this is Struct){
+                               if ((flags & va) != 0){
+                                       Modifiers.Error_InvalidModifier (loc, "virtual or abstract");
+                                       ok = false;
+                               }
+                       }
+
                        if ((flags & Modifiers.OVERRIDE) != 0 && (flags & nv) != 0){
                                Report.Error (
                                        113, loc, name +
@@ -1781,7 +1789,7 @@ namespace Mono.CSharp {
        }
        
        public class Method : MethodCore {
-               public readonly string ReturnType;
+               public Expression ReturnType;
                public MethodBuilder MethodBuilder;
                public readonly Attributes OptAttributes;
 
@@ -1807,7 +1815,7 @@ namespace Mono.CSharp {
                //
                // return_type can be "null" for VOID values.
                //
-               public Method (string return_type, int mod, string name, Parameters parameters,
+               public Method (Expression return_type, int mod, string name, Parameters parameters,
                               Attributes attrs, Location l)
                        : base (name, parameters, l)
                {
@@ -1826,8 +1834,7 @@ namespace Mono.CSharp {
                public Type GetReturnType (TypeContainer parent)
                {
                        if (type_return_type == null)
-                               type_return_type = RootContext.LookupType (
-                                       parent, ReturnType, false, Location);
+                               type_return_type = parent.ResolveType (ReturnType, false, Location);
                        
                        return type_return_type;
                }
@@ -2024,11 +2031,8 @@ namespace Mono.CSharp {
                                        if ((ModFlags & Modifiers.STATIC) != 0)
                                                implementing = null;
                                } else {
-                                       if ((ModFlags & (Modifiers.PUBLIC | Modifiers.ABSTRACT)) != 0){
-                                               Report.Error (
-                                                       106, Location, "`public' or `abstract' modifiers "+
-                                                       "are not allowed in explicit interface declarations"
-                                                       );
+                                       if ((ModFlags & (Modifiers.PUBLIC | Modifiers.ABSTRACT | Modifiers.VIRTUAL)) != 0){
+                                               Modifiers.Error_InvalidModifier (Location, "public, virtual or abstract");
                                                implementing = null;
                                        }
                                }
@@ -2271,6 +2275,11 @@ namespace Mono.CSharp {
                                        return true;
 
                                t = ec.ContainerType.BaseType;
+                               if (ec.ContainerType.IsValueType) {
+                                       Report.Error (522, location,
+                                               "structs cannot call base class constructors");
+                                       return false;
+                               }
                        } else
                                t = ec.ContainerType;
                        
@@ -2300,7 +2309,8 @@ namespace Mono.CSharp {
 
                public void Emit (EmitContext ec)
                {
-                       ec.ig.Emit (OpCodes.Ldarg_0);
+                       if (parent_constructor != null)
+                               ec.ig.Emit (OpCodes.Ldarg_0);
                        if (argument_list != null)
                                Invocation.EmitArguments (ec, null, argument_list);
                        if (parent_constructor != null)
@@ -2420,8 +2430,8 @@ namespace Mono.CSharp {
                        ILGenerator ig = ConstructorBuilder.GetILGenerator ();
                        EmitContext ec = new EmitContext (parent, Location, ig, null, ModFlags, true);
 
-                       if (parent is Class && ((ModFlags & Modifiers.STATIC) == 0)){
-                               if (Initializer == null)
+                       if ((ModFlags & Modifiers.STATIC) == 0){
+                               if (parent is Class && Initializer == null)
                                        Initializer = new ConstructorBaseInitializer (null, parent.Location);
 
 
@@ -2430,7 +2440,7 @@ namespace Mono.CSharp {
                                // `this' access
                                //
                                ec.IsStatic = true;
-                               if (!Initializer.Resolve (ec))
+                               if (Initializer != null && !Initializer.Resolve (ec))
                                        return;
                                ec.IsStatic = false;
                        }
@@ -2441,12 +2451,11 @@ namespace Mono.CSharp {
                        // Classes can have base initializers and instance field initializers.
                        //
                        if (parent is Class){
-                               if ((ModFlags & Modifiers.STATIC) == 0){
+                               if ((ModFlags & Modifiers.STATIC) == 0)
                                        parent.EmitFieldInitializers (ec);
-
-                                       Initializer.Emit (ec);
-                               }
                        }
+                       if (Initializer != null)
+                               Initializer.Emit (ec);
                        
                        if ((ModFlags & Modifiers.STATIC) != 0)
                                parent.EmitFieldInitializers (ec);
@@ -2462,7 +2471,7 @@ namespace Mono.CSharp {
        // their common bits.  This is also used to flag usage of the field
        //
        abstract public class FieldBase : MemberCore {
-               public readonly string Type;
+               public Expression Type;
                public readonly Object Initializer;
                public readonly Attributes OptAttributes;
                public FieldBuilder  FieldBuilder;
@@ -2474,7 +2483,7 @@ namespace Mono.CSharp {
                //
                // The constructor is only exposed to our children
                //
-               protected FieldBase (string type, int mod, int allowed_mod, string name,
+               protected FieldBase (Expression type, int mod, int allowed_mod, string name,
                                     object init, Attributes attrs, Location loc)
                        : base (name, loc)
                {
@@ -2503,7 +2512,7 @@ namespace Mono.CSharp {
                        Modifiers.UNSAFE |
                        Modifiers.READONLY;
 
-               public Field (string type, int mod, string name, Object expr_or_array_init,
+               public Field (Expression type, int mod, string name, Object expr_or_array_init,
                              Attributes attrs, Location loc)
                        : base (type, mod, AllowedModifiers, name, expr_or_array_init, attrs, loc)
                {
@@ -2511,7 +2520,7 @@ namespace Mono.CSharp {
 
                public override bool Define (TypeContainer parent)
                {
-                       Type t = RootContext.LookupType (parent, Type, false, Location);
+                       Type t = parent.ResolveType (Type, false, Location);
                        
                        if (t == null)
                                return false;
@@ -2594,7 +2603,7 @@ namespace Mono.CSharp {
        }
                        
        public class Property : MemberCore {
-               public readonly string Type;
+               public Expression Type;
                public Accessor Get, Set;
                public PropertyBuilder PropertyBuilder;
                public Attributes OptAttributes;
@@ -2625,7 +2634,7 @@ namespace Mono.CSharp {
                        Modifiers.EXTERN |
                        Modifiers.VIRTUAL;
 
-               public Property (string type, string name, int mod_flags,
+               public Property (Expression type, string name, int mod_flags,
                                 Accessor get_block, Accessor set_block,
                                 Attributes attrs, Location loc)
                        : base (name, loc)
@@ -2760,11 +2769,8 @@ namespace Mono.CSharp {
                                        if ((ModFlags & Modifiers.STATIC) != 0)
                                                implementing = null;
                                } else {
-                                       if ((ModFlags & (Modifiers.PUBLIC | Modifiers.ABSTRACT)) != 0){
-                                               Report.Error (
-                                                       106, Location, "`public' or `abstract' modifiers "+
-                                                       "are not allowed in explicit interface declarations"
-                                                       );
+                                       if ((ModFlags & (Modifiers.PUBLIC | Modifiers.ABSTRACT | Modifiers.VIRTUAL)) != 0){
+                                               Modifiers.Error_InvalidModifier (Location, "public, virtual or abstract");
                                                implementing = null;
                                        }
                                }
@@ -2867,7 +2873,7 @@ namespace Mono.CSharp {
                        flags |= MethodAttributes.HideBySig | MethodAttributes.SpecialName;
 
                        // Lookup Type, verify validity
-                       PropertyType = RootContext.LookupType (parent, Type, false, Location);
+                       PropertyType = parent.ResolveType (Type, false, Location);
                        if (PropertyType == null)
                                return false;
 
@@ -3144,7 +3150,7 @@ namespace Mono.CSharp {
                Type EventType;
                MethodBuilder AddBuilder, RemoveBuilder;
                
-               public Event (string type, string name, Object init, int mod, Accessor add,
+               public Event (Expression type, string name, Object init, int mod, Accessor add,
                              Accessor remove, Attributes attrs, Location loc)
                        : base (type, mod, AllowedModifiers, name, init, attrs, loc)
                {
@@ -3160,7 +3166,7 @@ namespace Mono.CSharp {
                        MethodAttributes m_attr = Modifiers.MethodAttr (ModFlags);
                        EventAttributes e_attr = EventAttributes.RTSpecialName | EventAttributes.SpecialName;
 
-                       EventType = RootContext.LookupType (parent, Type, false, Location);
+                       EventType = parent.ResolveType (Type, false, Location);
                        if (EventType == null)
                                return false;
 
@@ -3181,9 +3187,10 @@ namespace Mono.CSharp {
 
                        EventBuilder = new MyEventBuilder (parent.TypeBuilder, Name, e_attr, EventType);
 
-                       if (Add == null && Remove == null){
-                               FieldBuilder = parent.TypeBuilder.DefineField (
-                                       Name, EventType, FieldAttributes.Private);
+                       if (Add == null && Remove == null) {
+                               FieldBuilder = parent.TypeBuilder.DefineField (
+                                       Name, EventType, FieldAttributes.FamANDAssem);
+                               TypeManager.RegisterPrivateFieldOfEvent ((EventInfo) EventBuilder, FieldBuilder);
                                TypeManager.RegisterFieldBase (FieldBuilder, this);
                        }
                        
@@ -3220,6 +3227,8 @@ namespace Mono.CSharp {
                                remove_name, m_attr, null, parameters);
                        RemoveBuilder.DefineParameter (1, ParameterAttributes.None, "value");
                        EventBuilder.SetRemoveOnMethod (RemoveBuilder);
+                       if (parent.Pending != null)
+                               parent.Pending.ImplementMethod (null, remove_name, null, parameters, false);
 
                        //
                        // This looks like dead code
@@ -3325,7 +3334,7 @@ namespace Mono.CSharp {
                        Modifiers.EXTERN |
                        Modifiers.ABSTRACT;
 
-               public readonly string     Type;
+               public readonly Expression Type;
                public readonly string     InterfaceType;
                public readonly Parameters FormalParameters;
                public readonly Accessor   Get, Set;
@@ -3338,7 +3347,7 @@ namespace Mono.CSharp {
                
                EmitContext ec;
                
-               public Indexer (string type, string int_type, int flags, Parameters parms,
+               public Indexer (Expression type, string int_type, int flags, Parameters parms,
                                Accessor get_block, Accessor set_block, Attributes attrs, Location loc)
                        : base ("", loc)
                {
@@ -3393,12 +3402,8 @@ namespace Mono.CSharp {
                                        if ((ModFlags & Modifiers.STATIC) != 0)
                                                implementing = null;
                                } else {
-                                       if((ModFlags&(Modifiers.PUBLIC | Modifiers.ABSTRACT)) != 0){
-                                               Report.Error (
-                                                       106, Location,
-                                                       "`public' or `abstract' modifiers are not "+
-                                                       "allowed in explicit interface declarations"
-                                                       );
+                                       if((ModFlags&(Modifiers.PUBLIC | Modifiers.ABSTRACT | Modifiers.VIRTUAL)) != 0){
+                                               Modifiers.Error_InvalidModifier (Location, "public, virtual or abstract");
                                                implementing = null;
                                        }
                                }
@@ -3464,7 +3469,7 @@ namespace Mono.CSharp {
                                PropertyAttributes.SpecialName;
                        bool error = false;
                        
-                       IndexerType = RootContext.LookupType (parent, Type, false, Location);
+                       IndexerType = parent.ResolveType (Type, false, Location);
                        Type [] parameters = FormalParameters.GetParameterInfo (parent);
 
                        // Check if the return type and arguments were correct
@@ -3716,11 +3721,9 @@ namespace Mono.CSharp {
                };
 
                public readonly OpType OperatorType;
-               public readonly string ReturnType;
-               public readonly string FirstArgType;
-               public readonly string FirstArgName;
-               public readonly string SecondArgType;
-               public readonly string SecondArgName;
+               public readonly Expression ReturnType;
+               public readonly Expression FirstArgType, SecondArgType;
+               public readonly string FirstArgName, SecondArgName;
                public readonly Block  Block;
                public Attributes      OptAttributes;
                public MethodBuilder   OperatorMethodBuilder;
@@ -3728,8 +3731,10 @@ namespace Mono.CSharp {
                public string MethodName;
                public Method OperatorMethod;
 
-               public Operator (OpType type, string ret_type, int flags, string arg1type, string arg1name,
-                                string arg2type, string arg2name, Block block, Attributes attrs, Location loc)
+               public Operator (OpType type, Expression ret_type, int flags,
+                                Expression arg1type, string arg1name,
+                                Expression arg2type, string arg2name,
+                                Block block, Attributes attrs, Location loc)
                        : base ("", loc)
                {
                        OperatorType = type;