using System.Reflection.Emit;
using System.Runtime.InteropServices;
using System.Runtime.CompilerServices;
+using System.Security;
+using System.Security.Permissions;
using System.Text;
namespace Mono.CSharp {
/// </summary>
Attributes attributes;
- public Attributable(Attributes attrs)
+ public Attributable (Attributes attrs)
{
attributes = attrs;
- if (attributes != null)
- attributes.CheckTargets (ValidAttributeTargets);
}
public Attributes OptAttributes
}
set {
attributes = value;
- if (attributes != null)
- attributes.CheckTargets (ValidAttributeTargets);
}
}
public abstract void ApplyAttributeBuilder (Attribute a, CustomAttributeBuilder cb);
/// <summary>
- /// Returns combination of enabled AttributeTargets
+ /// Returns one AttributeTarget for this element.
/// </summary>
public abstract AttributeTargets AttributeTargets { get; }
/// Gets list of valid attribute targets for explicit target declaration.
/// The first array item is default target. Don't break this rule.
/// </summary>
- protected abstract string[] ValidAttributeTargets { get; }
+ public abstract string[] ValidAttributeTargets { get; }
};
public class Attribute {
- public string Target;
+ public readonly string ExplicitTarget;
+ public AttributeTargets Target;
+
public readonly string Name;
public readonly ArrayList Arguments;
public readonly Location Location;
public Type Type;
-
+
+ bool resolve_error;
+
// Is non-null if type is AttributeUsageAttribute
AttributeUsageAttribute usage_attribute;
return usage_attribute;
}
}
-
+
MethodImplOptions ImplOptions;
UnmanagedType UnmanagedType;
CustomAttributeBuilder cb;
Name = name;
Arguments = args;
Location = loc;
- Target = target;
+ ExplicitTarget = target;
}
void Error_InvalidNamedArgument (string name)
{
- Report.Error (617, Location, "'" + name + "' is not a valid named attribute " +
- "argument. Named attribute arguments must be fields which are not " +
- "readonly, static or const, or properties with a set accessor which "+
- "are not static.");
+ Report.Error (617, Location, "Invalid attribute argument: '{0}'. Argument must be fields " +
+ "fields which are not readonly, static or const; or read-write instance properties.",
+ Name);
}
static void Error_AttributeArgumentNotValid (Location loc)
"expression or array creation expression");
}
+ /// <summary>
+ /// This is rather hack. We report many emit attribute error with same error to be compatible with
+ /// csc. But because csc has to report them this way because error came from ilasm we needn't.
+ /// </summary>
+ public void Error_AttributeEmitError (string inner)
+ {
+ Report.Error (647, Location, "Error emitting '{0}' attribute because '{1}'", Name, inner);
+ }
+
+ public void Error_InvalidSecurityParent ()
+ {
+ Error_AttributeEmitError ("it is attached to invalid parent");
+ }
+
void Error_AttributeConstructorMismatch ()
{
Report.Error (-6, Location,
/// <summary>
/// Tries to resolve the type of the attribute. Flags an error if it can't, and complain is true.
/// </summary>
- protected virtual Type CheckAttributeType (EmitContext ec, bool complain)
+ protected virtual Type CheckAttributeType (EmitContext ec)
{
- Type t1 = RootContext.LookupType (ec.DeclSpace, Name, true, Location);
+ string NameAttribute = Name + "Attribute";
+
+ Type t1 = ec.ResolvingTypeTree
+ ? ec.DeclSpace.FindType (Location, Name)
+ : RootContext.LookupType (ec.DeclSpace, Name, true, Location);
// FIXME: Shouldn't do this for quoted attributes: [@A]
- Type t2 = RootContext.LookupType (ec.DeclSpace, Name + "Attribute", true, Location);
+ Type t2 = ec.ResolvingTypeTree
+ ? ec.DeclSpace.FindType (Location, NameAttribute)
+ : RootContext.LookupType (ec.DeclSpace, NameAttribute, true, Location);
String err0616 = null;
if (t2 != null && ! t2.IsSubclassOf (TypeManager.attribute_type)) {
t2 = null;
err0616 = (err0616 != null)
- ? "Neither '" + Name + "' nor '" + Name + "Attribute' is an attribute class"
+ ? "Neither '" + Name + "' nor '" + NameAttribute +"' is an attribute class"
: "'" + Name + "Attribute': is not an attribute class";
}
if (t1 != null && t2 != null) {
Report.Error(1614, Location, "'" + Name + "': is ambiguous; "
- + " use either '@" + Name + "' or '" + Name + "Attribute'");
+ + " use either '@" + Name + "' or '" + NameAttribute + "'");
return null;
}
if (t1 != null)
return null;
}
- if (complain)
- Report.Error (246, Location,
- "Could not find attribute '" + Name
- + "' (are you missing a using directive or an assembly reference ?)");
+ Report.Error (246, Location,
+ "Could not find attribute '" + Name
+ + "' (are you missing a using directive or an assembly reference ?)");
+
+ resolve_error = true;
return null;
}
- public Type ResolveType (EmitContext ec, bool complain)
+ public Type ResolveType (EmitContext ec)
{
if (Type == null)
- Type = CheckAttributeType (ec, complain);
+ Type = CheckAttributeType (ec);
return Type;
}
// Given an expression, if the expression is a valid attribute-argument-expression
// returns an object that can be used to encode it, or null on failure.
//
- public static bool GetAttributeArgumentExpression (Expression e, Location loc, out object result)
+ public static bool GetAttributeArgumentExpression (Expression e, Location loc, Type arg_type, out object result)
{
- if (e is Constant) {
- result = ((Constant) e).GetValue ();
+ if (e is EnumConstant) {
+ if (RootContext.StdLib)
+ result = ((EnumConstant)e).GetValueAsEnumType ();
+ else
+ result = ((EnumConstant)e).GetValue ();
+
+ return true;
+ }
+
+ Constant constant = e as Constant;
+ if (constant != null) {
+ if (e.Type != arg_type) {
+ constant = Const.ChangeType (loc, constant, arg_type);
+ if (constant == null) {
+ result = null;
+ Error_AttributeArgumentNotValid (loc);
+ return false;
+ }
+ }
+ result = constant.GetValue ();
return true;
} else if (e is TypeOf) {
result = ((TypeOf) e).TypeArg;
if (result != null)
return true;
} else if (e is EmptyCast) {
- result = e;
- if (((EmptyCast) e).Child is Constant) {
- result = ((Constant) ((EmptyCast)e).Child).GetValue();
- }
- return true;
+ Expression child = ((EmptyCast)e).Child;
+ return GetAttributeArgumentExpression (child, loc, child.Type, out result);
}
result = null;
return false;
}
- public CustomAttributeBuilder Resolve (EmitContext ec)
+ public virtual CustomAttributeBuilder Resolve (EmitContext ec)
{
+ if (resolve_error)
+ return null;
+
+ resolve_error = true;
+
Type oldType = Type;
// Sanity check.
- Type = CheckAttributeType (ec, true);
+ Type = CheckAttributeType (ec);
+
if (oldType == null && Type == null)
return null;
- if (oldType != null && oldType != Type) {
- Report.Error (-6, Location,
+ if (oldType != null && oldType != Type){
+ Report.Error (-27, Location,
"Attribute {0} resolved to different types at different times: {1} vs. {2}",
Name, oldType, Type);
return null;
}
+ if (Type.IsAbstract) {
+ Report.Error (653, Location, "Cannot apply attribute class '{0}' because it is abstract", Name);
+ return null;
+ }
+
bool MethodImplAttr = false;
bool MarshalAsAttr = false;
bool GuidAttr = false;
e = a.Expr;
object val;
- if (!GetAttributeArgumentExpression (e, Location, out val))
+ if (!GetAttributeArgumentExpression (e, Location, a.Type, out val))
return null;
-
+
pos_values [i] = val;
+
if (DoCompares){
- if (usage_attr)
- usage_attribute = new AttributeUsageAttribute ((AttributeTargets) pos_values [0]);
- else if (MethodImplAttr)
- this.ImplOptions = (MethodImplOptions) pos_values [0];
- else if (GuidAttr){
+ if (usage_attr) {
+ if ((int)val == 0) {
+ Report.Error (591, Location, "Invalid value for argument to 'System.AttributeUsage' attribute");
+ return null;
+ }
+ usage_attribute = new AttributeUsageAttribute ((AttributeTargets)val);
+ } else if (MethodImplAttr) {
+ this.ImplOptions = (MethodImplOptions) val;
+ } else if (GuidAttr){
//
// we will later check the validity of the type
//
- if (pos_values [0] is string){
- if (!ValidateGuid ((string) pos_values [0]))
+ if (val is string){
+ if (!ValidateGuid ((string) val))
return null;
}
} else if (MarshalAsAttr)
this.UnmanagedType =
- (System.Runtime.InteropServices.UnmanagedType) pos_values [0];
+ (System.Runtime.InteropServices.UnmanagedType) val;
}
}
Location);
if (member != null) {
- Report.Error_T (122, Location, GetFullMemberName (member_name));
+ Report.Error (122, Location, "'{0}' is inaccessible due to its protection level", GetFullMemberName (member_name));
return null;
}
}
- if (member == null || !(member is PropertyExpr || member is FieldExpr)) {
+ if (member == null){
+ Report.Error (117, Location, "Attribute `{0}' does not contain a definition for `{1}'",
+ Type, member_name);
+ return null;
+ }
+
+ if (!(member is PropertyExpr || member is FieldExpr)) {
Error_InvalidNamedArgument (member_name);
return null;
}
PropertyExpr pe = (PropertyExpr) member;
PropertyInfo pi = pe.PropertyInfo;
- if (!pi.CanWrite) {
+ if (!pi.CanWrite || !pi.CanRead) {
+ Report.SymbolRelatedToPreviousError (pi);
Error_InvalidNamedArgument (member_name);
return null;
}
- Type type = e.Type;
- EmptyCast ecast = e as EmptyCast;
- if ((ecast != null) && (ecast.Child is Constant))
- e = ecast.Child;
-
- Constant c = e as Constant;
- if (c != null) {
- if (type != pi.PropertyType) {
- c = Const.ChangeType (Location, c, pi.PropertyType);
- if (c == null)
- return null;
- }
-
- object o = c.GetValue ();
- prop_values.Add (o);
-
- if (usage_attribute != null) {
- if (member_name == "AllowMultiple")
- usage_attribute.AllowMultiple = (bool) o;
- if (member_name == "Inherited")
- usage_attribute.Inherited = (bool) o;
- }
-
- } else if (e is TypeOf) {
- prop_values.Add (((TypeOf) e).TypeArg);
- } else if (e is ArrayCreation) {
- prop_values.Add (((ArrayCreation) e).EncodeAsAttribute());
- } else {
- Error_AttributeArgumentNotValid (Location);
+ object value;
+ if (!GetAttributeArgumentExpression (e, Location, pi.PropertyType, out value))
return null;
+
+ if (usage_attribute != null) {
+ if (member_name == "AllowMultiple")
+ usage_attribute.AllowMultiple = (bool) value;
+ if (member_name == "Inherited")
+ usage_attribute.Inherited = (bool) value;
}
-
+
+ prop_values.Add (value);
prop_infos.Add (pi);
} else if (member is FieldExpr) {
return null;
}
- Type type = e.Type;
- EmptyCast ecast = e as EmptyCast;
- if ((ecast != null) && (ecast.Child is Constant))
- e = ecast.Child;
-
- //
- // Handle charset here, and set the TypeAttributes
+ object value;
+ if (!GetAttributeArgumentExpression (e, Location, fi.FieldType, out value))
+ return null;
- Constant c = e as Constant;
- if (c != null) {
- if (type != fi.FieldType) {
- c = Const.ChangeType (Location, c, fi.FieldType);
- if (c == null)
- return null;
- }
-
- object value = c.GetValue ();
- field_values.Add (value);
- } else if (e is TypeOf) {
- field_values.Add (((TypeOf) e).TypeArg);
- } else if (e is ArrayCreation) {
- field_values.Add (((ArrayCreation) e).EncodeAsAttribute());
- } else {
- Error_AttributeArgumentNotValid (Location);
- return null;
- }
-
+ field_values.Add (value);
field_infos.Add (fi);
}
}
}
MethodBase constructor = Invocation.OverloadResolve (
- ec, (MethodGroupExpr) mg, pos_args, Location);
+ ec, (MethodGroupExpr) mg, pos_args, false, Location);
if (constructor == null) {
return null;
ParameterData pd = Invocation.GetParameterData (constructor);
- int group_in_params_array = Int32.MaxValue;
- int pc = pd.Count;
- if (pc > 0 && pd.ParameterModifier (pc-1) == Parameter.Modifier.PARAMS)
- group_in_params_array = pc-1;
+ int last_real_param = pd.Count;
+ if (pd.HasParams) {
+ // When the params is not filled we need to put one
+ if (last_real_param > pos_arg_count) {
+ object [] new_pos_values = new object [pos_arg_count + 1];
+ pos_values.CopyTo (new_pos_values, 0);
+ new_pos_values [pos_arg_count] = new object [] {} ;
+ pos_values = new_pos_values;
+ }
+ last_real_param--;
+ }
for (int j = 0; j < pos_arg_count; ++j) {
Argument a = (Argument) pos_args [j];
return null;
}
- if (j < group_in_params_array)
+ if (j < last_real_param)
continue;
- if (j == group_in_params_array){
- object v = pos_values [j];
- int count = pos_arg_count - j;
-
- object [] array = new object [count];
+ if (j == last_real_param) {
+ object [] array = new object [pos_arg_count - last_real_param];
+ array [0] = pos_values [j];
pos_values [j] = array;
- array [0] = v;
- } else {
- object [] array = (object []) pos_values [group_in_params_array];
-
- array [j - group_in_params_array] = pos_values [j];
+ continue;
}
+
+ object [] params_array = (object []) pos_values [last_real_param];
+ params_array [j - last_real_param] = pos_values [j];
}
- //
// Adjust the size of the pos_values if it had params
- //
- if (group_in_params_array != Int32.MaxValue){
- int argc = group_in_params_array+1;
- object [] new_pos_values = new object [argc];
-
- for (int p = 0; p < argc; p++)
- new_pos_values [p] = pos_values [p];
+ if (last_real_param != pos_arg_count) {
+ object [] new_pos_values = new object [last_real_param + 1];
+ Array.Copy (pos_values, new_pos_values, last_real_param + 1);
pos_values = new_pos_values;
}
else
cb = new CustomAttributeBuilder (
(ConstructorInfo) constructor, pos_values);
- } catch (NullReferenceException) {
- //
- // Don't know what to do here
- //
- Report.Warning (
- -101, Location, "NullReferenceException while trying to create attribute." +
- "Something's wrong!");
} catch (Exception e) {
//
// Sample:
// [DefaultValue (CollectionChangeAction.Add)]
// class X { static void Main () {} }
//
- Report.Warning (
- -23, Location, "The compiler can not encode this attribute in .NET due to a bug in the .NET runtime. Try the Mono runtime. The exception was: " + e.Message);
+ Error_AttributeArgumentNotValid (Location);
+ return null;
}
+ resolve_error = false;
return cb;
}
/// </summary>
public string GetIndexerAttributeValue (EmitContext ec)
{
- if (pos_values == null) {
+ if (pos_values == null)
// TODO: It is not neccessary to call whole Resolve (ApplyAttribute does it now) we need only ctor args.
// But because a lot of attribute class code must be rewritten will be better to wait...
Resolve (ec);
- }
return pos_values [0] as string;
}
/// <summary>
/// Returns condition of ConditionalAttribute
/// </summary>
- public string GetConditionalAttributeValue (DeclSpace ds)
+ public string GetConditionalAttributeValue (EmitContext ec)
{
- if (pos_values == null) {
- EmitContext ec = new EmitContext (ds, ds, Location, null, null, 0, false);
-
+ if (pos_values == null)
// TODO: It is not neccessary to call whole Resolve (ApplyAttribute does it now) we need only ctor args.
// But because a lot of attribute class code must be rewritten will be better to wait...
Resolve (ec);
- }
// Some error occurred
if (pos_values [0] == null)
/// <summary>
/// Creates the instance of ObsoleteAttribute from this attribute instance
/// </summary>
- public ObsoleteAttribute GetObsoleteAttribute (DeclSpace ds)
+ public ObsoleteAttribute GetObsoleteAttribute (EmitContext ec)
{
- if (pos_values == null) {
- EmitContext ec = new EmitContext (ds, ds, Location, null, null, 0, false);
-
+ if (pos_values == null)
// TODO: It is not neccessary to call whole Resolve (ApplyAttribute does it now) we need only ctor args.
// But because a lot of attribute class code must be rewritten will be better to wait...
Resolve (ec);
- }
// Some error occurred
if (pos_values == null)
/// before ApplyAttribute. We need to resolve the arguments.
/// This situation occurs when class deps is differs from Emit order.
/// </summary>
- public bool GetClsCompliantAttributeValue (DeclSpace ds)
+ public bool GetClsCompliantAttributeValue (EmitContext ec)
{
- if (pos_values == null) {
- EmitContext ec = new EmitContext (ds, ds, Location, null, null, 0, false);
-
+ if (pos_values == null)
// TODO: It is not neccessary to call whole Resolve (ApplyAttribute does it now) we need only ctor args.
// But because a lot of attribute class code must be rewritten will be better to wait...
Resolve (ec);
- }
// Some error occurred
if (pos_values [0] == null)
return (bool)pos_values [0];
}
+ /// <summary>
+ /// Tests permitted SecurityAction for assembly or other types
+ /// </summary>
+ public bool CheckSecurityActionValidity (bool for_assembly)
+ {
+ SecurityAction action = GetSecurityActionValue ();
+
+ if ((action == SecurityAction.RequestMinimum || action == SecurityAction.RequestOptional || action == SecurityAction.RequestRefuse) && for_assembly)
+ return true;
+
+ if (!for_assembly) {
+ if (action < SecurityAction.Demand || action > SecurityAction.InheritanceDemand) {
+ Error_AttributeEmitError ("SecurityAction is out of range");
+ return false;
+ }
+
+ if ((action != SecurityAction.RequestMinimum && action != SecurityAction.RequestOptional && action != SecurityAction.RequestRefuse) && !for_assembly)
+ return true;
+ }
+
+ Error_AttributeEmitError (String.Concat ("SecurityAction '", action, "' is not valid for this declaration"));
+ return false;
+ }
+
+ System.Security.Permissions.SecurityAction GetSecurityActionValue ()
+ {
+ return (SecurityAction)pos_values [0];
+ }
+
+ /// <summary>
+ /// Creates instance of SecurityAttribute class and add result of CreatePermission method to permission table.
+ /// </summary>
+ /// <returns></returns>
+ public void ExtractSecurityPermissionSet (ListDictionary permissions)
+ {
+ if (TypeManager.LookupDeclSpace (Type) != null && RootContext.StdLib) {
+ Error_AttributeEmitError ("security custom attributes can not be referenced from defining assembly");
+ return;
+ }
+
+ SecurityAttribute sa;
+ // For all assemblies except corlib we can avoid all hacks
+ if (RootContext.StdLib) {
+ sa = (SecurityAttribute) Activator.CreateInstance (Type, pos_values);
+
+ if (prop_info_arr != null) {
+ for (int i = 0; i < prop_info_arr.Length; ++i) {
+ PropertyInfo pi = prop_info_arr [i];
+ pi.SetValue (sa, prop_values_arr [i], null);
+ }
+ }
+ } else {
+ Type temp_type = Type.GetType (Type.FullName);
+ // HACK: All mscorlib attributes have same ctor syntax
+ sa = (SecurityAttribute) Activator.CreateInstance (temp_type, new object[] { GetSecurityActionValue () } );
+
+ // All types are from newly created corlib but for invocation with old we need to convert them
+ if (prop_info_arr != null) {
+ for (int i = 0; i < prop_info_arr.Length; ++i) {
+ PropertyInfo emited_pi = prop_info_arr [i];
+ PropertyInfo pi = temp_type.GetProperty (emited_pi.Name, emited_pi.PropertyType);
+
+ object old_instance = pi.PropertyType.IsEnum ?
+ System.Enum.ToObject (pi.PropertyType, prop_values_arr [i]) :
+ prop_values_arr [i];
+
+ pi.SetValue (sa, old_instance, null);
+ }
+ }
+ }
+
+ IPermission perm = sa.CreatePermission ();
+ SecurityAction action;
+
+ // IS is correct because for corlib we are using an instance from old corlib
+ if (perm is System.Security.CodeAccessPermission) {
+ action = GetSecurityActionValue ();
+ } else {
+ switch (GetSecurityActionValue ()) {
+ case SecurityAction.Demand:
+ action = (SecurityAction)13;
+ break;
+ case SecurityAction.LinkDemand:
+ action = (SecurityAction)14;
+ break;
+ case SecurityAction.InheritanceDemand:
+ action = (SecurityAction)15;
+ break;
+ default:
+ Error_AttributeEmitError ("Invalid SecurityAction for non-Code Access Security permission");
+ return;
+ }
+ }
+
+ PermissionSet ps = (PermissionSet)permissions [action];
+ if (ps == null) {
+ ps = new PermissionSet (PermissionState.None);
+ permissions.Add (action, ps);
+ }
+ ps.AddPermission (sa.CreatePermission ());
+ }
+
+ object GetValue (object value)
+ {
+ if (value is EnumConstant)
+ return ((EnumConstant) value).GetValue ();
+ else
+ return value;
+ }
+
public object GetPositionalValue (int i)
{
return (pos_values == null) ? null : pos_values[i];
i = 0;
foreach (FieldInfo fi in field_info_arr) {
if (fi.Name == name)
- return field_values_arr [i];
+ return GetValue (field_values_arr [i]);
i++;
}
return null;
}
- public UnmanagedMarshal GetMarshal ()
+ public UnmanagedMarshal GetMarshal (Attributable attr)
{
+ object value = GetFieldValue ("SizeParamIndex");
+ if (value != null && UnmanagedType != UnmanagedType.LPArray) {
+ Error_AttributeEmitError ("SizeParamIndex field is not valid for the specified unmanaged type");
+ return null;
+ }
+
object o = GetFieldValue ("ArraySubType");
UnmanagedType array_sub_type = o == null ? UnmanagedType.I4 : (UnmanagedType) o;
case UnmanagedType.CustomMarshaler:
MethodInfo define_custom = typeof (UnmanagedMarshal).GetMethod ("DefineCustom",
BindingFlags.Static | BindingFlags.Public);
- if (define_custom == null)
+ if (define_custom == null) {
+ Report.RuntimeMissingSupport (Location, "set marshal info");
return null;
+ }
object [] args = new object [4];
args [0] = GetFieldValue ("MarshalTypeRef");
return UnmanagedMarshal.DefineSafeArray (array_sub_type);
case UnmanagedType.ByValArray:
+ FieldMember fm = attr as FieldMember;
+ if (fm == null) {
+ Error_AttributeEmitError ("Specified unmanaged type is only valid on fields");
+ return null;
+ }
return UnmanagedMarshal.DefineByValArray ((int) GetFieldValue ("SizeConst"));
case UnmanagedType.ByValTStr:
return;
AttributeUsageAttribute usage_attr = GetAttributeUsage ();
- if ((usage_attr.ValidOn & ias.AttributeTargets) == 0) {
- // "Attribute '{0}' is not valid on this declaration type. It is valid on {1} declarations only.";
- Report.Error_T (592, Location, Name, GetValidTargets ());
+ if ((usage_attr.ValidOn & Target) == 0) {
+ Report.Error (592, Location, "Attribute '{0}' is not valid on this declaration type. It is valid on {1} declarations only.", Name, GetValidTargets ());
return;
}
emitted_targets.Add (Target);
}
+ if (!RootContext.VerifyClsCompliance)
+ return;
+
// Here we are testing attribute arguments for array usage (error 3016)
if (ias.IsClsCompliaceRequired (ec.DeclSpace)) {
if (Arguments == null)
return;
if (arg.Type.IsArray) {
- Report.Error_T (3016, Location);
+ Report.Error (3016, Location, "Arrays as attribute arguments are not CLS-compliant");
return;
}
}
return;
if (arg.Type.IsArray) {
- Report.Error_T (3016, Location);
+ Report.Error (3016, Location, "Arrays as attribute arguments are not CLS-compliant");
return;
}
}
return null;
}
- ResolveType (ec, true);
+ ResolveType (ec);
if (Type == null)
return null;
ns = container.NamespaceEntry;
}
- protected override Type CheckAttributeType (EmitContext ec, bool complain)
+ protected override Type CheckAttributeType (EmitContext ec)
{
- NamespaceEntry old = ec.DeclSpace.NamespaceEntry;
- if (old == null || old.NS == null || old.NS == Namespace.Root)
+ // RootContext.Tree.Types has a single NamespaceEntry which gets overwritten
+ // each time a new file is parsed. However, we need to use the NamespaceEntry
+ // in effect where the attribute was used. Since code elsewhere cannot assume
+ // that the NamespaceEntry is right, just overwrite it.
+ //
+ // Precondition: RootContext.Tree.Types == null || RootContext.Tree.Types == ns.
+ // The second case happens when we are recursively invoked from inside Emit.
+
+ NamespaceEntry old = null;
+ if (ec.DeclSpace == RootContext.Tree.Types) {
+ old = ec.DeclSpace.NamespaceEntry;
ec.DeclSpace.NamespaceEntry = ns;
- return base.CheckAttributeType (ec, complain);
+ if (old != null && old != ns)
+ throw new InternalErrorException (Location + " non-null NamespaceEntry " + old);
+ }
+
+ Type retval = base.CheckAttributeType (ec);
+
+ if (ec.DeclSpace == RootContext.Tree.Types)
+ ec.DeclSpace.NamespaceEntry = old;
+
+ return retval;
+ }
+
+ public override CustomAttributeBuilder Resolve (EmitContext ec)
+ {
+ if (ec.DeclSpace == RootContext.Tree.Types) {
+ NamespaceEntry old = ec.DeclSpace.NamespaceEntry;
+ ec.DeclSpace.NamespaceEntry = ns;
+ if (old != null)
+ throw new InternalErrorException (Location + " non-null NamespaceEntry " + old);
+ }
+
+ CustomAttributeBuilder retval = base.Resolve (ec);
+
+ if (ec.DeclSpace == RootContext.Tree.Types)
+ ec.DeclSpace.NamespaceEntry = null;
+
+ return retval;
}
}
/// <summary>
/// Checks whether attribute target is valid for the current element
/// </summary>
- public void CheckTargets (string[] possible_targets)
+ public bool CheckTargets (Attributable member)
{
+ string[] valid_targets = member.ValidAttributeTargets;
foreach (Attribute a in Attrs) {
- if (a.Target == null) {
- a.Target = possible_targets [0];
+ if (a.ExplicitTarget == null || a.ExplicitTarget == valid_targets [0]) {
+ a.Target = member.AttributeTargets;
continue;
}
- if (((IList) possible_targets).Contains (a.Target))
- continue;
+ // TODO: we can skip the first item
+ if (((IList) valid_targets).Contains (a.ExplicitTarget)) {
+ switch (a.ExplicitTarget) {
+ case "return": a.Target = AttributeTargets.ReturnValue; continue;
+ case "param": a.Target = AttributeTargets.Parameter; continue;
+ case "field": a.Target = AttributeTargets.Field; continue;
+ case "method": a.Target = AttributeTargets.Method; continue;
+ case "property": a.Target = AttributeTargets.Property; continue;
+ }
+ throw new InternalErrorException ("Unknown explicit target: " + a.ExplicitTarget);
+ }
StringBuilder sb = new StringBuilder ();
- foreach (string s in possible_targets) {
+ foreach (string s in valid_targets) {
sb.Append (s);
sb.Append (", ");
}
sb.Remove (sb.Length - 2, 2);
- Report.Error_T (657, a.Location, a.Target, sb.ToString ());
+ Report.Error (657, a.Location, "'{0}' is not a valid attribute location for this declaration. Valid attribute locations for this declaration are '{1}'", a.ExplicitTarget, sb.ToString ());
+ return false;
}
+ return true;
}
- private Attribute Search (Type t, EmitContext ec, bool complain)
+ public Attribute Search (Type t, EmitContext ec)
{
foreach (Attribute a in Attrs) {
- if (a.ResolveType (ec, false) == t)
+ if (a.ResolveType (ec) == t)
return a;
}
return null;
}
- public Attribute Search (Type t, EmitContext ec)
- {
- return Search (t, ec, true);
- }
-
/// <summary>
/// Returns all attributes of type 't'. Use it when attribute is AllowMultiple = true
/// </summary>
ArrayList ar = null;
foreach (Attribute a in Attrs) {
- if (a.ResolveType (ec, false) == t) {
+ if (a.ResolveType (ec) == t) {
if (ar == null)
ar = new ArrayList ();
ar.Add (a);
public void Emit (EmitContext ec, Attributable ias)
{
+ if (!CheckTargets (ias))
+ return;
+
ListDictionary ld = new ListDictionary ();
foreach (Attribute a in Attrs)
{
return Search (t, ec) != null;
}
-
- public Attribute GetClsCompliantAttribute (EmitContext ec)
- {
- return Search (TypeManager.cls_compliant_attribute_type, ec, false);
- }
-
- /// <summary>
- /// Pulls the IndexerName attribute from an Indexer if it exists.
- /// </summary>
- public Attribute GetIndexerNameAttribute (EmitContext ec)
- {
- Attribute a = Search (TypeManager.indexer_name_type, ec, false);
- if (a == null)
- return null;
-
- // Remove the attribute from the list because it is not emitted
- Attrs.Remove (a);
- return a;
- }
-
}
/// <summary>
foreach (Parameter arg in fixedParameters) {
if (!AttributeTester.IsClsCompliant (arg.ParameterType)) {
- Report.Error_T (3001, loc, arg.GetSignatureForError ());
+ Report.Error (3001, loc, "Argument type '{0}' is not CLS-compliant", arg.GetSignatureForError ());
return false;
}
}
static object TRUE = new object ();
static object FALSE = new object ();
- /// <summary>
- /// Non-hierarchical CLS Compliance analyzer
- /// </summary>
- public static bool IsComplianceRequired (MemberInfo mi, DeclSpace ds)
- {
- DeclSpace temp_ds = TypeManager.LookupDeclSpace (mi.DeclaringType);
-
- // Type is external, we can get attribute directly
- if (temp_ds == null) {
- object[] cls_attribute = mi.GetCustomAttributes (TypeManager.cls_compliant_attribute_type, false);
- return (cls_attribute.Length == 1 && ((CLSCompliantAttribute)cls_attribute[0]).IsCompliant);
- }
-
- string tmp_name;
- // Interface doesn't store full name
- if (temp_ds is Interface)
- tmp_name = mi.Name;
- else
- tmp_name = String.Concat (temp_ds.Name, ".", mi.Name);
-
- MemberCore mc = temp_ds.GetDefinition (tmp_name) as MemberCore;
- return mc.IsClsCompliaceRequired (ds);
- }
-
public static void VerifyModulesClsCompliance ()
{
Module[] modules = TypeManager.Modules;
for (int i = 1; i < modules.Length; ++i) {
Module module = modules [i];
if (!IsClsCompliant (module)) {
- Report.Error_T (3013, module.Name);
+ Report.Error (3013, "Added modules must be marked with the CLSCompliant attribute to match the assembly", module.Name);
return;
}
}
}
+ /// <summary>
+ /// Tests container name for CLS-Compliant name (differing only in case)
+ /// </summary>
+ public static void VerifyTopLevelNameClsCompliance ()
+ {
+ Hashtable locase_table = new Hashtable ();
+
+ // Convert imported type names to lower case and ignore not cls compliant
+ foreach (DictionaryEntry de in TypeManager.all_imported_types) {
+ Type t = (Type)de.Value;
+ if (!AttributeTester.IsClsCompliant (t))
+ continue;
+
+ locase_table.Add (((string)de.Key).ToLower (System.Globalization.CultureInfo.InvariantCulture), t);
+ }
+
+ foreach (DictionaryEntry de in RootContext.Tree.Decls) {
+ DeclSpace decl = (DeclSpace)de.Value;
+ if (!decl.IsClsCompliaceRequired (decl))
+ continue;
+
+ string lcase = decl.Name.ToLower (System.Globalization.CultureInfo.InvariantCulture);
+ if (!locase_table.Contains (lcase)) {
+ locase_table.Add (lcase, decl);
+ continue;
+ }
+
+ object conflict = locase_table [lcase];
+ if (conflict is Type)
+ Report.SymbolRelatedToPreviousError ((Type)conflict);
+ else
+ Report.SymbolRelatedToPreviousError ((MemberCore)conflict);
+
+ Report.Error (3005, decl.Location, "Identifier '{0}' differing only in case is not CLS-compliant", decl.GetSignatureForError ());
+ }
+ }
+
static bool IsClsCompliant (ICustomAttributeProvider attribute_provider)
{
object[] CompliantAttribute = attribute_provider.GetCustomAttributes (TypeManager.cls_compliant_attribute_type, false);
if (mc != null)
return mc.GetObsoleteAttribute ();
- // TODO: remove after Constructor will be ready for IMethodData
+ // compiler generated methods are not registered by AddMethod
if (mb.DeclaringType is TypeBuilder)
return null;
public static void Report_ObsoleteMessage (ObsoleteAttribute oa, string member, Location loc)
{
if (oa.IsError) {
- Report.Error_T (619, loc, member, oa.Message);
+ Report.Error (619, loc, "'{0}' is obsolete: '{1}'", member, oa.Message);
return;
}
if (oa.Message == null) {
- Report.Warning_T (612, loc, member);
+ Report.Warning (612, loc, "'{0}' is obsolete", member);
return;
}
- Report.Warning_T (618, loc, member, oa.Message);
+ if (RootContext.WarningLevel >= 2)
+ Report.Warning (618, loc, "'{0}' is obsolete: '{1}'", member, oa.Message);
}
public static bool IsConditionalMethodExcluded (MethodBase mb)
projects / mono.git / blobdiff