//
// Author:
// Miguel de Icaza (miguel@ximian.com)
+// Martin Baulig (martin@gnome.org)
//
-// (C) 2001 Ximian, Inc.
+// (C) 2001, 2002, 2003 Ximian, Inc.
//
using System;
using System.Reflection;
{
type = t;
eclass = ExprClass.Value;
- builder = ec.GetTemporaryStorage (t);
+ loc = Location.Null;
+ builder = ec.GetTemporaryLocal (t);
}
public void Release (EmitContext ec)
{
- ec.FreeTemporaryStorage (builder);
+ ec.FreeTemporaryLocal (builder, type);
builder = null;
}
{
type = t;
eclass = ExprClass.Value;
+ loc = Location.Null;
builder = b;
}
/// the expression represented by target.
/// </summary>
public class Assign : ExpressionStatement {
- Expression target, source;
- public Location l;
+ protected Expression target, source, real_source;
+ protected LocalTemporary temp = null, real_temp = null;
+ protected Assign embedded = null;
+ protected bool is_embedded = false;
+ protected bool must_free_temp = false;
public Assign (Expression target, Expression source, Location l)
{
this.target = target;
- this.source = source;
- this.l = l;
+ this.source = this.real_source = source;
+ this.loc = l;
+ }
+
+ protected Assign (Assign embedded, Location l)
+ : this (embedded.target, embedded.source, l)
+ {
+ this.is_embedded = true;
+ }
+
+ protected virtual Assign GetEmbeddedAssign (Location loc)
+ {
+ return new Assign (this, loc);
}
public Expression Target {
//
public override Expression DoResolve (EmitContext ec)
{
- source = source.Resolve (ec);
+ // Create an embedded assignment if our source is an assignment.
+ if (source is Assign)
+ source = embedded = ((Assign) source).GetEmbeddedAssign (loc);
+
+ real_source = source = source.Resolve (ec);
if (source == null)
return null;
+ //
+ // This is used in an embedded assignment.
+ // As an example, consider the statement "A = X = Y = Z".
+ //
+ if (is_embedded && !(source is Constant)) {
+ // If this is the innermost assignment (the "Y = Z" in our example),
+ // create a new temporary local, otherwise inherit that variable
+ // from our child (the "X = (Y = Z)" inherits the local from the
+ // "Y = Z" assignment).
+
+ if (embedded == null) {
+ if (this is CompoundAssign)
+ real_temp = temp = new LocalTemporary (ec, target.Type);
+ else
+ real_temp = temp = new LocalTemporary (ec, source.Type);
+ } else
+ temp = embedded.temp;
+
+ // Set the source to the new temporary variable.
+ // This means that the following target.ResolveLValue () will tell
+ // the target to read it's source value from that variable.
+ source = temp;
+ }
+
+ // If we have an embedded assignment, use the embedded assignment's temporary
+ // local variable as source.
+ if (embedded != null)
+ source = (embedded.temp != null) ? embedded.temp : embedded.source;
+
target = target.ResolveLValue (ec, source);
-
+
if (target == null)
return null;
Type target_type = target.Type;
- Type source_type = source.Type;
-
- type = target_type;
+ Type source_type = real_source.Type;
+
+ // If we're an embedded assignment, our parent will reuse our source as its
+ // source, it won't read from our target.
+ if (is_embedded)
+ type = source_type;
+ else
+ type = target_type;
eclass = ExprClass.Value;
- //
- // If we are doing a property assignment, then
- // set the `value' field on the property, and Resolve
- // it.
- //
- if (target is PropertyExpr){
- PropertyExpr property_assign = (PropertyExpr) target;
-
- //
- // FIXME: Maybe handle this in the LValueResolve
- //
- if (!property_assign.VerifyAssignable ())
- return null;
-
- return this;
- }
-
- if (target is IndexerAccess)
- return this;
-
if (target is EventExpr) {
-
- Binary tmp;
EventInfo ei = ((EventExpr) target).EventInfo;
-
Expression ml = MemberLookup (
ec, ec.ContainerType, ei.Name,
- MemberTypes.Event, AllBindingFlags, l);
+ MemberTypes.Event, AllBindingFlags | BindingFlags.DeclaredOnly, loc);
if (ml == null) {
//
// If this is the case, then the Event does not belong
- // to this TypeContainer and so, according to the spec
+ // to this Type and so, according to the spec
// is allowed to only appear on the left hand of
// the += and -= operators
//
- // Note that if target will not appear as an EventExpr
+ // Note that target will not appear as an EventExpr
// in the case it is being referenced within the same type container;
// it will appear as a FieldExpr in that case.
//
- if (!(source is Binary)) {
- error70 (ei, l);
+ if (!(source is BinaryDelegate)) {
+ error70 (ei, loc);
return null;
- } else {
- tmp = ((Binary) source);
- if (tmp.Oper != Binary.Operator.Addition &&
- tmp.Oper != Binary.Operator.Subtraction) {
- error70 (ei, l);
- return null;
- }
- }
+ }
}
}
- if (source is New && target_type.IsSubclassOf (TypeManager.value_type)){
+ if (source is New && target_type.IsValueType &&
+ (target.eclass != ExprClass.IndexerAccess) && (target.eclass != ExprClass.PropertyAccess)){
New n = (New) source;
- n.ValueTypeVariable = target;
- return n;
+ if (n.SetValueTypeVariable (target))
+ return n;
+ else
+ return null;
}
- if (target.eclass != ExprClass.Variable && target.eclass != ExprClass.EventAccess){
- Report.Error (131, l,
+ if (!(target is IAssignMethod) && (target.eclass != ExprClass.EventAccess)) {
+ Report.Error (131, loc,
"Left hand of an assignment must be a variable, " +
"a property or an indexer");
return null;
}
+ if ((source.eclass == ExprClass.Type) && (source is TypeExpr)) {
+ source.Error_UnexpectedKind ("variable or value");
+ return null;
+ } else if (!RootContext.V2 && (source is MethodGroupExpr)){
+ ((MethodGroupExpr) source).ReportUsageError ();
+ return null;
+
+ }
+
if (target_type == source_type)
return this;
if (this is CompoundAssign){
CompoundAssign a = (CompoundAssign) this;
- a.original_source = a.original_source.Resolve (ec);
- if (a.original_source == null)
- return null;
-
Binary b = source as Binary;
- if (b != null && b.IsBuiltinOperator){
+ if (b != null){
//
// 1. if the source is explicitly convertible to the
// target_type
//
- source = ConvertExplicit (ec, source, target_type, l);
+ source = Convert.ExplicitConversion (ec, source, target_type, loc);
if (source == null){
- Error_CannotConvertImplicit (l, source_type, target_type);
+ Convert.Error_CannotImplicitConversion (loc, source_type, target_type);
return null;
}
//
// 2. and the original right side is implicitly convertible to
- // the type of target_type.
+ // the type of target
//
- a.original_source = a.original_source.Resolve (ec);
- if (a.original_source == null){
- Error_CannotConvertImplicit (l, source_type, target_type);
- return null;
- }
-
- if (StandardConversionExists (a.original_source, target_type))
+ if (Convert.ImplicitStandardConversionExists (a.original_source, target_type))
+ return this;
+
+ //
+ // In the spec 2.4 they added: or if type of the target is int
+ // and the operator is a shift operator...
+ //
+ if (source_type == TypeManager.int32_type &&
+ (b.Oper == Binary.Operator.LeftShift || b.Oper == Binary.Operator.RightShift))
return this;
- Error_CannotConvertImplicit (l, a.original_source.Type, target_type);
+ Convert.Error_CannotImplicitConversion (loc, a.original_source.Type, target_type);
return null;
}
}
-
- source = ConvertImplicitRequired (ec, source, target_type, l);
+
+ source = Convert.ImplicitConversionRequired (ec, source, target_type, loc);
if (source == null)
return null;
+ // If we're an embedded assignment, we need to create a new temporary variable
+ // for the converted value. Our parent will use this new variable as its source.
+ // The same applies when we have an embedded assignment - in this case, we need
+ // to convert our embedded assignment's temporary local variable to the correct
+ // type and store it in a new temporary local.
+ if (is_embedded || embedded != null) {
+ type = target_type;
+ temp = new LocalTemporary (ec, type);
+ must_free_temp = true;
+ }
+
return this;
}
+ Expression EmitEmbedded (EmitContext ec)
+ {
+ // Emit an embedded assignment.
+
+ if (real_temp != null) {
+ // If we're the innermost assignment, `real_source' is the right-hand
+ // expression which gets assigned to all the variables left of it.
+ // Emit this expression and store its result in real_temp.
+ real_source.Emit (ec);
+ real_temp.Store (ec);
+ }
+
+ if (embedded != null)
+ embedded.EmitEmbedded (ec);
+
+ // This happens when we've done a type conversion, in this case source will be
+ // the expression which does the type conversion from real_temp.
+ // So emit it and store the result in temp; this is the var which will be read
+ // by our parent.
+ if (temp != real_temp) {
+ source.Emit (ec);
+ temp.Store (ec);
+ }
+
+ Expression temp_source = (temp != null) ? temp : source;
+ ((IAssignMethod) target).EmitAssign (ec, temp_source);
+ return temp_source;
+ }
+
+ void ReleaseEmbedded (EmitContext ec)
+ {
+ if (embedded != null)
+ embedded.ReleaseEmbedded (ec);
+
+ if (real_temp != null)
+ real_temp.Release (ec);
+
+ if (must_free_temp)
+ temp.Release (ec);
+ }
+
void Emit (EmitContext ec, bool is_statement)
{
if (target is EventExpr) {
return;
}
+ bool use_temporaries = false;
+
//
// FIXME! We need a way to "probe" if the process can
// just use `dup' to propagate the result
//
IAssignMethod am = (IAssignMethod) target;
-
- if (this is CompoundAssign){
- am.CacheTemporaries (ec);
- }
- if (is_statement)
- am.EmitAssign (ec, source);
- else {
+ if (this is CompoundAssign)
+ am.CacheTemporaries (ec);
+
+ if (!is_statement)
+ use_temporaries = true;
+
+ Expression temp_source;
+ if (embedded != null) {
+ temp_source = embedded.EmitEmbedded (ec);
+
+ if (temp != null) {
+ source.Emit (ec);
+ temp.Store (ec);
+ temp_source = temp;
+ }
+ } else
+ temp_source = source;
+
+ if (use_temporaries){
+ //
+ // Doing this for every path is too expensive
+ // I wonder if we can work around this and have a less
+ // expensive path
+ //
LocalTemporary tempo;
tempo = new LocalTemporary (ec, source.Type);
- source.Emit (ec);
+ temp_source.Emit (ec);
tempo.Store (ec);
am.EmitAssign (ec, tempo);
- tempo.Emit (ec);
+ if (!is_statement)
+ tempo.Emit (ec);
+
tempo.Release (ec);
+ } else {
+ am.EmitAssign (ec, temp_source);
+ }
+
+ if (embedded != null) {
+ if (temp != null)
+ temp.Release (ec);
+ embedded.ReleaseEmbedded (ec);
}
}
//
- // This is just a class used to flag that the assignment was part of a
- // compound assignment, hence allowing a set of extra rules to be used.
+ // This class is used for compound assignments.
//
class CompoundAssign : Assign {
+ Binary.Operator op;
public Expression original_source;
- public CompoundAssign (Expression target, Expression source, Expression osource, Location l)
+ public CompoundAssign (Binary.Operator op, Expression target, Expression source, Location l)
: base (target, source, l)
{
- original_source = osource;
+ original_source = source;
+ this.op = op;
+ }
+
+ protected CompoundAssign (CompoundAssign embedded, Location l)
+ : this (embedded.op, embedded.target, embedded.source, l)
+ {
+ this.is_embedded = true;
+ }
+
+ protected override Assign GetEmbeddedAssign (Location loc)
+ {
+ return new CompoundAssign (this, loc);
}
public Expression ResolveSource (EmitContext ec)
{
return original_source.Resolve (ec);
}
+
+ public override Expression DoResolve (EmitContext ec)
+ {
+ original_source = original_source.Resolve (ec);
+ if (original_source == null)
+ return null;
+
+ target = target.Resolve (ec);
+ if (target == null)
+ return null;
+
+ //
+ // Only now we can decouple the original source/target
+ // into a tree, to guarantee that we do not have side
+ // effects.
+ //
+ source = new Binary (op, target, original_source, loc);
+ return base.DoResolve (ec);
+ }
}
}