-Major tasks:
-------------
+NEW NOTES:
+----------
- Apply the method verification process to indexers and properties as well.
+ ImplicitStandardConversionExists and ImplicitStandardConversion
+ should always be the same, but there are a few diverging lines that
+ must be studied:
- Properties and 17.6.3: Finish it.
+ if (expr_type == target_type && !(expr is NullLiteral))
+ return expr;
-BUGS
-----
+ vs:
-* Adding variables.
+ if (expr_type == target_type)
+ return true;
- We do add variables in a number of places, and this is erroneous:
- void a (int b)
- {
- int b;
- }
+Null Type
+---------
- Also:
+ Need to introduce the NullType concept into the compiler, to address a
+ few small buglets and remove the hardcoded values for NullLiteral.
- void a (int b)
- {
- foreach (int b ...)
- ;
- }
+ NullLiteral will be the only expression that has the NullType as its type.
-* Visibility
+ This is what must be used to test for Null literals, instead of `is NullLiteral',
+ and this will introduce a couple of fixes to the rules.
- I am not reporting errors on visibility yet.
+ Revert Martin's patch to Conditional expression that worked around this bug:
-* Interfaces
+ Reference r = xx ? null : null
- For indexers, the output of ix2.cs is different from our
- compiler and theirs. They use a DefaultMemberAttribute, which
- I have yet to figure out:
+ The right fix is to introduce NullType
- .class interface private abstract auto ansi INTERFACE
- {
- .custom instance void [mscorlib]System.Reflection.DefaultMemberAttribute::.ctor(string)
- = ( 01 00 04 49 74 65 6D 00 00 ) // ...Item..
- ...
- }
+****************************************************************************************
+*
+* The information on the rest of this file is mostly outdated, and its kept here for
+* historical reasons
+*
+****************************************************************************************
+
+Error Reporting:
+----------------
+
+ * Make yyerror show a nice syntax error, instead of the current mess.
+
+Iterators
+---------
+
+ * Reset should throw not implemented now.
+
+Optimization ideas
+------------------
+
+ Currently when we build a type cache, it contains private members,
+ internal members, and internal protected members; We should trim
+ these out, as it shows up on the profile.
+
+ We create too many Arraylists; When we know the size, we should create
+ an array;
+
+ During parsing we use arraylists to accumulate data, like this:
+
+ thing:
+
+ thing_list
+ : thing { $$ =new ArrayList (); $$.Add ($1); }
+ | thing_list thing { ArrayList a = $1; a.Add ($2); $$ = a; }
+
+ We probably could start using "Pairs" there:
+
+ thing_list
+ : thing { $$ = new Pair ($1, null); }
+ | thing_list thing { Pair p = $1; $$ = new Pair ($2, $1); }
-* Interface indexers
- I have not figured out why the Microsoft version puts an
- `instance' attribute, and I am not generating this `instance' attribute.
+EmitContext.ResolveTypeTree
+---------------------------
- Explanation: The reason for the `instance' attribute on
- indexers is that indexers only apply to instances
+ We should investigate its usage. The problem is that by default
+ this will be set when calling FindType, that triggers a more expensive
+ lookup.
-* Handle destructors specially
+ I believe we should pass the current EmitContext (which has this turned off
+ by default) to ResolveType/REsolveTypeExpr and then have the routines that
+ need ResolveType to pass null as the emit context.
- Turn ~X () { a () } into:
- void Finalize () { try { a (); } finally { base.Finalize (); } }
+DeclareLocal audit
+------------------
- The code is mostly done, but `base' is missing. The reason it is
- missing is because we have to implement visibility first.
+ DeclareLocal is used in various statements. The audit should be done
+ in two steps:
-* Method Names
+ * Identify all the declare locals.
- Method names could be; `IFACE.NAME' in the method declaration,
- stating that they implement a specific interface method.
+ * Identify its uses.
- We currently fail to parse it.
+ * Find if we can make wrapper functions for all of them.
-* Arrays
+ Then we can move DeclareLocal into a helper class.
- We need to make sure at *compile time* that the arguments in
- the expression list of an array creation are always positive.
+ This is required to fix foreach in iterators.
-* Implement dead code elimination in statement.cs
+Large project:
+--------------
- It is pretty simple to implement dead code elimination in
- if/do/while
+ Drop FindMembers as our API and instead extract all the data
+ out of a type the first time into our own datastructures, and
+ use that to navigate and search the type instead of the
+ callback based FindMembers.
-* Indexer bugs:
+ Martin has some some of this work with his TypeHandle code
+ that we could use for this.
- the following wont work:
+Ideas:
+------
- x [0] = x [1] = N
+ Instead of the hack that *knows* about System.Object not having any children classes,
+ we should just make it simple for a probe to know that there is no need for it.
- if x has indexers, the value of x [N] set is set to void. This needs to be
- fixed.
+Dead Code Elimination bugs:
+---------------------------
-* Array declarations
+ I should also resolve all the children expressions in Switch, Fixed, Using.
- Multi-dim arrays are declared as [,] instead of [0..,0..]
+Major tasks:
+------------
+ Properties and 17.6.3: Finish it.
+
+readonly variables and ref/out
+
+BUGS
+----
* Break/Continue statements
They should transfer control to the finally block if inside a try/catch
block.
-* Conversions and overflow
-
- I am not using the checked state while doing type casts,
- they should result in conv.ovf.XXX
-
* Method Registration and error CS111
The way we use the method registration to signal 111 is wrong.
Method registration should only be used to register methodbuilders,
we need an alternate method of checking for duplicates.
-* We need to catch:
-
- extern string Property {
- get { }
- }
-
- The get there should only have a semicolon
-
*
> // CSC sets beforefieldinit
> class X {
PENDING TASKS
-------------
- * Implement Goto.
-
- * Unsafe code.
- Making the parser accept unsafe code.
-
- * Implement `base' (BaseAccess class)
-
- * Implement constant folding. We might need to implement
- a new `Constant' class and derive Literal from it.
-
-* OUT Variables passed as OUT variables.
-
- Currently we pass the pointer to the pointer (see expression.cs:Argument.Emit)
-
-* Function Declarations
-
- Support PINvoke/Internallcall and extern declarated-functions.
-
-* Manual field layout in structures
-
-* Make the rules for inheritance/overriding apply to
- properties, operators and indexers (currently we only do this
- on methods).
-
-* Handle volatile
-
-* Support Re-Throw exceptions:
-
- try {
- X ();
- } catch (SomeException e){
- LogIt ();
- throw;
- }
-
-* Static flow analysis
-
- Required to warn about reachability of code and definite
- assignemt as well as missing returns on functions.
-
-* Implement `goto case expr'
-
- switch (x){
- case 1: print ("1"); goto case 4;
- case 2: ...
- case 4: ...
- }
+* Merge test 89 and test-34
* Code cleanup
The information when registering a method in InternalParameters
is duplicated, you can always get the types from the InternalParameters
-OPTIMIZATIONS
--------------
-
-* Emitcontext
-
- Do we really need to instanciate this variable all the time?
-
- It could be static for all we care, and just use it for making
- sure that there are no recursive invocations on it.
-
-* Static-ization
-
- Since AppDomain exists, maybe we can get rid of all the stuff
- that is part of the `compiler instance' and just use globals
- everywhere.
-
-
-* Constructors
+* Emit modreq for volatiles
- Currently it calls the parent constructor before initializing fields.
- It should do it the other way around.
+ Handle modreq from public apis.
-* Reducer and -Literal
+* Merge tree.cs, rootcontext.cs
- Maybe we should never handle -Literal in Unary expressions and let
- the reducer take care of it always?
-
-* Use of EmitBranchable
+OPTIMIZATIONS
+-------------
- Currently I use brfalse/brtrue in the code for statements, instead of
- using the EmitBranchable function that lives in Binary
+* User Defined Conversions is doing way too many calls to do union sets that are not needed
-* Create an UnimplementedExpcetion
+* Add test case for destructors
- And use that instead of plain Exceptions to flag compiler errors.
+* Places that use `Ldelema' are basically places where I will be
+ initializing a value type. I could apply an optimization to
+ disable the implicit local temporary from being created (by using
+ the method in New).
-* ConvertImplicit
+* Dropping TypeContainer as an argument to EmitContext
- Currently ConvertImplicit will not catch things like:
+ My theory is that I can get rid of the TypeBuilder completely from
+ the EmitContext, and have typecasts where it is used (from
+ DeclSpace to where it matters).
- - IntLiteral in a float context to generate a -FloatLiteral.
- Instead it will perform an integer load followed by a conversion.
+ The only pending problem is that the code that implements Aliases
+ is on TypeContainer, and probably should go in DeclSpace.
* Tests
Write tests for the various reference conversions. We have
test for all the numeric conversions.
-* Remove the tree dumper, cleanup `public readonly'
+* Optimizations: variable allocation.
- And make all the stuff which is `public readonly' be private unless
- required.
+ When local variables of a type are required, we should request
+ the variable and later release it when we are done, so that
+ the same local variable slot can be reused later on.
-* Optimizations
+* Add a cache for the various GetArrayMethod operations.
- In Indexers and Properties, probably support an EmitWithDup
- That emits the code to call Get and then leaves a this pointer
- in the stack, so that later a Store can be emitted using that
- this pointer (consider Property++ or Indexer++)
+* MakeUnionSet Callers
+ If the types are the same, there is no need to compute the unionset,
+ we can just use the list from one of the types.
-* Add a cache for the various GetArrayMethod operations.
+* Factor the lookup code for class declarations an interfaces
+ (interface.cs:GetInterfaceByName)
-
RECOMMENDATIONS
---------------
Notice how numbering of the arguments changes as the
{ oob_stack.Push (lexer.Location) } takes a "slot" in the productions.
-* local_variable_declaration
-
- Not sure that this grammar is correct, we might have to
- resolve this during semantic analysis.
-
-
-* Try/Catch
-
- Investigate what is the right value to return from `Emit' in
- there (ie, for the `all code paths return')
-
-
-* Optimizations
-
- Only create one `This' instance per class, and reuse it.
-
- Maybe keep a pool of constants/literals (zero, 1)?
-
-
-************
-Potential bug:
-
- We would need to decode the shortname before we lookup members?
-
- Maybe not.
-
-interface I {
- void A ();
-}
-
-class X : I {
- void I.A ();
-}
-class Y : X, I {
- void I.A () {}
-}
\ No newline at end of file
projects / mono.git / blobdiff