-NOTES:
- I am trying to remove the LocalVariableReference from the code
- but the compiler does not pass its own self-compilation.
+Iterators
+=========
- The problem is that constructs with embedded_statements like:
- foreach (int b in X)
- if (b ...)
+ Ok, solved part of the problem, but not the second.
- The ec.CurrentBlock is not updated with the fact that `b' lives
- in an implicit internal block, and the lookup is attempted on the
- parent's block, hence rendering the lookup invalid.
+ Apparently there are 2 scopes in test-iter-05.cs that
+ are referenced, but when we call "ComputeMethodHost" in
+ iterators.cs:854 this information is not yet available.
-Major tasks:
-------------
+===========================================
- Pinned and volatile require type modifiers that can not be encoded
- with Reflection.Emit.
+* Value Parameter
- Properties and 17.6.3: Finish it.
+ I believe that `Value Parameter' might have been introduced
+ after C# 1.0, also notice than in the treatment of Value Parameter
+ the parameters are defined in four categories:
- Implement base indexer access.
+ Section 9.3 in the latest spec.
-MethodGroupExpr
- These guys should only appear as part of an Invocation, so we
- probably can afford to have a special callback:
+Large project:
+--------------
- Expression.ResolveAllowMemberGroups
+New
+---
- This is only called by Invocation (or anyone that consumes
- MethodGroupExprs)
+ It would be nice to optimize the case of:
- And the regular DoResolve and DoResolveLValue do emit the error
- 654 `Method referenced without argument list'.
+ Method (new ValueType ())
- Otherwise, a resolution will return a MethodGroupExpr which is
- not guaranteed to have set its `Expression.Type' to a non-null
- value.
+ So that no temporary is created, and we only use a newobj call
+ that remains on the stack, as opposed to ldloca, initobj, ldloc
+ call.
-readonly variables and ref/out
-
-BUGS
-----
+NEW NOTES:
+----------
-* Check for Final when overriding, if the parent is Final, then we cant
- allow an override.
+ ImplicitStandardConversionExists and ImplicitStandardConversion
+ should always be the same, but there are a few diverging lines that
+ must be studied:
-* Add test case for destructors
+ if (expr_type == target_type && !(expr is NullLiteral))
+ return expr;
-* Do not declare a .property on things that are just implementations, that
- comes from the parent, just do the method.
+ vs:
-* Currently the code path for 108/109 reporting is not being ran for methods
- as we need to compare method signatures. But since we retrieve the expensive
- method arguments in the method, we probably should do 108/109 processing there.
+ if (expr_type == target_type)
+ return true;
-* Emit warning on hiding members without NEW not only in members.
+****************************************************************************************
+*
+* The information on the rest of this file is mostly outdated, and its kept here for
+* historical reasons
+*
+****************************************************************************************
+
+Error Reporting:
+----------------
-* Implement visibility.
+ * Make yyerror show a nice syntax error, instead of the current mess.
-* Casts need to trigger a name resolution against types only.
+Iterators
+---------
+ * Reset should throw not implemented now.
-* Adding variables.
+Optimization ideas
+------------------
- We do add variables in a number of places, and this is erroneous:
+ Currently when we build a type cache, it contains private members,
+ internal members, and internal protected members; We should trim
+ these out, as it shows up on the profile.
- void a (int b)
- {
- int b;
- }
+ We create too many Arraylists; When we know the size, we should create
+ an array;
- Also:
+ During parsing we use arraylists to accumulate data, like this:
- void a (int b)
- {
- foreach (int b ...)
- ;
- }
+ thing:
+
+ thing_list
+ : thing { $$ =new ArrayList (); $$.Add ($1); }
+ | thing_list thing { ArrayList a = $1; a.Add ($2); $$ = a; }
+
+ We probably could start using "Pairs" there:
-* Visibility
+ thing_list
+ : thing { $$ = new Pair ($1, null); }
+ | thing_list thing { Pair p = $1; $$ = new Pair ($2, $1); }
- I am not reporting errors on visibility yet.
-* Interface indexers
+EmitContext.ResolveTypeTree
+---------------------------
- I have not figured out why the Microsoft version puts an
- `instance' attribute, and I am not generating this `instance' attribute.
+ We should investigate its usage. The problem is that by default
+ this will be set when calling FindType, that triggers a more expensive
+ lookup.
- Explanation: The reason for the `instance' attribute on
- indexers is that indexers only apply to instances
+ I believe we should pass the current EmitContext (which has this turned off
+ by default) to ResolveType/REsolveTypeExpr and then have the routines that
+ need ResolveType to pass null as the emit context.
-* Arrays
+DeclareLocal audit
+------------------
- We need to make sure at *compile time* that the arguments in
- the expression list of an array creation are always positive.
+ DeclareLocal is used in various statements. The audit should be done
+ in two steps:
-* Implement dead code elimination in statement.cs
+ * Identify all the declare locals.
- It is pretty simple to implement dead code elimination in
- if/do/while
+ * Identify its uses.
-* Indexer bugs:
+ * Find if we can make wrapper functions for all of them.
- the following wont work:
+ Then we can move DeclareLocal into a helper class.
- x [0] = x [1] = N
+ This is required to fix foreach in iterators.
- if x has indexers, the value of x [N] set is set to void. This needs to be
- fixed.
+Ideas:
+------
-* Array declarations
+ Instead of the hack that *knows* about System.Object not having any children classes,
+ we should just make it simple for a probe to know that there is no need for it.
+
+Dead Code Elimination bugs:
+---------------------------
+
+ I should also resolve all the children expressions in Switch, Fixed, Using.
+
+Major tasks:
+------------
+ Properties and 17.6.3: Finish it.
- Multi-dim arrays are declared as [,] instead of [0..,0..]
+readonly variables and ref/out
+
+BUGS
+----
* Break/Continue statements
Method registration should only be used to register methodbuilders,
we need an alternate method of checking for duplicates.
-* We need to catch:
-
- extern string Property {
- get { }
- }
-
- The get there should only have a semicolon
-
*
> // CSC sets beforefieldinit
> class X {
PENDING TASKS
-------------
-* Constant Folding
-
- Constant Folding does not take into account Enumerations, we should maybe
- extract the underlying value, and constant fold on it.
-
-* Revisit
-
- Primary-expression, as it has now been split into
- non-array-creation-expression and array-creation-expression.
-
-* Static flow analysis
-
- Required to warn about reachability of code and definite
- assignemt as well as missing returns on functions.
+* Merge test 89 and test-34
* Code cleanup
Handle modreq from public apis.
-* Emit `pinned' for pinned local variables.
-
- Both `modreq' and pinned will require special hacks in the compiler.
-
-* Make sure that we are pinning the right variable
-
-* Maybe track event usage? Currently I am not tracking these, although they
- are fields.
+* Merge tree.cs, rootcontext.cs
OPTIMIZATIONS
-------------
-* Use of local temporary in UnaryMutator
-
- We should get rid of the Localtemporary there for some cases
-
-* Emitcontext
-
- Do we really need to instanciate this variable all the time?
-
- It could be static for all we care, and just use it for making
- sure that there are no recursive invocations on it.
-
-* Static-ization
-
- Since AppDomain exists, maybe we can get rid of all the stuff
- that is part of the `compiler instance' and just use globals
- everywhere.
-
-
-* Constructors
+* User Defined Conversions is doing way too many calls to do union sets that are not needed
- Currently it calls the parent constructor before initializing fields.
- It should do it the other way around.
-
-* Use of EmitBranchable
+* Add test case for destructors
- Currently I use brfalse/brtrue in the code for statements, instead of
- using the EmitBranchable function that lives in Binary
+* Places that use `Ldelema' are basically places where I will be
+ initializing a value type. I could apply an optimization to
+ disable the implicit local temporary from being created (by using
+ the method in New).
-* ConvertImplicit
+* Dropping TypeContainer as an argument to EmitContext
- Currently ConvertImplicit will not catch things like:
+ My theory is that I can get rid of the TypeBuilder completely from
+ the EmitContext, and have typecasts where it is used (from
+ DeclSpace to where it matters).
- - IntLiteral in a float context to generate a -FloatLiteral.
- Instead it will perform an integer load followed by a conversion.
+ The only pending problem is that the code that implements Aliases
+ is on TypeContainer, and probably should go in DeclSpace.
* Tests
Write tests for the various reference conversions. We have
test for all the numeric conversions.
-* Remove the tree dumper, cleanup `public readonly'
-
- And make all the stuff which is `public readonly' be private unless
- required.
-
-* Optimizations
-
- In Indexers and Properties, probably support an EmitWithDup
- That emits the code to call Get and then leaves a this pointer
- in the stack, so that later a Store can be emitted using that
- this pointer (consider Property++ or Indexer++)
-
-
* Optimizations: variable allocation.
When local variables of a type are required, we should request
* Add a cache for the various GetArrayMethod operations.
-* Optimization:
-
- Do not use StatementCollections, use ArrayLists of Statements,
- and then "copy" it out to arrays. Then reuse the existing
- Statement structures.
-
-* TypeManager.FindMembers:
-
- Instead of having hundreds of builder_to_blah hash table, have
- a single one that maps a TypeBuilder `t' to a set of classes
- that implement an interface that supports FindMembers.
-
* MakeUnionSet Callers
If the types are the same, there is no need to compute the unionset,
we can just use the list from one of the types.
+* Factor the lookup code for class declarations an interfaces
+ (interface.cs:GetInterfaceByName)
+
RECOMMENDATIONS
---------------
Notice how numbering of the arguments changes as the
{ oob_stack.Push (lexer.Location) } takes a "slot" in the productions.
-* local_variable_declaration
-
- Not sure that this grammar is correct, we might have to
- resolve this during semantic analysis.
-
-
-* Try/Catch
-
- Investigate what is the right value to return from `Emit' in
- there (ie, for the `all code paths return')
-
-
-* Optimizations
-
- Only create one `This' instance per class, and reuse it.
-
- Maybe keep a pool of constants/literals (zero, 1)?
-
-************
-Potential bug:
-
- We would need to decode the shortname before we lookup members?
-
- Maybe not.
-
-interface I {
- void A ();
-}
-
-class X : I {
- void I.A ();
-}
-class Y : X, I {
- void I.A () {}
-}
+* Anonymous Methods
+===================
+In EmitAnonymousHelperClasses we set the "NeedThis" parameter of all
+the roots, but this is not necessary. We should track the
+"HaveCapturedFields" on a per-ScopeInfo basis, and only set the
+HaveCapturedFields on the proper roots, instead of all the roots.
-*************