-* Assignment
+TODO:
- string a, b;
- property string c;
+ 1. Create a "partial" emit context for each TypeContainer..
- a = c = b = "hello"
+ 2. EmitContext should be partially constructed. No IL Generator.
- Problem is that setter properties do not return a value, so we must
- create a temporary on the situation above to store the value of "b"
- and then pass that on to "a".
+ Optimize the internal type expressions in the parser (system_object, etc)
+ to be something other than DecomposeQI-based expressions.
-* Optimizations
+ interface_type review.
- Handle if (!x) converting to remove the `!' and instead of using
- a brfalse use a brtrue to jump to the end.
+ parameter_array, line 952: `note: must be a single dimension array type'. Validate this
-* LValueResolve
+Dead Code Elimination bugs:
+---------------------------
- Maybe we should only call Resolve on RValues and LValueRsolve
- on LValues so that DoREsolve can flag errors on properties
- missing `get' and indexers without a get indexer.
+ I should also resolve all the children expressions in Switch, Fixed, Using.
-* Emitcontext
+Major tasks:
+------------
- Do we really need to instanciate this variable all the time?
+ Pinned and volatile require type modifiers that can not be encoded
+ with Reflection.Emit.
- It could be static for all we care, and just use it for making
- sure that there are no recursive invocations on it.
+ Properties and 17.6.3: Finish it.
+
+ Implement base indexer access.
-* Static-ization
+readonly variables and ref/out
+
+BUGS
+----
- Since AppDomain exists, maybe we can get rid of all the stuff
- that is part of the `compiler instance' and just use globals
- everywhere.
+* We suck at reporting what turns out to be error -6. Use the standard error message
+ instead.
-* FindMembers
+* Explicit indexer implementation is missing.
- Move our utility FindMembers from TypeContainer to Decl, because interfaces
- are also scanned with it.
+* Check for Final when overriding, if the parent is Final, then we cant
+ allow an override.
-* Ordering
+* Interface indexers
- Can a constant_expression invoke overloaded operators?
- Explicit user-defined conversions?
+ I have not figured out why the Microsoft version puts an
+ `instance' attribute, and I am not generating this `instance' attribute.
-* Visibility
+ Explanation: The reason for the `instance' attribute on
+ indexers is that indexers only apply to instances
- I am not reporting errors on visibility yet.
+* Indexer bugs:
-* Enumerations
+ the following wont work:
- Currently I am not resolving enumerations.
+ x [0] = x [1] = N
- Either I track them with `RecordEnum' as I do with classes,
- structs and interfaces or I rewrite the code to visit type
- containers and `walk' the enums with this process.
+ if x has indexers, the value of x [N] set is set to void. This needs to be
+ fixed.
-* Known problems:
+* Array declarations
- Cast expressions
+ Multi-dim arrays are declared as [,] instead of [0..,0..]
- They should should use:
+* Break/Continue statements
- OPEN_PARENS type CLOSE_PARENS
+ A finally block should reset the InLoop/LoopBegin/LoopEnd, as
+ they are logically outside the scope of the loop.
- instead of the current production which is wrong, because it
- only handles a few cases.
+* Break/continue part 2.
- Complex casts like:
+ They should transfer control to the finally block if inside a try/catch
+ block.
- Array r = (string []) object
+* Method Registration and error CS111
- Wont be parsed.
-
-* Interfaces
+ The way we use the method registration to signal 111 is wrong.
+
+ Method registration should only be used to register methodbuilders,
+ we need an alternate method of checking for duplicates.
- For indexers, the output of ix2.cs is different from our
- compiler and theirs. They use a DefaultMemberAttribute, which
- I have yet to figure out:
+* We need to catch:
- .class interface private abstract auto ansi INTERFACE
- {
- .custom instance void [mscorlib]System.Reflection.DefaultMemberAttribute::.ctor(string)
- = ( 01 00 04 49 74 65 6D 00 00 ) // ...Item..
- ...
+ extern string Property {
+ get { }
}
-* Interface indexers
+ The get there should only have a semicolon
+
+*
+> // CSC sets beforefieldinit
+> class X {
+> // .cctor will be generated by compiler
+> public static readonly object O = new System.Object ();
+> public static void Main () {}
+> }
+>
- I have not figured out why the Microsoft version puts an
- `instance' attribute, and I am not generating this `instance' attribute.
+PENDING TASKS
+-------------
- Explanation: The reason for the `instance' attribute on
- indexers is that indexers only apply to instances
+* IMprove error handling here:
-* Constructors
+ public static Process ()
- Currently it calls the parent constructor before initializing fields.
- It should do it the other way around.
+ THat assumes that it is a constructor, check if its the same name
+ as the class, if not report a different error than the one we use now.
-* Use of EmitBranchable
+* Merge test 89 and test-34
- Currently I use brfalse/brtrue in the code for statements, instead of
- using the EmitBranchable function that lives in Binary
+* Revisit
-* Create an UnimplementedExpcetion
+ Primary-expression, as it has now been split into
+ non-array-creation-expression and array-creation-expression.
+
+* Static flow analysis
- And use that instead of plain Exceptions to flag compiler errors.
+ Required to warn about reachability of code and definite
+ assignemt as well as missing returns on functions.
-* ConvertImplicit
+* Code cleanup
- Currently ConvertImplicit will not catch things like:
+ The information when registering a method in InternalParameters
+ is duplicated, you can always get the types from the InternalParameters
- - IntLiteral in a float context to generate a -FloatLiteral.
- Instead it will perform an integer load followed by a conversion.
+* Emit modreq for volatiles
-* In class.cs: Method.Define
+ Handle modreq from public apis.
- Need to use FindMembers to lookup the member for reporting
- whether a new is needed or not.
+* Emit `pinned' for pinned local variables.
-* virtual-method.cs breaks
+ Both `modreq' and pinned will require special hacks in the compiler.
- It breaks on the call to: new B ();
+* Make sure that we are pinning the right variable
- Where B is a class defined in the source code, my guess is that
- the look for ".ctor" fails
+* Maybe track event usage? Currently I am not tracking these, although they
+ are fields.
-* Foreach on structure returns does not work
+* Merge tree.cs, rootcontext.cs
- I am generating invalid code instead of calling ldarga for the
- structure, I am calling ldarg:
+OPTIMIZATIONS
+-------------
- struct X {
- public IEnumerator GetEnumerator ();
- }
+* Implement loop inversion for `For' as well.
- X x;
+* There is too much unshared code between MemberAccess.Resolve and SimpleName
+ resolve.
+
+* User Defined Conversions is doing way too many calls to do union sets that are not needed
- foreach (object a in x){
- ...
- }
+* Add test case for destructors
- I need to get the address of that bad boy
+* Places that use `Ldelema' are basically places where I will be
+ initializing a value type. I could apply an optimization to
+ disable the implicit local temporary from being created (by using
+ the method in New).
-* Work todo:
+* Dropping TypeContainer as an argument to EmitContext
- Understand how methods are invoked on structs
+ My theory is that I can get rid of the TypeBuilder completely from
+ the EmitContext, and have typecasts where it is used (from
+ DeclSpace to where it matters).
-* Using Alias
+ The only pending problem is that the code that implements Aliases
+ is on TypeContainer, and probably should go in DeclSpace.
- Need to reset the aliases for each compilation unit, so an
- alias defined in a file does not have any effect on another one:
+* Casts need to trigger a name resolution against types only.
- File.cs
- =======
- namespace A {
- using X = Blah;
+ currently we use a secret hand shake, probably we should use
+ a differen path, and only expressions (memberaccess, simplename)
+ would participate in this protocol.
- class Z : X { <-- This X is `Blah'
- }
+* Use of local temporary in UnaryMutator
- File2.cs
- namespace {
- class Y : X { <-- This X Is not `Blah'
- }
- }
+ We should get rid of the Localtemporary there for some cases
- I think we can implement Aliases by having an `Alias' context in all
- the toplevel TypeContainers of a compilation unit. The children typecontainers
- just chain to the parents to resolve the information.
+* Emitcontext
- The driver advances the Alias for each file compiled, so that each file
- has its own alias set.
+ Do we really need to instanciate this variable all the time?
+
+ It could be static for all we care, and just use it for making
+ sure that there are no recursive invocations on it.
+
+* Use of EmitBranchable
+
+ Currently I use brfalse/brtrue in the code for statements, instead of
+ using the EmitBranchable function that lives in Binary
+
+* ConvertImplicit
+
+ Currently ConvertImplicit will not catch things like:
+
+ - IntLiteral in a float context to generate a -FloatLiteral.
+ Instead it will perform an integer load followed by a conversion.
* Tests
Write tests for the various reference conversions. We have
test for all the numeric conversions.
-* Handle destructors specially
+* Optimizations
- Turn ~X () { a () } into:
- void Finalize () { try { a (); } finally { base.Finalize (); } }
+ In Indexers and Properties, probably support an EmitWithDup
+ That emits the code to call Get and then leaves a this pointer
+ in the stack, so that later a Store can be emitted using that
+ this pointer (consider Property++ or Indexer++)
-* Handle volatile
+* Optimizations: variable allocation.
-* Support Re-Throw exceptions:
+ When local variables of a type are required, we should request
+ the variable and later release it when we are done, so that
+ the same local variable slot can be reused later on.
- try {
- X ();
- } catch (SomeException e){
- LogIt ();
- throw;
- }
+* Add a cache for the various GetArrayMethod operations.
-* Implement lock()
+* TypeManager.FindMembers:
-* SimpleNames and ElementAccess
+ Instead of having hundreds of builder_to_blah hash table, have
+ a single one that maps a TypeBuilder `t' to a set of classes
+ that implement an interface that supports FindMembers.
- If a SimpleName makes it outside the ElementAccess, we should
- flag a 246. I am not sure the current hack in
- Invocation.DoResolve is appropiate (catching 246 there), as I
- am pretty sure, SimpleNames will appear elsewhere.
+* MakeUnionSet Callers
-* Remove the tree dumper
+ If the types are the same, there is no need to compute the unionset,
+ we can just use the list from one of the types.
- And make all the stuff which is `public readonly' be private unless
- required.
+* Factor all the FindMembers in all the FindMembers providers.
+
+* Factor the lookup code for class declarations an interfaces
+ (interface.cs:GetInterfaceByName)
+
+RECOMMENDATIONS
+---------------
* Use of lexer.Location in the parser
We need to change that to use this pattern:
- TOKEN { $$ = lexer.Location } nt TERMINAL nt TERMINAL nt3 {
- $$ = new Blah ($3, $5, $7, (Location) $2);
+ TOKEN { oob_stack.Push (lexer.Location) } nt TERMINAL nt TERMINAL nt3 {
+ $$ = new Blah ($3, $5, $7, (Location) oob_stack.Pop ());
}
- Notice how numbering of the arguments changes, as the { $$ =
- lexer.Location } takes up a number
+ Notice how numbering of the arguments changes as the
+ { oob_stack.Push (lexer.Location) } takes a "slot" in the productions.
+
+* local_variable_declaration
+
+ Not sure that this grammar is correct, we might have to
+ resolve this during semantic analysis.
+
+* Idea
+
+ MethodGroupExpr
+
+ These guys should only appear as part of an Invocation, so we
+ probably can afford to have a special callback:
+
+ Expression.ResolveAllowMemberGroups
+
+ This is only called by Invocation (or anyone that consumes
+ MethodGroupExprs)
+ And the regular DoResolve and DoResolveLValue do emit the error
+ 654 `Method referenced without argument list'.
+ Otherwise, a resolution will return a MethodGroupExpr which is
+ not guaranteed to have set its `Expression.Type' to a non-null
+ value.
projects / mono.git / blobdiff